From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2D1A4CE7A9F for ; Thu, 5 Sep 2024 22:05:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD4AF6B0083; Thu, 5 Sep 2024 18:05:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A5DB36B0085; Thu, 5 Sep 2024 18:05:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 909A96B0088; Thu, 5 Sep 2024 18:05:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6EDAA6B0083 for ; Thu, 5 Sep 2024 18:05:33 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E6A2A160BA8 for ; Thu, 5 Sep 2024 22:05:32 +0000 (UTC) X-FDA: 82532066904.03.662D3CA Received: from fgw23-7.mail.saunalahti.fi (fgw23-7.mail.saunalahti.fi [62.142.5.84]) by imf14.hostedemail.com (Postfix) with ESMTP id 45D40100010 for ; Thu, 5 Sep 2024 22:05:30 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf14.hostedemail.com: 62.142.5.84 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725573835; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=jcukej5JwcllXKjMUIfTfBgkDwueYBqf1cJXxrsLqa0=; b=mQKaFNxqwBKUALHVm9I4yq+yIvHQESfBy7DnGKlmhZU5nFlnoOVkveWbQawbfaZYFDxWuW h7vBe1SLHdHc+TUnV2bF3fpLB/Mg4gwVOeiyeWg4vm1XFKTxWHafpXEYYStmt7zTuIZm6L lTHvudyjfvMzs6iIXhH3c/4wSsO+uzU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725573835; a=rsa-sha256; cv=none; b=0mjJiDDiflCmcYwzlWwhw2lhUPfUtc6Nr9/9P7YN9610vPdA1866pXelQhEoug67Wc76KW pHa19l5FtuuDxeTl82h0A79FuJ6OPPFkh4ZNAK244RCTyuY4a6kQe9hSaNNUTRyPXbwmGh tKNTYZpOW3WijauEteT+U7AfAjIJCIo= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (imf14.hostedemail.com: 62.142.5.84 is neither permitted nor denied by domain of andy.shevchenko@gmail.com) smtp.mailfrom=andy.shevchenko@gmail.com Received: from localhost (88-113-25-87.elisa-laajakaista.fi [88.113.25.87]) by fgw20.mail.saunalahti.fi (Halon) with ESMTP id f4f752b3-6bd2-11ef-8e98-005056bd6ce9; Fri, 06 Sep 2024 01:05:27 +0300 (EEST) From: Andy Shevchenko Date: Fri, 6 Sep 2024 01:05:26 +0300 To: Andrew Morton Cc: Andy Shevchenko , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev, Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt Subject: Re: [PATCH v1 1/1] mm/page_alloc: Mark has_unaccepted_memory() with __maybe_unused Message-ID: References: <20240905171553.275054-1-andriy.shevchenko@linux.intel.com> <20240905142220.49d93337a0abce5690e515d9@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240905142220.49d93337a0abce5690e515d9@linux-foundation.org> X-Rspamd-Queue-Id: 45D40100010 X-Stat-Signature: ufad1uemr6w17cgkjspehybqeqy8yb5t X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725573930-779873 X-HE-Meta: U2FsdGVkX1+x4qYsfuYkLbHUJHEawv5LVh8VzZcL8hBFEgtyeI510TNUjDtPv9VnYBV37XRjHCi+bUrgPEG5KnXrkr5BPVA/uv1NcLMISAnjq6jFNh+sN+xBhxpHtA7L3J/+1TsYGe6DkP9KTQ2PdmTS9UGUodn63oJN7mqFaeA6RXLX0tiplSV9nlH5bQjkYN6DyWm8BOdZQLwLUIk48oQ1w2ARg68IfpdqXaP/MGEh4HK8KaOLU3ZMvONIPYgrO1sxphpbF1WxPtQ4LG6GujDsg0osGDrQ2BzxMq0SX8NXDiJ/bq9vv/Xh+/kgsIODJNhQLMW5nT/jwSk0gVc3XsC3FxifvPtoVGXZstkrwa+2b9B6jznduLSAoQEXqIGVOdzLyDSuiwyDB6EVLiFUTTIOqyEYju6qb9lMN8IvXfd1duKG05W+yTxx1fe9t/8buXd7IZFvd/h8cdIqb76kbB5Zns0FjczppEizZ4vhTPSpW3Ku0D49U/G7dmO5RXrewvxvLURpp7oTunv3OFB+K/glTFeylTgfIZiYdyODbQgR72vgynSyZ8Mrm7kp5lVf2vmPP9B5WUPYVJ7HeHgDgoIlhvPfdLvTfzAtRlrM+KwKuLC7U7B70dnD+sNgozJma4+ybFvCo5+ddtT9SOx2mBzucx9/bPb3EfCS3Vrl92TEe9p6la376FC2dAHU3vectB5YDSCa3Pc5o5Wmjo1x+s/kt19gkOCS8Ct3aWEDP58qICFwqbxGL36RJzI7k0xV4nHzxZTLR5qTWJDHQou2fWMdtNisz+vS1aXj64KkCswmG8KEXRZx13RXOlGGZmbBdZxW75wGI/C2bKo7GnPkiWmqLE4ngxy90y7g0yamB6c2mvOCS3db+omBF5QL8N0btsLUGO2/4Mnb++nDCwlZ3P59Fe6khGMO2B0VFi9NSfvvkWjeR5xw0dSTVm3AOCgrvalzn+AA2E3/88YITbe cGWuqMRY 7ypxkqzsl6mUCtM4wOMIG94hpezSn+w1grNVKq9WmL6pBMZQWQgZgVN77HhnRa4bXsIkZseL3qsKTIY1y51JG5L5d6y3CSwwZJOl/AuXQfyWH/HVTTssSTHh2nMzUK7jvxOMi7hmrTk5gRzgjLOTJoSKLFdlg7HyGktfg6lrpjd7l6sbtI3dOu5sJjplgn88gBESn7vgnEB7MXSrCS89YRoNG8JaLzKdJlNpRl7RuCfsFEBa6r46QBdwzYfyyH3nD+i3TwB3l4QFLQmvWD82aTcSV7ImSviae6RrockqJRbVdO5hWQN8/GeTE5k1iOrsG+z8Q8xopYa+vWv2VPkidMBZdTqBzrLiBIG1DhKAlqY25dlTjO3Hvb3jWBt9Qwy5IHtoLLSdfSnEAi6c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Thu, Sep 05, 2024 at 02:22:20PM -0700, Andrew Morton kirjoitti: > On Thu, 5 Sep 2024 20:15:53 +0300 Andy Shevchenko wrote: > > > When has_unaccepted_memory() is unused, it prevents kernel builds > > with clang, `make W=1` and CONFIG_WERROR=y: > > > > mm/page_alloc.c:7036:20: error: unused function 'has_unaccepted_memory' [-Werror,-Wunused-function] > > 7036 | static inline bool has_unaccepted_memory(void) > > | ^~~~~~~~~~~~~~~~~~~~~ > > > > Fix this by marking it with __maybe_unused (all cases for the sake of > > symmetry). > > > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > > inline functions for W=1 build"). > > has_unaccepted_memory() has no callers if CONFIG_UNACCEPTED_MEMORY=n. > Can't we do this better thing? Sure! Please, use your patch, I'm fine with that Reported-by: Andy Shevchenko -- With Best Regards, Andy Shevchenko