From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 538FBCD6E58 for ; Thu, 5 Sep 2024 17:03:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E873B6B0089; Thu, 5 Sep 2024 13:03:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E11186B008A; Thu, 5 Sep 2024 13:03:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CB16C6B0092; Thu, 5 Sep 2024 13:03:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AC1186B0089 for ; Thu, 5 Sep 2024 13:03:45 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 2B41F1404A8 for ; Thu, 5 Sep 2024 17:03:45 +0000 (UTC) X-FDA: 82531306410.12.9E8D15B Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf29.hostedemail.com (Postfix) with ESMTP id 39283120011 for ; Thu, 5 Sep 2024 17:03:43 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b="S8oxi/AJ"; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf29.hostedemail.com: domain of "SRS0=ehJl=QD=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=ehJl=QD=zx2c4.com=Jason@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725555798; a=rsa-sha256; cv=none; b=LvAI+hYREzVuiaZutY3BO9Ui46su1q98HWMDdaPwVuslQfCtZRhubeqJS+1/+tsYX/0BC6 hjeHv57NUFzOa12UuW/FP/T/B4/x4KIg9DuwYDwlUl7e+XWOsKa0P6+OdtKAoTfSXocE+Q 9gYKv7NWs1+377PJVuxMGlkL/S6vGWQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b="S8oxi/AJ"; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf29.hostedemail.com: domain of "SRS0=ehJl=QD=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=ehJl=QD=zx2c4.com=Jason@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725555798; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2WPPczzM5fWySeHC6qCU5mJN44nYuMHACOhNso4EGCc=; b=Ga6N8BoaCzcLx3AQRvp0w8D8CdsBimL6XoaJ14sesyLXDNIzdjTLjGgaWH0alCyuq+/tg0 48OGAVlC0qgvNSiPIs5JBahp1Q1pnQ0PgafH9onyT0ZHcFHJilS2tD84N87ZC1eo59qwfc 2YOTglX5XwtSlMLoDgRmJNVinGbedrg= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 49D83A44E14; Thu, 5 Sep 2024 17:03:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2114C4CEC3; Thu, 5 Sep 2024 17:03:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725555817; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2WPPczzM5fWySeHC6qCU5mJN44nYuMHACOhNso4EGCc=; b=S8oxi/AJO3vG5kC0wYzvPcvwfn+o0kCttzDIhQelVpgwHEjGgAUGSmBmhwbhPa1WeQUBkb zu10fm2SriimEK0oAC9nBbD2fdcQS3U5JLuIJ3Yt6a4wdt2cJhjM7HSPHPV5+s0R7BSnJa 90zYJO/+yld5Pdz8ajTRqlFukUnSKxg= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 27c37213 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Thu, 5 Sep 2024 17:03:37 +0000 (UTC) Date: Thu, 5 Sep 2024 19:03:34 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v5 4/5] powerpc/vdso: Wire up getrandom() vDSO implementation on VDSO32 Message-ID: References: <1f49c2ce009f8b007ab0676fb41187b2d54f28b2.1725304404.git.christophe.leroy@csgroup.eu> <85c02620-e8b2-4c97-9905-685a9a4e556d@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <85c02620-e8b2-4c97-9905-685a9a4e556d@csgroup.eu> X-Rspam-User: X-Rspamd-Queue-Id: 39283120011 X-Rspamd-Server: rspam01 X-Stat-Signature: waye1rj5p9uowcgc9g9ed48nckf7hs5c X-HE-Tag: 1725555823-854711 X-HE-Meta: U2FsdGVkX1+1FtqWiMQ46a9FhDHQ+aJYJ2J2AoVDYE0E/4NdEBCt/jydIowjHS8hzv6r0eC9bsdBSUpOg9WrOQTV5FD6aBxIMW+nMpKWkBEq9sVB9elzoW3Rjrj8otD/B5La4bm5jqxQaV4+a1Q8USMjtHtKCTpfeKxEMzp/hznDrCUR1re7wY6jpokz3NtNQq8nUJqjokAUXd4lJ4t624xacAgvW7UmX910rW/izuTkNHk7l+CuAvUKZ+M1oW//o0tjbEyZIaB1xBp//U4Yj72dII8KkSir5svqm5pv2A+oTb8/Zkp8G3fV2HTdcXAdPeI+7zfN1afgrUBahS9sYjz55W98Ml4ubiiBfu0BzJK678DG4kHSlJLyaNtmtop9Hl1vOvXUjt5eddf6w3J5o3s7RnCtmGqKVQFvHnqISX9i5+MPMeH99d7Nxxtk8klJ4McoiMQkmBA4K/qblchjDbBF3Du4v6lsS4ULPPJrCBFzZ4Jpw3yjUE1DERLy7g5fmfnUCr+/loU5g3wViS+KoNjk3r5IogXMiY3AbUWEFm7q91OxIbQaWXGkHImRyHvg9v4OKI+U8Bo8oVppoc4qSXoVugUKBlvjLd8Qbc/+iifNW0/XYJjPdz4txPty1Bmuv28k9fbsZWWDMSyAkVfJ8eWBvBbg0vnbGxZFa0x26eORlvrN5UvgaXcEwcy9u9RCeCGjvDvpMh6pT/NsFZOb0GJdBuYI0uAMt+B4HftjwKhTIkqxSDvkW6AKU0MrqKG3OENx6iP+/f0nhyYLt+FFzPjZiALF/hx+QSUGjdQzHMTknauav/dxRtEnY7AOZCDq2qW61O0BTvyIjGPKRQjekBNXuT1LRBkZ5x/xueIqbGKkNrFenQi6FVhnpN/BJ9gdrkhK8qX2PAi4F/A3C7xb2JV7x2Lu+RnZp2CyG8PreB6y+LQPZPZULFR5J8zJ5irRs5gKovoDGP0WdRA4heH RWqVe77A xqFfkCqDL18ekdeD4ewjQlwDlExe1Td5oS4MY88qeIqexgj5rTamNM18oJiGpkG6y0pecwqK3rq2JD2r1JXH87EF/p8Z0wtkd72CV7G6rZPT8BPC2h3dHbWucbjKWxXaUacV2sFZ36EdEChBM1XtxAsFPy+eYO008qG9A6y6Ok5JZg7LhMw+7bqfGRzP8YOUF2foEAtqVRSO5YDtL5zvkPP2W5A0lxkK/EvpdIvmXrDZuNVjBtGK7uqr1gAJ9+pC7KjCTwmDZDgobnrHO+HHPaKcXnCg4eeWaqY4NsbllTDle9rdRG//53f8KEWFVdkNsasqdlhZiTFtYk1IPpv3AH1TLYam7U2g5m3ZqLCxumSpNr9cBFVB58CLdFtK9MlBCz1qMYE4V6lse2KUVKuE3sKEaWEqLDKa4N+IX/hz5CBy3we3Kdykjf3hbInVLUUllMW4j/GjJkON//0A= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 06:55:27PM +0200, Christophe Leroy wrote: > > > Le 05/09/2024 à 18:13, Jason A. Donenfeld a écrit : > >> +/* > >> + * The macro sets two stack frames, one for the caller and one for the callee > >> + * because there are no requirement for the caller to set a stack frame when > >> + * calling VDSO so it may have omitted to set one, especially on PPC64 > >> + */ > >> + > >> +.macro cvdso_call funct > >> + .cfi_startproc > >> + PPC_STLU r1, -PPC_MIN_STKFRM(r1) > >> + .cfi_adjust_cfa_offset PPC_MIN_STKFRM > >> + mflr r0 > >> + PPC_STLU r1, -PPC_MIN_STKFRM(r1) > >> + .cfi_adjust_cfa_offset PPC_MIN_STKFRM > >> + PPC_STL r0, PPC_MIN_STKFRM + PPC_LR_STKOFF(r1) > >> + .cfi_rel_offset lr, PPC_MIN_STKFRM + PPC_LR_STKOFF > >> + get_datapage r8 > >> + addi r8, r8, VDSO_RNG_DATA_OFFSET > >> + bl CFUNC(DOTSYM(\funct)) > >> + PPC_LL r0, PPC_MIN_STKFRM + PPC_LR_STKOFF(r1) > >> + cmpwi r3, 0 > >> + mtlr r0 > >> + addi r1, r1, 2 * PPC_MIN_STKFRM > >> + .cfi_restore lr > >> + .cfi_def_cfa_offset 0 > >> + crclr so > >> + bgelr+ > >> + crset so > >> + neg r3, r3 > >> + blr > >> + .cfi_endproc > >> +.endm > > > > You wrote in an earlier email that this worked with time namespaces, but > > in my testing that doesn't seem to be the case. > > Did I write that ? I can't remember and neither can I remember testing > it with time namespaces. It's possible I confused you with someone else? Hum. Anyway... > > From my test harness [1]: > > > > Normal single thread > > vdso: 25000000 times in 12.494133131 seconds > > libc: 25000000 times in 69.594625188 seconds > > syscall: 25000000 times in 67.349243972 seconds > > Time namespace single thread > > vdso: 25000000 times in 71.673057436 seconds > > libc: 25000000 times in 71.712774121 seconds > > syscall: 25000000 times in 66.902318080 seconds > > > > I'm seeing this on ppc, ppc64, and ppc64le. > > What is the command to use to test with time namespace ? Look at the C in the commit I linked.