From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0ABA6CD5BC8 for ; Thu, 5 Sep 2024 14:32:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 734B16B010E; Thu, 5 Sep 2024 10:32:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6E49B6B010F; Thu, 5 Sep 2024 10:32:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DDA56B0110; Thu, 5 Sep 2024 10:32:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 3F97A6B010E for ; Thu, 5 Sep 2024 10:32:28 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 96F51140498 for ; Thu, 5 Sep 2024 14:32:27 +0000 (UTC) X-FDA: 82530925134.28.7BC3314 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id DA02214000B for ; Thu, 5 Sep 2024 14:32:24 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k7EmstYs; spf=pass (imf26.hostedemail.com: domain of snitzer@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=snitzer@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725546720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SS5GHiDtJCmOemdLqWYCThFFmWhC5dTf8rN2I2wRXWs=; b=IN2F9Fslr0rCSbOOD3LeVl2E1NbhegxSQLCRDjwL5Mqojd6mTYlXD4HGeu7jsZWxXwGNEB J/pr2xKfB2TmFt+1NlBwAK+gCB+az4HL+JsKmFX0Lo4GODeUs++0InzAH+vOXs4rlxWWi+ ivKhTH9ppF4Ew0gxqch9q8tL/vmWpvM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=k7EmstYs; spf=pass (imf26.hostedemail.com: domain of snitzer@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=snitzer@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725546720; a=rsa-sha256; cv=none; b=k7iDO+XaqohO5l8tTVxtGlVjq/jfUk1J0IlHItRgsVGG/QOaxL2qKXdo3yoJyJoMaMW8eE J4JCvJQjDahcdFABZJzHZfj7bSOTms29onYBgjD/E/VR2MVOjYpemIKQn0cDzT7b432gn1 KCC4YBO+WYdRtGz2T1TldXc5Ta97gpc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7D9FB5C5CC9; Thu, 5 Sep 2024 14:32:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4CCB3C4CEC3; Thu, 5 Sep 2024 14:32:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725546743; bh=BQW84hZwFEmS7SWLZzzzYJkxu62txwxLKb3iaRMFqGw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=k7EmstYsha8/YxlvmdJE3En30h5WrM1gd+iaZwCA2oeDSmrjs8XYfqRAo+q5dgL6e kQEos2Xq+xQQK9pYuKbGyrsdNjuj+AxzBXnfLfw0AbkB6PSAhkbRvKsE8t1V/gn7FG M0en7nzZI7K3djsXbhllRFpoLBlNksDfdkYqhBLf3TVnNxlzYXHcJGqOnJv3cFPtoe z5T90On3Vjjd64zwkXkCCHuazfS05ht+AXPRlO4kPVzNG3Ckb49Ik7OeRlj8m4K4jC E0skKiLEItq6mNSHfjqUyU4lvJeanDSJm7b2m9qnJnNZWXLwhsdrC4FsTVRKb9i8Ra hGMrxSGmy8paQ== Date: Thu, 5 Sep 2024 10:32:22 -0400 From: Mike Snitzer To: Eric Biggers Cc: dm-devel@lists.linux.dev, Alasdair Kergon , Mikulas Patocka , Tejun Heo , Lai Jiangshan , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sami Tolvanen Subject: Re: dm verity: don't use WQ_MEM_RECLAIM Message-ID: References: <20240904040444.56070-1-ebiggers@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904040444.56070-1-ebiggers@kernel.org> X-Rspam-User: X-Stat-Signature: 7aed4d7apjtqcmi51gtqa8dbkyuchpby X-Rspamd-Queue-Id: DA02214000B X-Rspamd-Server: rspam11 X-HE-Tag: 1725546744-567873 X-HE-Meta: U2FsdGVkX19ss5cvQncr+CPfT1Ny1F7+stKnTBoNErHEtLuOnLGL5684guQBONnaJFV3DV3WxJu/8LCcd2Qn46Cdd/yw7ig6DR2LA+e6uFVrkj3gsmZYyVIepIqMae1ovwCY6n268Iki9HQy87OczTPBYneG0WgopSh1lmSsHazvybsUK21qUHwqXxchiA+mEu/WoXl+gX4sJzmHGm3MLjh+ij4oDHCKXA1KJZ8Ox+VHOYg7eWCeSqfcz21XZzQYTZTWlm+ainX0+h6ugJQ+hIwfaF5peCLSyvzULQpAVJKTS+TEX3PfPEQtYRreYUoM4mgG/jQ2P2xdp/GcALWYCGkehk2cFDlpPBQmd6LKMCDIKAlNSBHuKzLBSy4oi1g1Zapn/vsOcv1O0+TxMsNdAbkZL47PADh2NYCOqSOoSJZYdVu1+uBFXgKJSJfubS6q8+eykwBM1Q42+/Bh23QiDU87b9dFxD784jYSypPRncnIiSA9kIE6NFyvFtGXNAzegPHO4rYrqC3S1bBqH+EEfdLjcDIFUz1z9GO+QT1M6n/ZJkTl6TrrGBd6/32/3cwiY58uTret4IDC5RQJeFp0nbekW1W50r5I20XG/ZHGSy2apMhp5g6qaiN1H+KIcE59bi93dtdOPqEVNw9ydmwYf+aDuM78QkJ/Ycjm6kNBYAQ/CAaBkSJcz5Bg8FiN1+g+X3e64/fan08JBi7t3saFtV7moVqpKXTBrPpy892W62ZRnUWSVw/RoFHIwN2VJr8qtw6NIMn3R4cnnNthwBOSyznRGtU3n5+M2Fu5dG+/eMYVOcrO8FifrKLltdmcjRsp3N/Ohc2XsSWQRbLrV3PvCvKAgGSO10LYKE0OKyJ+C+QtiiONh8nSfWk6to7OYXB1J0NPCnZnh7eSDeYAssHcZP5L36j4H/EirJDf8o3VJLiwk6tvJ9l3FtThCgAceEhdbn7Av4IOXkCLun/7jaR B+lQq7UC pM8ecneKPtaEH0/wi9WzoghkrYHEJdPRA/auVNCu7T6Oj8OehfoK6MsP9P0d7WJe0hxoHtQkfiGBmVfzAf1TUJutfnUrhRuIZMKI+9bqJtdmM9ccuknOxQv1959loX52DdhJh3P5dHv5srq4WouvR53RzkmpkAaa/Y7mhffIS41m3jrY8tGMISMgR/G5a2XSN1D3DZxwT+VP/YrircZ5CdO72oGOxFjJEWbS/1sFUmJCcbEok3jyr5sx5ZEWO5JEkENz4W5unxwzGy/9Pf1tnbTUdgEX9pXZdPg/GI8VUu+sP3HVMPqzm6EfnML1U+r7uMHInGOI7f9VfqXIZQ9XnzJfm5FLlpbhV665D X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 09:04:44PM -0700, Eric Biggers wrote: > From: Eric Biggers > > Since dm-verity doesn't support writes, the kernel's memory reclaim code > will never wait on dm-verity work. That makes the use of WQ_MEM_RECLAIM > in dm-verity unnecessary. WQ_MEM_RECLAIM has been present from the > beginning of dm-verity, but I could not find a justification for it; > I suspect it was just copied from dm-crypt which does support writes. > > Therefore, remove WQ_MEM_RECLAIM from dm-verity. This eliminates the > creation of an unnecessary rescuer thread per dm-verity device. > > Signed-off-by: Eric Biggers Thanks! Reviewed-by: Mike Snitzer