From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B0A6CD5BC0 for ; Thu, 5 Sep 2024 12:50:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E88066B025F; Thu, 5 Sep 2024 08:50:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DF3726B0266; Thu, 5 Sep 2024 08:50:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5FFC6B0269; Thu, 5 Sep 2024 08:50:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A68C96B025F for ; Thu, 5 Sep 2024 08:50:25 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4B4991A0149 for ; Thu, 5 Sep 2024 12:50:25 +0000 (UTC) X-FDA: 82530668010.17.8B0DBBC Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf30.hostedemail.com (Postfix) with ESMTP id 9DA0F80023 for ; Thu, 5 Sep 2024 12:50:22 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YHlITdCo; spf=none (imf30.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.12) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725540574; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EAW45a0U9j1e2lPXIuQMvQGMQnrBT/nCalGm13oRckY=; b=F3O1a/CMYEy1yNlWZXRuqcIq+WAqRZ00kw+Fhkoh2bvkj4hms8P+B7s6XxCZ9RH156BI9W OYnlDNO8GrlEGB8qqZjC+ZYwjTSXXnDBTOwkl721LGPmL5AWJW/gm+IdKgBUOwC3ILZLEt Q9oeFC/iEN+w7+9B1t5/aG8AGEAV5ew= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=YHlITdCo; spf=none (imf30.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.12) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725540574; a=rsa-sha256; cv=none; b=UTVBNaaqvm5IU0Vf+CPfhrYXpheg/VzRJ/nubxdR44MXDfopHb0X4W7iv2nNwy/mV8/jCU n48slatmjUh10sWIYqgKHGFGCLUD3M8CJc5pn0zzYL68pdyEdwC3WoOqq4/xikwXITib+M PW2aX0vsanETXPgGNkK+hG0OzwVjdPI= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725540623; x=1757076623; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=KGYsF/SRHemHh4EJhmdtbUuBR3GMDFjHUBP96dHDS1E=; b=YHlITdCo0Z5xOtACx1aY3+1s5uzyyAkjsl/PSmmVS8tRkJq//94SBobA WsIL62GIiH6eKx7d/Ho9AwJgLYOHVU5uqsBgljD/WaD7WOmOYeWuKO7vH B3sZ9HgxS1wn30A3cxA751Y2xmY5c8w8lfGCNgNIjQM7Tq90qBGpLU4NH 0alKOknfXiy7O/Z94vLnd8zjQ9ZjY8md4dlNecZmNWbp2qyYR8RLv0nqG wB4MU8o2tMme3HQtK7NppfeMvYNN7HKvIA/ZQx8Cv8bX3+cJF6tQ5INJT IQDP47jo/ZVuo9ayzKk3l3bDjjRxkF5UwmZ4frIDWs9N8X7yxTl/mYUJM A==; X-CSE-ConnectionGUID: T1H09lUWTKu15uSh/wnOhg== X-CSE-MsgGUID: tSzVgA/6TkmwybQvxn9FZA== X-IronPort-AV: E=McAfee;i="6700,10204,11185"; a="28142005" X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="28142005" Received: from fmviesa002.fm.intel.com ([10.60.135.142]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 05:50:14 -0700 X-CSE-ConnectionGUID: jO07qKfISP+G9wXxcLjZNg== X-CSE-MsgGUID: SJZXvzrVS0SvG8f4yIitww== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="88856711" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa002.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 05:50:10 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smBw4-00000005Ogg-3jxN; Thu, 05 Sep 2024 15:50:04 +0300 Date: Thu, 5 Sep 2024 15:50:04 +0300 From: Andy Shevchenko To: David Hildenbrand Cc: Dan Williams , "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> <65838cc0-9a20-4994-a0ef-9cd50bb00951@redhat.com> <09d44b21-9739-417b-a76c-5383fcbde96b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <09d44b21-9739-417b-a76c-5383fcbde96b@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 9DA0F80023 X-Stat-Signature: y3pn9e8eytdt5r65gp9kskoo4gjeor49 X-HE-Tag: 1725540622-761475 X-HE-Meta: U2FsdGVkX199ybwm0lS4QJzV6sK+cFe0hd3XLIZrWS+i9ZKW8FLYgY9jdRIecnMNJZESDc358+2HSx3pgwhNmtLMSvNdmJ/m6xdJKv71jnmMYHqsxZINByaFIPMFXVSrDo/5SRgy1tgyg1BYADgBn6MWBbs9Q1G2GCPxsWHxqfkFgjHwF8y6o7Dn86FQWkNNplZ1abUN9vzJshQX5nmYU/Y2kfeEp9Zr5VicV0hhJTgNOQmIH9x93/H258c4R58S2NCD5yPnwKcJlDTCp5tqDP/3DFCAnLJa5onYso7LBbmiE2NVhtIQUdm08JtWPouJvbWmClozdFpLISBMXvPNzau9eKjWSdIxZ9xdNRIP1PYyskdOwyRP1PiQOwoR2UIoBNA+O9ujht5us1Nzlx135rGUeWSLtct5FKH01hytf4oF0VtcxeXCJhRHziSiLM4ZRPY07EHvYnv5Iy0Z62EtfxS3MbTmQBVVp5SO6MD2b3/s4CL3NlUL3sur50dcvynwwUOK829kCHu7zNEeyI7sJ4MkQ03/oX4HyYW2b41vYmZbFt/5msm8d8NP0Bl2+Q01Pz1JmZkfXeizTB7l/EbWyL40EzHmi3zY/gX7KdJ7vzehOFYjTPK6hfpjXOo1nIwfZlrWZL5wvLQHn9tH6uuuXWzRhKZCquRrssl2rFn34pGNBbm85lh4DoRmm7QjTEOhFo9O1fTutJNLVU/9sBbkf86Q48SFJXi0XZKdSESwwJ5SY+znpqfYgtAo5Hwoo8Uz2rCq6Tzwf65STAq+VfD/UgE6fxvrdfUZVf55d39twPi/RR2DDkXaJTBBQTKe35cVkBmlceIKD07+MhvnDFt6vTTLDShuFUC/Y4maqse6Y1V1vqCG0dkvGQ3GePNvklpPjKQVNUNKuCs4LfICee37jqd2k/sYkvu4gjJCB+svZDUrzYJwEob8WTU8M3BgNLHhaE3cVDggRCi1NNRTXa3 +19Y9ZyS 91EJa0XufnRX8ri7Zw8tEGWHqYm6m3Edqe9+nsuTrSPD27hUl9rc9XwA6zIE9D5eTs0ewzqhlHxqpjtA7KFEH7U/gJbFdpnrZG0SiPGruSRWkVIR74eVaryrkXbjd7rTtT+Kw5W94r0gcQotVAmkp8Ikn7S9bj15wFC4dyyDbc/emgP/qxGofFkh5xM+1NZz5KXh/KZDiWPl8SFu91JbFbzZo3gfiH8cFtaMOttFE9kfgoXli6wnPVRKRT7xXDX7MXvUKlFEqi9vyksRvO0EWOZTA4dxY18CD/bNnfWmp7/Qnpl8miFdGG6VoOZwREcF26QE5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 02:42:05PM +0200, David Hildenbrand wrote: > On 05.09.24 14:36, Andy Shevchenko wrote: > > On Thu, Sep 05, 2024 at 01:08:35PM +0200, David Hildenbrand wrote: > > > On 05.09.24 12:56, Andy Shevchenko wrote: > > > > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > > > > > Huang, Ying wrote: > > > > > > Andy Shevchenko writes: [..] > > > > > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > > > > > > message. > > > > > > > > > > > > Emm... It appears that it's a common practice to include "Cc" in the > > > > > > commit log. > > > > > > > > > > Yes, just ignore this feedback, it goes against common practice. Cc list > > > > > as is looks sane to me. > > > > > > > > It seems nobody can give technical arguments why it's better than just keeping > > > > them outside of the commit message. Mantra "common practice" nowadays is > > > > questionable. > > > > > > Just look at how patches look like in the git tree that Andrew picks up. > > > (IIRC, he adds a bunch of CCs himself that are not even part of the original > > > patch). > > > > I know that and it's historical, he has a lot of the scripts that work and when > > he moved to the Git it was another long story. Now you even can see how he uses > > Git in his quilt approach. So, it's an exceptional and not usual workflow, hence > > bad example. Try again :-) > > Point is, it doesn't matter what we do in this patch here if Andrew will > unify it at all. Point is, that this is exceptional. And better to teach people based on better practices, no? > > > Having in the git tree who was actually involved/CCed can be quite valuable. > > > More helpful than get_maintainers.pl sometimes. > > > > First of all, there is no guarantee they _were_ involved. From this perspective > > having Link: tag instead has much more value and supports my side of arguments. > > Link is certainly preferable. Usually when I fix a commit, I make sure to CC > the people that are listed for the patch, because it at least should have > ended up in their mailbox. > > Often, it also helped to see if a buggy commit was at least CCed to the > right persons without digging through mailing list archives. How is it better than having it in lore.kernel.org in archives where you even see who _actually_ participated in discussion, if any? Again, Cc neither in the Git commit, nor in the email guarantees the people were involved. Having Cc in the commit just a big noise that pollutes it. Especially I do not understand at all Cc: mailing-list@bla.bla.bla cases. They are not people, they have a lot of archives besides lore.kernel.org, only waste of resources in all means of that. I tried to summarize that in the submitted patches to the documentation, that I referred earlier in this thread to. -- With Best Regards, Andy Shevchenko