From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 999AFCD4F58 for ; Thu, 5 Sep 2024 12:36:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0E2CA6B0177; Thu, 5 Sep 2024 08:36:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0933D6B017A; Thu, 5 Sep 2024 08:36:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E766D6B017C; Thu, 5 Sep 2024 08:36:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C72596B0177 for ; Thu, 5 Sep 2024 08:36:34 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 68AD31A1BE5 for ; Thu, 5 Sep 2024 12:36:34 +0000 (UTC) X-FDA: 82530633108.15.C4EB779 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.13]) by imf01.hostedemail.com (Postfix) with ESMTP id A045B4001D for ; Thu, 5 Sep 2024 12:36:30 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LLlzrT8v; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf01.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725539719; a=rsa-sha256; cv=none; b=ki2KLUEZ1fTQxrFKA0wBEio8eXVHPsSK5U+k9P/o1NmZP/igMnobYD4JoHXGHangaCR/Ka H/9aKlMNJW76q0DTtUONky7KWFEccVgP6yk5NA3+TNtnwvVG06G4U/TZiZO/jm0oC5FnA6 IHzW4yEjfZCDxYB56VGvaxZdQUFioJg= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=LLlzrT8v; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf01.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.13) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725539719; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IysJPwa3MUu6LewiAiwohIuuEJakDu2PjmO1bj20sxA=; b=sDxQdi0qIwTRI2NbHCDv7tckoT1CwIOhwleLoS0LKJYDK5YisKgkhgUTQRhOqDa7x7i5IT jjz1i96aTuUkyiZcmiGODR4pr2yUugCPZIDUM5HXw2N36FLtAi87zCVLAjEf0JFWNmh1mg cxbvNC7eozzcWnLcv34cVXKQAaGr2O4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725539791; x=1757075791; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tUOAOd8CYkdJjqbj7ss21WuFdmdRdcvBFxMicTiHizk=; b=LLlzrT8vQKwQ0Yu4fNcI6ZXezzS1GvHGp/i500vC/10N9rGkutTArQwx 5wevym2Ak3Ct6uz0Px7fiiURNkVP5MpcUqjXTaFaMWDY3fDSNAINnrpVE TC+kFiPTuQ2O5g0XrWwB/rdvRUkg9KTHNIE27SqEpbqd70FOdTX7PlawM oqsDDvbHN5nipI4LZqM2xqA/UJWVBs7NY53b2JdNt4R4WZb5XazXppAgS iq5GQko5nn0bQ2UdH4OoW/Plo/t8cTV3b/IgO0m9MUea6bqVikdRhiRUF 6SRQ0hC6d3jZGMLBZFllJ0v85AfyPj9gFsxftekgdKgoT8qS+lBODmSkr A==; X-CSE-ConnectionGUID: F8t048F7SqmgLLXN9qKHxA== X-CSE-MsgGUID: j1N4cwL1SAOQKolGhlveVw== X-IronPort-AV: E=McAfee;i="6700,10204,11185"; a="27173410" X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="27173410" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by fmvoesa107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 05:36:29 -0700 X-CSE-ConnectionGUID: Exg24nuaSxatVWhPMsTnaQ== X-CSE-MsgGUID: 6GCVJ3eWRzqlJgZaX2z7Hw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="70408882" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa003.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 05:36:25 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smBim-00000005OTQ-0x57; Thu, 05 Sep 2024 15:36:20 +0300 Date: Thu, 5 Sep 2024 15:36:19 +0300 From: Andy Shevchenko To: David Hildenbrand Cc: Dan Williams , "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> <65838cc0-9a20-4994-a0ef-9cd50bb00951@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <65838cc0-9a20-4994-a0ef-9cd50bb00951@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Queue-Id: A045B4001D X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: egte6n9xyntzf1t7ff3kudfjqnsbwyhc X-HE-Tag: 1725539790-298408 X-HE-Meta: U2FsdGVkX1/gV233r6Ofqks1vVlUrSje///qbQlz/8S/fGaKC8gwIDVRdrwnnOFqpw+k206sGWmzjsjxuE8ICl2XhrIYdMxUNY+cOWMekkGdDBgQI8c4MwtmT502rECQV9EJEBlyiQ8amEPKZnD6wjzOY49UijcFxYrfnnxAVPwl9+6d+gd/QtUOc4etl18vLFGj4yXGHbRBQKi6002zaHzv0SlR5Xl/W7KuAkRsjNZVbF213EGelbRhS5jKIfpwH819hgQKAJQPpDZ0EeJDyzMcbhVqCxU4Ez+ZJPGoB+e2HSBHwZkV/1fnyJtnOHy5/Upt24F7QkhNBGP4NLIIbL9Yg15B8uSohrdFwKH+YrcjyFE7ntou13SfJe5gEQF/Ug0XlgNWL+tCAZgXKOIyx4sEN8FHaqmyUeS0P4jI5w0N45bWVEKdRrVyfb8tl4Kgq5gzYEDBeQuKiQmKpvo0vXFQBu84xLa8AiipRGNrcj99TUDTMGoz32Djz2NrBwiFVdRjuAppo5sTjGFUnhAEJ6mPxjhi8ys0x9gbIHxlu/8Y/1n7jS4ccZd3zlHseVue5HM2ajjL7o4ZrrED7V0FjJmUl4est2+d9y5rCY/Mx412B7XfjfVF4BHejVqTCKk2Z4upZIRyn6pZsJyiNHVzQYsJN/m5/2t9qZ7DVSE83C4MUHayNlPl7TcxLaTZDG9CqPoD5SMNROM2UgcGHdUVWxzf99+tKsZMUwBF8obbislKgPw5CUrJM/aGfmIYWvdwH1+QSxq8hRBvIrj0yp+0hdfdrO2+8jOoG4C0+yZYKh76cONmJv+U4IEaouHE29dEQui4EQAeH4UFspT5Cfzth8zaQeMiIELWcKhvUiHNMQAOUoh7OIs36udrmjSu1fBYcZN254TuI2Onyu4oIudXyjjcVqZFLIRYOK8fU+se8jO4khBYfTajEqVoja0L/gJM903fKFC9gQfiM2eObq/ Mp4aPvwh Y///jL2PYhUg71UcwYUrqfeZl5BIc3SgOBdQy8C2mpmHjmWtfuKRlvivvdycnUH/V8sG7GvO2ed+S8uDrUWCgUYYH1tSth0lw9pAUhxRbqNJtP5+c8RvZ5MsLhVGMWF5/wZt7j4P2cG31mcm2+t8OTOxTTWgc0HKqnrsGaZXyqo8BDM1GkXPpeFvqw72QfJWSA7eH6ivdIbAcTJJzKZXSPV6DV3aOgdDP8OJX4kn7Zh73mAjX21S4qgTQZRSgIUPtcjmJHbVD7mc1twvNiQadjgOw4MrLIGp0ZnF/E5vA020Y6ak= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 01:08:35PM +0200, David Hildenbrand wrote: > On 05.09.24 12:56, Andy Shevchenko wrote: > > On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > > > Huang, Ying wrote: > > > > Andy Shevchenko writes: [..] > > > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > > > > message. > > > > > > > > Emm... It appears that it's a common practice to include "Cc" in the > > > > commit log. > > > > > > Yes, just ignore this feedback, it goes against common practice. Cc list > > > as is looks sane to me. > > > > It seems nobody can give technical arguments why it's better than just keeping > > them outside of the commit message. Mantra "common practice" nowadays is > > questionable. > > Just look at how patches look like in the git tree that Andrew picks up. > (IIRC, he adds a bunch of CCs himself that are not even part of the original > patch). I know that and it's historical, he has a lot of the scripts that work and when he moved to the Git it was another long story. Now you even can see how he uses Git in his quilt approach. So, it's an exceptional and not usual workflow, hence bad example. Try again :-) > Having in the git tree who was actually involved/CCed can be quite valuable. > More helpful than get_maintainers.pl sometimes. First of all, there is no guarantee they _were_ involved. From this perspective having Link: tag instead has much more value and supports my side of arguments. Anything else? -- With Best Regards, Andy Shevchenko