From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B64CACD5BA9 for ; Thu, 5 Sep 2024 10:57:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4B6BC6B0107; Thu, 5 Sep 2024 06:57:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3C8CE6B0280; Thu, 5 Sep 2024 06:57:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26A4E6B0282; Thu, 5 Sep 2024 06:57:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 4A4A86B0107 for ; Thu, 5 Sep 2024 06:57:50 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id F1BA080B9E for ; Thu, 5 Sep 2024 10:57:49 +0000 (UTC) X-FDA: 82530384258.29.491AB3C Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) by imf23.hostedemail.com (Postfix) with ESMTP id 97F54140009 for ; Thu, 5 Sep 2024 10:57:47 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MOV3q5Kj; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.12) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725533818; a=rsa-sha256; cv=none; b=eSph4vwDhzhrU5991i+THfADANsSRUkt1baFrp8+6yUtkXBvoHk9cWuXJ2Eu8nYazUqoYK cbIENsp5FZNJNpcLq+2oKkK5CdYpFLTdSnkFzFCooBU5I71Z7ouo7IElCKRPBfxhnZeHr2 agX9//S5An4Nhapw9wcPJwANy51pt64= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=MOV3q5Kj; spf=none (imf23.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.12) smtp.mailfrom=andriy.shevchenko@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725533818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1k5nvWFPJy5L+YcZwaqV8WF1IPdvY76t+/KLZY2fw2Q=; b=0tk2vv8jGuybVIIiqipYRSQb2hkPHqlWZ23VoNMeXnXjZ1S1+0SMjUZh2Isde1uqw8nTbn fQarCOYP6unzNNMLklxgkdDJIZDb4w1CmRA6M3IR9UV0WQ41yrUcszsm9qmR5OUnWof+n1 FxDQHY+w7bEjsCXIMEh5xxCo8uGMI5c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725533867; x=1757069867; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=DI+sK8/T3gsskf8f7Ss0ayjTN8+mqBY1/Q7agvx86X0=; b=MOV3q5KjFEETDjzI3IWnMRhiFhzK29LkM7eCGzR4sEXjnnNNf3add9O6 FHcUyFfxKJaifsIrwbD+7nEnosNRt4YFXCjRdA2gPtJLENj31JgQbY4mx zEnO0iKhZ1uzqKa6lenTJ4zhSOa86dZuQso7ZBQQSK9Ke/HLNJkd970ff Y7PH+cZjGUcEY3KLLgm+xsRpfB1QzUKnk0CF+4Y6disxBNHIX1IByXWZb HRtkpRvnFW3mNx6okLy8yNaQtjVTqNeilAvZsriOJM1rYiuf7g8q1+qM3 LdShrcOXr4goqq13QJE9FoNEtjSdNML3XITTzXX4BFnmfdlLLJ1arPyYw A==; X-CSE-ConnectionGUID: Y9gd9ZXfQguJDDurk+mGYw== X-CSE-MsgGUID: 8fknqhNYSAO6SmjwOq07KA== X-IronPort-AV: E=McAfee;i="6700,10204,11185"; a="28131156" X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="28131156" Received: from orviesa007.jf.intel.com ([10.64.159.147]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 03:57:45 -0700 X-CSE-ConnectionGUID: iNVFaFI9Q3aOkLfmT7/UOg== X-CSE-MsgGUID: 4r3rc4XZSy67rTi0AfwWzA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="66108488" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa007.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 03:57:42 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smABF-00000005Mqd-4BDl; Thu, 05 Sep 2024 13:57:37 +0300 Date: Thu, 5 Sep 2024 13:57:37 +0300 From: Andy Shevchenko To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Dan Williams , David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <87tteu6c01.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tteu6c01.fsf@yhuang6-desk2.ccr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Stat-Signature: 3h91g6bod679snhwmue8zop839fotsxa X-Rspamd-Queue-Id: 97F54140009 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725533867-746425 X-HE-Meta: U2FsdGVkX1+zZe0c9wZUAs0C19sI0luAZs4PxkBFjE8IErrwya8c+oHyrDWjX04ArjNr62Kz81B4WXJBPXrJPouEOqu+PKNdHYgHlWFaIt5UzqzbMbsi1DU9L8NUq8g9PCBv3CLjhCQHcfGcGRapmm5rdjz08Olril66+NkwWRjiCSvyXVRLoFaXX1udbFKSMXKBKKkA5pJCbZ5aCNkdLL8WTB/qQOwaMRXBDuNb2ZWYIKADXSzZeUrSpONqS90MRwmbU0qv4zce9WFQWAYMLl7kYnvgzUKVRpOjPH/cFCu0ZJD5Tcpg7oJav3vF61LPn/6F1NYsZOCo7bey92ccYuhSAwzz2mPsGhTGRZEqV7nSCIEo5iYzvcfFzWJmd0i4Q4DTKgRJwN6Ta45Q0/UNZJ4MGkULW1VOTMPRd5a/wjmdMTD5LKKnYicdjWPZXYMn2CCYBr4L/wbthkYUwn52kdG0MuMyKw+2e5N14upt148IIrBDoAEVAEKMHOJirIaz9LfQ2VCxuJxlpn7e1JxamVmAAWzfT2gaQkKydx7qTJBpRSbA3mmngLxBshiMwfBcyNM0w6RdpfuXndce8NK3ZMoGhzjb22N9ndUSabXTVMbsnI1yi9wRC9EDNQUP5j0ezv8lWGJEyqFwinBQZpQPzectCeP+KfleduW9ig5JlPkyoD9aIXYXtoYTgW6J3ccpbhYBvs936dOE2qsw3vfpHWL+3dsC0Ymms3NpEV+qaNNX8wB4xazxFTOj4Fux0znNAZCAkm/Y3zYix/YC9698TGAV1Pu0X94QTivsPINqvox89McycZIRXtTlDxz7YMnJc7GDTsEFM3Hr3VdOEP+KVVuYzBDKN7LiZvzomzY4UJ0NvqC4wWpJtiaJy5VeQ0q1skmwG7SCgut0qFW2Q9WClikcGpXQLlQLF3MCepjGXeiMzz7ZvGzQi01COKTwdoDWEBStHQv1sNiLmTGqtz9 dOEGmJ5r 0jMKwa751QyQHdlqBh4WVf8pLxyatJr5T/uC0Z1blRNqmmpmdIc71kLpzuC5LNmAf122s63e0DWrZB2/3q0O0mKls3CsA8ZP5f7AKI9JkTW0LbsK1vEFwMjYqImaQJXY4z9s8rkhDyV2X2oVHUM+O8H0RVCzN4ZNyefs3LqC3K+vKfOCpNJsPeX0pKZMcpa9T10b/VHX9BO5z0cXdHYM/KYDrEgfVa0G/ZJ/fnhw4fN/WuMOJO10WqQgRHlaGq6sE2xWEVTIknlDXEWU4bWBnbJVtjzy3Hg4WDFz3AcfQgC+otcc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Sep 05, 2024 at 11:00:14AM +0800, Huang, Ying wrote: > Andy Shevchenko writes: > > On Wed, Sep 04, 2024 at 03:48:44PM +0800, Huang, Ying wrote: > >> Andy Shevchenko writes: > >> > On Mon, Aug 19, 2024 at 10:34:13AM +0800, Huang Ying wrote: [snip] > >> >> + ostart = max(res.start, p->start); > >> >> + oend = min(res.end, p->end); > >> > > >> > Isn't a reinvention of resource_intersection()? With that in place you may also > >> > drop the above resource_overlaps(). > >> > >> sizeof(struct resource) == 8 * sizeof(unsigned long) > >> > >> Just want to avoid to define another struct resource on stack. > > > > Is it a problem? > > Not a serious problem. Just prefer to avoid too much stack usage. > IMHO, the benefit isn't large too. Benefit is so use existing APIs and see from the code where we handle resources (in semantic meaning). -- With Best Regards, Andy Shevchenko