From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31F20CD5BAA for ; Thu, 5 Sep 2024 10:56:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 666136B0376; Thu, 5 Sep 2024 06:56:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 550C66B0378; Thu, 5 Sep 2024 06:56:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 243ED6B0374; Thu, 5 Sep 2024 06:56:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E8B986B036D for ; Thu, 5 Sep 2024 06:56:24 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A492D161B52 for ; Thu, 5 Sep 2024 10:56:24 +0000 (UTC) X-FDA: 82530380688.19.E73F153 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.19]) by imf15.hostedemail.com (Postfix) with ESMTP id D7EEFA0017 for ; Thu, 5 Sep 2024 10:56:21 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ecSYbZ+D; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725533674; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N0MFMAsF/rY8zI9PWXRCUjcFbA5GRi8R+pNJG4JQDpU=; b=MgI6dkcMmPfe6Bq7Rk1ZJbWT6uu5pf6PGnd2xXq3QWedXmwfyjGm/nuaRa/pR7GEHJPFjX EWbvp0WYolWsWoaJJlyh6t+mYBjBC/cu//5hXqgQaG1/1WG4AO5sryXsNwEqMou+EX27N0 Mai6Fua/DIyGIOgXv4c1zPMWWuHIOE4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725533674; a=rsa-sha256; cv=none; b=PaFtydDOjsfd4+qLxsmdC1lOgb4sezZlflmAv8IkSx+wsSrCW1ZMAa/zJPZU01v+CjoxQz EPnKzaU1uCO1JgeRxDYI9lZ6XPOQlr6h3lUGy3bXAE7TPvkYIr1Q47tlnyRESYYFX1kYvM dAwvTHtNXb3eigoMUt1iuAxxQ7tkVcA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=ecSYbZ+D; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf15.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.19) smtp.mailfrom=andriy.shevchenko@linux.intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725533782; x=1757069782; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=Wk1LIKQbYQFhOY73fCkbnAsWD2OyDkMfbFjwDTD6xHs=; b=ecSYbZ+DJYyxiMiw8SeZWheyaSvTU8DW2fTIkcM+YtHiC/VPtlHsdrYn qQUkSwHfZZDs2/HhpL37tDi5LSwgz/C5cpOSlJykbbb8YqxRMT8SXL96P e/kGmdz0LLTQUWgNRktyWQlXRbYtegcEmq+3laPVfXxJzzMz9QpeYiBEz 82e91hf5uu2/f2ywXHXoFxAwSqFpOhsxAyxSx1EHnoF8Cd2X8+XTZ1xS3 8YuuybChTh9ubBMuk7z+MsyGjMQh+GyJtIJYh3C7jI6Rwtfs4CCpDnm1/ XfLMZ0JdOe4M6IzdCcrxufigrxjhVGeqmofSk3rlZUhEtbTU8UwTliD8s w==; X-CSE-ConnectionGUID: tPVCt41WQ8CrzhNIwmLSQQ== X-CSE-MsgGUID: csmqXA+xQuaNmZ3okTw+FA== X-IronPort-AV: E=McAfee;i="6700,10204,11185"; a="23800209" X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="23800209" Received: from fmviesa004.fm.intel.com ([10.60.135.144]) by fmvoesa113.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 03:56:20 -0700 X-CSE-ConnectionGUID: U+51NrYkTdW4nYruBTQgKA== X-CSE-MsgGUID: ZvBcwRMNQhaVASWjD1CDDQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,204,1719903600"; d="scan'208";a="70180004" Received: from smile.fi.intel.com ([10.237.72.54]) by fmviesa004.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Sep 2024 03:56:16 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1smA9t-00000005Mov-31NN; Thu, 05 Sep 2024 13:56:13 +0300 Date: Thu, 5 Sep 2024 13:56:13 +0300 From: Andy Shevchenko To: Dan Williams Cc: "Huang, Ying" , Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D7EEFA0017 X-Stat-Signature: qjgdo3sabukjkf1qsarn1b4ukwaxzzjh X-Rspam-User: X-HE-Tag: 1725533781-173489 X-HE-Meta: U2FsdGVkX1+c5L4/WS1dP/WqLCKKObQjZLhkBJJ8WrG/crbYh/5QgbXGCUn2NDogeBPQEY5ZZ9PRrGr4gpwsl62Dqeh/iHhLWs3XmXacdQ7gO/X2Q03ncvixHNGBXS3nWKOBoYha0gVfLB5eYyPLiImIXIiqhRHkxLwORtqgI80S/wYPfPXFD7KIdNKmaUQuP4BtIInvQ1W2aqW5yAOWa3RXJj1u/K3hAatVfrHfkcT+fHRyMYoA0Rd3RaumFur1egetON0faer1BqDuLLjODz69JqRET6lJdw5vdXgHLEH7pgTBZ1VqvmsMC7WAWHpgEHvSW79FaDTygqlfsUZlOu/f5CYYeIY/zQVbUv8LdBavXNaDiDautxPPSyRmgaQcGapG1i1rPoF+ygptY8f9uiSBEqapaTSpuvJsFF3QPj/HomGAW4W3BPi+zPDw+UdeEftT4K8EPC0/cHcpIOK37rqgXOfOQnZVrXB2vckmlnyGIRDDxlFDmsjjbBGqt3N+lwosnJ++MahivUrirjKfedWPZTBEh78Vz4oI9M4CaoBnxpT+vFJIqNm21Z9eMDzvAL18rHk19LphlS/5m2O5fzX/waBr9j3LePhDFIIuVR+fiuQ+I37LOdZIDMLS2v29YaPlwKat5hLMed9Z/kU/XhTF4u0nyVYmXRHGvhQKLMUDyiEGqme5NuebmDK/TmHSSC7Q2rwSQNU92SGmY2jFVRYgpQkAR/oAPgNlDzFRUv3RFmTglA0iKWp6zHck3mzyyBnzbbh4I504vit8l0FBmlBbkdEYwYjDVi/+gUQamkAdWSYv5eenVHC/Gl1WeCQU5G+ncDqNy/0g83yBQfuLHMbuEYxlQWAG05o9r655VOb3WdrLag/u+VuKQ5rq/0RxnJo/hmolrDYBS9lSFA5vearRG8v4h3I/1n9WHtDKEYM/MJ3cYIoUDcKKTCdj3QsMJm6l9dSTyxNeIug8Vna BGnFjZXC Go3VUoX1b0ae+5LfFuEVT1NSRdQ1HORIZoLU4A/Y5vdkAeoZsuoVRmFg9yeoaX1lof/0cNNxc2oQdwLM2Fndfw1qbc3Meoil7Bn7yLUz7BVwSy4YsNU+nY+jirocHG9SHp4Ald6D44fXc2VH5Ivw4IhLIQACHjrejOGeIyYsw7X94GRQIa9S2CLkEDOfgHa9O1h9UWYguHsLPiEalGq0cFl4UOZWJjoDS9WYNp+0UZxPUqacoScwN2Yk2dbGntzxNDSpAbOt/JHLi6LH41VTBQza/DA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote: > Huang, Ying wrote: > > Andy Shevchenko writes: [..] > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > > message. > > > > Emm... It appears that it's a common practice to include "Cc" in the > > commit log. > > Yes, just ignore this feedback, it goes against common practice. Cc list > as is looks sane to me. It seems nobody can give technical arguments why it's better than just keeping them outside of the commit message. Mantra "common practice" nowadays is questionable. -- With Best Regards, Andy Shevchenko