From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Dan Williams <dan.j.williams@intel.com>
Cc: "Huang, Ying" <ying.huang@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
linux-cxl@vger.kernel.org, David Hildenbrand <david@redhat.com>,
Davidlohr Bueso <dave@stgolabs.net>,
Jonathan Cameron <jonathan.cameron@huawei.com>,
Dave Jiang <dave.jiang@intel.com>,
Alison Schofield <alison.schofield@intel.com>,
Vishal Verma <vishal.l.verma@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
Alistair Popple <apopple@nvidia.com>,
Bjorn Helgaas <bhelgaas@google.com>, Baoquan He <bhe@redhat.com>
Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory
Date: Thu, 5 Sep 2024 13:56:13 +0300 [thread overview]
Message-ID: <ZtmOTYF9EWPeLg5u@smile.fi.intel.com> (raw)
In-Reply-To: <66d8f41cb3e6_3975294f9@dwillia2-xfh.jf.intel.com.notmuch>
On Wed, Sep 04, 2024 at 04:58:20PM -0700, Dan Williams wrote:
> Huang, Ying wrote:
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
[..]
> > > You may move Cc list after '---', so it won't unnecessarily pollute the commit
> > > message.
> >
> > Emm... It appears that it's a common practice to include "Cc" in the
> > commit log.
>
> Yes, just ignore this feedback, it goes against common practice. Cc list
> as is looks sane to me.
It seems nobody can give technical arguments why it's better than just keeping
them outside of the commit message. Mantra "common practice" nowadays is
questionable.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-05 10:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-19 2:34 Huang Ying
2024-08-19 8:13 ` Andy Shevchenko
2024-09-04 7:48 ` Huang, Ying
2024-09-04 12:43 ` Andy Shevchenko
2024-09-05 3:00 ` Huang, Ying
2024-09-05 10:57 ` Andy Shevchenko
2024-09-04 23:58 ` Dan Williams
2024-09-05 10:56 ` Andy Shevchenko [this message]
2024-09-05 11:08 ` David Hildenbrand
2024-09-05 12:36 ` Andy Shevchenko
2024-09-05 12:42 ` David Hildenbrand
2024-09-05 12:50 ` Andy Shevchenko
2024-09-05 12:57 ` David Hildenbrand
2024-10-07 14:24 ` Andy Shevchenko
2024-09-05 21:37 ` Dan Williams
2024-10-07 14:16 ` Andy Shevchenko
2024-09-06 1:07 ` Huang, Ying
2024-10-07 14:12 ` Andy Shevchenko
2024-10-08 2:52 ` Huang, Ying
2024-10-08 17:01 ` Andy Shevchenko
2024-10-08 19:02 ` Dan Williams
2024-10-08 19:18 ` Andy Shevchenko
2024-08-21 18:46 ` Bjorn Helgaas
2024-08-22 1:43 ` Dan Williams
2024-08-22 21:29 ` Bjorn Helgaas
2024-09-04 23:58 ` Dan Williams
2024-08-30 6:43 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtmOTYF9EWPeLg5u@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=alison.schofield@intel.com \
--cc=apopple@nvidia.com \
--cc=bhe@redhat.com \
--cc=bhelgaas@google.com \
--cc=dan.j.williams@intel.com \
--cc=dave.jiang@intel.com \
--cc=dave@stgolabs.net \
--cc=david@redhat.com \
--cc=ira.weiny@intel.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-cxl@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vishal.l.verma@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox