From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9EA7CD4857 for ; Wed, 4 Sep 2024 16:18:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 440306B00F4; Wed, 4 Sep 2024 12:18:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3EE3A6B016E; Wed, 4 Sep 2024 12:18:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 28FA76B01A3; Wed, 4 Sep 2024 12:18:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 08C1D6B00F4 for ; Wed, 4 Sep 2024 12:18:58 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id A286D1C5118 for ; Wed, 4 Sep 2024 16:18:57 +0000 (UTC) X-FDA: 82527564714.05.89F8502 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf26.hostedemail.com (Postfix) with ESMTP id D4133140013 for ; Wed, 4 Sep 2024 16:18:55 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Jr0W+cR8; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725466608; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/AHroGqRWp7smquL5PdsSHEEg2hWlixexSI2pPw9pKo=; b=OyQWhr8z66anlpeKzKTBzsshSAjd6IdRkuYh0FPDHGubfryAfJh5XxSA1eMZxcAtAbaG9f sEnoEVXONeJcwBscInkNYP1/rsu9FjlA5D27zKYTbWO+HGLFENvayu7cmb1J5MCX1QiB6B v3tGhrB1YHHjLdg3HOXV1WiS3hBxKuM= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Jr0W+cR8; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725466608; a=rsa-sha256; cv=none; b=OMB45+JhSHDDb2OcjXhDbJgynK5xvaBfXcLW1nGBAhLAPFH71Sz5I2CTtgMhGg4DHdN8r4 6iP0GyZHRv61LqWQ1q65m+10cnjonEG/hP4xSIhsJkzgjZy0VnI3gLamQ7BdB2ZukGQRWG 2ClJqUmFOgN8oCH3ypxSUFyfGD1wGfo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5728E5C546A; Wed, 4 Sep 2024 16:18:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3286C4CEC2; Wed, 4 Sep 2024 16:18:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725466734; bh=tesxBCfwTg/kuycru8Mg8u33/AsWOez2Oe+2bc/mUpc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Jr0W+cR8hIUdNwmqShiz1t9o+WnBH+SKdPQBjMZobL8IaSZmfyg16ByWaUSNmn3az eQ2V7PjXigS7rWNXM3TDxuIM4nNMT1Z2K2AGImWSjnP3HEVpjQTCUWLaBsaMu0bDJH SWKOTJFC1Ha7BQo4fOCsrVooZL3wUiTkI10L69koN8q7dRUG5PX4Yzd6NvQeAW89sE 4lM6KUoGKB2xgkW6DQ/VR1jLlqh5oQJDz/gz09dcshIHHIqdP6nqK06BaAmW4bSl1I GPqCiXVnPV7eKuWETTIHoJN2sSvh86xKDJt3Oq7aLImNtI2gyXcCjU0p76x1qBv+HB rquw64gZAScWQ== Date: Wed, 4 Sep 2024 19:16:07 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 02/15] slab: add struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-2-76f97e9a4560@kernel.org> <20240904-bauaufsicht-gewohnheit-a70bd9266986@brauner> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904-bauaufsicht-gewohnheit-a70bd9266986@brauner> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: D4133140013 X-Stat-Signature: 1ka4j8mrchefc6eioga3xtfgatjxu5cy X-Rspam-User: X-HE-Tag: 1725466735-779201 X-HE-Meta: U2FsdGVkX1/q3fXtMg+Zs7Amrwf/rSSs0Sb1ET0IYXtZssSDCVhSzrCFRP7XhholGRZ2s5/fDSok/IVT/O1W04WQWGsqw5+jS9NxovDQ/HVbaIQK1mMhy2O+S37OB9eLzt2jMIZeaO+j74/v98+zVLBLyifQhz6IP+I9iJfIIZyVdsRfDORlksVBTTUIcIeSorQpumd8hQCwltu2UjPX1dcCvT0SUiljfjSdFhaYXhqeE+N9VI9hdcdFcqupsWJF/9J4XnbshyUlvoKua/7128ufrrBrv8UIevQejqUVRWJPJhSufVRT0GkabneL6sCsOYwBhVkveP8hyxCvu02g/A2h03UGx+2DDZ4qzSDLscChjkXtW3z3yB6Ur8Yxlf2WnlEgSbtfEwznrb7aSRFU9w+Q+jRACNOWtXek+XOmcTgZDirIj1cw+nF8kFjOFD7OtAkrw8+wnPqG6lFDYfis+z23DIhrVfNx58LdG8CKQhTgs2f/Yxahc5QOP0FYZKbg7ymGHDgoW2uxr7hS8tWuotJ0wvi7IqvduqBcFtnxOxivNzSzDcsuT+w4ua6F/ukE0fShyddM9+/mE4iVSgKYA3DRYetG7x98qpWPi0csoBh6bsHXHtsY0zdg8hvTVCvtFDtgFWwi47Wh/0Dj9jeNxqqgXKTBkXB3hB40QtjbNrM16Vu+33GrwDlLFkzfcGAHFSp32DTZU0Xt8D7pMmtVSS1Z6M3EXUSozzJRhLFi736+Ugw6H3+qW+zBiunSj+uaC5NM2oUeivwQc2vHyqdy8rF4SBSj3NZkWk+ueb8M6oBmmHy5Cb9GT2hczXO5kRvgfCat67ScwOWfymVYebZhTPt6DybOncUT/m+N9fzgvCmJ3oiwoYFha2HvK+M7s7HD5MBrye0Lsofg56UgPXdQUKy7Mgvo2UTK8oxKxr8Sgl+OVSmjK9f0FdrpKDSSSvmEf0vOLjwoDyD1gjmzfnA 023cE2iI 576LxAYf6ODT/6Y76oIvc9aU3Jbp7PifP1aJdg5KrldmkET5DovMGJrTZzibA7x9cAo29lMht3uC+T0nZREhpha0ZQLzP9xN20ckFgW/gwBFZ4Rl46O2EGKVd9CtVC/gFhMmYBglBMl7nTy431sJ6KOTZraY5beh6olm+b+nO+VOeHhwEddmtuWHFfMg6Hf9vqDKeq1IFoo+doqgAXquJvhWLFugtbryOlg1+cOLx1mMkijBUEK46wV6f+GmJJQfSm0xSGFZJsGIzWa6BEVI8aVl0990CNZMdYcJlHh45RWpi0NfEJcQVa2FjynLt/a4dV+EvbgCkRgMA8aQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 05:48:31PM +0200, Christian Brauner wrote: > On Wed, Sep 04, 2024 at 06:16:16PM GMT, Mike Rapoport wrote: > > On Tue, Sep 03, 2024 at 04:20:43PM +0200, Christian Brauner wrote: > > > Signed-off-by: Christian Brauner > > > --- > > > include/linux/slab.h | 21 ++++++++++++++++ > > > mm/slab_common.c | 67 +++++++++++++++++++++++++++++++++++++++------------- > > > 2 files changed, 72 insertions(+), 16 deletions(-) > > > > > > diff --git a/include/linux/slab.h b/include/linux/slab.h > > > index 5b2da2cf31a8..79d8c8bca4a4 100644 > > > --- a/include/linux/slab.h > > > +++ b/include/linux/slab.h > > > @@ -240,6 +240,27 @@ struct mem_cgroup; > > > */ > > > bool slab_is_available(void); > > > > > > +/** > > > + * @align: The required alignment for the objects. > > > + * @useroffset: Usercopy region offset > > > + * @usersize: Usercopy region size > > > + * @freeptr_offset: Custom offset for the free pointer in RCU caches > > > + * @use_freeptr_offset: Whether a @freeptr_offset is used > > > + * @ctor: A constructor for the objects. > > > + */ > > > +struct kmem_cache_args { > > > + unsigned int align; > > > + unsigned int useroffset; > > > + unsigned int usersize; > > > + unsigned int freeptr_offset; > > > + bool use_freeptr_offset; > > > + void (*ctor)(void *); > > > +}; > > > + > > > +struct kmem_cache *__kmem_cache_create_args(const char *name, > > > + unsigned int object_size, > > > + struct kmem_cache_args *args, > > > + slab_flags_t flags); > > > struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > > > unsigned int align, slab_flags_t flags, > > > void (*ctor)(void *)); > > > diff --git a/mm/slab_common.c b/mm/slab_common.c > > > index 91e0e36e4379..0f13c045b8d1 100644 > > > --- a/mm/slab_common.c > > > +++ b/mm/slab_common.c > > > @@ -248,14 +248,24 @@ static struct kmem_cache *create_cache(const char *name, > > > return ERR_PTR(err); > > > } > > > > > > -static struct kmem_cache * > > > -do_kmem_cache_create_usercopy(const char *name, > > > - unsigned int size, unsigned int freeptr_offset, > > > - unsigned int align, slab_flags_t flags, > > > - unsigned int useroffset, unsigned int usersize, > > > - void (*ctor)(void *)) > > > +/** > > > + * __kmem_cache_create_args - Create a kmem cache > > > + * @name: A string which is used in /proc/slabinfo to identify this cache. > > > + * @object_size: The size of objects to be created in this cache. > > > + * @args: Arguments for the cache creation (see struct kmem_cache_args). > > > + * @flags: See %SLAB_* flags for an explanation of individual @flags. > > > + * > > > + * Cannot be called within a interrupt, but can be interrupted. > > > + * > > > + * Return: a pointer to the cache on success, NULL on failure. > > > + */ > > > +struct kmem_cache *__kmem_cache_create_args(const char *name, > > > + unsigned int object_size, > > > + struct kmem_cache_args *args, > > > + slab_flags_t flags) > > > { > > > struct kmem_cache *s = NULL; > > > + unsigned int freeptr_offset = UINT_MAX; > > > const char *cache_name; > > > int err; > > > > > > @@ -275,7 +285,7 @@ do_kmem_cache_create_usercopy(const char *name, > > > > > > mutex_lock(&slab_mutex); > > > > > > - err = kmem_cache_sanity_check(name, size); > > > + err = kmem_cache_sanity_check(name, object_size); > > > if (err) { > > > goto out_unlock; > > > } > > > @@ -296,12 +306,14 @@ do_kmem_cache_create_usercopy(const char *name, > > > > > > /* Fail closed on bad usersize of useroffset values. */ > > > if (!IS_ENABLED(CONFIG_HARDENED_USERCOPY) || > > > - WARN_ON(!usersize && useroffset) || > > > - WARN_ON(size < usersize || size - usersize < useroffset)) > > > - usersize = useroffset = 0; > > > - > > > - if (!usersize) > > > - s = __kmem_cache_alias(name, size, align, flags, ctor); > > > + WARN_ON(!args->usersize && args->useroffset) || > > > + WARN_ON(object_size < args->usersize || > > > + object_size - args->usersize < args->useroffset)) > > > + args->usersize = args->useroffset = 0; > > > + > > > + if (!args->usersize) > > > + s = __kmem_cache_alias(name, object_size, args->align, flags, > > > + args->ctor); > > > > Sorry I missed it in the previous review, but nothing guaranties that > > nobody will call kmem_cache_create_args with args != NULL. > > > > I think there should be a check for args != NULL and a substitution of args > > with defaults if it actually was NULL. > > I think that callers that pass NULL should all be switched to > KMEM_CACHE() and passing NULL should simply not be supported. And the > few callers that need some very special alignment need to pass struct > kmem_cache_args anyway. So there should never be a need to pass NULL. But you can't guarantee that some random driver won't call __kmem_cache_create_args("name", size, NULL, flags); At least we'd need if (!args) return -EINVAL; -- Sincerely yours, Mike.