From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57115CD3431 for ; Wed, 4 Sep 2024 12:44:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1FAC6B03D2; Wed, 4 Sep 2024 08:44:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CF736B03D4; Wed, 4 Sep 2024 08:44:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 897E46B03D2; Wed, 4 Sep 2024 08:44:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6D19F6B03CD for ; Wed, 4 Sep 2024 08:44:07 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id E39151A0E11 for ; Wed, 4 Sep 2024 12:44:06 +0000 (UTC) X-FDA: 82527023292.23.5BA9859 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by imf30.hostedemail.com (Postfix) with ESMTP id D241A8001D for ; Wed, 4 Sep 2024 12:44:03 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DiLPqok4; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf30.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.16) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725453766; a=rsa-sha256; cv=none; b=5AvBuS9egHEBFx3idEFY5+iEXmbBlwj+H1bO3c8AX+yS0t0kRe2wGBvh19cC/sA75RlrPu X32Eggs2HhbJVZizp/L/72I67ffGGd3KTED4Zm4hC/nTReiRKy5gNlPeXRVQxqdjreFCRW p/NjNKsV/tf8QpOACXi8AhvyFmZl4Ao= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=DiLPqok4; dmarc=pass (policy=none) header.from=intel.com; spf=none (imf30.hostedemail.com: domain of andriy.shevchenko@linux.intel.com has no SPF policy when checking 192.198.163.16) smtp.mailfrom=andriy.shevchenko@linux.intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725453766; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Xvm6yodKaYXp6aEZmRC3O35O2LsNysrr2eXYpKb2zRE=; b=ZteVExOrU3RL+51QRaVdOaWd2UJZu27Vi3eGvKiVWXjnm9UXBVW3vHCNN2ZArmu0CIn/47 Dg+pCacvfQEavOGJy88XDBe3oXiYGR/2Xh13Il9HHPg8HYQCNiX9a3tSQUDEfri80KCR1E A6zW1z/CwAfmNrGEnmCBq1ozpaG1Zfs= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1725453844; x=1756989844; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=tJGTLcktLd7tavZHRdOlm61GQ0ma4cOPb2sKQtEiXps=; b=DiLPqok42bLC21bGBGjNe8NVFpO4CvAqviBn0Kq+C12HUBkyhx5QZvbH XqxR1OoQE4CGligbYOH9BTu/rZwb634Frr3S894kijJActyeJDdB5f+RP T3cdPkRGWUkTwgMsUcZWqZAKaVgrpf1B8keHO5frUHMYBU9RSQKQgYYjD ccn1T+01GC/tvm0Di5gSWEeYdhSWj3tve9kcMRkZvJQ+T5FJZQbX2/NtM M+nMjrUn1NY7dUAEuP1UOxQIPuJtUjmm7D2zngZ5OcJM9yk2iIdkQFhlg JxSsoisaXdxSVy/T42zGIL6T7jUen8gS4Tnshkae8Q3H4uN6J+JU28gy6 g==; X-CSE-ConnectionGUID: RQDTNKlQSIuE4UuTR0YtYg== X-CSE-MsgGUID: waZIXFC4QEWB6t0+ve8ICA== X-IronPort-AV: E=McAfee;i="6700,10204,11184"; a="13368167" X-IronPort-AV: E=Sophos;i="6.10,201,1719903600"; d="scan'208";a="13368167" Received: from orviesa005.jf.intel.com ([10.64.159.145]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 05:44:02 -0700 X-CSE-ConnectionGUID: mBEWJLO1SHa3KbIefr81zQ== X-CSE-MsgGUID: vnGnocvRStC/I5gMTVre5Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,201,1719903600"; d="scan'208";a="70069854" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa005.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Sep 2024 05:43:58 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1slpMY-000000053xj-3rwX; Wed, 04 Sep 2024 15:43:54 +0300 Date: Wed, 4 Sep 2024 15:43:54 +0300 From: Andy Shevchenko To: "Huang, Ying" Cc: Andrew Morton , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-cxl@vger.kernel.org, Dan Williams , David Hildenbrand , Davidlohr Bueso , Jonathan Cameron , Dave Jiang , Alison Schofield , Vishal Verma , Ira Weiny , Alistair Popple , Bjorn Helgaas , Baoquan He Subject: Re: [PATCH -v2] Resource: fix region_intersects() for CXL memory Message-ID: References: <20240819023413.1109779-1-ying.huang@intel.com> <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874j6vc10j.fsf@yhuang6-desk2.ccr.corp.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: D241A8001D X-Stat-Signature: pmf15ucrkykkd6wzmut8eu8aef74oion X-Rspam-User: X-HE-Tag: 1725453843-432683 X-HE-Meta: U2FsdGVkX1/8adZRjcZNIp2ZmPp2XFA0RaA2xRf7gyYEZg2IF1qh+vpcTJhyqXHF65r6MOmn+nLHqmeUBKF8AE3hx9HFnLnEr9SlC/Jih6k1civG95FlVu0ZDgZ5ImiOsZPRJju7VV+EhwRt8hxTML2C7S4wCgdq7RvEuBYlBJU20mq9FyyPI5y6pbcsVLtk5sk9Lct04GJrm5rvSSlcIr0+naVOi9znigcn8isWD1hf6ODZDZbA7SQVi2aizyI4T7W4vs/lYihxw4O5exFAsY1aXucVVvmCFyqja+XfBpeN11ElnhW4KSyNrMvwBqjcn3Mw/xVlXgH6Mmld7yIC/RQK8ldwIsL2aiS+xTA8lHTaPSHPjDZdkm6WzJ2esmPhxaw+0ajHG01JJ3Fg6HeARKl4RVeO7TLKi1YWI1tRMj6hEorLww2I8nbtUYA6V0MCZC9S6NyfkA58ruhEuW5teOx+ca4jhSry2jD9V/Cs5xzICWr5Voi8ycYWmPyoDh3B9HUpxy4t4lDoEfWpT+s2Qq/4/Bf4UPyMje79zFdbGof7tvuKO6NVbPAhU83emU4k1ndBv5Kijtmv9L2YHmRdCcl/N4LFMorTyhaGsTmOXrnaxZxlHodk4vbLjqyz2jewo6wJ8s8H4HKpQ6o4POkzziBNUcApgoaThf0TN6bjJHpWUDpCeA0aw0IQwJj1ru5VACc9H+rZ0NftSsh2jc5feTjPM8bO/VuX1pR4ffZUWvfx/RxpeS/prnCG/m2Yfl4j680vk97+dKi3YYRiKOw5Q1OtXo2+MBGb6NoauyVvFL7zosl6jP/A6TVf2vJ54N1JmyRwt1ashbl8hjMw+iuzfECrjDfVKyuS5lUCoxfRwir68q3lbKjHdpkYLYXUm5c5lj75VOUgGcKZjScqKW3jgBabuCi8HPMJenEcTvYsacsOd6Big2KobbkjSs81lM0RPv6opmWtRiKG8mqePrS fRCZa/Bp phQMvK5SsDl0OtQYe6NqGtURKTABqGa9TLHo8w+O1zDJyQFpVd39QwpRrYfcSwvgzzR4pTPlpK8bdkQdRwB0hzxMPVdAJ4PnyQsQgrgJtwAjwXQqmNSTXcwnqMQb2fHENS6shjUnBksajTzIJRyPiR3mYWDE/GxPs3WswqAMWo/NUWJqXra3PYD3MhO2fzJ8UrXrplVZpavWVfzDwO3vdV31ERPHu5YQ/R3uiXL5BzriyuDN7Ik9KH0+y8i2kUh1WRtufpJ+dmyVZ8Ji7ayWVgzzyLGeIl/Wn50tJ3KTCSwDPx69hlbWDJXje/Y6fghnW75t5jbXXc6eVJPxICmw35V2gtdttb/wFiS3hi5yfHY95TXiUYQRIDNXrllvTjbmJ7F97Zdm9Dd30ev5f5qS5+HcTnhtxX8ayJU9C/dNXarVun7bqhCVSmddhAxVoce1NMbYLGdEZF8nuDGKl1nvx1hJbFPN4IrcZEm44 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 03:48:44PM +0800, Huang, Ying wrote: > Andy Shevchenko writes: > > On Mon, Aug 19, 2024 at 10:34:13AM +0800, Huang Ying wrote: ... > >> Signed-off-by: "Huang, Ying" > >> Cc: Dan Williams > >> Cc: David Hildenbrand > >> Cc: Davidlohr Bueso > >> Cc: Jonathan Cameron > >> Cc: Dave Jiang > >> Cc: Alison Schofield > >> Cc: Vishal Verma > >> Cc: Ira Weiny > >> Cc: Alistair Popple > >> Cc: Andy Shevchenko > >> Cc: Bjorn Helgaas > >> Cc: Baoquan He > > > > You may move Cc list after '---', so it won't unnecessarily pollute the commit > > message. > > Emm... It appears that it's a common practice to include "Cc" in the > commit log. For what benefit? (Note, nowadays we have lore.kernel.org which is under the control of Linux kernel project) Personally I see only downsides of these being inside the commit message. Here is a discussion about this https://lore.kernel.org/linux-doc/20240423132024.2368662-1-andriy.shevchenko@linux.intel.com/ ... > >> + ostart = max(res.start, p->start); > >> + oend = min(res.end, p->end); > > > > Isn't a reinvention of resource_intersection()? With that in place you may also > > drop the above resource_overlaps(). > > sizeof(struct resource) == 8 * sizeof(unsigned long) > > Just want to avoid to define another struct resource on stack. Is it a problem? -- With Best Regards, Andy Shevchenko