From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D649CD3431 for ; Wed, 4 Sep 2024 11:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1591B8D0003; Wed, 4 Sep 2024 07:38:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 106628D0253; Wed, 4 Sep 2024 07:38:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE9008D0003; Wed, 4 Sep 2024 07:38:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id CD7796B032F for ; Wed, 4 Sep 2024 07:38:15 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A60D1A12B1 for ; Wed, 4 Sep 2024 11:38:15 +0000 (UTC) X-FDA: 82526857350.08.A4F2981 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf05.hostedemail.com (Postfix) with ESMTP id C282F100002 for ; Wed, 4 Sep 2024 11:38:13 +0000 (UTC) Authentication-Results: imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725449818; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=b7RjP2YDjsQDAgpAI67p4oi8OpVaJqVhfPX6M63fqx8=; b=SRb2vqaX8RgeLCoHPQCAz9iF5NUna8767pPdycfh+SYSgMQyFHUb3T+78Ri7Bzno0qbejo 6CbHXaQEzTOO46h7HSddkvE4XQsZHknaIaHeaFo0QmURJKwvuDncRcgQykD115SNO7g9AF hxJvPz2A13sCF56JgCZr0jg4O75vVHs= ARC-Authentication-Results: i=1; imf05.hostedemail.com; dkim=none; spf=pass (imf05.hostedemail.com: domain of cmarinas@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=cmarinas@kernel.org; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725449818; a=rsa-sha256; cv=none; b=Dy9s1P7OAZ0B1rHzPgdt/35HdOf+1Iw+rWZlwywmj+lazsHCdqT1IkUbwVHWh8aVCYylEy GeIzE5JhK/roZbyvD+cOjyclapiothiQ6xNN49iX/fHWrGeZC+W8nCqXfOsN7TH//b20hZ O8cHbM4gtcaQMK/1AQvaNm1GT7Mr6e4= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id B69A5A43FAF; Wed, 4 Sep 2024 11:38:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F4212C4CEC2; Wed, 4 Sep 2024 11:38:07 +0000 (UTC) Date: Wed, 4 Sep 2024 12:38:05 +0100 From: Catalin Marinas To: Will Deacon Cc: Joey Gouly , linux-arm-kernel@lists.infradead.org, nd@arm.com, akpm@linux-foundation.org, aneesh.kumar@kernel.org, aneesh.kumar@linux.ibm.com, anshuman.khandual@arm.com, bp@alien8.de, broonie@kernel.org, christophe.leroy@csgroup.eu, dave.hansen@linux.intel.com, hpa@zytor.com, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, maz@kernel.org, mingo@redhat.com, mpe@ellerman.id.au, naveen.n.rao@linux.ibm.com, npiggin@gmail.com, oliver.upton@linux.dev, shuah@kernel.org, skhan@linuxfoundation.org, szabolcs.nagy@arm.com, tglx@linutronix.de, x86@kernel.org, kvmarm@lists.linux.dev, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v5 06/30] arm64: context switch POR_EL0 register Message-ID: References: <20240822151113.1479789-1-joey.gouly@arm.com> <20240822151113.1479789-7-joey.gouly@arm.com> <20240823144531.GH32156@willie-the-truck> <20240823170835.GA1181@willie-the-truck> <20240827113803.GB4318@willie-the-truck> <20240903145413.GB3669886@e124191.cambridge.arm.com> <20240904102254.GA13280@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240904102254.GA13280@willie-the-truck> X-Stat-Signature: hpi5r81f5kb3xoegspqpdz1fxp69iwz5 X-Rspam-User: X-Rspamd-Queue-Id: C282F100002 X-Rspamd-Server: rspam02 X-HE-Tag: 1725449893-337592 X-HE-Meta: U2FsdGVkX18ifiJ/St+ftLSr2/9GLwTpGurlPSZ5OA2ie8oGtecgi1dbbNSo8n9CUtGgB1MrP657jyxKERjw/5C0MaesXQWGFrk/OQIxbz8MR3MW/Lfw2vIAEqpDbdl50HkxWF3leGBzTd/9EWIqfZ93SgYz4S5eDrYdLQMPg0xCnNb90zV2zGTIsa1agGljDoGGl9hD5ai7EUxVG6ZS+48a5wcTkwfSY3nM6DehYzBFgYhBzgi0juV1CoPpb0zNnMNpTgMjVGHO6YorTEbaivgrA438R7ZVKvnIQIoSQS5ZbkYWahGgT6bYV4rBZMecxnd3ofYh8FBhQ83SxXVoKlhBdPjVOCk+Xc1/kVKhbK4tHNlg2HGqPgvLtt+3q73qHkObM81mlLMVJ4lvS6FWkgvXKWqJBZmpNnxoUDQV50hRZBOqbeJ9yAnGnQnM84PhNYviMnXP5IVhnqO4UrBe6ga5SVQP29ZOqe8BZ5FIqYuYO3u/1738YG5TSpeGmBF8BBxqjQ6Rrd+LqMUbm6Ez2+fTnpQjna6yDXuvRO7W7saENZjdMZ9GeNwAAnEqj8UNbfAqVJCy4jxZvVfvfDvT0WvIMEYv7Qj+UD3C2MTUTA9Rk1GCxA6Uqz2tgOxg9OBoqQ33+YL3yBOK/zPQuhJUWBa1qO6oT/TYz+SGqM2ZNvVQwIx1l0dBiviloUyDWRgPsB3XjZhkIYj0Q+kQ6BO2DFf1r9JV9Ni5+EUkywn4AzpIpGdWJihwPFl98aIDSkkVoxYmznibHYtSalmni+QHtOeS7OEfE+e0OkBvqx97obwWPHsWZ7WE9zgSKnt66N2lzi/C4LbIPJWcAunBSkZLlxdhfhF/NM2eHSA5CLZD5F6bNi5qV+8taNLnmKBehcliKG68Xy3LzQMyHV+K8xS3HEaI7ZAzoc0Uk2tojYPXNEEWB4RfMtf6S1B19PrzPvhBxDadfp62TLl1H9OjCuh vJvELNbB y9vFBrHiVTuNMLH2KBk9asU1Cro7kKEk4uumCAMpLvGhyt3AjMPiCGJl3txit7bkqWJif2s44TV0LxR9GOogiyGka8hHVTOby2fjhfe14NFZ4zmpU83cp+3TsAT8S7I97ObnIBL3fVwaMUvcO8gUeVKerBuU8Ti1q1NInwfCuK5/rRok0G+SxQJebY00HZnUmaDf3d8gypCqgBAZepn3w8cgDaw1P7qIoQh3LqS9CO4vjJBLb/k7ToNI8+NrmrN2JjK545h0DumukQdtN9Q1c6tED1V6xdrNaKJbExi3+8AENPqrumi6h2kxXvqmbr+/glcN5tsf2BpGY0oDlskagQD8dp4403aQmc+dRYQc4p8b+zW9XTSGNo11FGi00nTO9e0hC8V4XH9el3HvB7JiExWuxqtx7ZC+51wQilv3DP4JhjeW4QEu3+Xq5NrHMPMCbesseoNzSP8NbKAw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Sep 04, 2024 at 11:22:54AM +0100, Will Deacon wrote: > On Tue, Sep 03, 2024 at 03:54:13PM +0100, Joey Gouly wrote: > > commit 3141fb86bee8d48ae47cab1594dad54f974a8899 > > Author: Joey Gouly > > Date: Tue Sep 3 15:47:26 2024 +0100 > > > > fixup! arm64: context switch POR_EL0 register > > > > diff --git a/arch/arm64/kernel/process.c b/arch/arm64/kernel/process.c > > index a3a61ecdb165..c224b0955f1a 100644 > > --- a/arch/arm64/kernel/process.c > > +++ b/arch/arm64/kernel/process.c > > @@ -515,11 +515,8 @@ static void permission_overlay_switch(struct task_struct *next) > > return; > > > > current->thread.por_el0 = read_sysreg_s(SYS_POR_EL0); > > - if (current->thread.por_el0 != next->thread.por_el0) { > > + if (current->thread.por_el0 != next->thread.por_el0) > > write_sysreg_s(next->thread.por_el0, SYS_POR_EL0); > > - /* ISB required for kernel uaccess routines when chaning POR_EL0 */ > > - isb(); > > - } > > } > > What about the one in flush_poe()? I'm inclined to drop that as well. Yes, that's a similar thing. -- Catalin