From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFEF1CA0ED3 for ; Wed, 4 Sep 2024 04:57:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3641B6B00D9; Wed, 4 Sep 2024 00:57:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2EC2E6B00DB; Wed, 4 Sep 2024 00:57:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 18DC06B00DD; Wed, 4 Sep 2024 00:57:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id ED2966B00D9 for ; Wed, 4 Sep 2024 00:57:23 -0400 (EDT) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B26D61A0D41 for ; Wed, 4 Sep 2024 04:57:23 +0000 (UTC) X-FDA: 82525847166.26.0FEDB09 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 18EC0C0006 for ; Wed, 4 Sep 2024 04:57:21 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GCYtQSM7; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725425771; a=rsa-sha256; cv=none; b=GOa7mozyFRU24vFTigMyVlzpuB2CF0ly7GqkFLfyaMpPP0QMLZQjrJYjnTQ/ZhmkS+2iIf DI2485vHwpX4jYL72+xb8MmqKgbFM4PdQfW9klkQivh7XLxpnJnWIND0jRT0fLlnecVWxQ 8QGk+X47jisUHsUORi/Zc6geb5sImKE= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GCYtQSM7; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf22.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725425771; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=m76QrtrLuHBx2CbbvGmwxeFpQ/qF6R/+keKO3bNNKvo=; b=s0bUcSTII9iaP2KFtw4cFtQTOU9RBTzUHcbWXBRLDd733wq6k45SrjUgF/MkrKa7rexhxT 8ThevcGTgl8k6Ftt1/o8lCmzKWJBhoxzZuv0Sr3fkVm6T7eSIX1xLp/80STt+dhiSjNwzj pKJ8x6oBrH/S+F5T33W5yAIAfDk7njk= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 491ABA404B1; Wed, 4 Sep 2024 04:57:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 88DE0C4CEC2; Wed, 4 Sep 2024 04:57:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725425841; bh=2y+DJZFNKmliFw8DrO+uDxsKwo6inzzDw6rLq2yGUFA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=GCYtQSM7gSAoGINO6wdU9VVI6Ybf9K2YQ7x598s57M3xTqeQmbwAXAHeu2f4mgQL0 gWgwKF5rBoxcRzZiQgG1uSOWBT0ZVPeFWdeVmfn0Y7Y+xbLyZZmLoRgKU8XS0CSJ2m rq01CiT0YBWxKNLIuRWnkubQuBiEYqijdyP6mDECczyrs0X5lFGYj9K0jKxttjpcSZ dALGSbTTQTfPp5l5R0rLQTwsoEzl4YTSj2/I0+WHZbnhnDvmvJ3CdB/FDbCZ/XRkIY mZY0YcZDN0+qFTVKef7vhIFhg9dpyYf4mK9Y/ZWT8OP4PjrVu1QB3nGG4U2gs8aAqW hAI29/0MWK8YA== Date: Wed, 4 Sep 2024 07:54:34 +0300 From: Mike Rapoport To: Christian Brauner Cc: Vlastimil Babka , Jens Axboe , Jann Horn , Linus Torvalds , linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Subject: Re: [PATCH v2 02/15] slab: add struct kmem_cache_args Message-ID: References: <20240903-work-kmem_cache_args-v2-0-76f97e9a4560@kernel.org> <20240903-work-kmem_cache_args-v2-2-76f97e9a4560@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240903-work-kmem_cache_args-v2-2-76f97e9a4560@kernel.org> X-Rspamd-Queue-Id: 18EC0C0006 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: wdh6jnekun19p68cukxfxn6u5ryy1e1t X-HE-Tag: 1725425841-1255 X-HE-Meta: U2FsdGVkX1946gHoT24rspwmNcH/F4kxQ6ihjgzsP9lUHRBesjeZc67Jpdrr6FkTtsISXLwtpT2GqY8VnbdTituZDZIYEpK1TLiBX6cjLzXY5CR7nKruxvI5gHpsdtzAoZRqS496IqpMYuAiR3LgOTa7Y00avTslNra4OvDK20deweQe7pOAzXuuTJY/UXUd32LqnMLCc5+WZm66wx2K/tFfzi3BbAzqVx7NK6dZkAVMy4RxSaBYo7VS96ZdZtadMtZECokasNU3iT7AyTmN/JhCoQ2+6PLp176Od5+GmIdk4YyfMSookJ/7V4nZVZKq9AaDwrz8ATQ+iYyMs8N4+LhPAkKJaYSm4C3ln5zr4Jp63O0DW8YPjSpmy60cf/GXDLZ2Mqxo7Bz1yognsxPKFkVDV3/7siKndToHsQKkYG5WMR+OgzShD7FNdF1Vg7UOmzCpB+Xrq+f75BRmJZmkg574kSGzDxUBpA4cehtoiYu8xk1CxC1xo2QoqIGVF245pkXNTmoWj10h0hOy2dkAYt6CXXlcXMmkKF6EnFCsC0t38jaz/7INFEqYQkEGP49vJc83d8Ad7jXXAmugKYaQhbuV7vH1dPVAJZUXonHtFqnBYR591PoPvn79PrkN1hv5cEHswa1xLKQeuSGSFADo2Xxkhm9fG6opOvf2OWR/fZxEOwpDQGv93jStQdG7EEdCG9MCwLJu5/RvnksSdIQjV7nF+JnAUpsPsq8jnUYA2EBFkSmMs12uBSWRPaLRhBjJR/zwPtR4sCuyttQ98jKuRUkk3PiGSib2C+pxWDkIZPuk0ASVhHyRGVVkWQbng9jurl95HbncDUoaUhZ/8eXSSIlh1ygNsTOI8MwcyZ6WsqARSnGPXLnh9UPcvvXuJIjl6QpvZIU7pbNKkmucQYi257Xr/D/VrIyY5YnDQsO6OFy7ZLMwzhwXnvxbpYtHlqmSlX7LYFtblJPdw5wHaO3 n9EsHHFW Yml69LpV3H9A9hChh4xxZ5tu01jSC+ADW6TBucmDO6rmrHdl7CHrIAfwFQJJGSSFT5xw0lrI5IaIALJEtpGdFDXcjqXisQ5auoVbH6ec6WU+frcfQZGDDaJQ9BKixL/jaqzlHfVnNHpJl2ECjKNwtp9MHXPVwwsdfEfa7SdSLfnR7k0L3nUMM+KGlj+8nairD/xgmt9zckvIJgSW9cn1q6wS/EAl9XWlYHy0YiKbOc3WgotCZlNRQbTBcv8CSnRdfAoMiigBwqcBLtaynrfSppgqyba37RKjzdzHcpDjuWToWBA0CbaF+mPnrGJ85kgV8MBx0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 03, 2024 at 04:20:43PM +0200, Christian Brauner wrote: > Signed-off-by: Christian Brauner > --- > include/linux/slab.h | 21 ++++++++++++++++ > mm/slab_common.c | 67 +++++++++++++++++++++++++++++++++++++++------------- > 2 files changed, 72 insertions(+), 16 deletions(-) > > diff --git a/include/linux/slab.h b/include/linux/slab.h > index 5b2da2cf31a8..79d8c8bca4a4 100644 > --- a/include/linux/slab.h > +++ b/include/linux/slab.h > @@ -240,6 +240,27 @@ struct mem_cgroup; > */ > bool slab_is_available(void); > > +/** > + * @align: The required alignment for the objects. > + * @useroffset: Usercopy region offset > + * @usersize: Usercopy region size > + * @freeptr_offset: Custom offset for the free pointer in RCU caches > + * @use_freeptr_offset: Whether a @freeptr_offset is used > + * @ctor: A constructor for the objects. > + */ > +struct kmem_cache_args { > + unsigned int align; > + unsigned int useroffset; > + unsigned int usersize; > + unsigned int freeptr_offset; > + bool use_freeptr_offset; > + void (*ctor)(void *); > +}; > + > +struct kmem_cache *__kmem_cache_create_args(const char *name, > + unsigned int object_size, > + struct kmem_cache_args *args, > + slab_flags_t flags); I'd name it __kmem_cache_create() and then s/kmem_cache_create/_kmem_cache_create/ in patch 12. Other than that Reviewed-by: Mike Rapoport (Microsoft) > struct kmem_cache *kmem_cache_create(const char *name, unsigned int size, > unsigned int align, slab_flags_t flags, > void (*ctor)(void *)); -- Sincerely yours, Mike.