From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6A3BCD3437 for ; Tue, 3 Sep 2024 14:04:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 677D58D0174; Tue, 3 Sep 2024 10:04:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 627878D016E; Tue, 3 Sep 2024 10:04:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EEC28D0174; Tue, 3 Sep 2024 10:04:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 31B548D016E for ; Tue, 3 Sep 2024 10:04:07 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C3E04140430 for ; Tue, 3 Sep 2024 14:04:06 +0000 (UTC) X-FDA: 82523596092.30.DA1C2BE Received: from mail-lj1-f177.google.com (mail-lj1-f177.google.com [209.85.208.177]) by imf30.hostedemail.com (Postfix) with ESMTP id C3446800DB for ; Tue, 3 Sep 2024 14:03:59 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=OJNO3tvs; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725372145; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=f4kZV7sylO482dTZcl3SB+t2bxHcHNDfXt4kPi8kfl8=; b=zNxksDVYnANRc+x2rLCTHmlht4tEXr1kjKUGOqxT7bj+mbveRuJvFYsCQRBnB4FjMuZtF9 8qJmpc+pEX1GYOAGU/shyin2RYUQM1av1sLmSynWqe5H0zsIhk0qOjKrNjLxBHfAtfohHN cqVxFIQp5bylgqf2uSTwMR+Z9fS0R4s= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725372145; a=rsa-sha256; cv=none; b=kUMS19b56Eu25aXku+amvr9lcICxGBlqSis9kCdmUxJH8II8r4aEU8QyOytLAlYO1lK0/c aEknBzqBSFiSDxdDIH+iATw/ByJ1DXXwWTKxEp7g/XPuYlOrVyjL2qEUx5NBwTcm0i1rEw APN/xtWwi1OOWw5IzebnrGKVg+tedeU= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=OJNO3tvs; spf=pass (imf30.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.177 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-lj1-f177.google.com with SMTP id 38308e7fff4ca-2f3f0bdbcd9so63315491fa.1 for ; Tue, 03 Sep 2024 07:03:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725372238; x=1725977038; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=f4kZV7sylO482dTZcl3SB+t2bxHcHNDfXt4kPi8kfl8=; b=OJNO3tvslc15oLfC0kOk0p6ebiTc79yZO8Mr0wqT2O9+BAhJG6owotQVke/fLNPO/h G9RqXWuZh9+nw8DlNFA9dygkdMq35hYUziO16nPAZ84lRClJAsysmwS94VwWqpJ8Vrek hK3JK94vBoMAvjpecww+jj3adSKU6/rOGdZG8l2kVrtxU8uQerj/RtQ5ChnHVLr5tyMG 0NEp1siq8TRnX3VLOHaxaTsv8jjnU7lUn0WNKXWcIoRTe2wRuMoiDgiih0ai5UUZuK5n bpyFv57LCMWOIXT0HQaIQhPkF1sOuTUFNsELelrxgRyVnC4eE1K7lhGNvhDEfJ7SaA+r 4p9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725372238; x=1725977038; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=f4kZV7sylO482dTZcl3SB+t2bxHcHNDfXt4kPi8kfl8=; b=vvpd9/4MUi5twGsJMJJpLSsYrl6m6R/L1LjeGA5kwpZ4GS4roF49nl1eJoENNBTgyb 8AJedvjzGl5eIEkSYQO07+d53m9Pz/0QVlqAAv79IWGSB4IXXhCiJPvK7q2BwsbsB9Dt joD5S+R2IsDkBHIBP3cga2Bc9voDtuumsD2m1tUiNHBRtC0UvTR5yGOhNjBk/0s7WC59 BeM4HEPo8s0MdpVggL84PRYb+Peco10hzk28Qc9S29QZcpjv3m4mUnkLjgchmJsQS+ot lqLh/5yCEWmOG+ngMcQ8P+2+k3VlBOYAY7/OUCQC3qKUw/jLQl7fZZQgJMMdb/qPFH0O vrdA== X-Forwarded-Encrypted: i=1; AJvYcCW1eZM/qCA35QKKBodJWci6aVU9duJ8QpFXS42caeAY6AiYdHySnEUOf4qFIvFGz3BWz2FsK/alQg==@kvack.org X-Gm-Message-State: AOJu0YyhGnTvy++n23qqpHojHTILqjrT+LNHG3V3rUgBr2Prmm3RrV6X YmvF+MIxDaL/jjcULZYTxPFuEHoWzU58rCEDG+8lJTMcK0FLul8md2Q+ukSxKofPKd26H8L30Ws d X-Google-Smtp-Source: AGHT+IFzD+eY4sNRW/2ZIQH2AIKlAmIhsXltUfopKsrNXJ8WlkE/Cqluh7S5xLrhLL6tkfBv7gk8+A== X-Received: by 2002:a05:651c:1a0c:b0:2ef:2ef5:ae98 with SMTP id 38308e7fff4ca-2f636a7fec3mr40816641fa.34.1725372236951; Tue, 03 Sep 2024 07:03:56 -0700 (PDT) Received: from localhost ([193.86.92.181]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c24372d393sm4407310a12.23.2024.09.03.07.03.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Sep 2024 07:03:56 -0700 (PDT) Date: Tue, 3 Sep 2024 16:03:56 +0200 From: Michal Hocko To: Yafang Shao Cc: Theodore Ts'o , Dave Chinner , Kent Overstreet , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations Message-ID: References: <20240903124416.GE424729@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: C3446800DB X-Stat-Signature: kw7np7zbak3a9oar45ebpcw1hxduufxp X-HE-Tag: 1725372239-889828 X-HE-Meta: U2FsdGVkX1/euS7i0s2x4xS2LQ+0rfnzf/YKo0xDlhqhFX7LmZB3BmAR2huVV/q8nq0yGdqWeXwtmmU8xS5Dt5majFO31383W+NSSsYK7GO46AJHQfCbYNV+Oe+BPVrUmPDDDGd/mw50a8JtrEqn2WLgHlEOLKa/94Pz/42cAblCEEMSuJ0uRLOOdRkXAsaYgFXzpJj7u3CjSJJ6VxJDxnl45jtv76+2iqtgFK5KeJ8fn8VbHbwBqAlnzRREK6eCqfwdl2fGEcp3Cc7DUU+LIXX0kcDYecGMIHeuO65iZNLl9DzoCl9JD2g+YQ6AivU5mGpCcjb3uuq+1tKX8fWmRwLm7p1lAOxLLHQieZz+2+JoKP+mf5AzkGLIWFq2kZ1B5EwU7jcFzwoUbfrNU+0rZOxGf2BDcptn6UhjCMWmCUoA1MEk30s6S60iyPKCdmiOHVadzcIZNtHopXqAh4pPQu95/F2lYuRLzweV+7vzlTLUw6006PocslmeQA0tvc735cKWizGR9Yg/W5+y1xmCw6acfFXYgpnpjux7dNncxOfuCpsTf7WuW1i6P/9TAw3FCdlrafrauoWuNEUYDh6VTCuU2DGfLMnZv4F6T3hpKgJfmmRuyD912AkFz3IfqOucPMVf/IoE02v1Jne309qbJVFw747+fITIuGH9O36+ovR2kxLT54HivX4cwLbi7pTp8N7LZJyOrPQizmXa1drWca6i4Mb1qo9SMXBRv35cygTGdFzZ+z6Qm8OwuJxGB/f9YyuCCXEEdDH6ert/7Imfm5DFoTgA+lJZfDhb/NqfBB+XPnaavKcbLfKOZQPZSGkmVsYMUmJsFFkHGG1xUQumYGQPTmhffYcQXICzMoAwgr915dXy8IPaTO25OARLFjni45xZh7eX5Rvar3kPdz6x/ULeb5MAUkbdaRz2CDsJ1ObCG8c6ArRlPDXIiB5lP5yATw4Ejcp4kEvHgZ+DfvQ dQITDXEn JoDcdzN73KMEzdNCEqm05X1euLACGsCdCEuWTSy1Io4XYPFZcMwxt0ipIyigyrZjF2WMdDfvfUqe3fqCqqCPWwKb2rTZ9EGBrmpcdfgBbXJTOIerWFLy+v/BkZ7EC4YqcVx1V7XTgNvyTQX3d08cVWIxPKRhyO8T4xRvFbZUyhDHMjO+JR5gt2X9V+99J0AjXxAqh0o5Xkx6Y9wEXrlRaTuZUuqhDsZ8QFVsiLL6GLHZoJcwBMTKuHgJZCWa0GakwNkc97DVWNml86aXFHPMWF8gc3DillOHkq+uSy4/NU0cRIOaYSsWGZhmy6QOqu41B1m2Vdml0qLxopm2aXwE3+10Uik1udUrpBnH2yIydnQAyC4s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.002529, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue 03-09-24 21:15:59, Yafang Shao wrote: [...] > I completely agree with your point. However, in the real world, things > don't always work as expected, which is why it's crucial to ensure the > OOM killer is effective during system thrashing. Unfortunately, the > kernel's OOM killer doesn't always perform as expected, particularly > under heavy thrashing. This is one reason why user-space OOM killers > like oomd exist. I do undestand your point. On the other hand over a long time seeing all different usecases we have concluded that the OOM killer should be really conservative last resort. More agressive OOM policies should be implemented by userspace to prevent from regressions in other usecases. That doesn't really mean improvements to the kernel oom killer are not welcome or impossible. The bar is just quite hard as the wide variety of workloads is really hard to support. Heavy trashing is one example. Different workloads will have a different understanding what that means actually. -- Michal Hocko SUSE Labs