From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6811ECE564 for ; Tue, 10 Sep 2024 04:47:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1D7278D0016; Tue, 10 Sep 2024 00:47:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 187928D000E; Tue, 10 Sep 2024 00:47:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 076138D0016; Tue, 10 Sep 2024 00:47:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id DF5768D000E for ; Tue, 10 Sep 2024 00:47:52 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 582541208CB for ; Tue, 10 Sep 2024 04:47:52 +0000 (UTC) X-FDA: 82547595984.02.438C5E5 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf03.hostedemail.com (Postfix) with ESMTP id 0A4EB20004 for ; Tue, 10 Sep 2024 04:47:49 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LCK1EnCF; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725943534; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c0/KMxGI62d39aIfqydXbjcfGL/DQ5/n5haroblqj80=; b=qhVDM7dIxKAY2sChZiWTboom8mZ/iU3su4TP2x+n3274cFiux1MV+7GjP4Fqm5VkABe4I4 eMohqhzI4g+RM5s+eK0h7o72NyuSyJIgXEEgnaT6cwB2Da1tXAeLhCVUutlYMZvfpQEU0L X9GVDnxNJnammSc2HiJYI+c452Y5hzg= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=LCK1EnCF; spf=none (imf03.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725943534; a=rsa-sha256; cv=none; b=arA1PyoelI3y60St8GV8BsyXC69/Ug7yRk5wt8rNRhFvowy0k7SzIggtorCV0y2cF+OZ6B hBND5P+e8lRHsUw/hA1RUHcQg0Q3xycL+89ZOFGl9NsTjzWYszsqqVzU4h6MakswX8FrUO cd/UCxAoHeoiK8KVqgAvztCBVtCZv1o= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=c0/KMxGI62d39aIfqydXbjcfGL/DQ5/n5haroblqj80=; b=LCK1EnCFN8sE7ipvGAc8UQ2cYA x0qquDQQJXVrrzzdKi4N4M+3xPY367t9udRzgrjwbuaaV/t/EOPA18CtPCtGpeg5g2S6mq9UPTVMY qOorwFK7L+qbEqWzmGd/ADQLtdWzdM2yuTGiVya3mW7Rp1LoTyT26SLecZAa3jYEcBVscKOsE6wjS 3fh454fYf5iaCmgBbCxWSvcTMiKeJDd3OLFSSuDCieAc/LX0nhmzj4323V7hPCPHpQUcm57lRkjir ysN1fMLF0KDjVx20FCu9CZ7wGsfxPB18U67jSno24eKa7XBE1NVWnSD08C0xQoywBYznZ7D5X/VkY OG0n4GAQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1snsmy-000000050uo-2esU; Tue, 10 Sep 2024 04:47:40 +0000 Date: Tue, 10 Sep 2024 05:47:40 +0100 From: Matthew Wilcox To: Alistair Popple Cc: dan.j.williams@intel.com, linux-mm@kvack.org, vishal.l.verma@intel.com, dave.jiang@intel.com, logang@deltatee.com, bhelgaas@google.com, jack@suse.cz, jgg@ziepe.ca, catalin.marinas@arm.com, will@kernel.org, mpe@ellerman.id.au, npiggin@gmail.com, dave.hansen@linux.intel.com, ira.weiny@intel.com, djwong@kernel.org, tytso@mit.edu, linmiaohe@huawei.com, david@redhat.com, peterx@redhat.com, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, nvdimm@lists.linux.dev, linux-cxl@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, jhubbard@nvidia.com, hch@lst.de, david@fromorbit.com, Jason Gunthorpe Subject: Re: [PATCH 04/12] mm: Allow compound zone device pages Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 0A4EB20004 X-Stat-Signature: xoh9tyxtoezxmz7bjc6gtgm6sbhubqgf X-Rspam-User: X-HE-Tag: 1725943669-743050 X-HE-Meta: U2FsdGVkX19bHuGTSDcMBBw7dFoTFC0Pp0bp6Ic+Rx61T5KA8hOMyd9rIX//svOXMYTgxQ+3HJuaglSZi+g+3eVblEeEHaeig0r/EhEU5PTXDUp5AgwIykVKHOzIJRiDZ/c7XsXASaDV1gPUsiBOJK5VYNduMpw/6JIuoAUNLeO6x5ez9U9D+lNHzDunf3w/LmJWsCfgkW4UyrlGfnWOvKaP8be93qxlKHX4qmDbXZekspQVpzUvnG/j/n2x/b7CCBzAqewUJ7ARg54SPhsnXoRF3EbAsCpVqJqOYdYsHX3W/nZIIyg4VwtzeRxS6lveFp6qazkycmSUzoWSaVitHB1nadDmaqzaIfVeVzfWG3vzUkLclWxmv6FtC+3CZ1CmD82um9C91oODS/cokA+1jvxIOq0AuLRF7yCX6l47OUNumq1TeViepSSNv48JHV5jX1xVuHkyUKPFcymep0q6jLzS1zaASkzGcyivQmdokV+41Vu4jnA/5bBEA7/QfGfRGjSxT/APpUCC25nprL3WIPHjs9KuA5bhLwYLz5+CYeK1wuuyGfIiWdS3gT0r777NQLYXWPBOzjnC4IlB/xYsAFyVvw8SsAGM6fErFx7/8JPg+4uesVypmmrZxrIWFtwdKAOjT2qZ7sJw+1Xdje+3/fbJeJoJWtVO+4AF7aCwRw/w/T8XGtRRuOdUu6FHwQH2T2+ZHA7asGF917Pjl/kfnHnum5giGzaJX60u+po7O21rTA0gICbCFT4aRX8EXIAgdrpmDC7o/T9eVJ7Bof1UikuVAnr+Kl/B+pg/O6QrrV2GcKxBTVPOxNyd756Awjgc2Kh7QUmqH5xnzwLpXcQFCUxAS1sPwseGjvxJS1HAYTtsDiCOlqcFW0SWBFXqMQL/gwLDKMpIc6qtFyZbvbk9H+6my2bklcPgUYsq3DXguddP4Kc5TMdAEWF4CFZu7cYIosO5eXlRfG9Qx9Yib/h V3nAylxn GQNO3drAzkiTvAxci3jIMoqUPjIertnO1SpfmiVR84zWpqA6/NbCgEy1xlMUW6lbeRRuScIyGNByNN6124/jnwlBvISX06xBDac4eT8zKjvG4dn+BIomRTVzc7RpNCIytgq9TS1ifnxzwUFRB+xQ84d00QkPhro0adSpTuZOnhFp24DrkVIZ8cI+lvuEJiyS1GC9RX8TkIveEsz3uLQD31dS1z9/jxIGw018LNxWswr67g0Q= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Sep 10, 2024 at 02:14:29PM +1000, Alistair Popple wrote: > @@ -337,6 +341,7 @@ struct folio { > /* private: */ > }; > /* public: */ > + struct dev_pagemap *pgmap; Shouldn't that be indented by one more tab stop? And for ease of reading, perhaps it should be placed either immediately before or after 'struct list_head lru;'? > +++ b/include/linux/mmzone.h > @@ -1134,6 +1134,12 @@ static inline bool is_zone_device_page(const struct page *page) > return page_zonenum(page) == ZONE_DEVICE; > } > > +static inline struct dev_pagemap *page_dev_pagemap(const struct page *page) > +{ > + WARN_ON(!is_zone_device_page(page)); > + return page_folio(page)->pgmap; > +} I haven't read to the end yet, but presumably we'll eventually want: static inline struct dev_pagemap *folio_dev_pagemap(const struct folio *folio) { WARN_ON(!folio_is_zone_device(folio)) return folio->pgmap; } and since we'll want it eventually, maybe now is the time to add it, and make page_dev_pagemap() simply call it?