From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7695DCD13CF for ; Mon, 2 Sep 2024 17:03:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 055156B03AF; Mon, 2 Sep 2024 13:03:05 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 004266B03B0; Mon, 2 Sep 2024 13:03:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0DBF6B03B1; Mon, 2 Sep 2024 13:03:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id C48AF6B03AF for ; Mon, 2 Sep 2024 13:03:04 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 9F87CC1A8F for ; Mon, 2 Sep 2024 17:02:57 +0000 (UTC) X-FDA: 82520417994.02.B247AF9 Received: from mail-il1-f175.google.com (mail-il1-f175.google.com [209.85.166.175]) by imf29.hostedemail.com (Postfix) with ESMTP id B717F120026 for ; Mon, 2 Sep 2024 17:02:55 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TRGRGp6H; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725296451; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CZVOdmbajPOyilhVT2ENHokoQg+1tObNsMtDHCqaHb8=; b=chBxZkj/oqmIZkpF1zT3X5hKtFsJCbzCVfyCGervrqKiqFKR4tdfX41uRayr8yWKRd9YAO TZLnYDsp/CUpk3JPIM24lq7R1QaPSmmLhkpTSUlvlOMHPbsN78RoaBPKiCEYfJ+2Y+XxS+ rTlKdLV2OfoVpcA9WkcZMukc2ULzRZQ= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=TRGRGp6H; spf=pass (imf29.hostedemail.com: domain of yuzhao@google.com designates 209.85.166.175 as permitted sender) smtp.mailfrom=yuzhao@google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725296451; a=rsa-sha256; cv=none; b=QkdxET2HkPskAf/nNz8o+jwvrZEshdA45lk/4dOybyLWqdOn9fuL6oKowVwkVSA791aKW2 55L/JCUlEpCfOasfGTxaSlTm1O2ykIL7oeYp9GS6vA+h1y8u1z0/O19P5kIFeuZyxsD2Lt 4+N54xVkOksXIXFLCNQfnwlE3T5wYWo= Received: by mail-il1-f175.google.com with SMTP id e9e14a558f8ab-39d26a8f9dbso16046985ab.1 for ; Mon, 02 Sep 2024 10:02:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725296575; x=1725901375; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=CZVOdmbajPOyilhVT2ENHokoQg+1tObNsMtDHCqaHb8=; b=TRGRGp6HCT/UnWGMEv7JpVnJBg2aAzSz6Kg0kT20Zxm4lpElAOOJEVxMJPpXzYgMay n89wavqRUs4V4tTuQ30DOwPcBpA6vBxLi61NVo7Dp1x1ljMuaoZDgnzrvjkRSv08Ppzu aIFOMkzljiovXk+X1u/AIjL0kAsNry/ZnHG4Jw3Y7B2p4umJrrEnHdCUMLYN1Iun94kx fkUcKQ8EEw3myQdw0nSe95PT/QKpwoWSiPWjwcpVhRzZTSqZlXBlN/jxfrLa+C8fsyI8 SdXFlTD2U8Hijalz0p7oj6XfhMBiJIU+QnlBYQUm4lJ10emGooCfkTU+MxB6xAP33sFd ebsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725296575; x=1725901375; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=CZVOdmbajPOyilhVT2ENHokoQg+1tObNsMtDHCqaHb8=; b=AyolIIt2lkzQ84zzycG5NihM6M6yfIT37Pcvm8VbZOQVqi9zVOHQpLvBtROP3FWqMn WWqhBokbVhd3eMUeFGAkrNi2pLmc/j/AcrymmnTKbrZ/iED77XOVn4OMFgJGV4CzBBKr PyWHNCk0bGS7u+YMMmmjFofm1QlyitkyFtzwzzSe6FhHUT+TYEZCewNGs8GW6XSAvfmQ 8oCWWt6oDqX0h/JQU9ENssdFeHvv1fXHEVpDZ9hJFdRka30kiSSVcKUDfQ/kl14xkrBf gz1rshNBZVLM2eXDX9xzcuqk90EqMQt9JTmgFJBpJ2cxGlWDDEFCZPayc1A79IQs8+NI wfxA== X-Forwarded-Encrypted: i=1; AJvYcCWqj/5IfaHnPoHz246r+Xw/tPhWSHQpz1GULKwK5Ps+eEmmxKrwVnPIEQV7PjoFpoSVR93gIW2QPQ==@kvack.org X-Gm-Message-State: AOJu0YzRbvqACp3dfuq1+szDXLfQE4QaCUDuPUJsfMC3i2E1THjJQG5k +KAiYx7wGeRLVEbYaAP5EcAxfuUCnwbzJEODMuLZ3A54773q8SPdIAFUM0Go4GXWrHis7wVpBFp KNw== X-Google-Smtp-Source: AGHT+IEMq7TZba2SLvaof/QHOP04CrSz+gFKDPNws1yOGU0WvsF0B64Ea9P5fwxfXowGNjz7299f3g== X-Received: by 2002:a05:6e02:2196:b0:39e:3952:6dd4 with SMTP id e9e14a558f8ab-39f4f55eedbmr91478485ab.20.1725296574248; Mon, 02 Sep 2024 10:02:54 -0700 (PDT) Received: from google.com ([2a00:79e0:2e28:6:485e:a0d2:7c59:d251]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4ced2dcdfbcsm2228970173.29.2024.09.02.10.02.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 10:02:53 -0700 (PDT) Date: Mon, 2 Sep 2024 11:02:46 -0600 From: Yu Zhao To: Matthew Wilcox Cc: Andrew Morton , Muchun Song , Zi Yan , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v2 1/3] mm/contig_alloc: support __GFP_COMP Message-ID: References: <20240814035451.773331-1-yuzhao@google.com> <20240814035451.773331-2-yuzhao@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: B717F120026 X-Stat-Signature: ngj66ibsgeykudrapstimy9bzxf4t7j3 X-Rspam-User: X-HE-Tag: 1725296575-480229 X-HE-Meta: U2FsdGVkX19Y7f2KpxCfvfHJ+X1yAQsvPcFG6j7MvhQz9v6GI9a1z1q0fMDJHgdG/uc5jeuvwhvJQlhMLU4mHPP4Kigm3U5OPwAWnZfnqfVgYTqgjZcZxo9KG32wEnmI/DC5ssppDNelaAHOPsdAXRIc/7kEsVbcaKWkf/H+A5azH6lFIVtydsBGNuX+ujYShKq1MwTQ2L2l9ihPiymOrIalot9XFCPoT7HF6FjSknEiZcavyVW+R2Hx7HTygH3su4M8Ds45SnseP6nTydfDe7RJBo5istUqQ9B0IbNlsEm/IGoMgWsDWM+iTZX/xwPfbNtog9FsJk82aatVztunmXANkj6xIrEnWFGcYCmGs5IAp0juuyJHvd0qlo8RXsGGmD7UEPsnCvka0jD/JFUECYN3/Ns5q99J+9iLBKffRu0XFMgSNey2PLtWFOw3tJjFkRdNJ+kn5ggRDGGaaRIMq3/ktJJON5NV0TZewjKUwTdMynSRh/mHjgvntRbPE/fXsHIBxS83lU0ctlgoNTF2LIdsJw75FqE3g7JrblwjFeNYNkeuOIrod5xY8215JWtLQ0UGajCkXHeOG5kNOh5l9irSGqI2/mkfYDsuL7RmAmtnkhhFFnlnplAIDP6+E4kXu0OayXF0uncuGsopxmeK/oLjAOyQAfG45SpmolYsrkHFGQG0b7BV2+b+EJrSi1C1kvJQzOrPzdvOiWPUr+BJmr01YF0DrBg7Q2TJH19+9QECB9avyIRlYdz48PWz2//EO2b0zDVD7d8tuRvLdsib3dbOsVTjk+vV3Mp35pnPxxquohmKf3qFJbbAyTrUzV7DmKIE3MU0WDerEZDcB+KPmUV9MWsKrysMWP6jdblZNANFlyO1jNcJEvwuzan3wY+T2T+f878DebgC+UsotuFH/OxDvjCDqL4Ktu0VHc/PxihWBERDaoVO27kJy+gu20RGgzQCyMeVeM+/GTvT7KE mdPyHpzC 7JNUW6AeDzsF4MBiMxBt9MFobWv1fue3AOy97LoEXyFFhJe0HOFhl5E0cryNiGBHdh26j5n+5G2WE9E6yrX9SQ+ZSdJE6r6GxCJDzpwOQuLhSkCXccvjuwOybu8ITfyVbA54EC0s4zvNN9SUAVhnGVOXIeKJNgh/oUQFk89+oOckRwBQ7TaVk8NRgMNg8Lm0zCE7ASz4aJLBXosJtMY5/Gu7cbwrE0CuXlq3LGkWaz/yKYKivKAOVtKOjEQbeIfTLSC8i7IYFKXe/yI9eTshwCGCcvJ52t6nj96zN6W5CCiWvk/5GMuJd7vKWTbr1Z5CKyDZU4IqXplR8CNiEJHaqWlNvad8j95G4dPWWFa+53U2PvEYIr1mo90H11PDVMXA4oHzbdOgjeXcWgeQtuN01hFKHkTmfk5iq9mlI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 07:42:20PM +0100, Matthew Wilcox wrote: > On Thu, Aug 22, 2024 at 11:23:04AM -0600, Yu Zhao wrote: > > Andrew, could you patch up the line above? This is what it's supposed > > to check: > > > > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > > index 59266df56aeb..03ba9563c6db 100644 > > --- a/include/linux/gfp.h > > +++ b/include/linux/gfp.h > > @@ -452,7 +452,7 @@ static inline struct folio *folio_alloc_gigantic_noprof(int order, gfp_t gfp, > > { > > struct page *page; > > > > - if (WARN_ON(!order || !(gfp | __GFP_COMP))) > > + if (WARN_ON(!order || !(gfp & __GFP_COMP))) > > return NULL; > > I don't think we should do this at all. Just this should be enough: > > gfp |= __GFP_COMP; > > same as folio_alloc() (or now folio_alloc_noprof()). > Do we really caree if somebody tries to allocate a gigantic page with an > order of 0? If this ever happens, I'd bet it's a bug. > It's weird, but would work, so I don't see the need for the > warning. So the warning could catch that, but if we think it's verbose, then please fold the following in: diff --git a/include/linux/gfp.h b/include/linux/gfp.h index a951de920e20..b43934d79dd9 100644 --- a/include/linux/gfp.h +++ b/include/linux/gfp.h @@ -452,10 +452,7 @@ static inline struct folio *folio_alloc_gigantic_noprof(int order, gfp_t gfp, { struct page *page; - if (WARN_ON(!order || !(gfp & __GFP_COMP))) - return NULL; - - page = alloc_contig_pages_noprof(1 << order, gfp, nid, node); + page = alloc_contig_pages_noprof(1 << order, gfp | __GFP_COMP, nid, node); return page ? page_folio(page) : NULL; }