From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6420CCA0ED3 for ; Mon, 2 Sep 2024 14:37:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E61598D00E4; Mon, 2 Sep 2024 10:37:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E132A8D0065; Mon, 2 Sep 2024 10:37:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C62B68D00E4; Mon, 2 Sep 2024 10:37:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id A80A68D0065 for ; Mon, 2 Sep 2024 10:37:33 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 21241141D7A for ; Mon, 2 Sep 2024 14:37:33 +0000 (UTC) X-FDA: 82520051586.06.324C9A3 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf11.hostedemail.com (Postfix) with ESMTP id 44E0940016 for ; Mon, 2 Sep 2024 14:37:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b="i1U/TFM/"; spf=pass (imf11.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725287828; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fkpr2xyIOoNVSN6u9wpBQgcyAP1uccLTt9mgRczfpKU=; b=QphvMAf83ZtCva5c5fUi06U49oP2pJqawZ4XaVa4MO9ZRabjqkQSH3eguw+Hik+f11iN2G DoTnhLyWlpytDl/CHijkUqxX83MTEpVVUPCEgGWL1dKTSZkjmkVWbO+3up6WVmKD3IMVoi 5bTj4ONF7VFeF2cNkEuk8LOmrFIrl+s= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b="i1U/TFM/"; spf=pass (imf11.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725287828; a=rsa-sha256; cv=none; b=Vtgi0YKXPmpwR1zpHo15SNfEeCvA72PGvTTCAYtNNIRbPL8fLYgqGLf1yIe0YHQLBD5NJ2 efL6B6Lq66Tu2Qgy4mvenuoUh1XbyW1IKgLhXrJdxLv6QTFwZPB1UU8exQDS2QeheOxMn7 juEOYTe9cmhThNo5o/IkLp/QKrkad/A= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id D1AB85C5848; Mon, 2 Sep 2024 14:37:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8DB3CC4CEC2; Mon, 2 Sep 2024 14:37:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725287845; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fkpr2xyIOoNVSN6u9wpBQgcyAP1uccLTt9mgRczfpKU=; b=i1U/TFM/BVYMk5TlS2vnBMnfGpj32tpFcSRnNwTo99N5lrPyNwJjZr8pkxe6jXhDmkDbjn GWCnZdMN+yY/+ANdCkUyfXNpGinu8fcfRlZAsDMhrKZE6VFWFmnpGRjRv73QnO4bRbnrxQ dbBjZkpe5RvVnXQOmj1jYisPJP5j5YU= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id b222261e (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Sep 2024 14:37:25 +0000 (UTC) Date: Mon, 2 Sep 2024 16:37:24 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 Message-ID: References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Stat-Signature: yr8fd39zpp91nk54joi9h7m6sm1fus9p X-Rspamd-Queue-Id: 44E0940016 X-Rspamd-Server: rspam11 X-HE-Tag: 1725287851-314167 X-HE-Meta: U2FsdGVkX1/PaSc2K8O2PsAMf5gw0wd8ceNGBiUXacV+rz9ZMiuafnZg9BXdcK8ehIiBdf7HSsIDBWWG8Es7WHz6rTHze0bIG2j2nbgIUpPlNa72aBdDPhzWzxkGl8sos1dnAZL8PNx14vqCppCSqGh7wrEkZ/v+zlDy+i4nbwP+z5xD2B4XJAIlqYyXTY613lJRgYGZtvMGOctqOKjWhZatCJrYaNDH6pJIlq2lDBZcLTntNBfspkX1fHm06Ck2imurQh4+mYPEkt4q0DUPjOUnRCSMiQZ+vXWYcItF2jj+V1dW4bnxnD5ssrsIhCKBZtTLvOCIxkiqQQeZtq7a8QdZyshktyjMtzFDX/HtqSx/zV2dj6/kju825sQJxN6WYFt1qvcXLtEpibRPe7QB8MB2/IHiHG54DKpO6e8nO1RjKEBoCs9mPV7X+B2pe7RxJ6EZJnRMpNGJEuSDIW74HZGPTNM5k1WsI4R94kZbjkDOuekLp5cN7z4aEdRaHM6Lq4KWDMKc/RVICh3X9Hk04wUjDpirUpi2XYnxl0ocpe69Gh9J9sLQ7jDgwRvfiamJ5sqFEwIroRIwfWZMOvEcMRZY3veTx2au9ndFNztNvUuSVBA4LpMT3Mi6r36GoGX138chW0/c18ZwUIKorMCcE4hV5NBEaT1/ndAPnAQhG0dE56RlEs2bviKQ+MF5zh0DDqCiSrqs2EFcBWl/gi3NeOWdGtjyn6zNm3ZucBpy0gzo4xyuE52pZf9QkKG+cyBe9Z+MgRNxOFsiYViXV3WoolRuAteBgoyRIVX5udTbuMU2tQIEZwh+7rlipKhcgVoPQoEkHG5dRFtRVbUcCCDyQA5KA9MQZFbwJn6bSmgDU9Ss45JJDR8swGDcsS/2gQ6hjT4/cFUQEFscOu/ToiB4fQ+r+DydKdecF9S4zEmoYFEHUqLrLHcu4DSiVzyDO67ikz/m/YwqUZeQmTDmIZj j9F557Et 45vwJmoi5TKYhlwRkocxNdAPE9uZKSK9DEof0LNTNDCeSg2/oQe6XXvocxZMimaZXODVU9gORYd/Q24J8fFi1crmH5LxrkYlBKcj5euoLUmw0lj79OpDcI6JKiLSd8lLrpC6TLlbdDputwgWfqmLkxcU6y0UpvHyhrRGK6cNUt7xmTOi+kVKNNoC1oEO/Y5uPAEpngRDXrCV4NKnquL+MEnBu42cqitKVvQwH1nW+5C/oEc9/0CKobCMRLKiTXlgPUQPYu+kQg2hAkDdEecy5oXSVjfrLY4O+mN7Norf1GK6szhxFMYU+zssNGSg+6fukJFOfJxaqLUT3lbSKukVm06umiwbFUsUDMsJHXHGfqw1d0tGlc66jowzAtPWmMlhOXTJpfld30T/dozceu9sGn+cmVf4B9RtusedxqSWbxiO4TDwOgkpBHH0wxZZM2VM5aeKzhne5agbFoZg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 04:27:12PM +0200, Christophe Leroy wrote: > Hi Jason, hi Michael, > > Le 02/09/2024 à 16:19, Jason A. Donenfeld a écrit : > > On Mon, Sep 02, 2024 at 04:16:48PM +0200, Christophe Leroy wrote: > >> Can do that, but there will still be a problem with chacha selftests if > >> I don't opt-out the entire function content when it is ppc64. It will > >> build properly but if someone runs it on a ppc64 it will likely crash > >> because only the low 32 bits of registers will be saved. > > > > What if you don't wire up the selftests _at all_ until the ppc64 commit? > > Then there'll be no risk. > > > > (And I think I would prefer to see the 32-bit code all in the 32-bit > > commit; that'd make it more straight forward to review too.) > > I'd be fine with that but I'd like feedback from Michael on it: Is there > a risk to only get PPC32 part merged as a first step or will both PPC32 > and PPC64 go together anyway ? > > I would prefer not to delay PPC32 because someone doesn't feel confident > with PPC64. I have no objection to applying these at the same time.