From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CFF6CD3427 for ; Mon, 2 Sep 2024 14:19:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F39B96B0308; Mon, 2 Sep 2024 10:19:56 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EE95E6B0312; Mon, 2 Sep 2024 10:19:56 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DB0276B0313; Mon, 2 Sep 2024 10:19:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id BDDFB6B0308 for ; Mon, 2 Sep 2024 10:19:56 -0400 (EDT) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 420A8C1CB9 for ; Mon, 2 Sep 2024 14:19:56 +0000 (UTC) X-FDA: 82520007192.21.CBC3794 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 6C8E9180009 for ; Mon, 2 Sep 2024 14:19:53 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=KeV5OogA; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf16.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725286724; a=rsa-sha256; cv=none; b=PWhsYOFa8O3yvcz/6Fi3QVRtFxGxpQ2b6R73chgEhxV2OzK3URYKEIRAVLH8oJdXaIF7M1 J34aq5B+WozEhuooPcTtn+XOyjVnNZDtruvMnmUOz1KOggQfAZZGZZ+Y3NnJBRFGQBTjs8 FIwkSV1u4r9+lgwPGx8KOkXUj7HNKJQ= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=KeV5OogA; dmarc=pass (policy=quarantine) header.from=zx2c4.com; spf=pass (imf16.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725286724; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=IdelkNQNEJ/x7d6HdhvWfHMFNgEcvt0QuA/u9U3RtjY=; b=PX3YtNgyY4G+mCx/txeSasoXPwq3h7i1fndP55/pHDMjsCBVyyl7Oy45G5penj/S/zKoLp VA60fw3pUdx56Ujhxx8pz5g7xnZTXIPyGYsWX1fF94e701I8jLpF8u8kGcKog/Cj+D9ZCt ARCZRGOBIj8MOO3cVsbQH65wAGA6XQo= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id CA8845C10A2; Mon, 2 Sep 2024 14:19:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9739EC4CEC2; Mon, 2 Sep 2024 14:19:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725286788; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IdelkNQNEJ/x7d6HdhvWfHMFNgEcvt0QuA/u9U3RtjY=; b=KeV5OogAbTBAMOtuoki3DgeJqyVvllDRgndH2dkze3yJLmaacKcbExWRMITKy5or0SV258 x4gQsu2kUb+oZQiOAJEgQaamdG25Rb8FTyy7E8qPs0Lh1OU6kkbcfMQTYpVqXGsBV9qP8K jOeTQOwZFwE9yTVHoh1o8Hd59SW8oSE= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 5527ce07 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Sep 2024 14:19:47 +0000 (UTC) Date: Mon, 2 Sep 2024 16:19:42 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 Message-ID: References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 6C8E9180009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: igmrj1pxbem6des5hma9krtptffm3wey X-HE-Tag: 1725286793-417465 X-HE-Meta: U2FsdGVkX1903gwq/lWO2FD8esBRjObTVTVkADUAdtXLF0EQv9QOdrj5bwXWHtE/Hwy89zgfBCFU+KNn6rKLAON29fYc6fCOnQNk6Ai/0hqr9Im8WF+v7/AZxgM+CbFKLsMPFrfP10a8ncUIkJ/3WfSdRnSNUKGM5xWllzoRedVKeYKYqUPJZ2nItYx9rVKnNXrq2xbG4uCDzpMUn7WlvtA633nAZ7vx8QsAEQ6CL12lWx7QdJgwY/ck/jv6Op2Nn0gDjCbuUFKlXJgxZqKZqev6MNDOOVqnsCXDG9edml+/fM8P+Tu29MJcdYrWWcx9me7L1Dw3nlTyLeuQzlHoLu1m3VHMR++Nv6LBGUMdMdjKzPgvFW0qlCPoA/zXG1VVjkjOyM4Ok5rEakvTNtq+hiOfpSPw8U7eOoT2pUzTyd7lTp/L5Ee9VNf5Pg4XOIajDkxrgRIE8emn6IsT/+02Ped7TVdgOGsBBGaX6oB+zxaBjgzbK9kWCCp+XBGIezGQOed4/kF4FezA7vj5krNfm+8VYnnxBe3xElJIQODFj9hzblGjvySnmKldA6MBZobkMGK7H0TrB2Rfq5I5Z85oZ25jrmaavzvsKNidBvnUU/uKfOwgjvci7XfE7zYg5uIUy6Cz5QnSHP6oWYJpmJnWZ7OpBLJw2UzNdcCYsR8igQgA0xSqzVHw1ZsRp4JrfJ288l5XuiUwqBeb62D1u2pkM61O29XWdBvc11zD+smczE5Jyub390ZHdrNOzw3Uft+WXixndPY0Y0XxlWwUnEKbH3lk6gdfb3/bQgnQDkL93/q59sIlhBZOTRH1vCdKoFqpvoLDwl5scLYBvha+vQc7smBrdaSh0l719TJEkQjVkMHA+f3BZzwttAZWX9D6i9YiSt/LuHuQ+t81nHGBEIX1ZguOQJnI5EWbZQJukV1jv+Wzep18ndze+oRN8dgKz1iNc6xZlkOs7565ByegUCJ q0r4jWOL aUHKe+UJcRD2Yfv94bGd0M7VvbJQSsQPhLFB3gxzv/pMHR7Z8CmMOENuFUnUEXz90X0RRSUSGrFm4R/MBn1Cnpd0rDPOF8bQta0Pt5bfYDZgWyfgVzrur+10WzWRtdde228GFhSTeimTg/qQAloQ+vmPexu9R4FbjOYygjivDXwOF2wrxLLJt/9DsOJ8oNZ+PSQR2e80l/Owpf07Lpb1ymeOCusm39i3Mse8SZmGRLaDUMtOlg4uzJRCpLq6l+61gryvK5nj4PM0QDxYY/A6tkfCuvMqDOHvdCSksI7fx9shGFhW3nEpz4jGjkK/Fc0Gx+9V2EAqTgXGTOG8uuLQ2qX5DZzpy0vSvecurAkdvr6h0yAt1f8IQg9jvnwynvfwKOgLLvW5Ev2KZtHRmW8VSAD9oIh/Ws/6q6klZkT5O4e4+Uxfk93Fggy3gOA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 04:16:48PM +0200, Christophe Leroy wrote: > Can do that, but there will still be a problem with chacha selftests if > I don't opt-out the entire function content when it is ppc64. It will > build properly but if someone runs it on a ppc64 it will likely crash > because only the low 32 bits of registers will be saved. What if you don't wire up the selftests _at all_ until the ppc64 commit? Then there'll be no risk. (And I think I would prefer to see the 32-bit code all in the 32-bit commit; that'd make it more straight forward to review too.)