From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F5D9CA0ED3 for ; Mon, 2 Sep 2024 14:00:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 90D846B0385; Mon, 2 Sep 2024 10:00:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8BD596B0386; Mon, 2 Sep 2024 10:00:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 785426B0387; Mon, 2 Sep 2024 10:00:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 5B9B76B0385 for ; Mon, 2 Sep 2024 10:00:37 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id C3C4B81D5E for ; Mon, 2 Sep 2024 14:00:36 +0000 (UTC) X-FDA: 82519958472.22.FF8F15E Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id D54C240035 for ; Mon, 2 Sep 2024 14:00:33 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=X99r7ucy; spf=pass (imf04.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725285540; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dH1tTlDFz02LirzapNYJOjvf27rZrsn4qQhBH9PXJJI=; b=59axLZJ+lME6Eiu5+nyEeJpYVV/QEo8SaSU8uVuhT02m8l//pys5GW+vCmxeSu2zQtBVOV buou7T8rRH4q2UX8bL8eq6LSKdvIzLN1Ap+PvRfQFtdPWtk5viZ/gTDP31m1+7quGz/myx rkyIuy7n2Arrlpj6cJOprtENfTUbQDk= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725285540; a=rsa-sha256; cv=none; b=prjacsEIwI7zkdLT2q10v9N9/tifkuuBGDpmn7hQvgL83PJkck/DEtKYkeCrcqiLOheJw3 /eGSjIe4BkoVCWhdv5EQDfw6wqufcGt+M7CZnCyIK0qsdgwyPdiFltImTMGNyfnLKU7mPZ zpLv30hIpVZfGx0sJL2zPiL7lKasMPU= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=X99r7ucy; spf=pass (imf04.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id C078DA403BF; Mon, 2 Sep 2024 14:00:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9B4E3C4CEC2; Mon, 2 Sep 2024 14:00:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725285629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dH1tTlDFz02LirzapNYJOjvf27rZrsn4qQhBH9PXJJI=; b=X99r7ucyzGQYz7BV9t3L42iNhMq4Gphnca5YBUq9T8Om5gEZzj1YIOYWEfXnn1VQwl8yQU 8dh8jff+3pIFuuuweAdnIGuZm/DTbFo6qJfXoT4ZY0IHBzAX9pRhxb8I6Wcc6Mk6KtYGP0 9nZRx5Gug0R98ELGgORIOU8/WjjAKP0= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 26b40413 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Sep 2024 14:00:28 +0000 (UTC) Date: Mon, 2 Sep 2024 16:00:24 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 Message-ID: References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D54C240035 X-Stat-Signature: 1g77qt3hubk35t33fimdbtpop9atsz6r X-HE-Tag: 1725285633-218089 X-HE-Meta: U2FsdGVkX1/QyC0h21vpr/16mAW3CHSj8gjOvG/LVg7NtGpg2aIFfJN6Z114IlqHo/wJuMAPDopRgcvlLiY9xJj8yah52/3FgOQW5b2wtYBmirsquteoiXTMyRpjvRsMmOJ8FUIFBBlxHzn3z6cMxPZBk95r+2KLkiBdMe6Q8OQ8cXz/SlTnGJLN/WadUqJk7mgOZTwxqnpQQuQXfGpoYDxlzuIJ6pG/8F+3m71vM8T1wHFxhcU3ZqmbbyYQPkjPakFswQ7lfDeJHjXv7EeDOUeXNH031AoJhTRbND4OXPKZ/QUqjbLoOodB5pfKG1/qZPMrDc7abagaEvLXCpEHwaJWTZXJ9EUlGplDgXijge7Awp5IIBSJyvtEuJWAQKQCHWE9KBLqr1P8upXYMfrAIrSAulAvO7aFvEjC1xXtLavpHXb9ZQoj3YmMyoqGnkCqHGbd/vjOvTmA4FuFBBMVlEx2N00ltDFh/EQ6MGh5ILXqe7aAEFcfHbvSzVrF0/4dCpfbkWt/nSjFQddHU6Ie4y/leTjCKE7/swii+FJZ1fkdxoXgUwIinA0EHAAPDsWEY4VltjYwEKKsX+XWsVEpSJRpKC/yqjEExmYTXc88vgLE6bbdgADgk77Jy1NZK7x5OBBxpqW2oljOJA2b9rvEAumHmS2UPY/G4jKef+Jib5gu+yVmo68TkRmbJ7y0FhP6LM9VAVX2Bf1IZwHrUm5mYGiidVtQE5HFLrAOa48Z25RIIHQnd1vGM6J0MW8zjiRxxs/MKQqG7XrPB0eh1nf76lzVafxQPOSYVzx3SOwjd8xza9jA80ET5dAX8q4FSdRJQ68alQBNOUYNxIzxLJ0l/MjGn8q3c5JT4IBpkQuG1N33Qr5I+wF91GLmEJKcsBkUdLTajnEt3RD9OQ30qSZ2Qx+9Mj0SpQj2a6Sonbx/+XY6MkZPTC3K7YXpEC5jOm1GzW4vYyleNYjJhIDqqxP h9IcYJDY TiZdsGrQxwOiOj9E508yG8alvqwVyOtF9YEmzuBnotiXMFJeJPNvUtH9JnjHDpOuOhW2prmw4hgCsYPB7YNYp4D0iDS/LPMMA0eFy83OkvPXTMQdmzQszgCN6aLKYVtOcXUBN65h4Xr8zYEc5reR5/yq5J3hgwUlJ2zHMoxBYPO2mTGG5BTUDwLdRVXle8f4LAKzG4i0lk5XoW3s70whmWoWcbmmBWwAG7Op1aiGJdTXW41vxKrO3kc5AxEK+OSg9jGdWlWlbfI1GPw4ubs4ga5DIBBmj3JjCAyrPafsqQU6dPzKk/RuQnuAbjxHnSFYfWkn01feN8dI1C+AjLcIZHED1aBCNbxWtUekO3EGNDuAKwq53m8AbGuj17U1YMxmNye8CSsXxxpeoyJ42WPRE5A+B/vxKtHLb/588g0fpnsRW22hbnXlQ/LsYBA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 03:12:47PM +0200, Christophe Leroy wrote: > > > Le 02/09/2024 à 14:41, Jason A. Donenfeld a écrit : > > On Mon, Sep 02, 2024 at 02:04:42PM +0200, Christophe Leroy wrote: > >> SYM_FUNC_START(__arch_chacha20_blocks_nostack) > >> #ifdef __powerpc64__ > >> - blr > >> + std r5, -216(r1) > >> + > >> + std r14, -144(r1) > >> + std r15, -136(r1) > >> + std r16, -128(r1) > >> + std r17, -120(r1) > >> + std r18, -112(r1) > >> + std r19, -104(r1) > >> + std r20, -96(r1) > >> + std r21, -88(r1) > >> + std r22, -80(r1) > >> + std r23, -72(r1) > >> + std r24, -64(r1) > >> + std r25, -56(r1) > >> + std r26, -48(r1) > >> + std r27, -40(r1) > >> + std r28, -32(r1) > >> + std r29, -24(r1) > >> + std r30, -16(r1) > >> + std r31, -8(r1) > >> #else > >> stwu r1, -96(r1) > >> stw r5, 20(r1) > >> +#ifdef __BIG_ENDIAN__ > >> stmw r14, 24(r1) > >> +#else > >> + stw r14, 24(r1) > >> + stw r15, 28(r1) > >> + stw r16, 32(r1) > >> + stw r17, 36(r1) > >> + stw r18, 40(r1) > >> + stw r19, 44(r1) > >> + stw r20, 48(r1) > >> + stw r21, 52(r1) > >> + stw r22, 56(r1) > >> + stw r23, 60(r1) > >> + stw r24, 64(r1) > >> + stw r25, 68(r1) > >> + stw r26, 72(r1) > >> + stw r27, 76(r1) > >> + stw r28, 80(r1) > >> + stw r29, 84(r1) > >> + stw r30, 88(r1) > >> + stw r31, 92(r1) > >> +#endif > >> +#endif > > > > This confuses me. Why are you adding code to the !__powerpc64__ branch > > in this commit? (Also, why does stmw not work on LE?) > > That's for the VDSO32 ie running 32 bits binaries on a 64 bits kernel. > > "Programming Environments Manual for 32-Bit Implementations of the > PowerPC™ Architecture" say: In some implementations operating with > little-endian byte order, execution of an lmw or stmw instruction > causes the system alignment error handler to be invoked > > And GCC doesn't like it either: > > tools/arch/powerpc/vdso/vgetrandom-chacha.S:84: Error: `stmw' invalid > when little-endian Does it make sense to do all the 32-bit stuff in the PPC32 commit (and then you can introduce the selftests there without the error you mentioned), and then add the 64-bit stuff in this commit?