From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35098CD13CF for ; Mon, 2 Sep 2024 12:41:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BE2838D00D6; Mon, 2 Sep 2024 08:41:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B923E8D0098; Mon, 2 Sep 2024 08:41:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A81EF8D00D6; Mon, 2 Sep 2024 08:41:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 8EBB38D0098 for ; Mon, 2 Sep 2024 08:41:50 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 02C44A793F for ; Mon, 2 Sep 2024 12:41:49 +0000 (UTC) X-FDA: 82519759980.22.8972E4C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf03.hostedemail.com (Postfix) with ESMTP id 3927020007 for ; Mon, 2 Sep 2024 12:41:47 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=M4l7tvQZ; spf=pass (imf03.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725280861; a=rsa-sha256; cv=none; b=siGDhvlq7uvUcCfa5yUx+Xu585NII5mPYATN+6FMg3f11Jmrn/TgRFgmzVWI9Xm5PYDjur nt579DHhGSuf7rYqrHNAou01JvN6urOmwI2TJaAiEMR9PqQE5om+m+fJNaGCAOgys5FHnA hP3kiP6ddKkt4r/FLPGN+BMbyIp4Rlc= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=M4l7tvQZ; spf=pass (imf03.hostedemail.com: domain of "SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=HWIV=QA=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725280861; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SbTBvowwyqT3oktU3TVamYzwl3zcSe2e1nUrzf5xWhI=; b=oyKrVvc7Z4iNvo4pIIPLr6y9z/DWJMNEOkQK33Avaale9PpcdRZJoJ+QsV42XLyAuXsmj5 qBh5PYCFkx2NG4jg+6RIrUxfNTywSlz8qe97pyUc52j6cSBZt9cfkWWzGwYeJo1x3ajoD0 vPRyRcUjSFrZ8Ys7Jt0609h+CoHkqlE= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id BC3375C5827; Mon, 2 Sep 2024 12:41:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 743FAC4CEC2; Mon, 2 Sep 2024 12:41:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1725280902; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=SbTBvowwyqT3oktU3TVamYzwl3zcSe2e1nUrzf5xWhI=; b=M4l7tvQZwQqTIhDhEWMzWRgk170y1R8WZOVuU9ydtbdFJffbSwgyBcPmyblIcx3RaFuuft 0P1p7MEgxZ3b5Ms3Cv7Fo3H/sfGe8NhzU87uuO6Yo/cbI9eyDQYOhSvjsK5nWiAA+exnbi zSdAwQMYfNPZ9fMXx3kRAE0vEnV4nRQ= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id db49d980 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 2 Sep 2024 12:41:42 +0000 (UTC) Date: Mon, 2 Sep 2024 14:41:30 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Michael Ellerman , Nicholas Piggin , Naveen N Rao , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Shuah Khan , linux-kernel@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kselftest@vger.kernel.org, llvm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, Adhemerval Zanella , Xi Ruoyao Subject: Re: [PATCH v4 5/5] powerpc/vdso: Wire up getrandom() vDSO implementation on PPC64 Message-ID: References: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <27de70dcc356e56754a03a2887a97597f5e840a4.1725278148.git.christophe.leroy@csgroup.eu> X-Stat-Signature: hmhqruo17buspg4r1zs34nqyo8m9858z X-Rspamd-Queue-Id: 3927020007 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725280907-39205 X-HE-Meta: U2FsdGVkX18IO424U5kjhrOsknD5kUf383G4hA56G2QXKXfobQOAv2cPpYMcW4XJiK+2MlB1TtV0Ro78psh7lM/pYgDZULSVIzZw7f+ABDh8JpgVINDodpEZLdAoPMS/koPObLysPFPZl1SszYf9CPEY6zUdtlsgeRQRm1fNOX91ZGOAbALwh5SVA652TxnfaB518Zi+IgCpvGwfagwSzE0e+5qKPb57OzKSN/fe/NJPEpH6HDjNJWAdzSgw681jeUfkqigSANCGJy2JC10xV8lk5chXKb9FiguwoZuXl54l48t8uSeMKQamchjvtvPy2lrE0u5gxD4gQ1woUtdEP60wAxM0YwhpGvq4oriYLPz2iiHvAiEkbt7+gFFfeg4YAYZ/8GddcGEQ4vxykv5z614ag6n2MIyXlMFlvm66YhwZnA8pfuN+F7lf9h6ha1F30Ys15ttALemn6vv+wGbsrVC3W8wV3XJw2VSj87OgXFPhiX3seyUDqplXmYi7+6TlaQpePjRN6raNDJsjjlH7jLWdmyLl8tQo/UFy300kXZYGact257A9uZDV58iIbkP313VefUJaxQnIwrlUm9NnbAQ0fcd8qofQFK4OzcHxoAMgEfW3jWgPsyvd1tATc+2FMbXHqtyFamJvNl/unpJlu61QTG44J9zxJWxvwT6Msu7oOdb95Js0ydcitUhLSQR4jzjogDmRAofEi1V71g+aLgTZaOYq/WCFjzBMVgZ06kIDgRAr1M3mpq+PusGLAlNh+/oHJIv4oNB0ul4tZ4jLFnlg9RUfnv1N4ss1zPRqOAIgVOKIJBaViJr0GKhJFTbsmuJXoT2O9f3SPKEmiElALNZaViVdXOaCTU41T9+EN8Pq0ZuCoHCEuMV3hhWZoUUX934eKp5SiS/TJAvt/x8+ma5moUWVjKEKsW3hmV6322pNeRadDk8CPJd1/d/t6XxM/jeAMefgmHNNT0N8j9b Twlrl9M5 9MVxzu/d2Ax1kh8yOQtADxXg56llaJUoIFHzw6JuARAahNhkzNkkas9qYEtnb4PkJeHbvel6MQrQIalduWUmgFvC2oYEiXRbOjSGWoTwQbzQpp4Ykgwvnm8XrUZrEDJ9rvXkeOPJIaGviAbjcO+ATKqGMekXj21ByJz8ENgnRt64uFpjWKSbxtJazEW28QHUTkbRFc941IPMr12biseDqI57buLCtkGEQCqjGu5qIW1oDWULsTizGoPYdQYqhvsDMDK3QmYSLIDabGxXykh4oEAxcXXzi16jlUwHSFCtKC/C4KEqjWVFt0+Pb6Z1DplqXSprxpL8rgpbzzytmUm64l7mWKntXDEKDYX1pdAeYrlMgkix39qQWL/6kiPTPbStiSL777xvJ6oOZ0AWl2KeEt5GvC4pCf1/x6jzn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 02, 2024 at 02:04:42PM +0200, Christophe Leroy wrote: > SYM_FUNC_START(__arch_chacha20_blocks_nostack) > #ifdef __powerpc64__ > - blr > + std r5, -216(r1) > + > + std r14, -144(r1) > + std r15, -136(r1) > + std r16, -128(r1) > + std r17, -120(r1) > + std r18, -112(r1) > + std r19, -104(r1) > + std r20, -96(r1) > + std r21, -88(r1) > + std r22, -80(r1) > + std r23, -72(r1) > + std r24, -64(r1) > + std r25, -56(r1) > + std r26, -48(r1) > + std r27, -40(r1) > + std r28, -32(r1) > + std r29, -24(r1) > + std r30, -16(r1) > + std r31, -8(r1) > #else > stwu r1, -96(r1) > stw r5, 20(r1) > +#ifdef __BIG_ENDIAN__ > stmw r14, 24(r1) > +#else > + stw r14, 24(r1) > + stw r15, 28(r1) > + stw r16, 32(r1) > + stw r17, 36(r1) > + stw r18, 40(r1) > + stw r19, 44(r1) > + stw r20, 48(r1) > + stw r21, 52(r1) > + stw r22, 56(r1) > + stw r23, 60(r1) > + stw r24, 64(r1) > + stw r25, 68(r1) > + stw r26, 72(r1) > + stw r27, 76(r1) > + stw r28, 80(r1) > + stw r29, 84(r1) > + stw r30, 88(r1) > + stw r31, 92(r1) > +#endif > +#endif This confuses me. Why are you adding code to the !__powerpc64__ branch in this commit? (Also, why does stmw not work on LE?)