From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75A74CA0ED3 for ; Mon, 2 Sep 2024 10:49:42 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E23E58D00BA; Mon, 2 Sep 2024 06:49:41 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DD3DA8D0098; Mon, 2 Sep 2024 06:49:41 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9B1E8D00BA; Mon, 2 Sep 2024 06:49:41 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id AAD2B8D0098 for ; Mon, 2 Sep 2024 06:49:41 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 52E4CC1B2E for ; Mon, 2 Sep 2024 10:49:41 +0000 (UTC) X-FDA: 82519477362.23.A1B44CD Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.8]) by imf24.hostedemail.com (Postfix) with ESMTP id EBD53180007 for ; Mon, 2 Sep 2024 10:49:38 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=softfail (imf24.hostedemail.com: 192.198.163.8 is neither permitted nor denied by domain of andy@kernel.org) smtp.mailfrom=andy@kernel.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725274085; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=nzD8+SgRgYOaCqKgEHVBdYOHYPvmdiSLUnFjUfqLSuY=; b=iTdlr1QBvp2x+nJiDzM1yVZK6cOqvSBzWUMjT8lOUwr1kBv9jMUUJZ+N9OB9yQ3fIcWhp/ qqarPZdyjxAndnB59E9zccdeTr4obesVKXf5F+yOzwAwPCqr6SI0jCCWXOvGihTZKI5pf1 IL9qzIaxGcuqOYNM8RtoaSxLU6Vah+E= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725274085; a=rsa-sha256; cv=none; b=lip2bsXrKUHgnv6sVNjXgxgMiZTpcLPz7TL2TzkqhXnp785kngZ9XGVsy9AIGx4jsRF+kF m56D2CvfOzg2aMNkmAut9AIXJZ+lgk2cJa6ofAV7gXfBiOXM8Eox3A40WzVTNjm2IWXxd+ /7a2RYa5w1fJG+68YK62ihb0SqIyOIA= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=softfail (imf24.hostedemail.com: 192.198.163.8 is neither permitted nor denied by domain of andy@kernel.org) smtp.mailfrom=andy@kernel.org; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=kernel.org (policy=quarantine) X-CSE-ConnectionGUID: cFf15Fw7SR2Ood5M9nSszw== X-CSE-MsgGUID: kyBusGIYSA2uTHQaI6ukaA== X-IronPort-AV: E=McAfee;i="6700,10204,11182"; a="41350235" X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="41350235" Received: from orviesa004.jf.intel.com ([10.64.159.144]) by fmvoesa102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 03:49:37 -0700 X-CSE-ConnectionGUID: z2YZOsV+QOSHt+7yVBwuQQ== X-CSE-MsgGUID: M1PbC1uaQA68058osujaZw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.10,195,1719903600"; d="scan'208";a="69445533" Received: from smile.fi.intel.com ([10.237.72.54]) by orviesa004.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Sep 2024 03:49:34 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.98) (envelope-from ) id 1sl4cl-00000004KVH-2dzm; Mon, 02 Sep 2024 13:49:31 +0300 Date: Mon, 2 Sep 2024 13:49:31 +0300 From: Andy Shevchenko To: Jakub Kicinski Cc: Hongbo Li , kees@kernel.org, willemdebruijn.kernel@gmail.com, jasowang@redhat.com, davem@davemloft.net, edumazet@google.com, pabeni@redhat.com, akpm@linux-foundation.org, linux-hardening@vger.kernel.org, netdev@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Message-ID: References: <20240831095840.4173362-1-lihongbo22@huawei.com> <20240831095840.4173362-3-lihongbo22@huawei.com> <20240831130741.768da6da@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240831130741.768da6da@kernel.org> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo X-Rspam-User: X-Rspamd-Queue-Id: EBD53180007 X-Rspamd-Server: rspam04 X-Stat-Signature: ncx98hmqw9hjsobryzfo9hsza8iq7e83 X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspam: Yes X-HE-Tag: 1725274178-908473 X-HE-Meta: U2FsdGVkX18CLueFWr9JkqgXraYsn9F3axrd4yrbeyijM/0P508ezOS9rqdwVjZmxTRsqrsYlgHoJ+VVrfdwlf33DhWCmHBCfMabOx/2Cqu/Qzi1ZLK6f9THKBr4YFRWvdxik+dT3dxGnrLUhkN7aK683q5Fgn6ZJImbQXTa96v8QjNvIkUJWhrmCkAQWfptER49w9biEkYw4itI28a02wI8lXtVBXFAyGUBIBudaozBYFoTXD72AbPgELRZlemck3G/tESigN1bJPF4Ze+2VtF0AJzmziLM+rINz96zQNJEXlxFZapsBqhVXm8K1jcrPVi4eKBcBdC/g+GODPdJTcJejSRd2cg+hPinobKtchhff97S5ELYt/Kb4wcEXQiJ3BN57DBCzILaI2XT4e5bgoleKxgFlRgeROOgkkijP3i2e+BrzjiggrIHUwZ8CtQR9MaYfv3cXvgap9ADpn2TUp1K5M61yPxJb6emk517o4pCTbYG/NCSXXHv5pLC6SbO+eCyuv2pe5BMge8mkniQzdLNNSSdmahmkFZYp77XCyczxEpQNETa2nfj+wc9n/SUUTxb9FFuW2jcZ66wQsP0vAXtPNaEM/CnCDj8+5B+f18ECQq0/Py+bujzYOROPJdLofUdqsnSc8L+ub7mtC6Ro6xjtv+Gr+n+RngqXhckZRjBiW34T+/nDmh9QKy0ycF4CNURl9AFSNke15rY5o1v0conAVN9E8pHieYoZxcH3vbyDBjjZWkz+a1Oif3oUiwezUD0Jg4BO2/nQ7w27jLj49Cw39XFSw0bgflBN/Rn+/KVTURxf+vHC0pQEji0iYG3k+eRV3tBWqEbw7Z080fyFNxAj1oBwdwG/cTK/SJ5GYimMN2kov5nccokQ6r8ekyx34Ub6XjdjKWuClfor/n+SiyV68m0pxn5oUcV/+s3ijLBVr0RPPmpmoPUs9Z9kciHDlkiYEm8lOf1FdGXAP1 EAv9cn7J ozMlJOLCD7CFek7TOxMLNsTIIH+zBtEtplBMs0S1n73czjRfeRyBlu0Cjkicmt3NQJwKtzqf/Lv0CfBvKTD+DomChev4zeL61/97qtOBZ4vbXy8FR2f5pY5Qej1Bo8bNSxjnmjEgRhI7LoIktE/E8CmlHgL/fw+iteTc1Ew6x07glb/aQRj3X5s6OVPclRBH19DJIRRF1CqCeHxBm8y4LVLnwbM1x/GSrVLvdpLIpn/Em1DnccCt2wx/U+/QrEUTWYb5h+bzoNOrB44pdijoa+A8snN+DGgFy/7w9EEJYJEh/Lvo= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote: > On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote: > > Use str_disabled_enabled() helper instead of open > > coding the same. ... > > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n", > > - arg ? "disabled" : "enabled"); > > + str_disabled_enabled(arg)); > > You don't explain the 'why'. How is this an improvement? > nack on this and 2 similar networking changes you sent Side opinion: This makes the messages more unified and not prone to typos and/or grammatical mistakes. Unification allows to shrink binary due to linker efforts on string literals deduplication. That said, I see an improvement here, however it might be not recognised as a Big Win. And yes, I agree on the commit message poor explanations. -- With Best Regards, Andy Shevchenko