From: Andy Shevchenko <andy@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Hongbo Li <lihongbo22@huawei.com>,
kees@kernel.org, willemdebruijn.kernel@gmail.com,
jasowang@redhat.com, davem@davemloft.net, edumazet@google.com,
pabeni@redhat.com, akpm@linux-foundation.org,
linux-hardening@vger.kernel.org, netdev@vger.kernel.org,
linux-mm@kvack.org
Subject: Re: [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper
Date: Mon, 2 Sep 2024 13:49:31 +0300 [thread overview]
Message-ID: <ZtWYO-atol0Qx58h@smile.fi.intel.com> (raw)
In-Reply-To: <20240831130741.768da6da@kernel.org>
On Sat, Aug 31, 2024 at 01:07:41PM -0700, Jakub Kicinski wrote:
> On Sat, 31 Aug 2024 17:58:38 +0800 Hongbo Li wrote:
> > Use str_disabled_enabled() helper instead of open
> > coding the same.
...
> > netif_info(tun, drv, tun->dev, "ignored: set checksum %s\n",
> > - arg ? "disabled" : "enabled");
> > + str_disabled_enabled(arg));
>
> You don't explain the 'why'. How is this an improvement?
> nack on this and 2 similar networking changes you sent
Side opinion: This makes the messages more unified and not prone to typos
and/or grammatical mistakes. Unification allows to shrink binary due to
linker efforts on string literals deduplication.
That said, I see an improvement here, however it might be not recognised
as a Big Win.
And yes, I agree on the commit message poor explanations.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2024-09-02 10:49 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-31 9:58 [PATCH -next 0/4] Introduce several opposite string choice helpers Hongbo Li
2024-08-31 9:58 ` [PATCH -next 1/4] lib/string_choices: " Hongbo Li
2024-08-31 9:58 ` [PATCH -next 2/4] tun: Make use of str_disabled_enabled helper Hongbo Li
2024-08-31 20:07 ` Jakub Kicinski
2024-09-02 1:27 ` Hongbo Li
2024-09-02 6:10 ` Gal Pressman
2024-09-02 16:11 ` Jakub Kicinski
2024-09-02 10:49 ` Andy Shevchenko [this message]
2024-09-02 14:30 ` Willem de Bruijn
2024-09-03 6:25 ` Hongbo Li
2024-09-03 15:09 ` Andy Shevchenko
2024-09-04 2:27 ` Hongbo Li
2024-09-04 14:33 ` Jakub Kicinski
2024-08-31 9:58 ` [PATCH -next 3/4] mm: page_alloc: Make use of str_off_on helper Hongbo Li
2024-08-31 9:58 ` [PATCH net-next 4/4] net: sock: Make use of str_no_yes() helper Hongbo Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZtWYO-atol0Qx58h@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=lihongbo22@huawei.com \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox