From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0432FCD13CF for ; Mon, 2 Sep 2024 09:39:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 894CB8D00B0; Mon, 2 Sep 2024 05:39:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 81E168D0098; Mon, 2 Sep 2024 05:39:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 649238D00B0; Mon, 2 Sep 2024 05:39:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 426588D0098 for ; Mon, 2 Sep 2024 05:39:47 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id DF5571C6B4B for ; Mon, 2 Sep 2024 09:39:46 +0000 (UTC) X-FDA: 82519301172.27.12260EA Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by imf03.hostedemail.com (Postfix) with ESMTP id D231D20027 for ; Mon, 2 Sep 2024 09:39:44 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=L3SxTJG1; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725269937; a=rsa-sha256; cv=none; b=4uAmrjWjWfbeLTGCrzh4gFvxc5nQ0d3mfqE3rVSm+Fo5tmZpE+/xcHm/TVUEDiHMXKCIg9 7A31ZuY91r1ceo/4hx3veXk83CGhd6OOuN+e66nBxokr5eEmZgojvZIsQb+DqPSCffCk+u 66CUzoLVdIIoosnNOHBaMqj3Rpd3/n0= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=L3SxTJG1; spf=pass (imf03.hostedemail.com: domain of mhocko@suse.com designates 209.85.167.47 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725269937; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=+b2Tu1YlvpDpDetKigSg2I/Ak7ZaGYzocV3AQmvxK6U=; b=GAf202v4GvZzX+ilXYph0SJR8oQ0FqJn4Xt3yZnzQQQV2QCWGjyH/NohKHVAx354HkuAB3 sWc0NKij3bkpqTtFjaJ8CokNVeoNgZJv8nuSDPtZHqK+wkO9B9kCUw4gbgZspQO11OWzJh yLTUatZ4kfWzQ2+v0FXEpYp51ncAe7I= Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-53349ee42a9so5362557e87.3 for ; Mon, 02 Sep 2024 02:39:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725269983; x=1725874783; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=+b2Tu1YlvpDpDetKigSg2I/Ak7ZaGYzocV3AQmvxK6U=; b=L3SxTJG1xlVlcEhENXWYyw/tWZDkBPUcsKkOCZscvaAQQjxkh0UABsajqWuWqKTUO7 WkWwUgKyxtMtujsP06cLlSTxyTE7JGmf7TDZbe7EdXWdF6o0OGWDNxCTRljl6V6EdOts aVaVg3N+lf3znSCa/dW7GcNV0i1pGBdvgK5d0Y5ByVm3zDmFjrSwMPjEVoC3ZxtuE4aq bUZmDhLnSsp/MlQOMOhEe7e1eStizcNbneoJonQGNFyWFlVkS5Xz3mJFd8fs3RZxWUJk E/Ryxtd7fQbuC+15vuQyeztPbw4Pdfy3d7Lw59g5IDrMVsQwEsi1kCLk1Uj+F9qRFKRj kreQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725269983; x=1725874783; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=+b2Tu1YlvpDpDetKigSg2I/Ak7ZaGYzocV3AQmvxK6U=; b=jh1Pl9ztN1bFfxhJ8IKvc+xmRwGtDbxxhlyCqt2iOgq7giO2JJbRVfQw3X/xYPYdZZ Pi912Ml0VNKIu7CJ2ZZ878X+wYt9QiCBDDl/WJJYJPLPHIq5ORMk5cEs+xsFvlwuiDEu 4i29Oe4ecwoyyjLPzYwUOpk1FOw+w/cZisISKYFq7zDHOkzZbrBvxFz033uQzyZlKhsi DlzlhF3DwaHGwX3zllU7iw0Xs66yTvmMrGTatuD8EcZaPWjX3EYNsmrLCAGyP2Ez+Llx t7gWDdib8tqHVUYXhPtxpGqOJ3s7dEtFrOvvej7WcAq+myy2pn9PzepKITBmu8tzABcJ Cd+A== X-Forwarded-Encrypted: i=1; AJvYcCXVgZTJhOTwBtuFrkc0LE9IyXQ1FbzbYjeua927RIIi6b2MVNbYUDbz6mycjSS4MSCtRzHAB5YCFA==@kvack.org X-Gm-Message-State: AOJu0YzKhcy/bLBeXhj1812k1AYsvPnsa0bmjMAFbtdUeMAKqxv6EbLt ZjwSrraWD9Gj33pR0lSJ2hIvnX0ZjmkClzaYgGZnnzyeTBceu/UbqQd5HshZcuM= X-Google-Smtp-Source: AGHT+IHZM5waMu+X5FhE3mW4B0crx++9U1PxnK3hjmktHHYE/8KgZSZDyo13u7RHZxzfN09KFJCN9Q== X-Received: by 2002:a05:6512:ea0:b0:52e:97dd:327b with SMTP id 2adb3069b0e04-53546b38f94mr5722464e87.23.1725269982952; Mon, 02 Sep 2024 02:39:42 -0700 (PDT) Received: from localhost (109-81-82-19.rct.o2.cz. [109.81.82.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891da22bsm533179266b.182.2024.09.02.02.39.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 02:39:42 -0700 (PDT) Date: Mon, 2 Sep 2024 11:39:41 +0200 From: Michal Hocko To: Kent Overstreet Cc: Dave Chinner , Andrew Morton , Christoph Hellwig , Yafang Shao , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2 v2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Message-ID: References: <20240826085347.1152675-2-mhocko@kernel.org> <20240827061543.1235703-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: eujd8rr1m1e6nt4yzey7wkc7pb68umq3 X-Rspamd-Queue-Id: D231D20027 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1725269984-947817 X-HE-Meta: U2FsdGVkX1+agp7XGdUWezPL2/td/aN9+UQxVLT8oa3xQS3bkPefJnVzuoEdiZ6W4T9mEjsBOVKx+BRG6G4k7/9ZzqWo6awhWhzEhvXe6VAj1f91C7fwpBV6oTNMyX8Y900uOeAJifReXYT0vWvd4LI9LkGVHWpb+3+aaktJ1Gyy5ZEtKHpcWeLqMkqFXJlaYie+h6+7H2JBQXGNJbpW+D/t2jpSosXdXkKwNzeynZC83tRJi1EOh3wIpToVvcf8IQQg6PqWFmo05oP8ipM5mIR0AVx0eWcdTHyJSmYgJrYAf+5FxA1CScXTO4qsPZthcRE3hd3ToxwvCKvgSHIp6pABm/zgkuQrv5iYAea4Tgnrd9ftW895CO40PqOmIKTVESlJAaJJdCo4TN1jFbBKHB+KxXwABTLnEgkdTg/z9m79FqPM4oNSy/t5mvkzcld4Q86MeeELnE30ZF1Qm9KdZGZ3yBXGmALdrmQp5sVWdMyLo6OalA5Kr+nhCKBeYjPm7MKTYl+snjR3wVTI2eRUMn2kFMl9G2/fD93ibFdF4UttVBhFBqKJ89DRk6VKkdCc4vAT2ehG3ZUL4vL7Yc8ZGvyJ9eM2QorgWtkl+Zvn+33fH7Or4x0L+mA6flYWJc38AIGNH0vpVAa3j+fgOO9VysUxrQUDUDB5+Zi6A4OgKLVTlyLiRr/qy1j2Ru2FfZYq6UIPzTWfP61l12CPfaEI4vidblwYgqYZM8SnJAn5K22er1JZ+iFUzGZoC7myd0snWe1sx7WYrwe9TCcLERt5SVpf0x+9/rJAIvCNKGgYqUuNB8L89ekBr0H/dkyV4Uwsfo3I/Nq0HffBoyKoTRC0wNmeDJYGUY394G4Gt7yq6lBVg5frY1wFHV79Ov3DmHHwoC/J3yXW61ncOOXwTOZirc+F3nfhlpNXnau/ays+rdUqDeQOSkYcponFV6/AAFxgsBrGtBaIcsna94iDEud Y7C9Kqn4 gzeE7uXDvOtDj+fjYP1Im5kw6QtdDSyHv85AouFHqT/rp5LlVlYfZ13AeYGm/ATF1zSOYID7q/7zTIaT5ieUzK1yF0dUQphVayfmutn53h22oYE17Iy99MOdnH1nqzdBb32s2Ikq8JTMH5go1yA8F5mnWZnZ74SVyvpa+TWGuz/7UcqqZJf4VZ95D20U3j0sEN+LoxUVajDV7ks9i/UFE+1tKPvTtAFNNPJ+Bp7mL5ApA3ubRI1K8kaOoU9RtmPpCfZqlXfqgaKlL+Nyw98H8pe+PEByP7KC1ltZRKiTGfs3teRP8AlVzxuWQE7WiZCWBgDzTq3oKo+X+AxRulvRf0CB2UOpUKN/anJ3yRh24H9xp5uacEXEiD7NpO8hRwS11YcVpyGfNJ5NIzL/YhI/RCae43SnbxoVO1gazAeMzTY/eMv8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 02-09-24 04:52:49, Kent Overstreet wrote: > On Mon, Sep 02, 2024 at 10:41:31AM GMT, Michal Hocko wrote: > > On Sun 01-09-24 21:35:30, Kent Overstreet wrote: > > [...] > > > But I am saying that kmalloc(__GFP_NOFAIL) _should_ fail and return NULL > > > in the case of bugs, because that's going to be an improvement w.r.t. > > > system robustness, in exactly the same way we don't use BUG_ON() if it's > > > something that we can't guarantee won't happen in the wild - we WARN() > > > and try to handle the error as best we can. > > > > We have discussed that in a different email thread. And I have to say > > that I am not convinced that returning NULL makes a broken code much > > better. Why? Because we can expect that broken NOFAIL users will not have a > > error checking path. Even valid NOFAIL users will not have one because > > they _know_ they do not have a different than retry for ever recovery > > path. > > You mean where I asked you for a link to the discussion and rationale > you claimed had happened? Still waiting on that I am not your assistent to be tasked and search through lore archives. Find one if you need that. Anyway, if you read the email and even tried to understand what is written there rather than immediately started shouting a response then you would have noticed I have put actual arguments here. You are free to disagree with them and lay down your arguments. You have decided to [...] > Yeah, enough of this insanity. so I do not think you are able to do that. Again... -- Michal Hocko SUSE Labs