From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D63EBCA0ED3 for ; Mon, 2 Sep 2024 09:09:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 68C468D00AE; Mon, 2 Sep 2024 05:09:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 63D768D0065; Mon, 2 Sep 2024 05:09:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4DE468D00AE; Mon, 2 Sep 2024 05:09:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 2D4E78D0065 for ; Mon, 2 Sep 2024 05:09:08 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id D3106161B95 for ; Mon, 2 Sep 2024 09:09:07 +0000 (UTC) X-FDA: 82519223934.27.2909B30 Received: from mail-lj1-f179.google.com (mail-lj1-f179.google.com [209.85.208.179]) by imf09.hostedemail.com (Postfix) with ESMTP id DE483140007 for ; Mon, 2 Sep 2024 09:09:05 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="EBqNJ/g4"; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725268053; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tc+tIxGI3WkXrC4GyS0UazwJpXd6EeGAj+AW+8MBy5w=; b=56B3hme3UazVR9jbt3d8Qu2/OvagC4uyCg2SbE9o8KcPk8r9092eccMvo8sm7+fU/kf2FO H/mgrkG0otvpMm5/KPbxAuu493pG2Bo09t4AXVMoW79Ez0YlpGbgPckNmJLPPdHTMgdSPg z5ZLgfjaiKoQSeaAwBkYZs9uF4raR/A= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725268053; a=rsa-sha256; cv=none; b=y4YDaiDch9RZZ8wCNBKA5BRxzhQNvJrF8xWosBMWOjdpWj1CKwwSoQQOU+lxSZ3wm9CUKq SOkgbHABVKczzIqbBnXwzjeMyV+asxnTgKfAdEyzJE935tTM0VQ81OXVhCwxQScv4Tyj4T A8X01eBnWwf7Ho8SmfKiuK8/sk04GJc= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b="EBqNJ/g4"; spf=pass (imf09.hostedemail.com: domain of mhocko@suse.com designates 209.85.208.179 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-lj1-f179.google.com with SMTP id 38308e7fff4ca-2f409c87b07so49017971fa.0 for ; Mon, 02 Sep 2024 02:09:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1725268144; x=1725872944; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tc+tIxGI3WkXrC4GyS0UazwJpXd6EeGAj+AW+8MBy5w=; b=EBqNJ/g4Fslz4jGb6js2uPD+03awalEqW0IL3uxL+OnPeUsU7/9+DK+IadgbomCZEX pz1SM3HdPqFJ3azShhpjvAG8plyoxe9B2dbP6Nhm4Siea5NW3FQbOIQI9d8MGD4n0p68 C6LQ051JM1A1d9JEgBgbxIODIvdT+nCqmRLxu8imfOmEqIgPBdO5ozGEG3chmsLnYCEb W+IFQHvYMYxW2u9nJ1ogooQyH6wLOnvYdodATK+iHqaoYrJRmQPeMesF7dk7uibrdefP /xw/31isxqrCWOpWqgTAJ6O7kmjDE8qVpdvE9rhiYgHSBZVkAY3MEJPLFYJ0DwjanR3d aMqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725268144; x=1725872944; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tc+tIxGI3WkXrC4GyS0UazwJpXd6EeGAj+AW+8MBy5w=; b=XNgVItfY2ZCzjAVWd8tUpnlQ5ZC5ezsgxIKoHkVu05L7CGPEOu4yEhA+tVB96xAX3n dC7ZuLRO4Qdg5/0PRUrd1oALtcD13jbyutL4UapzsVSbxxvlTaJsP/Bg3PYTqZ4t3xKv 0zabvNFgmKjeCsHHV7yf0x4pZNCHm4ojuKTpSB+pv+VoivBnsJEetiUIYxgWlpPGvZMH 2JW63q4OFFTysrh+WEsOotudQ+AmSfhouYRskvwn7twkMG9B/FWZt1pL7HEvxi91Aghz Eg7u30UezUyAzqS3sDTXp/ULJxd+Ye77rXqLRD6TFaRyyFWOknzTu4nNauXSUfIn0N6D AmUg== X-Forwarded-Encrypted: i=1; AJvYcCV4a3q0Ww0QXUoTWHm3RKaQPnIru3GLRDbbNwXKaoEbwAsvSNnKPSxmE1iWbvZEbj2mkc5TxNUUrQ==@kvack.org X-Gm-Message-State: AOJu0Yzx8gKWCMX/YDw70xFD21MeNzr39P1jXsn5EV+Vkfdnj+03+Mh8 n/JhrRbA8K1A20m6TEk8Kaqvw8SjbukyyMA3i2+h/b7ugNMiaE5Xxbrf/A7J/ts= X-Google-Smtp-Source: AGHT+IGE/GtNjsdfXTxeqr6p9FrfimaHQ9FGSfSyoXGsx0BhwbDRvvlZ17A524C8LUpRaD0LGFd9aA== X-Received: by 2002:a05:6512:3da9:b0:530:ae4a:58d0 with SMTP id 2adb3069b0e04-53546af3605mr6730057e87.8.1725268143851; Mon, 02 Sep 2024 02:09:03 -0700 (PDT) Received: from localhost (109-81-82-19.rct.o2.cz. [109.81.82.19]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a89891d6fa9sm528702166b.162.2024.09.02.02.09.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Sep 2024 02:09:03 -0700 (PDT) Date: Mon, 2 Sep 2024 11:09:02 +0200 From: Michal Hocko To: Yafang Shao Cc: Dave Chinner , Kent Overstreet , Matthew Wilcox , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Chinner Subject: Re: [PATCH] bcachefs: Switch to memalloc_flags_do() for vmalloc allocations Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: DE483140007 X-Stat-Signature: ucgdsutgeo9p9wxsr75rgfwf37jqsahe X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725268145-804695 X-HE-Meta: U2FsdGVkX1+gWOw/jPBCGnU4HSimPxAwbzCrIbzJTQSK0mSyZfVlWdliNpSEaWu9rkXYM/Y/GBvYZp8WOH1/xDfZNw2CAxsrVGiJ7n0I1XHUGrH1L3cFRIYEcsdIIF+eMLkrW4TC5zxEZ09MtZOi3u5PPXqukmkf8U1mqkQQtan0416RC3/+2XTAqhCWMyknbqOCy983ugOeBDxOAKKfBg4iBrhNiZwShbGGez8zJCXGWeXg61pN3skJJhHiiSsI/rzDlPL6zVGnw59XgGze+Seas9mnpw+6ob6BkeMlvDNATfl9TuHjXYvosLh4UStQwmxeVd7rIYeHx4ugp0LbwOc+bS689FiGZgdIj1Hp7uZA4tZrUBf6/PXd9iwVn+0T2elIu/iYghkHxY6CErXavt2bh7HBXTr60hJbQ0F8v6mueyLItIi3K73/9umHY5dYhTtPIivHc1nKHfBgm3Bce0Xwclym6ndv0Y0eX9jrGmywzsc9dbhSm8Ny+4B0TlYy2rtm+pRTPf4Yig5XaAH4oQGFzu/+rYebDGXAd+G3gBEjqHua7pAx/Qsw8nExDQWdmqx52c4CWcculwAqx7u4pNVbaJBaHqdh/g2tO3Kqife8hjsg5wkicuoLdnUhqWGqDFou6uFAfVSiHv6ivg2RPAEFEO1FN/cZQ2Ii1SKtFT1W0midJYn6Q6TlGTACmGieFrhKmchjHvPZJyAGQbJths1d18uBmLuOhqOim7BR8h4jsniswPypOMDdBsqZ/GGMQ6TaTNgSBIohBZK9zec6UxH/TrqD5UHRd3SZp/y7YDCbqpVvwMNEMCpOGDRYDqThCk0GTwp0zWAmCtkIKRM/1fNcUqC2v0asnbZ+I2fI/r20VY4/i3YZof+48falyNkhIfGOcfsVP9UhNzp8Y0vFwqEedSPRrAgLgU5iovRfNtxtAZIHjzF5jx4s3bFwPumqUAEWhT+ldNQCmxd/Qwu vhC+xrtG C6QgMbdCaibCVE+rVGInDv4Zk1L5AojFQJzZG1wpauqOHJeg5t/cKGOdiZEk0l2uGmtZvTgIJYur4jRcJawb7u+PNTuGg3ldb1gocRQpFgmupD2gX78Vz1EzPZM7/hwef5EnLaYfAjdS1VNLY8XsoLRDWhxGPUlbCzf6sPvZFYUsJ6CkBXMU7JYP+KWz3qi6vy8BiYtuA0ymN0DXOdL8dSI3GcBgfuqfLUNgoLp7Z0gObxcbKLCONpJinYNWLKwVioba7mstd8r7Q2A6ve0uAqVEAsikngke03OKWeBE9i+2Fbxu0ZSY0YiOz/cmeqzZkOSXBqhnkIglzOPEHUh1XKAef6rCV54sWk91CnPtSjB7q9XEXso/5KL2o8Y/oHNePzrb+pbIjOctCzXJ8adfpk5LHAw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.055208, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 02-09-24 17:01:12, Yafang Shao wrote: > > I really do not see why GFP_NOFAIL should be any special in this > > specific case. > > I believe there's no way to stop it from looping, even if you > implement a sophisticated user space OOM killer. ;) User space OOM killer should be helping to replenish a free memory and we have some heuristics to help NOFAIL users out with some portion of memory reserves already IIRC. So we do already give them some special treatment in the page allocator path. Not so much in the reclaim path. -- Michal Hocko SUSE Labs