Re: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM

kernel test robot
2024-08-26T19:52:35Z

Hi Michal,

kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]
[also build test ERROR on tip/sched/core brauner-vfs/vfs.all linus/master v6.11-rc5]
[cannot apply to next-20240826]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url: https://github.com/intel-lab-lkp/linux/commits/Michal-Hocko/bcachefs-do-not-use-PF_MEMALLOC_NORECLAIM/20240826-171013
base: https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link: https://lore.kernel.org/r/20240826085347.1152675-2-mhocko%40kernel.org
patch subject: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM
config: arc-randconfig-001-20240827 (https://download.01.org/0day-ci/archive/20240827/202408270304.AUPHM0xo-lkp@intel.com/config)
compiler: arc-elf-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240827/202408270304.AUPHM0xo-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202408270304.AUPHM0xo-lkp@intel.com/

All errors (new ones prefixed by >>):

fs/bcachefs/fs.c: In function '__bch2_new_inode':
>> fs/bcachefs/fs.c:248:70: error: macro "unlikely" passed 2 arguments, but takes just 1
248 | if (unlikely(inode_init_always_gfp(c->vfs_sb, &inode->v), gfp)) {
| ^
In file included from include/linux/build_bug.h:5,
from include/linux/container_of.h:5,
from include/linux/list.h:5,
from include/linux/backing-dev-defs.h:5,
from fs/bcachefs/bcachefs.h:186,
from fs/bcachefs/fs.c:4:
include/linux/compiler.h:77: note: macro "unlikely" defined here
77 | # define unlikely(x) __builtin_expect(!!(x), 0)
|
>> fs/bcachefs/fs.c:248:13: error: 'unlikely' undeclared (first use in this function)
248 | if (unlikely(inode_init_always_gfp(c->vfs_sb, &inode->v), gfp)) {
| ^~~~~~~~
fs/bcachefs/fs.c:248:13: note: each undeclared identifier is reported only once for each function it appears in
fs/bcachefs/fs.c: In function 'bch2_new_inode':
>> fs/bcachefs/fs.c:261:67: error: 'GFP_NOWARN' undeclared (first use in this function); did you mean 'GFP_NOWAIT'?
261 | struct bch_inode_info *inode = __bch2_new_inode(trans->c, GFP_NOWARN | GFP_NOWAIT);
| ^~~~~~~~~~
| GFP_NOWAIT

vim +/unlikely +248 fs/bcachefs/fs.c

233
234 static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c, gfp_t gfp)
235 {
236 struct bch_inode_info *inode = kmem_cache_alloc(bch2_inode_cache, gfp);
237 if (!inode)
238 return NULL;
239
240 inode_init_once(&inode->v);
241 mutex_init(&inode->ei_update_lock);
242 two_state_lock_init(&inode->ei_pagecache_lock);
243 INIT_LIST_HEAD(&inode->ei_vfs_inode_list);
244 inode->ei_flags = 0;
245 mutex_init(&inode->ei_quota_lock);
246 memset(&inode->ei_devs_need_flush, 0, sizeof(inode->ei_devs_need_flush));
247
> 248 if (unlikely(inode_init_always_gfp(c->vfs_sb, &inode->v), gfp)) {
249 kmem_cache_free(bch2_inode_cache, inode);
250 return NULL;
251 }
252
253 return inode;
254 }
255
256 /*
257 * Allocate a new inode, dropping/retaking btree locks if necessary:
258 */
259 static struct bch_inode_info *bch2_new_inode(struct btree_trans *trans)
260 {
> 261 struct bch_inode_info *inode = __bch2_new_inode(trans->c, GFP_NOWARN | GFP_NOWAIT);
262
263 if (unlikely(!inode)) {
264 int ret = drop_locks_do(trans, (inode = __bch2_new_inode(trans->c, GFP_NOFS)) ? 0 : -ENOMEM);
265 if (ret && inode) {
266 __destroy_inode(&inode->v);
267 kmem_cache_free(bch2_inode_cache, inode);
268 }
269 if (ret)
270 return ERR_PTR(ret);
271 }
272
273 return inode;
274 }
275

--
0-DAY CI Kernel Test Service