From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F20DCA0EFD for ; Fri, 30 Aug 2024 17:12:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B81686B0183; Fri, 30 Aug 2024 13:12:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B318A6B01A5; Fri, 30 Aug 2024 13:12:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F9F76B01A6; Fri, 30 Aug 2024 13:12:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6D3B16B0183 for ; Fri, 30 Aug 2024 13:12:34 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 0DDCC14024C for ; Fri, 30 Aug 2024 17:12:34 +0000 (UTC) X-FDA: 82509555828.22.403FC34 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf30.hostedemail.com (Postfix) with ESMTP id D9DBF80010 for ; Fri, 30 Aug 2024 17:12:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=h73zdqsi; spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725037832; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xSHx5MF06y4HT7OrzLXzlQLM81Zqol4C2EbQwQuVEjc=; b=6JXp9uN8ibhPnvUOXSefsopAXyjJ84geuqk04WBAxauEK5co4msQciSoIBamS8RMB9s3jH AB4ErkF3fmwQIbhxRZXk+j2zFgGRSO0H6PGAAVybn/NFuXIicdAm/nHSRarv8T3Ivz7Ejk 81/BCoNqcy6B1gFePpeTJeJQNEmvTj0= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=bombadil.20210309 header.b=h73zdqsi; spf=none (imf30.hostedemail.com: domain of mcgrof@infradead.org has no SPF policy when checking 198.137.202.133) smtp.mailfrom=mcgrof@infradead.org; dmarc=fail reason="No valid SPF, DKIM not aligned (relaxed)" header.from=kernel.org (policy=quarantine) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725037832; a=rsa-sha256; cv=none; b=wOysj/AR4jUCtYAJZYSAFvnEI3dO2NoF2v7JlvQ0J3nLjRASIwm3RBzfOarKMO92oxkID0 B3UgsJ7BrS2pNUShEtHlIXpYG1gcBAVASV37IHR/7yNgcDD4gXukg1hVNL8mr07/yRYZGV lQPaFPzXekrF+EcAZk8bXkUx9vU6Bpg= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=xSHx5MF06y4HT7OrzLXzlQLM81Zqol4C2EbQwQuVEjc=; b=h73zdqsibHLWoTYyIuw/1aVeVf 70hNqDMuLXXelasTAvi6PNImjXva6E2IichGiNdDxsMY6yYilL8r7Goas/DRbYECr05Af7UqSb0fx 0GW6IuvdhH1CRvQ3WLyMUqtWbkZ+swyxj+iNF1vpGRN/ieSfPuoQgM8JV2FVHTmyexpfssdwrhAiS ISKEPv/2asVBfDKnvQ9M+mnrR0WRqucZbdyydPQRBthDEfeEkWQmKWdRfsud/AUuNOCkz2yfSOMn+ 0D/1P8NjvMnMs674/33qXTdy5j+H/93dP0X1fMSdrPi7E/gReuxl/eECafXkwY4lxP4y//SHpiqe5 FCckFepA==; Received: from mcgrof by bombadil.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1sk5Aa-000000079AQ-0LhE; Fri, 30 Aug 2024 17:12:20 +0000 Date: Fri, 30 Aug 2024 10:12:20 -0700 From: Luis Chamberlain To: Pankaj Raghav Cc: Zi Yan , Matthew Wilcox , Sven Schnelle , brauner@kernel.org, akpm@linux-foundation.org, chandan.babu@oracle.com, linux-fsdevel@vger.kernel.org, djwong@kernel.org, hare@suse.de, gost.dev@samsung.com, linux-xfs@vger.kernel.org, hch@lst.de, david@fromorbit.com, yang@os.amperecomputing.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, john.g.garry@oracle.com, cl@os.amperecomputing.com, p.raghav@samsung.com, ryan.roberts@arm.com, David Howells , linux-s390@vger.kernel.org Subject: Re: [PATCH v13 04/10] mm: split a folio in minimum folio order chunks Message-ID: References: <20240822135018.1931258-1-kernel@pankajraghav.com> <20240822135018.1931258-5-kernel@pankajraghav.com> <221FAE59-097C-4D31-A500-B09EDB07C285@nvidia.com> <2477a817-b482-43ed-9fd3-a7f8f948495f@pankajraghav.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2477a817-b482-43ed-9fd3-a7f8f948495f@pankajraghav.com> X-Rspam-User: X-Rspamd-Server: rspam06 X-Stat-Signature: jr4cow1zsekpd74oa5ymzhdn3jjgtbid X-Rspamd-Pre-Result: action=add header; module=dmarc; Action set by DMARC X-Rspamd-Queue-Id: D9DBF80010 X-Rspam: Yes X-HE-Tag: 1725037950-142140 X-HE-Meta: U2FsdGVkX1/+ausdtA29ZDtNxj87NP88a33i63E8QEP/iUodgA/PbOE/c2N5XdCXdgHHbT8eRTsjpHCuFDKua7QIbjIeSDFYiHKFBpHahbN1fy35QHrSpRxr4CU0F7ORiigeBZMSLiNyMxVm70cx0iugxpup0rIuzxQac8NTAG1NvNhvJAceqCHVUy2ozjZUqUu9G19VXoXMkwSUAOYjeTA36HKe1/+Zfe2p0pQxziFWn+NqeTh8PzsNOt6rcvbPil67ld3eCv2JxMOBgQT65prYh1vRm19qPkeoc6L/o6/KGGkZne11HTvwlwPttKRpgEpQk5sDoQoEsd7fD/gEQGm0zwa+nOWRlBpD4JvyvtxVqEs+LLPYwPk5zzMVewBBoKvDUpraszzflUJIJWP5yTzsC5z4lKhRWU+B+EQ/R41hxYu6ZNXEtnqwqnCeGnTC854k7t+dFnw3b1noeAjsSN2W/EQ70RCuKAz4p7KBCodqct9/S+47y3zoxoVslhbxh9PZjLjNTC1Tmboks6K7OZ6n64CHzdP3hjHKoo9k9KHYdCjMwlvgKouzDRuKOWPKg6rv3cPLzEhCu6p1r4HEuhpXsJGSk4vJLsXevdRPpzYLjMNE+r01rl+HIVl+L4pLw47eo7UoQOLM0l7pJQlzV6Ls1RMgn8CTatuZcJSxBfivA7uIHGvSG8l/Mp6BwtqsdsRpvljoaEIXOCHkJe/N+Blm305KgN9iOBM5LdfQvOVLEiuxLDfKKehBIwY/YqOuvsHErukyhhpc2qvFn/loYnXl/aIlj55bN6gAU3OAApKjXWoHLyUYnGyB6iAATmfmUWJTD9TMGoCb37EaXog37oMhEz9SVvfkyzhJz2dYjHWl7wXPHILuypq3JX5ODSIRNuZMao8U+cdZyXwlUDqN8WSME7vrpIH4jpLaK8BwuVaQ6adgZripri2qZV49EF3bMODLQ2MO0p3iAWdoO5A GintAGPR APbAf1uXywQKpSKMfFMHawL/iL7zWQCEoscuy6RMFHIZ/HtCRpKgKHgYY0EAsduNvFEt7bTeoO/kUHfRv7ZWyVBA0dgdz6vR5OukPeoK9Lr9pr3GX/De9w56/LLzj3w4wZChz6F8UkwqMRTzCARw6MJtfbkOmO7NndzBaE4tM9qi2sv0i/USNS4R6u4npyb2alDUZVr+9ATBoOxrkqtnQDaXEnE2SJZlrgt3ttWNQMsyRfyHTBXIL6X9cqxg3a9JHblq4JOZBRTDgNuhsEWHn80nip0cRhEliy8OrBCVC9jfnDP76PUG+9HQjMChyfdF5qxHO4PrJTVw5gzKDBl5rbV8q820VTlZ04J4pWDSKXiFLI7J0B2pbAFiZZU4om9q6HGMCAm46enRQwsCRnGgcGvDrB0NfNL30/4HD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000003, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024 at 04:59:57PM +0200, Pankaj Raghav wrote: > It feels a bit weird to pass both folio and the page in `split_page_folio_to_list()`. Agreed.. > How about we extract the code that returns the min order so that we don't repeat. > Something like this: Of all solutions I like this the most, Zi, do you have any preference? Luis