From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A6917CA0EFD for ; Fri, 30 Aug 2024 17:10:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3DE036B01A2; Fri, 30 Aug 2024 13:10:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 38E1A6B01A3; Fri, 30 Aug 2024 13:10:08 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 208196B01A4; Fri, 30 Aug 2024 13:10:08 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E796C6B01A2 for ; Fri, 30 Aug 2024 13:10:07 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 7E91C120472 for ; Fri, 30 Aug 2024 17:09:37 +0000 (UTC) X-FDA: 82509548436.14.BA01D6B Received: from mail-pf1-f202.google.com (mail-pf1-f202.google.com [209.85.210.202]) by imf17.hostedemail.com (Postfix) with ESMTP id 60E0340017 for ; Fri, 30 Aug 2024 17:09:34 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pixEv0qh; spf=pass (imf17.hostedemail.com: domain of 3zPzRZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3zPzRZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725037685; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U/DqUd03uLisJ+lBV6coVazHA/8Mv1E9hChZqzhDQx4=; b=NWGQ/QLvo30+SCTaPa9DKjWaBLgIOy9gR6SvlvCfiHrLeIL9KmUXXVcgeM/xyf6EpJVJjE KR/zG+6PvMNEPQv687hdQkQ9ptA1uKNcukadc4gYLpc7J5FzYbgk3/HhLvRsH43OSZerd3 0bQJE2ylK8J9rPJv7LaXpX6y2xNqrVU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725037685; a=rsa-sha256; cv=none; b=ax3n6/MaY5lh+W4c33HxT/cbTbasIw/Oum76/eGUQXJXFDiun0KWyBuMHkmfXt6MhzChPO W6/U6ZtJsAJEoVWYSd/2kHLo8EKDfFL4jlq5Xk0aBEwZvkx4HB1HzbSC3HHSKxBYWA86q2 M758KzbIrRV5uS6hYwUT6PACcdUYD7c= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=google.com header.s=20230601 header.b=pixEv0qh; spf=pass (imf17.hostedemail.com: domain of 3zPzRZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com designates 209.85.210.202 as permitted sender) smtp.mailfrom=3zPzRZgYKCEs5rn0wpt11tyr.p1zyv07A-zzx8npx.14t@flex--seanjc.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com Received: by mail-pf1-f202.google.com with SMTP id d2e1a72fcca58-7144c67e3d0so2017370b3a.0 for ; Fri, 30 Aug 2024 10:09:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1725037773; x=1725642573; darn=kvack.org; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=U/DqUd03uLisJ+lBV6coVazHA/8Mv1E9hChZqzhDQx4=; b=pixEv0qhK6m/D9QwIPSVoUh8lIyfTvK/C9fs9nb20gJAwfdKZXW98XvCMLOleTvytQ TqbaOZ6Hr6XrjppE6FF2eMIbD0SqMZ7cDqYLwKAKAIsAs7hS/5iYrzdPZ6aAPL5JGY2t HSoLIrcp/ZXRpzScE8T1u1Zo9g+V/sQLznUqaEstWaIR+M4t6C1v4Zq7Wy8LmKRJmQ0O PBfawxd0R/Z0I7NrH7jXq7xV59rCfBvrHhuIG+Tm4vXQVjFBeIOj1P5CWaN5W1dvWnHm R5w71ucpZURXTS3ncQ6LKb2e9UgDiRYRCzlTMK1laY2LTCXMupyukEFJpGA/pN6S7MpS IS8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725037773; x=1725642573; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=U/DqUd03uLisJ+lBV6coVazHA/8Mv1E9hChZqzhDQx4=; b=cLtRHsS6vC52+z5rq49uaJsgBQAjGsAPqXxlk8Xl4u5UWLIbNgU5NcTaPYTVG/2XRa Nx20jwsCxdEq8og1fSyPwCkdXb8ETu9a2llT6UsDORfwiwZvu51X5NfAIt374d/jDwmo SWSQiq73+99rBfze5RJPxhO76fi6h8UnsPbysS+q2odwEWJ0wcrOzOcuL8eUYnhWGHkv T3/iEp5P3525Tp/Qgedxrz8oG+Tjr6S6dSuxYKKXMQDz9vfASsR7DbeqfdgEdK9sVoXe xOjqIfPty590DA2QsQtHp5OmOaAYZhZm/eOIKMsV3EDM5+zIMrDq1WxLcMX9a1XfEjjz UTtQ== X-Forwarded-Encrypted: i=1; AJvYcCV0JSL8L6tPeu8BS0gv8LH/k9kquZrb9tlxtos3bEA4UqpioZ/A24ZrtWDDc5FNxVMvgV1cQyLv8A==@kvack.org X-Gm-Message-State: AOJu0YzrQtjJtJ7zTxBrLusvrqPFSKvwiy+Ir/0JZ2L6AGj91znlMW/Q R0N5nklc8zTcEjgUDyvQMnDGpk508joF7kvMWSylwVOHNw60gX0FxYXxczQVL3s07xtVxUti8ST Sjw== X-Google-Smtp-Source: AGHT+IFFKP/thrpWlcd7MMBTCnnTgAMVFprrx6gPBFzwzuc79yk0sgtRNBZcK7vPcXyz945EdY+xAc0UhR8= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6a00:9467:b0:714:24bf:eaf5 with SMTP id d2e1a72fcca58-717307852dcmr5463b3a.5.1725037772263; Fri, 30 Aug 2024 10:09:32 -0700 (PDT) Date: Fri, 30 Aug 2024 10:09:30 -0700 In-Reply-To: <20240830124720.GX3468552@ziepe.ca> Mime-Version: 1.0 References: <20240724011037.3671523-1-jthoughton@google.com> <20240724011037.3671523-3-jthoughton@google.com> <20240830124720.GX3468552@ziepe.ca> Message-ID: Subject: Re: [PATCH v6 02/11] KVM: x86: Relax locking for kvm_test_age_gfn and kvm_age_gfn From: Sean Christopherson To: Jason Gunthorpe Cc: James Houghton , Andrew Morton , Paolo Bonzini , Ankit Agrawal , Axel Rasmussen , Catalin Marinas , David Matlack , David Rientjes , James Morse , Jonathan Corbet , Marc Zyngier , Oliver Upton , Raghavendra Rao Ananta , Ryan Roberts , Shaoqin Huang , Suzuki K Poulose , Wei Xu , Will Deacon , Yu Zhao , Zenghui Yu , kvmarm@lists.linux.dev, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 60E0340017 X-Stat-Signature: ftmgstrasknzzmcy447e9e7fncmu7c11 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725037774-895723 X-HE-Meta: U2FsdGVkX19yKafs3oSdoUdUQ4/bFo0p1aw+yTc1TeVl1zdetOLFuP07zb+LSyNZRStLI8avPyLgvK4bvkL4u+fgLObAYwsucOAK/5TpQVVglcnzc/IaCBOX3DLt/wGAnqo53nlcgSaDFVmJPWFqhfDsTgtojKvArNSmhi9MALby1BnqAdwLBAJBiqE7teWHNheEAu54kqbrkUa5mjBVaZmGYhMJc2wN9hkWAXVuPL4TuvDHr2ZB95xuNyM3Xz7jzMoUcGCzqU3i3A+M+vi8itlg22QptRYLEwcQSFSIFk+o86+KDIsXAJv4TNoQkFWkrTmz8Ia+T3wPesO4sHPDhYKrXM8NLaELCD+CG2l4AJ8bCR/uHVB+8zlXQclEtw3+lSlYYe+QLVtaTUcgPe7bMZhwyHYXbVZz9GwUa8xjHFAPxG4EzKqxgST09Fq57G6inIv+WMhtgJ7PvjY+9UGNcgGxb3FzbIYUQVq9Sltf+1r0vrasl+bqQmS8WzE1cxF6L/HixeFEFRy6fyhk2s0N5sBlcBVuESvjfiMuQ6KiRwUWYui6zpkdgHiDa7SYHlUWfzyeth9TQLfJ7yTlwMlifw38R6Ozi6Y11HSEfoQ77P8uEf9unPFOrF55qfpLTyOJKRpom13MV4NsApkCRREfZY3YESuZm8N1ogQ1AGWBUFDSSu57YiSSBr3SyBCBkttacZVtKgv13tqUVAsIcKYxOSQZUcBxvWGvq/E/OCwg8STYh9iZdCoJrpaa6gKbhB6Nj3UnjVoGxahRiLeRihlvtr5QKGU1yJdfH/RBHkw8uFMl/aHReWtbQLr7YUMevp+eO8qH+g0CuTj5QNsXSnsm87B5AVza6RGy2Y9WNQcDqem8Krk99L6k5ybpmjeE4+gpFvxvLQEdk1QpN6I4pC2CaQA6Whv0nnEA2uP9UVlTUHLtcWFFk+AMdHF0jzRiQFpgnfLK0FTBb2X47A7SKS7 TkpzD5r3 uK2teOB1amatc0MMv94Clf+JrRWsH/fEJ6b3FJMFZNpbU6samskeZlIbbSzLI004ICqbZDaX3COcse8h7+jWmzOaXZgVzdNWV/0Ra6VJcxSjLzwuh2R/TKCHPxXOFmhW/tyV/KpfGAmjsQwE59mG9yeZxNI/ioT5PswTCDx6MrJVEIOcl3q8ao0QOTx1wG1wSQVlJgkvwLFKadHS9ZK+w/5tzvScacLXXgnxEP9GutNsgCJllnF/h2gHa34WHW7w2ySJpWSqdYX5ShJo7pX4eeIK+fvNXwuu1ruxonZLG+b7XaiaRJk45f8fyIRyJlEx5ZVt9UH7xOnkvJLkSpFLexVHI+HZYZ/FvfPX+oWCMnCpbumy68B+yKixbPaVsE4Ytui/j4FccZ+moDNS/3jhVMS2H7yWqo47k10NpB6rhcJrO+BCrhpVBZ6LRBwM7Um5r5E4iTectt6ySIlKXcr97XOUVevEvLjEQFygYb5eFb4365lspRo80rBraPtmWSbtbckbco2muOCr3Tj6Auo3RYRzqDWpbqNdk1TV4qU6h0YGfTlZQuoOOK1c/ZBm9GOcJuw8UEyDj/0hLYbxFX+MWx7Q5OaUzGKI9fb7aqJg3Mt2JxJPXNgKzDGWYig== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Aug 30, 2024, Jason Gunthorpe wrote: > On Thu, Aug 29, 2024 at 08:47:59PM -0700, Sean Christopherson wrote: > > On Thu, Aug 29, 2024, James Houghton wrote: > > > On Fri, Aug 16, 2024 at 6:05=E2=80=AFPM Sean Christopherson wrote: > > > > > +static __always_inline bool kvm_tdp_mmu_handle_gfn_lockless( > > > > > + struct kvm *kvm, > > > > > + struct kvm_gfn_range *range, > > > > > + tdp_handler_t handler) > > > > > > > > Please burn all the Google3 from your brain, and code ;-) > > >=20 > > > I indented this way to avoid going past the 80 character limit. I've > > > adjusted it to be more like the other functions in this file. > > >=20 > > > Perhaps I should put `static __always_inline bool` on its own line? > >=20 > > Noooo. Do not wrap before the function name. Linus has a nice explanat= ion/rant > > on this[1]. >=20 > IMHO, run clang-format on your stuff and just be happy with 99% of > what it spits out. Saves *so much time* and usually arguing.. Heh, nope, not bending on this one. The time I spend far hunting for imple= mentations because of wraps before the function name far exceeds the time it takes me = to push back on these warts in review.