From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90949CA0ECD for ; Fri, 30 Aug 2024 01:16:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15BCE6B0089; Thu, 29 Aug 2024 21:16:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1324C6B008A; Thu, 29 Aug 2024 21:16:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EEDCE6B008C; Thu, 29 Aug 2024 21:16:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D07E16B0089 for ; Thu, 29 Aug 2024 21:16:50 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7DAF8A0BD9 for ; Fri, 30 Aug 2024 01:16:50 +0000 (UTC) X-FDA: 82507147380.03.99925F6 Received: from mail-oo1-f49.google.com (mail-oo1-f49.google.com [209.85.161.49]) by imf28.hostedemail.com (Postfix) with ESMTP id AF0A3C0005 for ; Fri, 30 Aug 2024 01:16:48 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=k8glIKYh; dmarc=none; spf=pass (imf28.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=charlie@rivosinc.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724980508; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Y7xDP+Z9ioGU1Ej/VigLqskETGN0WUiHvrKI/4LF5a8=; b=oNufIjC0lJf4DOXvhyQnCNOIiDTWCwUa5gQUp1ifQ5kHnL0wuTYqrQhjWZVSe68OrC71Ll lLDe7uN5fGYMPmdOKqkWvNtahRtxBhPNeQNgCq77B/dIaFctLZ0TQzYzue2xlGXBbgv9jl c+3wfuYq484Mf5TapycHp3cnbTT2oCE= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724980508; a=rsa-sha256; cv=none; b=t+/6n47AfuXzZFI2ia9ors+5Npt1Nf48367h6w+VplqC1czwXQsD6GSaglUg6/ip0Qt9tZ clKYIzIpYODoA9sOoMPCyrZTbYREUImq7b+CPPE1lCPeKmBcsH/H6E+SuDX0Op+pEpMM6W yiq0sN1JI820UcfNbN6j4E3aJ6+BkVo= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=k8glIKYh; dmarc=none; spf=pass (imf28.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.161.49 as permitted sender) smtp.mailfrom=charlie@rivosinc.com Received: by mail-oo1-f49.google.com with SMTP id 006d021491bc7-5dc93fa5639so783348eaf.1 for ; Thu, 29 Aug 2024 18:16:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1724980607; x=1725585407; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Y7xDP+Z9ioGU1Ej/VigLqskETGN0WUiHvrKI/4LF5a8=; b=k8glIKYhZtwfVSWRVlE1GhNjjcItIgCOrthJlU4LNPivtXYq5BsxdM/t9FIkXkrz4t LXmMPHXXiQCRLpH8TwMOwYxikvPToJ/x13fGWI1P96Nansb3EZsqvW23/3bOV4U/VjGZ M0ophdKHxZxPbbzCdCSABR3F1E5+apo7YBzyi0ECm6zVOaJDopsw0fBUlFjbe3MHxGYy AETSRV/WkFyhL4YGvdydcAGvoSGIUtllmKO0r/c4fz5D1LQTXdTLwV1FXwz6YE2y/x78 EMGzQaGfI3wbhAqVrkOrVHEC9m59Tl3NueHBi87ALXXygYqy7jlmkoYul/wIduFGYZuY zr3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724980608; x=1725585408; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Y7xDP+Z9ioGU1Ej/VigLqskETGN0WUiHvrKI/4LF5a8=; b=YOh9Qmj+tfVev1BLNW7M2nh6Eob6CHzisSTqv/gRml0Y0MVI17VdAAYgk37jwF8/A9 poJeu7O48G/Jo6dEM0t9IxgB9a/0r2N1Odw6HtgZyFDggy20BK1M8t6oHpDe2OcDUYAq qBnhYaF2ucTSeVMGVytfdExQw4YfiOZpsZtH502+5GiAVRcZnhdotaENojKh1vI5MGwy 96VtKbOOpF26bn7kqg8siCc5N359W5VpRyiIadg02IAt2myOJGz66QH75c+zw+spHq8k MZzDRFKVtV2gO4ZcERpDf2Ai+xMrbNzWch02AZhuWpZlGGrvof7Lhwm3Agl33FQfe95D rWkA== X-Forwarded-Encrypted: i=1; AJvYcCUSB41JrrBJkgqHWgcNwZU0zsVGgl+2If4Il95QJ/U2pdT93LYsP9YXNcgB87A1QGPpChTO/5zotw==@kvack.org X-Gm-Message-State: AOJu0Yz1Uoq3XcJ4qIjtXZRZFHHiatAPUaofX0dtp5t+0JcW13REI0Qz OrLZILn5W7tDj6YD69LyRbuIDFKQZqDxh5zZWoi+SeT6HV6hRQpeODTbWAM8Xlc= X-Google-Smtp-Source: AGHT+IH958S4ePdwDnUiHubyspadJoOLZkUZCeioopGjkAA0KkZUXlfkSz3mG+kkmopghBfnyH6A6g== X-Received: by 2002:a05:6358:2803:b0:1ac:f109:e248 with SMTP id e5c5f4694b2df-1b603c00435mr551866655d.2.1724980607523; Thu, 29 Aug 2024 18:16:47 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-715e55a5961sm1734132b3a.63.2024.08.29.18.16.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 18:16:46 -0700 (PDT) Date: Thu, 29 Aug 2024 18:16:42 -0700 From: Charlie Jenkins To: Michael Ellerman Cc: Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Lorenzo Stoakes , Shuah Khan , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC v2 1/4] mm: Add MAP_BELOW_HINT Message-ID: References: <20240829-patches-below_hint_mmap-v2-0-638a28d9eae0@rivosinc.com> <20240829-patches-below_hint_mmap-v2-1-638a28d9eae0@rivosinc.com> <87mskvenum.fsf@mail.lhotse> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87mskvenum.fsf@mail.lhotse> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: AF0A3C0005 X-Stat-Signature: 4sw398wfxnw4dwrof637m1pscpdgp1iz X-Rspam-User: X-HE-Tag: 1724980608-656769 X-HE-Meta: U2FsdGVkX1+Q7aH6ztsDRT/qaueLgdeWAUzQLH2QQ2otX50UXMyyYmjGwyN+PlIVMtXQnAtMy1MPdjFVRnd93WyGH43MuDO29o8CKE6g/o8kf2371l+aCDoL23oG7fRj6Zfg5GcK5RozS8tuAkr2pfQMfUTs4OVBIlRDikiErXrXtnxwTUh7gEgYFpKOwq9Sb1odigPC+ujoHdKM+Gc4MdpUwk2hmFc754XtcGwfNf9GcEaEXamNl3UF9DWaBBlQqHAyL35ivpi47r2vFw6aYmi2B3TDgAyuXlM0v6Yq8mXDzQtmNdEwzU5EoEx2fA6rIymV5OdTyQvnvce0ietDrCN/3ZmjeUKzUM8RVICmWGbcYJ2vdLm2Eyl+g5S8d2Z06HzQ6O/frI4W1r9wBNmurha+R0ZxL7ofT+P6LBfYZVc2YNvpzyJrhosggaE8w7E5LSbkzXB3+luFUtSngNx0JVgitqj9QX7lvfUGYzKHJmTG1+DBVIKW8bPAWR3fooWai4oFbGmJxRCV6c3+OlzBlpnFIwr9PZ76mER9w9R4iM3W0XPgGbQFIrXVC3bOi0oTHDCy6ge8c/8/ffvTyoxFqxIkhHl+eLAQpl6/vcslA15pLQFfto/T6fAhsQNDUJ722vF5v3M/iuR8G0UVBuVwWmoijDehyMjKhf8Jt7ROBirdeh/8gQr+cBU0YwPTfyZaXvMCS28v0ZbpolFH0ZIMBBfncCzlLtHjFRXhCdDugCiG7xgjsY7jm3spQNtZB75TN0cVgM5astMEfLbtjbGMBAENeebGh/ZiYcawS2dL/mO5q6ESIhKdhVSkBPnWIro+l/nue5XAjJYzvwUXBYrEMJweyVmetBDfF8a4K8bZj7etSAPpZBm7Umhb3h8eiFf0PW8+0QuLBqwoifl8/tdpp/FKMncYEazAp0P7vHNm/3w1TtfjMpqmE60KCpvncBSJdThxVd+pXYoEteBeEyN Hh8nJsaQ l9y1cpGk7N6UFGMSfWInh5ZffjdCSk3x+aK5OgcFRLJ8/uI580WKMLAfX5oIvZ11cegUGd2zw0aTpj6R3QYE+xgJRA47aZHcmcQEUjnW+a3z6bVawd09dPI+RebL8rL8pGdRHF2e4ld5weTqCaLVuxkfbVnu2jNhJjj3YoD+ebszGdTDv8bILrXNF+nNHNTgEls2le8ZpMMRMKXLQjUirDlNWXN/bzwWEAkZXqPVA+t1upjOLoKvknE8YZ1uQvboxhaBt6k+BEzFiNsOI+yVlJ4d56VOG4A0I8WniH2sO5wwmUOr7d4wbGN3eBWGAif5LgJiFZSYsJApJC89ii9DNJs/NNGQTNExoP+KZ8hgvjQjVsFBnFQyG75jArM+raYpN/CYvy0ypH95t2rHgojkHHLeob8VRRbWbBGggwkT28EVevfRPDpigTKzlXR0ncMj91vaKIFTsg8ujaBzjJErPmw6SDg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 06:26:41PM +1000, Michael Ellerman wrote: > Charlie Jenkins writes: > > Some applications rely on placing data in free bits addresses allocated > > by mmap. Various architectures (eg. x86, arm64, powerpc) restrict the > > address returned by mmap to be less than the 48-bit address space, > > unless the hint address uses more than 47 bits (the 48th bit is reserved > > for the kernel address space). > > > > To make this behavior explicit and more versatile across all > > architectures, define a mmap flag that allows users to define an > > arbitrary upper limit on addresses returned by mmap. > > > > Signed-off-by: Charlie Jenkins > > --- > > include/uapi/asm-generic/mman-common.h | 1 + > > tools/include/uapi/asm-generic/mman-common.h | 1 + > > You're not meant to update the headers in tools/ directly. There's a > mail somewhere from acme somewhere describing the proper process, but > the tldr is leave it up to him. Oh okay, thank you. > > > diff --git a/include/uapi/asm-generic/mman-common.h b/include/uapi/asm-generic/mman-common.h > > index 6ce1f1ceb432..03ac13d9aa37 100644 > > --- a/include/uapi/asm-generic/mman-common.h > > +++ b/include/uapi/asm-generic/mman-common.h > > @@ -32,6 +32,7 @@ > > > > #define MAP_UNINITIALIZED 0x4000000 /* For anonymous mmap, memory could be > > * uninitialized */ > > +#define MAP_BELOW_HINT 0x8000000 /* give out address that is below (inclusive) hint address */ > > IMHO the API would be clearer if this actually forced the address to be > below the hint. That's what the flag name implies after all. > > It would also mean the application doesn't need to take into account the > length of the mapping when passing the hint. > > cheers That's a good point. The reason I did it this way was to allow mmap the possibility of returning the same address as the hint. If it must be strictly less than the hint then the hint address can never be returned. Maybe that doesn't matter though. - Charlie