From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E1FCA0ECE for ; Fri, 30 Aug 2024 01:11:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C79616B0085; Thu, 29 Aug 2024 21:11:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C039B6B0088; Thu, 29 Aug 2024 21:11:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7DC06B0089; Thu, 29 Aug 2024 21:11:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 820956B0085 for ; Thu, 29 Aug 2024 21:11:25 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id EFCD3C0A3D for ; Fri, 30 Aug 2024 01:11:24 +0000 (UTC) X-FDA: 82507133688.08.06A7526 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) by imf19.hostedemail.com (Postfix) with ESMTP id 165701A000B for ; Fri, 30 Aug 2024 01:11:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=MGJtAP1f; spf=pass (imf19.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724980237; a=rsa-sha256; cv=none; b=t5UfYFQJiZxlT6J/8daip3Y30KphtQ9+V6MEd9c/23qf4DwKDOaVG0YJoE+OTyNNDIyyqv Qvt8ljzBBmQ0AcemUixr0IdzX7+jltz1cwQwje+dcSwEVB0TqSz4vGDDiGAqUXwiRuTas5 1kQS/Ap/EAXx2BcVVlc0KA2SWfuGSbs= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=rivosinc-com.20230601.gappssmtp.com header.s=20230601 header.b=MGJtAP1f; spf=pass (imf19.hostedemail.com: domain of charlie@rivosinc.com designates 209.85.210.172 as permitted sender) smtp.mailfrom=charlie@rivosinc.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724980237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Tq7LnGnCY31W8p33KfA4sDocR34ueQ+QZ1h3PRF4p6w=; b=PGuPfcSulTYl6jXQrzYHBfvO62lvRTxxbL1XoBCCKr0mLsaHuuGHoLr+qNBYQ4tB/i4c+d ziyGKRIVDnT8E0jB3qL83iQsI7hjtHuldMiDyEyWIXxYPW5se39cc1AbrJ8yU99BXxHIJv AfDTfbWxOJt8Z8AVaqc/YcOHIBHDH/M= Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-7143ae1b48fso840556b3a.1 for ; Thu, 29 Aug 2024 18:11:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1724980282; x=1725585082; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Tq7LnGnCY31W8p33KfA4sDocR34ueQ+QZ1h3PRF4p6w=; b=MGJtAP1ficC9e+PZIzrb4fx+6+G8I2spWmYxJjcQZapv3acdnDc/1WNF/lyeHXLIhO rcxAtXSR2a4bHGNBmtjqDLRJFIkiba6et913huylZdCTMJi6nhNQRh57SwMWPAIaTq78 KQoybDpAVEaDLsohFe2sW3MNO6nCQmIoPgfMH0oY6pSEk4T5O7tg9BAb4MtoFGYlM+rh 4a6X4T8dLGftchnb5x5Ri1lHRb9xND1aAZnQMAbLnsqkaPqXcAGytpP0du5vMgP+9Zyr pG+ElCmgHKx4gig2v/ZSxgo3lsKnuwGZLIEFa/yk0A4JQLm8kU7DY4Yz5do3T7stwCp0 yq0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724980282; x=1725585082; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Tq7LnGnCY31W8p33KfA4sDocR34ueQ+QZ1h3PRF4p6w=; b=AvAQjajswQHjfXctGV3R2nCAsCQyM75pC6j+QbDp2kplxJ17FHv7bHRJDWeZY4m80a xXmUnp4+0LSSI4O3vbwLfqPfm1LzOcRXJUVC7X1yNy11d0qVmkGHd2Bgybp8emNOvEkX DwsBBDRnYWgHzlLa4zUdV49lQ/I7eRI+B+Am92hSpHt2WlyAIGsso/SKwz/RxAp/rnCP OAYHvE9yPZlLuZPxKlByp6yVObiCD+JI33P2zIP6glrSTl3wlmU9hWYaC7HhTe5ntmn7 Jf8fkyzOLGL5CQ2Dl8/V5gAq8xFHZ10UYD/p88g8U2w3b3dyW3iJpcRc9YUX2j3Sq9XK 7LcQ== X-Forwarded-Encrypted: i=1; AJvYcCVFF5VlDk8oVRgd6izlnf+1XaF7Av/vmOg55bzm+qFh8gK+xBBfS/g5wSnj0z9vRoZXb5bLtl7arg==@kvack.org X-Gm-Message-State: AOJu0YyjoRvLCO9wlwSRh8adDnQ2htf6WWDyWkd7jaqEkw2ayTp5ycRz TgOkujqgKPg0wqieA3tHmOqdJwPEvu+tDfWWbA5Fop8a/n+Mxdi32kyl73ifgXU= X-Google-Smtp-Source: AGHT+IE/hxSbHJa0ey/qUAU4qMZr2Egy89hZiorh32Md7TMXE2itSwqfJ21BnW0A2NKOMSU/XYMAJQ== X-Received: by 2002:a05:6a20:c78e:b0:1c0:e49a:6900 with SMTP id adf61e73a8af0-1cce0fea52bmr4390650637.7.1724980281696; Thu, 29 Aug 2024 18:11:21 -0700 (PDT) Received: from ghost ([50.145.13.30]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2d8445e8f72sm4900654a91.20.2024.08.29.18.11.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 18:11:21 -0700 (PDT) Date: Thu, 29 Aug 2024 18:11:17 -0700 From: Charlie Jenkins To: Lorenzo Stoakes Cc: Arnd Bergmann , Richard Henderson , Ivan Kokshaysky , Matt Turner , Vineet Gupta , Russell King , Guo Ren , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , "James E.J. Bottomley" , Helge Deller , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Alexander Gordeev , Gerald Schaefer , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Sven Schnelle , Yoshinori Sato , Rich Felker , John Paul Adrian Glaubitz , "David S. Miller" , Andreas Larsson , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Andy Lutomirski , Peter Zijlstra , Muchun Song , Andrew Morton , "Liam R. Howlett" , Vlastimil Babka , Shuah Khan , linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, linux-alpha@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, sparclinux@vger.kernel.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH RFC v2 2/4] mm: Add hint and mmap_flags to struct vm_unmapped_area_info Message-ID: References: <20240829-patches-below_hint_mmap-v2-0-638a28d9eae0@rivosinc.com> <20240829-patches-below_hint_mmap-v2-2-638a28d9eae0@rivosinc.com> <0454187e-3e01-4af7-b193-07468ffa8934@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0454187e-3e01-4af7-b193-07468ffa8934@lucifer.local> X-Stat-Signature: d6n6osnzxhstmbe57dp56tdjftfnt8pe X-Rspamd-Queue-Id: 165701A000B X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724980282-434934 X-HE-Meta: U2FsdGVkX1/ncDQV+OmLKYPrAM0pY9WI70vbk4SMuBFVSboCJnIQ0XdKaNdWaQlmcYvP52Lp2fEpKm5/o07sAAmOwwVqa8kIR9OSFJWIxN36nC9Zo6qo4/xG94ke+nOicygk7EXYikU+hxXt5+/GJfJKuxV44klgjPzUv1hZ0tZYh5YYjMY7VViVqx3qx5LfUHmPPSQNYh9Cb0LQIl/j7v85LyO7VARwJbD2IX9sO9pVKsbQ06o55rjiNdwWNZlTqsWcGkim4ARmZ460+g6z3256aaehrjKmteCpy/ZuGxdmwPWR1yS3/FPCk6XIcFm8V9d0tYr8HTUbVfL+/at7cs9v2cEt15i7L899j85J1dJddEuDmhp6OjV6cSHoX7/bBFTipNdup2kA2aa3edNgFVoztmtab2yoITCkHxT/6djQv1bhzW37JJEuSVf6TWnANJEp3rWoOjfPTQt9fKF8WucY1+CczoOgW11AuJX+jDqIawtr5A9UHvM6b3ZE7GbBmCSQY+cMLQhHrkEZPAu4AN9V4Sq8wvVAN+5Jfwx94MtK5OptEjpaOpmerA81aNR2I5TvgB34WJXZRpQhiQQwwejOwlvgHUuS4nZ92WCU115Gizftk/hu6poynaZdQvSmP23pIWCgwm6aUGBu0Vvy3dsE5UOlTW7Qj0NKZ9JJzjglY9qzQ7BbhY0A94fKvCF8RZpuqBv/ZeDzQV8N9+SQmEiofaeihndbSKP3M99W6Kd0dlNC03bHPkr8hYb6RhH3fsK2hN5bXcgFZA3xVDxCWlf6nBHlP+BuOrf2CExymMtBfsV7OauL1CKdp8YE3aemjIKXMgko+PdidvtiZCz20RYzVIx2DJ1jNG0Ed0SfCc/G3cwHBxpH2jlS+P9CK5jHA0CFo5joqnOqAiwfnCL0iZtw5L1xjeHgl/SRPg0Tvb5AwUC1HIrCBH9HDfNFEvZspA1tj/wzCHlPL6+7Trj 9hmdf0KL VFvg90avhOWUqlKJpBxcVDeeo9fQzscWJoGwtlgi96FKmJXrJSyzxHc/aHJqYRtfl2PHAOwj4QrybCnp/htA1Ml7+MtCjxSiRwecVCcCmxW7xljzROg/71APl3V4e/rphdlrsv5lfvwJFwv+4M1eYf4ZSuI2RGvzQXlqNcDo8OO6cz1199qNRvpEDZCOX1+6Q2c+4fOdahPF/q1RdoJMhtsc8AUs0RvTj66ZLjAC9obZyDYIVoZlPSKV82OFFLldJRcpLHpqSpEhat8yATIkKafsjVNRgJrN9VLDVDcfHVpuPmdfxbJK70GbfmleCobcviGzDXQoAqXf/R3SeBQMyK28bSe5aA7HxcflgDsnzVPyASprfNpYUhBDr+U/hFGZTSuO5 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 09:48:44AM +0100, Lorenzo Stoakes wrote: > On Thu, Aug 29, 2024 at 12:15:59AM GMT, Charlie Jenkins wrote: > > [snip] > > > diff --git a/mm/mmap.c b/mm/mmap.c > > index d0dfc85b209b..34ba0db23678 100644 > > --- a/mm/mmap.c > > +++ b/mm/mmap.c > > @@ -1796,6 +1796,9 @@ generic_get_unmapped_area(struct file *filp, unsigned long addr, > > struct vm_unmapped_area_info info = {}; > > const unsigned long mmap_end = arch_get_mmap_end(addr, len, flags); > > > > + info.hint = addr; > > + info.mmap_flags = flags; > > + > > if (len > mmap_end - mmap_min_addr) > > return -ENOMEM; > > > > @@ -1841,6 +1844,9 @@ generic_get_unmapped_area_topdown(struct file *filp, unsigned long addr, > > struct vm_unmapped_area_info info = {}; > > const unsigned long mmap_end = arch_get_mmap_end(addr, len, flags); > > > > + info.hint = addr; > > + info.mmap_flags = flags; > > + > > /* requested length too big for entire address space */ > > if (len > mmap_end - mmap_min_addr) > > return -ENOMEM; > > > > These line numbers suggest you're working against Linus's tree, mm/mmap.c > has changed a lot recently, so to avoid conflicts please base your changes > on mm-unstable in Andrew's tree (if looking to go through that) or at least > -next. I will make sure that I base off of mm-unstable for future revisions. - Charlie > > > -- > > 2.45.0 > >