From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12103CA0EC4 for ; Thu, 29 Aug 2024 21:56:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9F2296B0085; Thu, 29 Aug 2024 17:56:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9A28D6B0088; Thu, 29 Aug 2024 17:56:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8916F6B0089; Thu, 29 Aug 2024 17:56:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6EA396B0085 for ; Thu, 29 Aug 2024 17:56:26 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 1C31D1609A1 for ; Thu, 29 Aug 2024 21:56:26 +0000 (UTC) X-FDA: 82506642372.05.3B5B0CE Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 8A5CC80005 for ; Thu, 29 Aug 2024 21:56:24 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EtXHr0bT; spf=pass (imf30.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724968495; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Hxr5yfV9upY+pUKSJ9nFJfsRCBHXA9tb+GVJ3z6Zywc=; b=LjAcCU+EcyarqJhIH5LLNgW5jfBfZ6sB1xnX7DJrvtU3tKz8DGpp0slVduPPdy0pllVjTW 5+qRAmDuz18Ihl2klntvl1jqit9CTEUNi7TLhgahzGmdStGXxbvtUKRlkMI+ReEhCWJZod 8NRqPu9D0yPyBDOPaNfsQl2+jWm85KU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724968495; a=rsa-sha256; cv=none; b=u+benA46r/JRBlIKic+QB2mNKbzAxYiMFPVU0YEFuJsei0Rovuzj36qsversydkJaxruj/ sn++UoiiJnFhO4Xr9waFokoGU6pB7JXbkR+LaHzrNuOGpkOxNvZTMFCB28CEhBzoK9xo3A EfxHN1DOw7DE/RxYuV1IRIx22l+TL9A= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=EtXHr0bT; spf=pass (imf30.hostedemail.com: domain of dakr@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=dakr@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 949DDA43BFB; Thu, 29 Aug 2024 21:56:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8240DC4CEC1; Thu, 29 Aug 2024 21:56:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1724968583; bh=FObmfTahpuIOJ8yu7UnULI90tps2h+H4ynBgK+BEgGo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=EtXHr0bTCh95yK3obYsgx8Xt2tMrDFnCUBRIWrTCdcsJm6sUc7mJLQ6cpT1o9mbaM cSv6fmbir18IyPdwz4WvLJ20whNlXR8WkFwFLwxF/E1rWWPUbHjukgD82n7eIJBAJ5 /3Xgww+aPE9lk8E704/mpZSFkMNCqjtsqXcuLoX0LD32/w2lvdrOZAfcBiHCuVnKyP WxwP8gu7IvOFg7ReSbuBHl1oLt3SLskfV4VppltJwurlcvX2yVxdE6UvifI4zmTk7e jm4sQCCfi77ofb61l1TKAX6i4YubPQ4N3u4yS0AnpABlpAIvAApkk+2JqkbftXFYk0 ECJKBIVJg0Okg== Date: Thu, 29 Aug 2024 23:56:15 +0200 From: Danilo Krummrich To: Benno Lossin Cc: ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, a.hindborg@samsung.com, aliceryhl@google.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, lina@asahilina.net, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v6 01/26] rust: alloc: add `Allocator` trait Message-ID: References: <20240816001216.26575-1-dakr@kernel.org> <20240816001216.26575-2-dakr@kernel.org> <60253988-37e7-4acb-b2ae-748b30a4ac21@proton.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <60253988-37e7-4acb-b2ae-748b30a4ac21@proton.me> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 8A5CC80005 X-Stat-Signature: 6woq6zp3oz1edgjkzmccw66s8byopq9q X-HE-Tag: 1724968584-334068 X-HE-Meta: U2FsdGVkX18Fxkn6JO1ro2lnDiFeYHJDTk7UtVlFkXVohfWTR2JSTM+BH0DZCjFry1LKhyX6UYsen2gc2ZVrruq2aV9UuFQAW9bF5WZj2LgcUSSzVdeDEDqZRW4W5hsiRgy6MwTMsuklgG4ezlZD6PAG4GgNmo1lID3Ot2LD5kqRnbfjCQEG+U1cFiJsLrWN9I1fqZ9T7gnXGkn7SkacQMSm3RiH8NvKl3aqgIMHmsi5C6DzYY2zL1+wHevImBkFexBC+eG3izfJOOc3YxS1+YI0jBP1f3wOTmXDegmdDDdFJzkvNG1X8fyHaC6UEbA9NbW0EPKRoUi04FUOhIcRAkjdQ170C6LZyQp6t0L9A9H4f9cZhxYDlFwq9OxOc7ObhMQgHYALYXvkTNkiV8qbr08M8HxUAOo2dl75LU7dDt6+KicU11k7NKuHlMQf6v8ra61tQ3diVVXh3ZHl2I+5Y2rI0sNTO47Xfhui8YXIMf3YZgFYh58iA1XwoW5eIA01TxXxsVYoJ+tIVssQbFIwg+BDtTuyMyS+opfQzKy2SE7NGMJMVcb3mWIUCXObD+pBG0TauAiuymuPYrBOO/rG1P52i648J3LZNvkdLS9T1UIVuYopuGyIUjSSVAVD/qRC9u0/ZgSJbls+q9tc6roQ6gRbjGGenoH5zwpAKKviIvKvX5Doc2XJiNpAvQqH9FEufJyTBPbShV38eofEt4qaDkWc9RTdquKOwkFINraRavM+Swzvej/+9yA14J9dH89/Tvvwq5ri8uPJJhmU3SQM8iphdBXD8M4nLvNnnj+89gIJEVK3awua3eYMEZJtlNXUNXCbf0dzvscKSZhSow9fz5IaOpdp+v9bhj9kGA5Wd+xiJQ3KScw3FQqjEGpdApjV+xVD4aFhJBUMLsbLyta6OBWDisp6TEPpKYasB1kLhh+UBVXIkkWeaftqBBS9Kz9K8jZPsuDuAFnNNQ/qPux Cb5Pqdjs USb4EpMEJCd6MZ7KRXK03iMKg8CyBGgNmWRcpxibPLC4FeqNtBYh1Qi0GkLCozW8P5kwj7t+jI0JDcGFHSxWv40cVRD9E/YQmRuyS8UsZ0vGpFcAgfa0DajEDCsW5IURHaxva+kc2cI0EMF8PTVzKkJYrT7aBtPRR8DvH/BBnqwqBaPpherabRThJhVBmffm5CiGe3ye/Swd8QOmQsmXhe2i0Dqr84T0XMTm7SNCgwXselAF7/fOeSCdIYgNjMMT5qCXqwLVXNKqGbTiH/kd9qPZBnpnLz204TOfuxgtAwu5XRynwvWgyaUPdY/xxSuhUacfonvjtXlAvHsiviwqWBxe1BvcXPtkn/WlWNosnmkuen2g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 06:19:09PM +0000, Benno Lossin wrote: > On 16.08.24 02:10, Danilo Krummrich wrote: > > Add a kernel specific `Allocator` trait, that in contrast to the one in > > Rust's core library doesn't require unstable features and supports GFP > > flags. > > > > Subsequent patches add the following trait implementors: `Kmalloc`, > > `Vmalloc` and `KVmalloc`. > > > > Reviewed-by: Alice Ryhl > > Signed-off-by: Danilo Krummrich > > We discussed this in our weekly meeting (I think ~one week ago?). If you > give me a draft version of the comment that you plan to add regarding > the `old_layout` parameter, I can see if I am happy with it. If I am, I > would give you my RB. May I propose you let me know what you would like to see covered, rather than me trying to guess it. :-) > > --- > Cheers, > Benno >