From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5160EC87FD6 for ; Thu, 29 Aug 2024 19:58:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C5A276B0096; Thu, 29 Aug 2024 15:58:25 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C095B6B0098; Thu, 29 Aug 2024 15:58:25 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AF90D6B0099; Thu, 29 Aug 2024 15:58:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 905C66B0096 for ; Thu, 29 Aug 2024 15:58:25 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4C3BD811D0 for ; Thu, 29 Aug 2024 19:58:25 +0000 (UTC) X-FDA: 82506344970.07.DE10FD2 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf29.hostedemail.com (Postfix) with ESMTP id A1FD2120009 for ; Thu, 29 Aug 2024 19:58:23 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oJiF1HZe; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724961414; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2y1Q6Z5FNb1Px58aZg62B3qtSMZPeJoICzrTDFXz/eo=; b=3tDcLLMsdUn6Go/BTb84EAafkOvosgMFeZoneibjyvOWQTr0+pqB47wbNVRt6Wi5a9k/W7 1vuP8R44WxTPIBe0IbDjDuZ/oQDPCUF1vvz4giwkjzW1pl2WApvjhrnKxhR8sc+BrFlBIj kAGns6g3zor84Sw4NoIGsYd99qz69s4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724961414; a=rsa-sha256; cv=none; b=gjqPQSWIaFrkV6aZIL2iGfxOZywk8E99lWKRq35//xTgfVFUHXVaxws1ibAj04VV/luHwk VU3zTQ6beeOxqKcyny/daEyl0CvSAwBDAF1sXNZYDQX3j1Qt/HrWI087NXZgcw20uZlvSE QpNSmBxw6y7xKU7xYfOSE61R4H+nevc= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=oJiF1HZe; spf=none (imf29.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Transfer-Encoding: Content-Type:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Sender:Reply-To:Content-ID:Content-Description; bh=2y1Q6Z5FNb1Px58aZg62B3qtSMZPeJoICzrTDFXz/eo=; b=oJiF1HZeObZH20BOyCNMGtmWAs IO1Rwzl99g6OHDbdJ+L3srXUg5bjrIgdPietSUfnzQ2pi9I9J8fzFRowOoMltDOrG06t97zKOq5YE 6nj3v7fvizoEY0BM7r1ybz3vnWNE/t63bfgy1cG7odCAfP7TfzhfiviOVttKOf93PisNO40zVNoiM 3qR41XcAI+LOyA7JHB3xmJOA/RBGb16jotT0XAiGb70IQc6iYQ5TC1JiKxu2tLd/STAagMUCeJF0f UfexAuysX3JVXrtdzM76fq5UWtJ8JV/whXRLHa9hFkqcm6J01WGm0i6Mnn9HISpnJV6UW/Bjp0c8e LjoMQ/VQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sjlHg-00000002T5Y-3Lzf; Thu, 29 Aug 2024 19:58:20 +0000 Date: Thu, 29 Aug 2024 20:58:20 +0100 From: Matthew Wilcox To: Jeff Xu Cc: Lorenzo Stoakes , akpm@linux-foundation.org, linux-kselftest@vger.kernel.org, linux-mm@kvack.org, linux-hardening@vger.kernel.org, pedro.falcato@gmail.com, rientjes@google.com, keescook@chromium.org, "Liam R. Howlett" , Vlastimil Babka Subject: Re: [PATCH v1 2/2] selftests/mm: mseal_test add more tests Message-ID: References: <20240828225522.684774-1-jeffxu@chromium.org> <20240828225522.684774-2-jeffxu@chromium.org> <097a3458-0126-48e3-ba0d-d7dc7b9069d2@lucifer.local> <5a312d38-4591-47b1-9a6c-4a7242dbe20d@lucifer.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A1FD2120009 X-Stat-Signature: iyigf9hmpfp9d15xojojxh93xacgphwj X-HE-Tag: 1724961503-827340 X-HE-Meta: U2FsdGVkX1/p4uUUQwMCc0vg/bB8/jZzHz3nPJ0S7Tp3RfVuBLaR0r3879rcMpavU1v+aWfFkKIeCHNYmtBtJ/h1yevC0BlT48bVkrmMPFx1roWxA/yVTgJXIrTh7LS1xVEHl0ZxjZHK/O8ErfEu3RbEvP6mAVfgTwYhxelIGUxof6kunH+Bew8JbxhtKqZlSsl0ysJvsHoDLMJhQzX4v6J7oaHBykrPkOwSl6GSStoFdtKmw3oec0RSrwxqw6ld8LlN3wfueEcT6Q523p1uENbA/hppNI581ZN8I805aX3DIlQloOLMw9vpfjh75bw5x4Jf9K8dKu18mpqPmRuMNZ54N8qvnSWHrU48FVlD5AOjYwuc/5gw5oKQc7Uo/Mi3iuH5uvf7WJVGcrTvbMwt6j0Evt6KdBU8FIKeJl9WXtadIoklpt1QONiDdaJGVgcGOWa0HG0ELyWY+vN1Xw+ked9g1m8jUG47RC1uU4biu1FbL86agKggLFmjwQkJJfM/Mpx2DA2agQSr6nJho5odiyzhUe+cuedS5AtY4kIfGtlMUoO9eoz2ufRot66cubup24+LnCjVLZ3uC5ezkBwnnotScLTXYa0Qsb2k+23t/CmBFKLYNP8rsPsyx0i8yhhERBQJHdlcN8ofZIyD6VvaxooqZr8yeYuZ077/4POiMqPishZP96UsNfiME09lsGCmQ+TIsAwQt5y/kd1QpOfjII8n1qlBlqksTOmPVi/WuAn5+ad2RL+sDDc0LkWC8OCyBoLNoT2LRqeN+z96x+pznMQkkzbMy5twBT+gGuvW71R4rBLv8yN6yH92C7nE3HHeBwNcfXoCH79qRskmSw6hB3xi5H3A2QIJFRVgJkm8lSnR8HaDwGdZWdPv+HDM/jKAip2k7qE7l15svM7g+Cex1n2ggx9i6Ao1yPCfmVU4fcNrAU9VOWZmPpjKBPmNUuhCvw1Tzd1vVvVRhWIbNtB fh/Xn3Mp kdIMWrQlubpc0Pz3AHe3jIbGqMLxihfiwrYPLWZwZhWdsiezgEz7y2JOLmCJT4ADEicv9oatz4WwvrDYIARquQHXcS6E7BHmzEVdV3xKi2VG1ngkkhEZxRwY9okWk0miY9IHXvHC+ZNmaL0sFTy25fD7zw+ePiytv9aX0iM+SZdAQto/uUEJwIclc/02Khb+uD4L0Qa8N++rQKdWUg3kCpTsPNwZkGM4UfUI69YoYhWEeTnsir1zJoaUHFJN+1TXBwJYuRC/+BbYb+tRbwiOnV04ES4rp26LYyDgLTSY+N9sfBeWKg099OVPsRkkGyYK1vfHi1hNhkVJOYrq/7gBiwkS0nqzpxBsjyavekGNG5rnNbUwB04Fz5fABH30Dif/GOkl8uddt5i29rP8= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 12:54:09PM -0700, Jeff Xu wrote: > Hi Lorenzo > > On Thu, Aug 29, 2024 at 8:44 AM Lorenzo Stoakes > wrote: > > > > > > > > > Also, this is a really unusual way to send a series - why is this a 2/2 in > > > > reply to the 1/2 and no cover letter? Why is this change totally unrelated > > > > to the other patch? > > > > > 1/2 has a fix that 2/2 is depending on. That is the reason they are together. The normal way to send out these patches is as three emails; a 0/2 cover letter, 1/2 replying to 0/2 and 2/2 also replying to 0/2. That's what has Lorenzo confused. > > > > Can you send this as a separate patch, preferably as an RFC so we can > > > > ensure that we all agree on how mseal() should behave? > > > > > It is not an RFC because it doesn't change any semanic to mseal. The > updated test will pass on linux main as well as 6.10. The increased > coverage will help to prevent future regression, i.e. during > refactoring. You seem to not understand that there is disagreement on the semantics of mseal(). I mean, ther's been a lot of arguing about that over the last week. There's understanable reluctance to accept a large pile of tests saying "this just ensures that mseal behaves the way I think it should", when there is substantial disagreement that the way you think it should behave is in fact the way it should behave. Be prepared to argue for each semantic that you think it should have. > I will add a cover letter, split the tests and add more comments to > help the review. Thank you.