From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B425CA0EC7 for ; Thu, 29 Aug 2024 22:29:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E46A6B009A; Thu, 29 Aug 2024 18:29:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 994886B009B; Thu, 29 Aug 2024 18:29:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 882E26B009C; Thu, 29 Aug 2024 18:29:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 6BA166B009A for ; Thu, 29 Aug 2024 18:29:10 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id E94AC1210F1 for ; Thu, 29 Aug 2024 22:29:09 +0000 (UTC) X-FDA: 82506724818.15.599DB8F Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf24.hostedemail.com (Postfix) with ESMTP id E2D2E180004 for ; Thu, 29 Aug 2024 22:29:07 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iRnLKAC4; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724970477; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=lb1pyj5zxbGFHDqjyX82l5HJgvNKijLaWdmPvU8hETY=; b=J5yGCq3Oe6LVg9aQz41mF5og7pd5wu2mETZ+CQap8wxaR5hmirJXRCLkhRXowPrYHyyPXX PlV8pCOpWFEBRh4gkYB5Mz4fp9QcsxisVo8gtAzwlS3sbuuiM4Hs4yWBsOJV3fswp2vOeL lzCf6I9lvpPJUv4+kRsrlWLuiQ9qRik= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=iRnLKAC4; spf=none (imf24.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724970477; a=rsa-sha256; cv=none; b=qOsOLzLryyBg+wkyA9OACH8DR/YO8std33JQY7fgqR6BRV7wE6d4AH/JLwODGs3hdPt6xK 8GU/dlzjKMOuSOudKY6izMIBdSpnoBtMioD9X52zJCW7MOZVbKXqRLJMY/VXbPIDOvVV9A /xUokHV4dQ6FLDuvwAUy8nZFhJXC8e0= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=lb1pyj5zxbGFHDqjyX82l5HJgvNKijLaWdmPvU8hETY=; b=iRnLKAC4B8wm5XBnfdv0OVgM/d cEEof1zWyfZzKsn0z3w44QW/32Zhgbp812aBTx+jhTo+SftWEQApD0+ZV+zNUGEWAShj/Vw2N8APd BiwXdVrkHv1Qp8VeZ0AkV+9CB6Q2ARQARu80xwEvI6Bc+QqUo9kej01g5gZEcEdB6OlMafb9uy2r9 m+bB++s/vJjuRvxLRhC/NhftzSfzj4lu6tJfEQRVAZhpHm85EhddPn4mJAk4s9E8IpqkpiyL6lEkj /qzv/vZTrSa37pIunplwVC0J1ymXvsPyufqiCrCu0UZGrHONGNZBBtOBhmLEZYRKL2tlsihuSU3TR c+J0Mcbg==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1sjndZ-00000002aLf-1Xma; Thu, 29 Aug 2024 22:29:05 +0000 Date: Thu, 29 Aug 2024 23:29:05 +0100 From: Matthew Wilcox To: Yosry Ahmed Cc: Piotr Oniszczuk , Pedro Falcato , Nhat Pham , Linux regressions mailing list , LKML , Johannes Weiner , Linux-MM Subject: Re: [regression] oops on heavy compilations ("kernel BUG at mm/zswap.c:1005!" and "Oops: invalid opcode: 0000") Message-ID: References: <6f65e3a6-5f1a-4fda-b406-17598f4a72d5@leemhuis.info> <02D2DA66-4A91-4033-8B98-ED25FC2E0CD6@gmail.com> <3D1B8F1F-2C41-4CCD-A5D7-41CF412F99DE@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: o67appcw6yekfi5ak7ty56a7bzgccsge X-Rspam-User: X-Rspamd-Queue-Id: E2D2E180004 X-Rspamd-Server: rspam02 X-HE-Tag: 1724970547-703830 X-HE-Meta: U2FsdGVkX1/Y1sQwybrzE5rf9sp5292mrXhJAwxo/OVEsV/jOzFMVuV+PqjbjSS6Jl6/8WW1WT14+ImXin9f6Q9HyB3GqIQm/UzIm2XCFUDcvQdc7zNl97GmXhGXCQU9ixMyzW7aA+/dFbHgyWPWiWgCOODOFLvaHSjhhRgFoxdWCdjIMOfPcMhScCu83+E0A/B65GelCtU7L8lprKpcfIPieH+Eyqj647lkKjS4a4z74dHaajEGnek+PMSg1W734wcoULx6mbOE2M6BsfNqfbwPXSmmpyjPV3k4hOyHJCmQxzpfZg51dwO+c9oUOC+EftfbwRoA37dMjnvxoaSIpb2LhlxAuNpBvtxX4gQNOrVKpjADRF/eqlcub2qi1S0V94s7dP8Z4v4V6OUuJsBSa7Qf0cN/fQWajz3Ax/XamN/SuxRlk32b5CuWRP4iDWcpn9yALTVGWC1ObFj2k+X9b8n9vy/nI6KAZFiY/TXXbd4IxoGuHLqYPnzmTOMZE2OB2SAJXtx2tDeao4OM5vE5Z/aWjZoSt4ubzmeAQzxlLKcXtd/Go6GAowxxzOstaQqr8XPb5Ygr320ANXctPNZYcMgTqBwSpiInby2c09QQi3DiacXsSn+9vQY6wClMLzFVjRveEtu/wGpWp0kIkCVzJXrWSwbXheJwIQhIsx/+B8BbTr1tuVlZ6iQt9fMDtxEH42kJyIFNeUS2xQko1cbxex39wPVOmIvFIbyMjLOlD+TuqpjpRxuTtpv5dPVQONigngHChK0oXylqxXd1ooHVvF7zM8Iv4IpEIl1v73NEhT44cwSSjODnuSNUvoElM3TPDBO0r8E9sUefuN203WdFrwWMlHZVGiDnrxypM7Y7SQCI2aAwsC70/e60gGQ2Zo+Sc+nvwvGaLdwA1UnGUvp6G+AoPn0BDTTM5Tf67ACtGUOcH94wggml+q/F1h71UonifA9cE7ZbQNaj3FFaf3z yBFuQ8dR cqPrYXRZwzTpTMEWQu46TlIkRJ8w/VnUXlfwWOVV6GtY+mVSXlx2+g10+4453PJSTUex1SMt7STdG42eBO0JakR2AwsqkIkk9L09+ljQxLWEQhrfYpb+ixta1rBAa1mT70zx84VCQUpCGjSD7GSkmlny7K7nfwrFSMHre73BM/ef7gReqahakVWgep9w73p2rfQ0QthVxxSZFpSiAVUoA3raFID5WXK0kkULp3s0f9PyntCG0JInou5DSzAPbUJYe2gWQbU4iVjC1KX8ciuHrh87P+C2tGcNwqkYj/xXEwz8p9I4g8zn+1hFkDpEH0VL9mnmdDhGDIim8k5Q3LHyl3rx8BTz5eNAT2iQzxAxIGTdX6C/5mDDQUBria/lXNsbMDEGqMud7G3xDtIw= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 02:54:25PM -0700, Yosry Ahmed wrote: > Looking at the zswap commits between 6.8 and 6.9, ignoring cleanups > and seemingly irrelevant patches (e.g. swapoff fixups), I think the > some likely candidates could be the following, but this is not really > based on any scientific methodology: > > 44c7c734a5132 mm/zswap: split zswap rb-tree > c2e2ba770200b mm/zswap: only support zswap_exclusive_loads_enabled > a230c20e63efe mm/zswap: zswap entry doesn't need refcount anymore > 8409a385a6b41 mm/zswap: improve with alloc_workqueue() call > 0827a1fb143fa mm/zswap: invalidate zswap entry when swap entry free > > I also noticed that you are using z3fold as the zpool. Is the problem > reproducible with zsmalloc? I wouldn't be surprised if there's a > z3fold bug somewhere. You're assuming that it's a zswap/zsmalloc/... bug. If it's a random scribble, as suggested by Takero Funaki: https://lore.kernel.org/linux-mm/CAPpoddere2g=kkMzrxuJ1KCG=0Hg1-1v=ppg4dON9wK=pKq2uQ@mail.gmail.com/ then focusing on zswap will not be fruitful.