From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51811C83F2E for ; Thu, 29 Aug 2024 14:33:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9F306B008C; Thu, 29 Aug 2024 10:33:02 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C4F1A6B0092; Thu, 29 Aug 2024 10:33:02 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AEFDB6B0093; Thu, 29 Aug 2024 10:33:02 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 937446B008C for ; Thu, 29 Aug 2024 10:33:02 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 452CC12052A for ; Thu, 29 Aug 2024 14:33:02 +0000 (UTC) X-FDA: 82505525004.06.A673089 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf14.hostedemail.com (Postfix) with ESMTP id F303C100011 for ; Thu, 29 Aug 2024 14:32:59 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ib6HJNkw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HnkQ4ZRk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ib6HJNkw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HnkQ4ZRk; dmarc=none; spf=pass (imf14.hostedemail.com: domain of chrubis@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=chrubis@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724941959; a=rsa-sha256; cv=none; b=bK4bRCDzCjrI6pzB2G+t88N5JUKaUF7frgemahWM23Hf/sAGVPwnVasSRXcgFxVZyVdYcQ dRNKCnwQOATfTIW3QTyvIFEe4qhY3CCCkvQ0RDB0uCBdUYWz6IioBuqOZ88SWTv1g5b8EB bwi5iEGdIVM7ugi8ejq7rjNyWpHVJdA= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ib6HJNkw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HnkQ4ZRk; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=Ib6HJNkw; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=HnkQ4ZRk; dmarc=none; spf=pass (imf14.hostedemail.com: domain of chrubis@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=chrubis@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724941959; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UgvBT/lMjv0ff6wv1Eg9swV/WKRHj1qSeWNebhjgOLE=; b=Z6zrO1nWZPolfXg5yZrje0ggY1G8iMWsbw67n3cRQFTQ8HbSlRy/eUj066EqWa2lVbvco2 CJo4SM64ODT2NqgEVzIRxATWqMaOIi4xibeZvmNb2vbiSyevVsZya4w+hCPVBSfg5P5ObE 1SZuuQ/BoXuY0Cnxs1an0bVpmdzpMIg= Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 1E5112191F; Thu, 29 Aug 2024 14:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724941978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UgvBT/lMjv0ff6wv1Eg9swV/WKRHj1qSeWNebhjgOLE=; b=Ib6HJNkweLpoMNy9W+ktcnIfarHyScnBiHOx6IeKMXpW2Gq4QBRThgGCIiPK1ILP9GgRaB SiRi9FFczMaF9NUte0GpcZ23rNgWmGv1WfrgVIxQDgfBE95unB4H47p0kEW8orpRq/+M46 dxEtOWVgq6V8xY5iphsktaQh9CnC7iA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724941978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UgvBT/lMjv0ff6wv1Eg9swV/WKRHj1qSeWNebhjgOLE=; b=HnkQ4ZRkz+qTUajSB8bGbE0s2bYu2jD9QSuBOJXfo/+nhkSo/IHe7qiLbfcyN35oYjQ8ca cUXPP7DlWiQnCIBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1724941978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UgvBT/lMjv0ff6wv1Eg9swV/WKRHj1qSeWNebhjgOLE=; b=Ib6HJNkweLpoMNy9W+ktcnIfarHyScnBiHOx6IeKMXpW2Gq4QBRThgGCIiPK1ILP9GgRaB SiRi9FFczMaF9NUte0GpcZ23rNgWmGv1WfrgVIxQDgfBE95unB4H47p0kEW8orpRq/+M46 dxEtOWVgq6V8xY5iphsktaQh9CnC7iA= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1724941978; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UgvBT/lMjv0ff6wv1Eg9swV/WKRHj1qSeWNebhjgOLE=; b=HnkQ4ZRkz+qTUajSB8bGbE0s2bYu2jD9QSuBOJXfo/+nhkSo/IHe7qiLbfcyN35oYjQ8ca cUXPP7DlWiQnCIBg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 09AFD13408; Thu, 29 Aug 2024 14:32:58 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id p6c4AZqG0GY6VwAAD6G6ig (envelope-from ); Thu, 29 Aug 2024 14:32:58 +0000 Date: Thu, 29 Aug 2024 16:31:50 +0200 From: Cyril Hrubis To: David Hildenbrand Cc: kernel test robot , Claudio Imbrenda , Ryan Roberts , lkp@intel.com, Vasily Gorbik , Jonathan Corbet , "Kirill A. Shutemov" , Matthew Wilcox , Linux Memory Management List , Sven Schnelle , Zi Yan , Gerald Schaefer , oe-lkp@lists.linux.dev, Andrew Morton , Christian Borntraeger , Alexander Gordeev , ltp@lists.linux.it, Janosch Frank Subject: Re: [LTP] [linux-next:master] [mm/migrate] b28dd7507f: ltp.move_pages04.fail Message-ID: References: <202408211026.636ade1a-oliver.sang@intel.com> <767d1908-dc30-42ae-9a8a-d2ad42a4d491@redhat.com> <8bde28af-3401-4d72-b821-d8cf01bbcd64@redhat.com> <4c190c79-401e-43a9-a4d1-e64f78110e0b@redhat.com> <8a16ac0e-4a3f-48cc-a118-ea05c23d5d2b@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8a16ac0e-4a3f-48cc-a118-ea05c23d5d2b@redhat.com> X-Rspam-User: X-Rspamd-Queue-Id: F303C100011 X-Rspamd-Server: rspam01 X-Stat-Signature: i4t8dhkoruiakgywfgjfw5g5taymzrwu X-HE-Tag: 1724941979-577422 X-HE-Meta: U2FsdGVkX18r1XKFwlePCKyEyK2lo0xfiY25JqJxCm6sT6EBijFdSLuJCRauyfdOmW5v9cSPYm8DfnNGa3MIcGnpwhdo78kRhXBqQOdhJ/feQeaDZ/qp0VGOgwzG0f6i4bnhRZqZE1p2ly0rHfZ+r2vpy7vrNUzI8aYL3j7IkyojmkSUPZECpOm3CZtxANBPGuuZ1OHCNMiIJT8nXTZ9j2pPeQ2WjKVSFjkQ3MmVz9WNg9Ceo1rtYrPBUERr1RW8PEx6Puj+qAE77tGinzh3xf1rFN5dC9o+89vLQbLaceUobBLg44UdJgAxtl/0NJeljJWO78ZZiMv64aYWQ4R6YlA5MlLn52AFaNy9L1rir1Y4eEzRVTiw2n9r0Ybgj1eZIVP9kgvSoVax6Msa3fp5Fb+WWH4Q+Vw/QHrbwPSDKVvKFsS5Zq1vshC58CHkEfDPaT4kODoTRsHOOWaE1W5T4aGi+B6t2EufILr47e2MBAufTq6mAJsPZiAmIJkdIE7UAe9skLEtmWU4PSXWJ9mKtgRwNx+bFU2yQyG4ArsYZ7FlMX4SkypcEVJl/L3uJwMSgGL32Nfsnf7bUa6It5DGHmQbPso/5VhRJ34gH2he1RLhlr86N9NbldXC8cUDCVEpG7Kc1geYVgb4YLZJG6ggRLyWjiNKDY22CyK1Glk1aap96R3ziexLV+HAq0Zq/o/xsPegGMGr6Jt+tosBRiSUr42a6OS6RqK3vXGDTThl6UriviqdE5NkXh7xLKyV13F4FhaMJYU9kpG7PuaAWynVmVD2utIaW9p1IJhfFHemiK4aCbzEMmzTFXu5GO4Q3c8D3ktd5Pr7Duq65WT7Nc8fvEG+YTr+yYm+/wvH92NY8sAw3nmbAZoL3tuVYHx/85Fhup7vdkguvVnAiKbQv+IJffDAS8NrC941IIHid8sXjAyTiaJWeJHL87i0T2WX0cQH6xGLcgFneDHjpVuV8L+ ZJ5c6g+N G8p+/g7RyV4/JA2IXF7HNSEiYtItlJfwdH7kAZyDVrrkdzxZ3DGgqnmVADWkKnQZ8TVgWjbljLx59UzhrJ2UKGfb71DeIFmVx5tkkLqDVFQ+SoMuWoY2lKzBATzZED6YL3Dx6Deo66flrJCyAkkuEl8UTuJqTopEBpNKqcGLCbeU1tuW+8Vz3uXRm+Pe5DejU92wwFoZfchk2fBMr500yUqYRGeE/8scEo6lcDf3mfD94dbAw/AxH1/jIUq+Vr0ONccRNR5Xw55h8oiH6uhV0vuCS7lZwG4EsXpOb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi! > >>> Also I think there is a third case that we do not cover either, what > >>> happens when we pass an address that is not mapped at all, e.g. NULL? Do > >>> we get EFAULT as well? > >> > >> Yes, that's documented as EFAULT and should behave that way. I can > >> extend the test to handle that as well. > > > > Ideally the test should be ported to the new test API as well, but I can > > do that later on the top of your work. > > I tried, and it all looked easy, until I realized that these tests use a > share code-base: > testcases/kernel/syscalls/move_pages/move_pages_support.c > > That is also written using the old API. I assume mixing APIs might not > work as expected ... The tst_resm() and tst_brkm() calls are redirected proplery in the case that the test runs with a new API so generally it should work fine as long as the cleanup callback is set to NULL for the tst_brkm(). That was one of the design decision we took years ago, because we knew that we are not going to reimplement thousands of tests instantly and that the old and new API would have to live alongside for a decade. I glanced over the code and I do not see anything in the move_paves_support.c or in the kernel/lib/numa_helper.c that would break when executed under the new library test. -- Cyril Hrubis chrubis@suse.cz