From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26699C83F16 for ; Thu, 29 Aug 2024 13:12:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ACF276B0085; Thu, 29 Aug 2024 09:12:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A7FB26B0088; Thu, 29 Aug 2024 09:12:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 947166B0089; Thu, 29 Aug 2024 09:12:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 76A9A6B0085 for ; Thu, 29 Aug 2024 09:12:27 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 3396580E18 for ; Thu, 29 Aug 2024 13:12:27 +0000 (UTC) X-FDA: 82505321934.12.C1D1EA2 Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by imf16.hostedemail.com (Postfix) with ESMTP id 17F99180028 for ; Thu, 29 Aug 2024 13:12:23 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=PvVCmH1s; spf=pass (imf16.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724937026; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8qX/f6dofDtGfqoUjh7wF0DGgkcB4Ol606CTys8bLCc=; b=gI35db/BnTS7/VDhxOJmzdvWXHj044udU+YCm65SkpjwDcRlQsP3k+bihQql92C54H3MPa qnZAnzawYH6GDQ3UA1onnD9J7OH3ORtkpSG5nN8FgrkjiwKpt5lo8lCQ97wdYOGOXWmrqZ 6FFnnIFK3zsD1h7+BvCeJlGFHllGBXM= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=fromorbit-com.20230601.gappssmtp.com header.s=20230601 header.b=PvVCmH1s; spf=pass (imf16.hostedemail.com: domain of david@fromorbit.com designates 209.85.216.46 as permitted sender) smtp.mailfrom=david@fromorbit.com; dmarc=pass (policy=quarantine) header.from=fromorbit.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724937026; a=rsa-sha256; cv=none; b=LKPJXq3/X3Y1BzaYId0duqNqMeGYxFk0PPscwTG4LMoMVfbcBsUrIUYOzzRFwe298HNldd 2OiF+JyWfPl2y9BUUM/PzdCmNWZEqqTaUV74IzO6YGVgEEMLhvG11Fbi/DSxLELa0vaayP Wz4dHDfxWhfBKm8LTa7CXVXFRJJuHa8= Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-2d5f5d8cc01so485908a91.0 for ; Thu, 29 Aug 2024 06:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fromorbit-com.20230601.gappssmtp.com; s=20230601; t=1724937143; x=1725541943; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=8qX/f6dofDtGfqoUjh7wF0DGgkcB4Ol606CTys8bLCc=; b=PvVCmH1sPdfCa0rUxtt5gRpSq/ZAa9Fxb/k27GQVg+rWFusmr8lfZPFD/WepwKJQdK 87Lzk72JjCc4y+IAsMRnKqE+9jwIXs2RRyRsLq3vfCoFH80PSucEhU6Td5uX3iIvGSZM sxDGVN0EYDpFZtan7PEcCQM6JH2sauk8H1Mn2SveMwkh8Njb97c2sF/TvAoDPIyRCIrN 9JKly6DtQqD02s0i7jOqkBRJH8NILDteBpc9OOP6SfeMo2+fgULoMvmV7AiUB9uI3wTl g/N1fyVsnUuwqvWDOSjcUabpyHQRwncZvBdFdv23gWqBUSI1uAwKZrqsrT4xtWU00zHV bv9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724937143; x=1725541943; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8qX/f6dofDtGfqoUjh7wF0DGgkcB4Ol606CTys8bLCc=; b=GUi5plXt+AnzVSLNAPXNgVELMgYTjSJ/TuTBa1oMKUHlRINWVIp4W+rNSGrVCn8oZY 8YZv9LbHNM3TLqE8454uOKV+qGqAY19i3DZ12cj5TdRTb3wdP0glVfVDhnjQ8VEtfXAw fg3LHcHIameHlup/89mYjoaOldYKeOoTQeJ0DNsK38TVaJYKK7F3Aa96Wcild5kstay2 jJH1r6Mhx5ECsRvGji53yR7hT6HMmqhwROmRJa6+twvaPfOUzKMq5+Gw/h+Fuhbfqx2M SdFL6devRePUjmNGBj9FQ1OAbZdej58kAtMonR6Pm84I3rmh+lp51RrufQDVqM2zIJSp XSLg== X-Forwarded-Encrypted: i=1; AJvYcCWtBjQLpCicI+oRA4MLgCL18x6i3kYG2fc7KRzdWcVAhahVHx3NSrKPD4/qh+mN81B7fh11O17Pxg==@kvack.org X-Gm-Message-State: AOJu0YxnijLTMcfTCt5r1npkDxW7U3NIwRQX+gCgj+L/P62L16OyEFwe Z4yyIs/J58gtPCskX6AJEg/5P1o/qu8k/WdYdr+p4+R8ROxgNlvtzOI0nTgaFN0= X-Google-Smtp-Source: AGHT+IE5og1QyFjbYL+fjlxeemY0chdVMvPBO6yd0H47y0vJ8/ygu0YjmhWpP08sTZ8j5BBHBY/dlw== X-Received: by 2002:a17:90b:c12:b0:2cb:5829:a491 with SMTP id 98e67ed59e1d1-2d85c7d28c3mr2403333a91.20.1724937142595; Thu, 29 Aug 2024 06:12:22 -0700 (PDT) Received: from dread.disaster.area (pa49-179-0-65.pa.nsw.optusnet.com.au. [49.179.0.65]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-20515542376sm10955575ad.204.2024.08.29.06.12.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 06:12:22 -0700 (PDT) Received: from dave by dread.disaster.area with local (Exim 4.96) (envelope-from ) id 1sjewk-00GwzF-1j; Thu, 29 Aug 2024 23:12:18 +1000 Date: Thu, 29 Aug 2024 23:12:18 +1000 From: Dave Chinner To: Kent Overstreet Cc: Michal Hocko , Andrew Morton , Christoph Hellwig , Yafang Shao , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH 1/2 v2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Message-ID: References: <20240826085347.1152675-2-mhocko@kernel.org> <20240827061543.1235703-1-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 17F99180028 X-Stat-Signature: addrecs3a8ky9jy9e6z73556kam3u4y7 X-Rspam-User: X-HE-Tag: 1724937143-401923 X-HE-Meta: U2FsdGVkX19I9TibMbVr7lKBDavQ5A4xHR3yXIMudhsk0zlBZpYYpfXIlOUNbf96LxVV/UgeRVzLDyPUXe7MXxsa5rdrx7Hc9jZUfQvFnR7iddcMYKResbXHYwfvC7nH8FUcNsO5RR/ewIztbG6ig2i3wUBQocVqP1kxkjrqmA6rT0VLMULjI7m6rMwmDtCAQsQmqbqMzLeLVjr6UTjg19/9DTq/EzOQaZqg7s4NYT0lLePNWbKX5Gx/t0ky7FfW5NdEspde56XndwR7ePn47+IyjLT8Gta3AcylugjFrS4kmDJ/Z5sjxjOWbgj6GsLQuobLXP5wMUmwg7ii4uWeHwDzgeQ4tlCmre9piLwwEcT4+HzgZn859FaaIhOwWErgni8kNFTr2+5yG/s3AQKQMoZjyAIf6xmxCvrZMeapVLoMNa+clFXcSv4zrmWCYlDvYVoWQPReiUtKHHOjsw9pe3qinUS+gkJRQUJlbHHDMPOygVe5AaCIykf0FayIicE60/8lQu/qqtk857RR1gbrLozDFqtFt7dGx/iGXDkuYilMw00asp9YiCkZD09aWvdyF320H1PFQsWZ7VvZw14JTE3yVq786LEQWtmpFhpCOUnoewXPiiVbshGrXhwPiIHQQcP49C1Zy6t7tiiqXEIEDKeU2JZH4q0ImcQIbx0BEr8PySVpP5vxoNyqn3pLlwtKG8FNpkXIdRO2ME3HsgwyjKTys2oH3GlacCtITmQWV0ct8TVscAMAbtWxhPnP3rT/9Jl4gWPeun/YkpeI2MHSH5Fa0cBCt74C10gKSEYIkJgC3kssDW7Cwnb56Em7QGzDOF2FHguQE4hk/KjAZzH96m/ZNYNTifR3o9ulMvdVfr0Dnd67/Znm8Z3P7XBRGdS4mWg1GDjsjCWMnQPD7NlYu1YW6KKXTktxsqVk8JrHqjrldSytmMIfa6jcFxehbQUZ/ZuqyZ+LNh8veky03N4 jOjKzUFv YyuXfq7rIGLYAKRIpPaB34TTOeD42xUfQqt06YCtpfxZw9OlAPPAZDg2o53ySe9ZqwBt/zQf9/biZjHSteY18zaa+NUHXH+w3yWagA2QD6odPTId0isfKqVv8Z6jDkPEnM8vFsFUptS/Q9SaaXc9R4C/uJJ3EF41SOoS/728tKv2jZ54jRAMLJyk84wtXgALJ2fk99qb5BhipKErSIQ9rtLbAJBRURnmWGGgcF8UJPowENj2kSCmo0TWxZdQ6ESUgMIN0oymyKCy8t1swScdYCvZ0nMmlFRhyNYvOXZmRu4544Gq0bX19XpBly35cbztYEYvXKDdvdPGm5lS/3B7vxCUGRrk/gtUhIoNsgW3BqFZX8BJqfkkUsP69OUx8N6JYXoK3KzjmfkC3FhkygRgD3bLDOOJQWb4dZjHKDphr3hoWqjmcll1K/1n/gsU6v/KdTz8CVrhcBoPk4DzbmT+DLqGe2XCT/z8dUnXhJcW1foK2iM219bVobDLtpJElLRUdi/4KhyKfNaJxyJURIqqUFo2gjJPCLM1SGIcCg4NAcKKL97bkpPPbaCgo4l+jGlZ7wDoISSCUuCSkhAfwp1xie4q4BA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 06:02:32AM -0400, Kent Overstreet wrote: > On Wed, Aug 28, 2024 at 02:09:57PM GMT, Dave Chinner wrote: > > On Tue, Aug 27, 2024 at 08:15:43AM +0200, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > bch2_new_inode relies on PF_MEMALLOC_NORECLAIM to try to allocate a new > > > inode to achieve GFP_NOWAIT semantic while holding locks. If this > > > allocation fails it will drop locks and use GFP_NOFS allocation context. > > > > > > We would like to drop PF_MEMALLOC_NORECLAIM because it is really > > > dangerous to use if the caller doesn't control the full call chain with > > > this flag set. E.g. if any of the function down the chain needed > > > GFP_NOFAIL request the PF_MEMALLOC_NORECLAIM would override this and > > > cause unexpected failure. > > > > > > While this is not the case in this particular case using the scoped gfp > > > semantic is not really needed bacause we can easily pus the allocation > > > context down the chain without too much clutter. > > > > > > Acked-by: Christoph Hellwig > > > Signed-off-by: Michal Hocko > > > > Looks good to me. > > > > Reviewed-by: Dave Chinner > > Reposting what I wrote in the other thread: I've read the thread. I've heard what you have had to say. Like several other people, I think your position is just not practical or reasonable. I don't care about the purity or the safety of the API - the practical result of PF_MEMALLOC_NORECLAIM is that __GFP_NOFAIL allocation can now fail and that will cause unexpected kernel crashes. Keeping existing code and API semantics working correctly (i.e. regression free) takes precedence over new functionality or API features that people want to introduce. That's all there is to it. This is not a hill you need to die on. -Dave. -- Dave Chinner david@fromorbit.com