From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3F0FC7EE3A for ; Thu, 29 Aug 2024 08:12:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4BB226B00B7; Thu, 29 Aug 2024 04:12:24 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 46A696B00B8; Thu, 29 Aug 2024 04:12:24 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35A246B00BA; Thu, 29 Aug 2024 04:12:24 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 16B366B00B7 for ; Thu, 29 Aug 2024 04:12:24 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AABB01403FE for ; Thu, 29 Aug 2024 08:12:23 +0000 (UTC) X-FDA: 82504565766.10.68D2872 Received: from mail-lf1-f44.google.com (mail-lf1-f44.google.com [209.85.167.44]) by imf11.hostedemail.com (Postfix) with ESMTP id B626C40025 for ; Thu, 29 Aug 2024 08:12:21 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=k789g1HN; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724919054; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gy/6guuz7idIpkVI/MLnSgp3SDDwAbobV8+omG5Ebjs=; b=HS1c/3snYCfXLb0SoWb82RndlbuisnVT4bjH9yMBye3uYY35XnscKjMLE4O4o9j47G41xD m3WqZpWJyjTEMTgJtYqJkv9Im3QwyEzzVgVpiYT2W1d1THWWQUv/6wH1K9bytuYm/FRzs0 mkP0exIE9m8pjKt02AhszUdZ6LYNKyw= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724919054; a=rsa-sha256; cv=none; b=dQbT+pW0APzQiMF7l43UswA6OTraVMUA+Czj9L3tXjC/tsEQsMhOIzJ1GW/HjPUibjL50U kWkH8mWTtqM/TNDZWG1ldRtuEcRG8rBHsy1D31FqI8TYWSbAkA1eFkAMMVQb5ELcK/FqX0 wSbDqW5I5vxneAh+KFCJaF32+QjOHt4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=k789g1HN; spf=pass (imf11.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.44 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-5334c018913so362967e87.0 for ; Thu, 29 Aug 2024 01:12:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724919140; x=1725523940; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=gy/6guuz7idIpkVI/MLnSgp3SDDwAbobV8+omG5Ebjs=; b=k789g1HNo0M4dhpIFiOVUHk8fEcJTIuLQbgblViQ+7ZRMT+iJjABTRuMqIqRCP13Rg TYxabRU0qLmd5vrKOaM0UAZ7U54TtxzcXhZGiT11dZj6wDCgc5Ui4e+LLSW0iN5+nqgT WQFgUTubNFKviR7NeKVdFIg7mZ/qaMrHzl5qIPUOAWtogGOc2WChX58rQ/yhVQl2821v 5fP1QOBLmvQ3RLmKttt/XYg5qIAZRKKWQFAA7q5oJThtwcLuqCzLWUcneuRbeG0rhAtb IMRodTbQyFlaDy3J2aXD1Ob9iBbA7fF4sSKQSRzUwLfN3SnqucDdr9T8CzuOTTBqEkwo IdTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724919140; x=1725523940; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gy/6guuz7idIpkVI/MLnSgp3SDDwAbobV8+omG5Ebjs=; b=t+d+Xhy1O2o/andYxaetbmcu57/q0vlgIqZP5A4K+qf7gIbomL35At6ypRBaz0jrsE LUuZgBZEiO4FagI3lMV+632/G66v/zA9BA1skUywEYZXgSBLSRzcvYDvXPkw/xXsB2SX BwNIsE8mE0c+cTDkYJFnWsZGSRRHdBJvfbD88mf1vJKsIlNezhZ7W4qnb9vOzK4gcBrq x62c8oJ2bADjECW7dbLcQARf1bT6V3KvSEHLxIvNPo2ZCkK7r4W2teh7kP8C/tDSmEX1 H68oM5n72Jim6izHpBrAQarmdT/vA79Eori1tUsiikasmVuIY/jfdMsL+fiktWQkrywc Wsmg== X-Forwarded-Encrypted: i=1; AJvYcCWfa3oI/dUHleP5ibebdiONvV/sujd61rMOXxOrsYT0U09nJVgsnRY9+W3mTYRIvDICieef2OmDUg==@kvack.org X-Gm-Message-State: AOJu0YyzlTys6CSdwJOZ7DOKFJoFgzuZvyHZqn0Gi5t8HnxFLNK58NpJ 0O880nDKGdXlxvdUiilWlrwYqrfa6Cc5IBO00BmsP5h8YEWDcxl6 X-Google-Smtp-Source: AGHT+IF2g4rxh2v8IQWftNJuiEP0QcG43IxLAxXGGYSGojBTNn/K9uXK81bYx7P448zKtBIyqyNFbA== X-Received: by 2002:a05:6512:ad3:b0:52e:9b92:4999 with SMTP id 2adb3069b0e04-5353e545f45mr1261010e87.2.1724919138914; Thu, 29 Aug 2024 01:12:18 -0700 (PDT) Received: from pc636 (84-217-131-213.customers.ownit.se. [84.217.131.213]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-535408277a1sm87592e87.129.2024.08.29.01.12.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 01:12:18 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 29 Aug 2024 10:12:16 +0200 To: Baoquan He Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm: vmalloc: Refactor vm_area_alloc_pages() function Message-ID: References: <20240827190916.34242-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: B626C40025 X-Stat-Signature: mhrikbmeour84hgaj3grt6k61c36zpu4 X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724919141-819693 X-HE-Meta: U2FsdGVkX194O2HvecCvBBZIypjLjo3nrjRnaOJdZSHzMMglr47SxihC+qh+bWFIrvvbAZLaIiNMUyk2Zz8f9Jm7fmzKimgIAPMdJwZOVt+Sem88HpzLD6v225Grjc3B9jKpoatKMAVfY/pFROPC2M+DSG14qpOeWN+9C/1+jBdnt+BLgXeYQ9mDQISDty6Vl6H8QgG7bj3opRExz/4H30NrobO3O02fdXlGGPQcalj12A5dmSCf1SBRPsoKi4L7Iwh1PLoJleMHaakfyj7k4z7gupNjs4014qaeww9UNCfKFqZ/60cMWs++EunABkXJK4UCrcHXGjk3cVIWx+iNjCRfqEhuYFTriunTdW4eJ60MhK3w+XdE64RcPfp4mOdBfGFVU41SaCIOld9s4SR9iTXwjgvO3FsI9JeLmwSgGbqNYqGQc+mQSLoW6JDDsLFje4bvTaTN8DRQkaNEvbvV1RZKK7RTcqadZmcOIHqcKQbiijMUuu2qnka16qi1WK4jB7dWryJgj5O+KtquEOfAjxgbMTT2urYB7QiurKwzsgOegyxryScQdfF7rAah2RGQuXFFsp2G8N6Fi/eb9lTP+G2Rs7EDHfSr2XhxN9bfxuReA/KnZDqkjrwR1CfDDUvhkjNBAnZLTlm7udmXGFuJbtcuQs8jYct7GSfRfJjFp7rHSv4VjiTjlHhqW5dMlbYGNca0i1kU+z9sXRQ+nxShuoBujwXh6nZhPpn2ocCgJ/wlztfkFp/5GRtojT6jpeb/IgVWTrYbVNU/5t6OIvcEk6t7KHgAjjjVpeSeZviutw5wR7trDX7mn6MtpQ2bBlBh69pAOn4kwJ4H38KYKEewU9ewF4fEsiaZkosnQ2qyqtJwPoVG6YAui3p8d36caY82DOeS9tcDArkZMJHe40rnxT+wwacKneCHdwOsH9bTu0uHRcpNDR/ITW6rsQGO83jWOm29k2Xla72cci5dxXq oo4YeAUd ongq1NQCNU45tF66XZx7ATjwrAIIDomu/FeU3cewgVRDVw+/V0L10Iy8GCdifqv5orUlj1mrcmo8GPKujL3rdbYhyBgQIAiFip93gzQ2WP29JpoBGB2P31HTxv01WE16Kb+m1tyMHE2y8c6ONUe/lVvUTpOrNEyEruk/r3FGGyu882RdlpfyY/vB/kdblAf7WsNOm8PLeBjXysoabJqr7n8sjCNvQzJAk2kZU6KXRiqJm+LIeOyyLFS1dxAFG2mPo7c5j+/ZKZhGjAcDR+7qC07mhxFfzIBv1x6oRHMNb+VGwITsvOx7kHQ1iFRnpHZe+BTP5jB4E0Yl9PwZ9oN2EHmioXbEpUb/NqoPSQfeirIPeVTQ5DFbTvbqpdBoceQjTAg2Z72fwQlmN7ib3pgu7k59dwF7NZX3fxaGVMZgo6YgMJkwBUC6E5XD5hxgq725tSUsGMCul2nQUWGknvTbUbwAJfq53RTcq++rFq+sAVFEY/VE= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 11:48:32AM +0800, Baoquan He wrote: > On 08/27/24 at 09:09pm, Uladzislau Rezki (Sony) wrote: > > The aim is to simplify and making the vm_area_alloc_pages() > > function less confusing as it became more clogged nowadays: > > > > - eliminate a "bulk_gfp" variable and do not overwrite a gfp > > flag for bulk allocator; > > - drop __GFP_NOFAIL flag for high-order-page requests on upper > > layer. It becomes less spread between levels when it comes to > > __GFP_NOFAIL allocations; > > - add a comment about a fallback path if high-order attempt is > > unsuccessful because for such cases __GFP_NOFAIL is dropped; > > - fix a typo in a commit message. > > > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 37 +++++++++++++++++-------------------- > > 1 file changed, 17 insertions(+), 20 deletions(-) > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > index 3f9b6bd707d2..57862865e808 100644 > > --- a/mm/vmalloc.c > > +++ b/mm/vmalloc.c > > @@ -3531,8 +3531,6 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > unsigned int order, unsigned int nr_pages, struct page **pages) > > { > > unsigned int nr_allocated = 0; > > - gfp_t alloc_gfp = gfp; > > - bool nofail = gfp & __GFP_NOFAIL; > > struct page *page; > > int i; > > > > @@ -3543,9 +3541,6 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > * more permissive. > > */ > > if (!order) { > > - /* bulk allocator doesn't support nofail req. officially */ > > - gfp_t bulk_gfp = gfp & ~__GFP_NOFAIL; > > - > > while (nr_allocated < nr_pages) { > > unsigned int nr, nr_pages_request; > > > > @@ -3563,12 +3558,11 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > * but mempolicy wants to alloc memory by interleaving. > > */ > > if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE) > > - nr = alloc_pages_bulk_array_mempolicy_noprof(bulk_gfp, > > + nr = alloc_pages_bulk_array_mempolicy_noprof(gfp, > > nr_pages_request, > > pages + nr_allocated); > > - > > else > > - nr = alloc_pages_bulk_array_node_noprof(bulk_gfp, nid, > > + nr = alloc_pages_bulk_array_node_noprof(gfp, nid, > > nr_pages_request, > > pages + nr_allocated); > > > > @@ -3582,30 +3576,24 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > if (nr != nr_pages_request) > > break; > > } > > - } else if (gfp & __GFP_NOFAIL) { > > - /* > > - * Higher order nofail allocations are really expensive and > > - * potentially dangerous (pre-mature OOM, disruptive reclaim > > - * and compaction etc. > > - */ > > - alloc_gfp &= ~__GFP_NOFAIL; > > } > > > > /* High-order pages or fallback path if "bulk" fails. */ > > while (nr_allocated < nr_pages) { > > - if (!nofail && fatal_signal_pending(current)) > > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) > > break; > > > > if (nid == NUMA_NO_NODE) > > - page = alloc_pages_noprof(alloc_gfp, order); > > + page = alloc_pages_noprof(gfp, order); > > else > > - page = alloc_pages_node_noprof(nid, alloc_gfp, order); > > + page = alloc_pages_node_noprof(nid, gfp, order); > > + > > if (unlikely(!page)) > > break; > > > > /* > > * Higher order allocations must be able to be treated as > > - * indepdenent small pages by callers (as they can with > > + * independent small pages by callers (as they can with > > * small-page vmallocs). Some drivers do their own refcounting > > * on vmalloc_to_page() pages, some use page->mapping, > > * page->lru, etc. > > @@ -3666,7 +3654,16 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > > set_vm_area_page_order(area, page_shift - PAGE_SHIFT); > > page_order = vm_area_page_order(area); > > > > - area->nr_pages = vm_area_alloc_pages(gfp_mask | __GFP_NOWARN, > > + /* > > + * Higher order nofail allocations are really expensive and > ~~~~~~~~~~~~ > Seems we use both higher-order and high-order to describe the > non 0-order pages in many places. I personally would take high-order, > higher-order seems to be a little confusing because it's not explicit > what is compared with and lower. > > Surely this is not an issue to this patch, I see a lot of 'higher order' > in kernel codes. > I agree. It sounds like hard to figure out the difference between both. Are you willing send the patch? If not, i can send it out :) > For this patch, > > Reviewed-by: Baoquan He > Thanks! -- Uladzislau Rezki