From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57F63C83010 for ; Thu, 29 Aug 2024 09:01:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DE3726B00B7; Thu, 29 Aug 2024 05:01:03 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D92EC6B00BA; Thu, 29 Aug 2024 05:01:03 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C5A516B00BE; Thu, 29 Aug 2024 05:01:03 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A7C056B00B7 for ; Thu, 29 Aug 2024 05:01:03 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 0913C1A0C6D for ; Thu, 29 Aug 2024 09:01:03 +0000 (UTC) X-FDA: 82504688406.23.04E69D7 Received: from mail-lj1-f175.google.com (mail-lj1-f175.google.com [209.85.208.175]) by imf16.hostedemail.com (Postfix) with ESMTP id E341918000E for ; Thu, 29 Aug 2024 09:01:00 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PfYd5hxI; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724921971; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mqrqAqaRSgrInF1coE2971HDeJozKvG8Ym+70UpmzmY=; b=ElZ6rT0jO+faUOoXevrfubZD0RYjOpDPTwnJWaNwPITTzwFtz5wGRT0buSRWkQyJBOCIgn udco/3SUaQu/1dcEmT0rQAzW6EE300QKpep6mCJR+T/zr+FjI/7Cdi9F+gRZ5C26AOP/QT IkhAJaMz2xdaT4gkG3pHrBlJaS3W0OU= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724921971; a=rsa-sha256; cv=none; b=tLTE6MsCCedlw/qF77Ew20oAmRJzUlQxtXgT4L7kL4GbmXMs/VSzXOeibWriKIMJh2v3nn /xa16qfPGhJPsk9V1XmecdG6eMQnHKBfJ+3pBTBKbgMm2zJ1i+RuFFn5Rw/Fzopzz1yYn8 VnN6wnpe052LO1X2IZnuBrx7wW9Po1w= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=PfYd5hxI; spf=pass (imf16.hostedemail.com: domain of urezki@gmail.com designates 209.85.208.175 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lj1-f175.google.com with SMTP id 38308e7fff4ca-2f43de7ad5eso5691751fa.1 for ; Thu, 29 Aug 2024 02:01:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1724922059; x=1725526859; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=mqrqAqaRSgrInF1coE2971HDeJozKvG8Ym+70UpmzmY=; b=PfYd5hxIunGVDA6/hCwIZND/MVMM8uTYVWATglDwYIWQhjt0AEHNSo14rjrl77RndT udVzOX2FldxjmJE30OHjg0rnzVRd8rriAxeJnGbMyjhRPT/ZCIdMvTCs+C0JbZXfmsRQ XNLUU6UbGiJ8FfoIQDiecmacPXxkw7MwA1ORkTSPjPpqFmFxi3Lr2748I4ZM2d2tB2Rq DObePsG5M5MtzXTCXvh8MOr4F2ZZviCw+rtF+pi1wPoB7CXylvJOZU47vKuShoBmxZIt ecllUEuJAFl2qpT2ao1PLXX5aCjw3wcgQ3F+5t538t0GPBxp01zXodD1yGRqUBCsMwKm f1rw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724922059; x=1725526859; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=mqrqAqaRSgrInF1coE2971HDeJozKvG8Ym+70UpmzmY=; b=hIfFuXBdgCQ5/NICtoDgo+0DLzlLxQpo4jB5ObbkouSflwRn1LcYClVN8zRC9fkVkK 43IYAWPVQRS3BZ4heU6L6ryPM+YuyMXx8QcbozW709rDr5PDlF47L59bkGGaKSb+LvI7 /4AtGEjIOt4K3wzrWxUI014yuHnr++P5RnkVGTJPbmymQr5xt+CAPqIRhUIYbp/bL5VY 3ZpfFHn5iY1QIXUaQJot7wAfYcfbEqzNG1dK53UPypG4EHSLpOTJHSzLJSf4XOlnPw8a b7aOALHdYjEo4+yTVF3sx4K+AGw10ObUHKzI/xbNrRx+k0hxMRYTZ8MBfJKDKF5hn9dC CsuQ== X-Forwarded-Encrypted: i=1; AJvYcCVs9wbKSzSB+pXVMe+OaTOXY5iThy/hbpCNNhr/eUeoWDMk4TFxLbnCtAdwey1xIEkzzb3pxer15w==@kvack.org X-Gm-Message-State: AOJu0Yyls0VWwJFC69IYAXvseE8TRCnCYJQGy9q1HOtz6tY1OU2pNWev c2xvadnrPwAaiGzIgCOfzwORUb4WerrCNSJJdCorcualJOisKJ3Q X-Google-Smtp-Source: AGHT+IGvhPGSk7+LB/aNy+FUpLxz7pd8E4OOIWgj18FiLvsH06laCDyXN+i/ssSX6zwLCl3/tf/Tbw== X-Received: by 2002:a2e:4612:0:b0:2ef:2061:8bf5 with SMTP id 38308e7fff4ca-2f610552732mr17072841fa.40.1724922058008; Thu, 29 Aug 2024 02:00:58 -0700 (PDT) Received: from pc636 (84-217-131-213.customers.ownit.se. [84.217.131.213]) by smtp.gmail.com with ESMTPSA id 38308e7fff4ca-2f614f00926sm1226551fa.40.2024.08.29.02.00.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Aug 2024 02:00:57 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 29 Aug 2024 11:00:56 +0200 To: Baoquan He Cc: Uladzislau Rezki , linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm: vmalloc: Refactor vm_area_alloc_pages() function Message-ID: References: <20240827190916.34242-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: c6hdatj7uiznbqhcidtxwmzqxffkjxtu X-Rspamd-Queue-Id: E341918000E X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724922060-655406 X-HE-Meta: U2FsdGVkX1+tdxgGh/ExY9DXjOAQ6Bpg87iUeFuj13UColZSkIZshvGdNcV6lA8+vHAfMTMMYG4N2yHUi7p/IyhoHU6XtVjlOiPaqn89xjyMRhIor4CS5NmyC/AXzvI+Umm/gnFSXGt81mJZ4VhJjkL+OsHYoMhTS3XuFrh/UXl1Vto0SbM6GY1x9gg63j1kD++oqVbDuwHlBJIpmTVqdKKaKEq9yEz1b7MusK5lAEp7PKzrdq9FiZjMH0RqGzYWmy9sS6J7K1uiM6lez+YDT02rc4nJ91kV4Qp+iE2uzPqk+2Rv/G6trsgk/lASCFKGnI1xUvA15cay0bnJqQ59QJvpgDLZeDrXoydNYlkgbdHQqm8xXqvrBmq+PIj2NmKcIR83TkHCfOV7r1hpac6/G+K83zK3WzwRVqpw8eosXm0X2/Ar6sqYME105RDEVoisWQX0Rg4OiCIHVi+UP9zJFD/nIIWGrLlM9pZRl1GpKbTiartI6InkYWRZqO/j+WBhbJM5PKtn9U25GfPqLDI2nHra14XCK7fBCsNwOh/8s+tVw+EVpoo8+X6abrzwlldPscuJL3Su5g6Ify38OGvIl1NyZfLF3SPyzex5Ljor7cr8N37vImJfg0eMItcoSk4YSfh+G1cJ2wIwKM1Kqdgj7BXjh/pYY8STn+ejtUSU4CMxTr9KTeoiU3OrxkUpjKnvVcq74wuC2XqA4aBAAYzEU3JQY4tQFB9wA83Az/Mm2DwQMVkW8ywk34FA8tyQYKr4PMNPo4xAT0kKmI+NVFxmmjfs8CYQEbc4jtaMRHX6lIjVvw8mTWRO23ffmNB6cTYgww7jmNJFIerdtywNgMePv1kKyt2wdnVDT/Y6/ZFwT8rv2D3bNg4SoD0VvbtlT+SJPDNcmolvDo82KCiYgkDIB5BfXREahPFmrNCaI0PuYf9vDeXJhWWgRpWribsSyJG22S9aUIdEkI+OHKevPqS OvsrON/Z LJvSMgDIioVFGLnuQcol2fnQ6kkRkY4+R5p8OMiLpQi5cDIEcFD+5p428iBa+5tY+774GvdMdb4sLpXYXyLgykH/hGS+F3JagKgYq3xJRmsIUbaT3K0Cf/7RGXLEKuqw3ReyaNmOfkZ4ikHgqCROa56QENZ4P+tOYTTbC0+joNqemOB7KWlxe6+UcWN4KKZ4ZBtqrDrNWuK3po0CEjLDGuzwu4HZvoiD/rCE+HOp/qb9bSdQLP13yNKEqTNXIysSyK+9Z/pX2Yio10SOI6r3FatYnKeZtClDnGaNKYKA73ohnFkEhEKNNQQsl6zZA0ocAjW0M/sxJEbOnmnNAmw8AALihRF+7mKPJGWopmp7BbIveiDzhUO+2nbA22dYFYKH5eMx8PTr0nM58mdP73KW9na7PT+QrgAXmL1HGf6YZPF/UClupDl+7Uyq9oe/NuCd+G4HaBBvzSTrHa7M62pPGF5rmug== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 29, 2024 at 04:44:51PM +0800, Baoquan He wrote: > On 08/29/24 at 10:12am, Uladzislau Rezki wrote: > > On Thu, Aug 29, 2024 at 11:48:32AM +0800, Baoquan He wrote: > > > On 08/27/24 at 09:09pm, Uladzislau Rezki (Sony) wrote: > > > > The aim is to simplify and making the vm_area_alloc_pages() > > > > function less confusing as it became more clogged nowadays: > > > > > > > > - eliminate a "bulk_gfp" variable and do not overwrite a gfp > > > > flag for bulk allocator; > > > > - drop __GFP_NOFAIL flag for high-order-page requests on upper > > > > layer. It becomes less spread between levels when it comes to > > > > __GFP_NOFAIL allocations; > > > > - add a comment about a fallback path if high-order attempt is > > > > unsuccessful because for such cases __GFP_NOFAIL is dropped; > > > > - fix a typo in a commit message. > > > > > > > > Signed-off-by: Uladzislau Rezki (Sony) > > > > --- > > > > mm/vmalloc.c | 37 +++++++++++++++++-------------------- > > > > 1 file changed, 17 insertions(+), 20 deletions(-) > > > > > > > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > > > > index 3f9b6bd707d2..57862865e808 100644 > > > > --- a/mm/vmalloc.c > > > > +++ b/mm/vmalloc.c > > > > @@ -3531,8 +3531,6 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > > > unsigned int order, unsigned int nr_pages, struct page **pages) > > > > { > > > > unsigned int nr_allocated = 0; > > > > - gfp_t alloc_gfp = gfp; > > > > - bool nofail = gfp & __GFP_NOFAIL; > > > > struct page *page; > > > > int i; > > > > > > > > @@ -3543,9 +3541,6 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > > > * more permissive. > > > > */ > > > > if (!order) { > > > > - /* bulk allocator doesn't support nofail req. officially */ > > > > - gfp_t bulk_gfp = gfp & ~__GFP_NOFAIL; > > > > - > > > > while (nr_allocated < nr_pages) { > > > > unsigned int nr, nr_pages_request; > > > > > > > > @@ -3563,12 +3558,11 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > > > * but mempolicy wants to alloc memory by interleaving. > > > > */ > > > > if (IS_ENABLED(CONFIG_NUMA) && nid == NUMA_NO_NODE) > > > > - nr = alloc_pages_bulk_array_mempolicy_noprof(bulk_gfp, > > > > + nr = alloc_pages_bulk_array_mempolicy_noprof(gfp, > > > > nr_pages_request, > > > > pages + nr_allocated); > > > > - > > > > else > > > > - nr = alloc_pages_bulk_array_node_noprof(bulk_gfp, nid, > > > > + nr = alloc_pages_bulk_array_node_noprof(gfp, nid, > > > > nr_pages_request, > > > > pages + nr_allocated); > > > > > > > > @@ -3582,30 +3576,24 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > > > > if (nr != nr_pages_request) > > > > break; > > > > } > > > > - } else if (gfp & __GFP_NOFAIL) { > > > > - /* > > > > - * Higher order nofail allocations are really expensive and > > > > - * potentially dangerous (pre-mature OOM, disruptive reclaim > > > > - * and compaction etc. > > > > - */ > > > > - alloc_gfp &= ~__GFP_NOFAIL; > > > > } > > > > > > > > /* High-order pages or fallback path if "bulk" fails. */ > > > > while (nr_allocated < nr_pages) { > > > > - if (!nofail && fatal_signal_pending(current)) > > > > + if (!(gfp & __GFP_NOFAIL) && fatal_signal_pending(current)) > > > > break; > > > > > > > > if (nid == NUMA_NO_NODE) > > > > - page = alloc_pages_noprof(alloc_gfp, order); > > > > + page = alloc_pages_noprof(gfp, order); > > > > else > > > > - page = alloc_pages_node_noprof(nid, alloc_gfp, order); > > > > + page = alloc_pages_node_noprof(nid, gfp, order); > > > > + > > > > if (unlikely(!page)) > > > > break; > > > > > > > > /* > > > > * Higher order allocations must be able to be treated as > > > > - * indepdenent small pages by callers (as they can with > > > > + * independent small pages by callers (as they can with > > > > * small-page vmallocs). Some drivers do their own refcounting > > > > * on vmalloc_to_page() pages, some use page->mapping, > > > > * page->lru, etc. > > > > @@ -3666,7 +3654,16 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > > > > set_vm_area_page_order(area, page_shift - PAGE_SHIFT); > > > > page_order = vm_area_page_order(area); > > > > > > > > - area->nr_pages = vm_area_alloc_pages(gfp_mask | __GFP_NOWARN, > > > > + /* > > > > + * Higher order nofail allocations are really expensive and > > > ~~~~~~~~~~~~ > > > Seems we use both higher-order and high-order to describe the > > > non 0-order pages in many places. I personally would take high-order, > > > higher-order seems to be a little confusing because it's not explicit > > > what is compared with and lower. > > > > > > Surely this is not an issue to this patch, I see a lot of 'higher order' > > > in kernel codes. > > > > > I agree. It sounds like hard to figure out the difference between both. > > Are you willing send the patch? If not, i can send it out :) > > I am fine, please go ahead. > Good! I will fix it. -- Uladzislau Rezki