From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F90AECE587 for ; Mon, 9 Sep 2024 19:47:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6D8C36B01F8; Mon, 9 Sep 2024 15:47:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 689336B01F9; Mon, 9 Sep 2024 15:47:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 577496B01FA; Mon, 9 Sep 2024 15:47:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 38F086B01F8 for ; Mon, 9 Sep 2024 15:47:57 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id B3A9280A1D for ; Mon, 9 Sep 2024 19:47:56 +0000 (UTC) X-FDA: 82546235352.25.056EF4B Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf07.hostedemail.com (Postfix) with ESMTP id 5FB6D40018 for ; Mon, 9 Sep 2024 19:47:53 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OuXvGo4G; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725911272; a=rsa-sha256; cv=none; b=HyN9SdkkDCivjgCDQnq8XY0TUf2TqZWVj8HZ+Kh7LAB8c/bYVpFeFGGFk7LpErXh0O/mjZ m3TBue+gxUPGm9ywMwRwqYLSnVrQw7ulQ8/KPw26+WrpLlGEMxR69aUkxJCf/BcHbZ3CeG v4txdyQzO+B/2v1oazNNULAjBrgMx5s= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=OuXvGo4G; dmarc=none; spf=none (imf07.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725911272; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=X0kV15Cqf3QYUwyAFRybcY7zV8gb4O0cZLiW/r9UUtg=; b=4oM+O2bkhhiBEl/nfqYcAl8IlAJdPLh5eS7rPi25KJmP2M6M6BbiaxzXQQ/UENhcNNypy2 pOcegXsTUf9ggG1fy+0Odlve6thVpKgQ8tZigfmSb9zq5yRRZuIIAY+s72OolSIN/Ro61p mI560lp2BjK7kAD6/7zsTYC7vmwvVWY= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=X0kV15Cqf3QYUwyAFRybcY7zV8gb4O0cZLiW/r9UUtg=; b=OuXvGo4GyRZTjIEKEXjmjgFl1J j6Nv3LC0t7FzOwLjeAt/656zhl+H7tAJk9w0NEbK/yCppP7KoqCbkw2e/vkl5hXookeOVoPmCCjgO 7T3ePe62o76M0mH/HOXTBIaWxdEZhPZqH/VSculwCfl/M5rxndcKreDyCO0TKS/9S4MzL9qyidCKd RXlC7nrho9/qN+FU5Z7/dtJMKDHtU11nmvdF6yv4F0dh5ta0gBkDo00XDvlCVOWVe+De1oeZ762Fb CGXPW5+2I4xXtFnJSs4MVyhw/I5MPtH3+KXubAht4unTutmUaArMWYEvPyDjuEN1reYxD9F/yVYRH /4nxIUiQ==; Received: from willy by casper.infradead.org with local (Exim 4.98 #2 (Red Hat Linux)) id 1snkMU-0000000Ggop-1vYY; Mon, 09 Sep 2024 19:47:46 +0000 Date: Mon, 9 Sep 2024 20:47:46 +0100 From: Matthew Wilcox To: chensong_2000@189.cn Cc: akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/filemap: introduce local helper for_each_folio Message-ID: References: <20240909061735.152421-1-chensong_2000@189.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909061735.152421-1-chensong_2000@189.cn> X-Rspam-User: X-Stat-Signature: 7bb3ug5n6pfbtcitq673bgpns9az7k7b X-Rspamd-Queue-Id: 5FB6D40018 X-Rspamd-Server: rspam02 X-HE-Tag: 1725911273-19083 X-HE-Meta: U2FsdGVkX1+vy74XEZLSHumFWBDezpQHH6edWOjeGkLANwmn1k716rDp1oh9JLbxk4/hYSAVOalOZMjqGzswjW7ChuQy6dAnJENWB2dC3Uok5mJCuAkU/x1GI6dLrwMxEYt1M7SU0YyNsOvBNNhE2CzG+k6yWU/bUa4qbPOCr3St46XzUjOu6tE3gPEwSzobgdZNXJ6IffB3jyD+uPbWlmPDvhEnXCeJSscQuC1SHh+FdPc1Ob2L1S/osMyqEDJZnybhY5VlN3X2QhUFQTHYy63OxhAhCgoFqYrSNSswnBKoGt3b5nny4CIbuEGhS35rYu1GJ/CVPIFEIyQanQFazbiXG093Nt+1xbO1NNtWqTNwBr1kCdK9Bib8ylQIV7/fG421002UDAU6FsPCMrkP9b16jq/v4xwjGM4t/9eCkmVZ14FWwPS3rzfoCUpbNpPkUUnFTLauZOW6mxTBm6bcn3ZTp7h9RV2+7zb3aWVbkN3ryyWy28gQ/QxvQJx52JbZWdDVLE9f/v2PL3HZho8VNaP4HAA2aZ+o0W1ahXIfKlRAxJAK2Yff/3WnaP9i9eay8KYHAuXRCa9554ZbwEjnt99m+YvvEx0G5DAvVZEXsqb7nEiIVogGdQa9Bon7CA2IZ19o94YTL4P8UUBInGeL68AlZwJ68clNUv0/quARsCpQs/QgigcjtM8lNXIntl/NDjbxZfx1/FuyxIF0uvmI0kIvZRcNgM4TICvO4dEo9GZMLEMIOX+QAsQphrJKwHQFSgs0V9HnDeOdmz5hTpt/TteGbGedxzTamC1PLIsfIwpn8bKStLGPGYYxCkzyab/fT2dIApCsT8XbM7WGRlN+EKACbsUyQAu1WLhUzfhWvA2WGRG2YrCjQVI/6+8oh0WI8XZtD0HrDGMY3V26F7kggcj8RysFjUQ3dxd/D1SnH6Ex6HmNHGbJlTaMhfYjWd3HhQVZGHi76bIlL5WNoo4 MJcP2rYS KMdD3OFCdEQ/zz07NRa/Z82eMtMCBVWIAZTFHKj6Wfk0ELG1CC2lCy2yg8DjWpf2l8SPUdsZlmVBTTtI0vP0I0cSpojYXzhqmm056NCWPN57+bGIRRudMI1R9vLkCLyrhhfLxSjux4HnRT+88FB0yAPN5vJYs4CHS7r+/zlXAKPuNzfG6KT60wDRrF6UHEEJte+Cm3Xrwkbvz5wjnkD0I0sF/RQWH7qEuYugdWTLfZzwcdR5WHb9I8oihWeO1RO9BKvSwLTSwCmEy/PDoVZwRAlUi2w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 02:17:35PM +0800, chensong_2000@189.cn wrote: > From: Song Chen > > Introduce for_each_folio to iterate folios in xarray for code style > compliance and better readability. I'm not sure this is really worth it. > Signed-off-by: Song Chen > --- > mm/filemap.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/mm/filemap.c b/mm/filemap.c > index d62150418b91..5386348acacd 100644 > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -62,6 +62,9 @@ > > #include "swap.h" > > +#define for_each_folio(folio, xas, max) \ > + for (folio = xas_load(&xas); \ > + folio && xas.xa_index <= max; folio = xas_next(&xas)) > /* > * Shared mappings implemented 30.11.1994. It's not fully working yet, > * though. > @@ -2170,8 +2173,7 @@ unsigned filemap_get_folios_contig(struct address_space *mapping, > > rcu_read_lock(); > > - for (folio = xas_load(&xas); folio && xas.xa_index <= end; > - folio = xas_next(&xas)) { > + for_each_folio(folio, xas, end) { > if (xas_retry(&xas, folio)) > continue; > /* > @@ -2306,7 +2308,7 @@ static void filemap_get_read_batch(struct address_space *mapping, > struct folio *folio; > > rcu_read_lock(); > - for (folio = xas_load(&xas); folio; folio = xas_next(&xas)) { > + for_each_folio(folio, xas, ULONG_MAX) { > if (xas_retry(&xas, folio)) > continue; > if (xas.xa_index > max || xa_is_value(folio)) > -- > 2.34.1 > >