From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D8DE3ECE579 for ; Mon, 9 Sep 2024 14:38:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2E67E6B00B4; Mon, 9 Sep 2024 10:38:01 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 2BCF46B00B6; Mon, 9 Sep 2024 10:38:01 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 185396B00BE; Mon, 9 Sep 2024 10:38:01 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id EF10B6B00B4 for ; Mon, 9 Sep 2024 10:38:00 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 615321A0498 for ; Mon, 9 Sep 2024 14:38:00 +0000 (UTC) X-FDA: 82545454320.16.F80D4CF Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf12.hostedemail.com (Postfix) with ESMTP id A35F440010 for ; Mon, 9 Sep 2024 14:37:58 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Fs6Al/RP"; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725892578; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fx5Q5wGHfaPcGQNBhBxzKuDh4bmf133p6Qs6k52Plj8=; b=fXi8215W7IEQ5nhro6f7lnlspCqf422ou4XL21hB5r9zwmIztnQ0cPbkOaCXABeErq3cP/ a2EqND/3UWvaMaHOyNa2AQKjPZN7dIlr9lcxABUVTVprMDPJs6zFA7SHfc/x5Essz/Eact 5yicFrwC9t4vkBeDbUGe+JtWrKxhchY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725892578; a=rsa-sha256; cv=none; b=dIJmqKtx4WTgfFpPesbPjfeZcxCmv7jdF6ljy2NhkjMKct7cdHCd5xa2mvagUqckMWPHBg 1bCuwOaUQHCESTOSU2xLMW1ybF8g7B7owbk3+Kbx+6lsPA5MMx/MB0cN0AvcbQorga9KWD 0ks8yC7zd2JqX/hbOOcEoIUmeLq6FfU= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="Fs6Al/RP"; spf=pass (imf12.hostedemail.com: domain of rppt@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id A79975C01BF; Mon, 9 Sep 2024 14:37:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4BA38C4CEC5; Mon, 9 Sep 2024 14:37:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725892676; bh=MghDFbPAU9zqqkhW3Xw5vWmg1dmDiUK7SCkrMyPD7PA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Fs6Al/RPqqDYAd+lPeXebcBiEsV8ZcvYqHnhgbekPtDgt19OlBHjiP9gQSdGe9afm E6dAjll1IYePf87BqvuUHZojSOISa9K5xqnGdYsjKjKAxmrH58TOhb7yDaJfDepFBa KmFe19pfYgaP0P6SOasN93vKsvEqQdqzY5UZFrT5OYDRUwY9bZOJ0yO3EIutfG5ADs 9/aQXVlZzbQSnDoIg63nYDc2lsJ+5/3DsjcdPHAdeypnZ/+PEaSwQCoG2ocV6cZ8IN 5SSH1gwzGe/PyYVHsa/teqwYFCWwEBH8MNluTcSCH96QK9eENqGcAFK+i9m860tlOX EjTv1+plHkaMQ== Date: Mon, 9 Sep 2024 17:34:48 +0300 From: Mike Rapoport To: Peter Zijlstra Cc: Andrew Morton , Andreas Larsson , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Brian Cain , Catalin Marinas , Christoph Hellwig , Christophe Leroy , Dave Hansen , Dinh Nguyen , Geert Uytterhoeven , Guo Ren , Helge Deller , Huacai Chen , Ingo Molnar , Johannes Berg , John Paul Adrian Glaubitz , Kent Overstreet , "Liam R. Howlett" , Luis Chamberlain , Mark Rutland , Masami Hiramatsu , Matt Turner , Max Filippov , Michael Ellerman , Michal Simek , Oleg Nesterov , Palmer Dabbelt , Richard Weinberger , Russell King , Song Liu , Stafford Horne , Steven Rostedt , Thomas Bogendoerfer , Thomas Gleixner , Uladzislau Rezki , Vineet Gupta , Will Deacon , bpf@vger.kernel.org, linux-alpha@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-csky@vger.kernel.org, linux-hexagon@vger.kernel.org, linux-kernel@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-modules@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-parisc@vger.kernel.org, linux-riscv@lists.infradead.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-trace-kernel@vger.kernel.org, linux-um@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, loongarch@lists.linux.dev, sparclinux@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH v3 6/8] x86/module: perpare module loading for ROX allocations of text Message-ID: References: <20240909064730.3290724-1-rppt@kernel.org> <20240909064730.3290724-7-rppt@kernel.org> <20240909092923.GB4723@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909092923.GB4723@noisy.programming.kicks-ass.net> X-Rspamd-Queue-Id: A35F440010 X-Stat-Signature: 5xmqypqgjidtb1kgfmd7ek38q14w7wpb X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1725892678-352975 X-HE-Meta: U2FsdGVkX18FtKkszeYvnmmLoYWaUfe4wZCuTPZ1++wPIbD3/jzh8HhqWifQs6C2nW/tExwPbf1n9cJDRPrCYwZUUnpuGW4f+85xa573RE7GdhahF4ayc3u/buVPtR2lVpe4rKKD0VGtXuhSsQj8ArMnHraEUQPSJUNzq+lYMYS/lVpp1jnPxDiJznY3t6aCSfCFWOXE5DCKSr5MQ7ksoKD1jvlL4xorXKpAxKRxMmZoaLrzF83uiTDKki6lsFfYtQ2RUfo5DZBo5mHelpOaCGnoE+n2bYGxbGrnK8twrWDHas++sJdzgTmbbtHqWmYVHsPPU3N5ULG6tP2xUruyXRgCkGS4+xyCtKbCnLGXvu28oIh7RJZHKTuvfMK6hWZs6EhSnTk2QViGP/0sWmXq8+82sU/k1oSI7fjljBSW06to36QsyzQPnpVU1TDQP5G3qkBp5Z8pMzQe1opM04zX2smLQ6fibz8ePch5ne9rz/po+6BWgxLU9CNJ8buD6J8VGbCdYyfUKiwliVcAKnwTZIBzXpYeCjkOYWPdIsKej5lrBC7JG5NXoIxlsgQ9XKI16+Mc10Tk8RCBH5F9qHO3PgCftr7v6HNd2DexWpNSJdb1dPnkJve41cPrjs5zopkIb7+me7eUHDPycczMOyAGRTt9D9teuoj79Q8gVnzGHtRYuG2uUCySwvyx8LgHv1Ash2i8C5DHPpfRaYO9E6XxI/P1Z4oIkn0Nj6ar+rrAtmIkid1P5CLk/penxM8NRbxyQNpRjV4+d7Sj62o/lFUZpbOyW527HQ3+/P0OfGfRqPs7VLqSz+ANHebMmjH9syDw4r0SC7OcSo2IUMhGDo7HUh0S9KW//4/Dg92ML8AqI4uBFgUW36hnIqN40U6poXNeRDCGfpQ9+xmsvI5BVtnbSO4JywWiIkCFatMOFbREFThngGq5I9cbqGTsW74jtUeP5ijMri/F4RIEi7C3aPe Yu18gI0W 9WX9iZiZNrdecTPvAQfpkFMvsakNDo39BaJ7Vzt3zbJa89btTwy6CjdIAHYFjmpLzv1EvDgyB+mJ953rXA6fqUHQwAgZh3oeIZLWjH43iSm7ZzexStlkfK+eeZ16t7JEGTU9asz07RMzc0dqKIyUyJFuCtZucKDYSmeVwj9Zaq3orBgzAmZaVMrUKPV2/y6HIv2huVk3hz8qIgn6QwzO8cxL0NDCdRdZfTQaLedxu3NaNRKiGWExb+YB29k+1JYZsCT4l X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 11:29:23AM +0200, Peter Zijlstra wrote: > On Mon, Sep 09, 2024 at 09:47:28AM +0300, Mike Rapoport wrote: > > diff --git a/arch/x86/kernel/ftrace.c b/arch/x86/kernel/ftrace.c > > index 8da0e66ca22d..563d9a890ce2 100644 > > --- a/arch/x86/kernel/ftrace.c > > +++ b/arch/x86/kernel/ftrace.c > > > @@ -654,4 +656,15 @@ void ftrace_graph_func(unsigned long ip, unsigned long parent_ip, > > } > > #endif > > > > +void ftrace_swap_func(void *a, void *b, int n) > > +{ > > + unsigned long t; > > + > > + WARN_ON_ONCE(n != sizeof(t)); > > + > > + t = *((unsigned long *)a); > > + text_poke_copy(a, b, sizeof(t)); > > + text_poke_copy(b, &t, sizeof(t)); > > +} > > This is insane, just force BUILDTIME_MCOUNT_SORT The comment in ftrace.c says "... while mcount loc in modules can not be sorted at build time" I don't know enough about objtool, but I'd presume it's because the sorting should happen after relocations, no? -- Sincerely yours, Mike.