From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA6ABECE577 for ; Mon, 9 Sep 2024 17:52:47 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 596516B01B3; Mon, 9 Sep 2024 13:52:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 546A86B01F0; Mon, 9 Sep 2024 13:52:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 40E5D6B01F1; Mon, 9 Sep 2024 13:52:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 25E876B01B3 for ; Mon, 9 Sep 2024 13:52:47 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id A08D040E95 for ; Mon, 9 Sep 2024 17:52:46 +0000 (UTC) X-FDA: 82545945132.27.D9961D4 Received: from mail-lf1-f54.google.com (mail-lf1-f54.google.com [209.85.167.54]) by imf09.hostedemail.com (Postfix) with ESMTP id B417E140002 for ; Mon, 9 Sep 2024 17:52:43 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HWp3iSlb; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725904261; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e60WACr5wMaV0x8+q92ApCB8ruX2ciph8OpfU82ymdM=; b=f1j4rvq4kgLzIghCFjWmYJGlDM1P5Q3RP2c1KF3TXPxaFTOymkaOIzLz2NiHcbwmRafnxt bBhfGmtJRCRYevcPnq7KrSi75O5R0U5tIZwPBzO7dDtNwMIPmUI/l2Dc7Pf2omgz48fqwE g7b79ziFUqZQMhwoB+buXUHDvIbPBOc= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725904262; a=rsa-sha256; cv=none; b=fC8tYe8RQ3J+tTyr3sF39J21+jmH0YhZesF+AEiVoEkF+rmteWYhbePH2I1yoSNDonx53F YI18eOCbhUsgmo4j8qd2Taa21vnYSMiSEbjnQhkiE0L96yZJK3nX2Sgq3+GeQasTyOsaBv hIHjOdETGyT+2LrYvgrGGUmEX2uyl7o= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=HWp3iSlb; spf=pass (imf09.hostedemail.com: domain of urezki@gmail.com designates 209.85.167.54 as permitted sender) smtp.mailfrom=urezki@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-53659c8d688so2466250e87.1 for ; Mon, 09 Sep 2024 10:52:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1725904362; x=1726509162; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:from:to:cc:subject:date:message-id:reply-to; bh=e60WACr5wMaV0x8+q92ApCB8ruX2ciph8OpfU82ymdM=; b=HWp3iSlbWzp2Z6V5hTcBypYytDIugGVH1UcOtTBeK/OxkArRwl/5M6ocKvlU7a/q86 5PASVyVt/YBJ3KB9/3VkzHeU23JAu21MIVfYpXosHcZ9EEMWf5rtfxysS9vGZ2UIF+mW k6mEFFUT9CNEBV3CStBTclNg6Ge/IoRmxOQFkPAao6UzoeKlAXwbPMqbvgsF8KnDRzvU tMNh1+oXEC0wcpRIpNzlyf/qU0oBx2jRDB3UK48bz66XpkiOpowAtiFOyXHYQXrYIIDF d+njXH40tXYf9CP9ORa/wFY/q3c0ntHnbEvDzoiQS3VLKaB9ne/poIUBKiTYl7LODB5d 6kgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725904362; x=1726509162; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:date:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=e60WACr5wMaV0x8+q92ApCB8ruX2ciph8OpfU82ymdM=; b=JjGfVGyeKjbJbqLBJxAFkeN9dagfgRX7PqAnXJk8N0g1SvGDTi3L5dkYnH9++tKWmI TSQ9Wgue7BJbmtJdA6dT/PZBRbNnngseKgCn+9Ir+ZRjxUk29PUFJAZpa9GgryRNnmDX DwvJpv7oeE1AlecgOjhS3QxAI1iSb1twJjQsn6JV2nmUk1hbj5XwSf4p341m5aw/joc+ p3TvbDjwYVOFthRb95Fd5wyYVDxhTdbJ7XTJ6OPu41cLdR/7uEQqGyg58hbhJAcSeYve pLn/fTrPoPWh0UtAV1W8taOr/oJBpVYmVAhjBDa27ZtulNgcRqv9qHT6gNuKLqSXLmNb gDhw== X-Forwarded-Encrypted: i=1; AJvYcCVtnFYGC+qtY7v4JQw452l9IELFtkvjJQgx1ZtXluY2P1e5p7Vbz9hZczR/hG6TxCvkspwGSeu2rw==@kvack.org X-Gm-Message-State: AOJu0YxUbrmzvItEH9pkH80krwJ7uSkiatuFieWYnArINOwsS4oLn/EN G0unhvmPHmWfZXHG39dol50Gx5o0hj6fJYw8+YYdgJnCsu69bZpe X-Google-Smtp-Source: AGHT+IFDtaMKlVLzoxah6gErN8HAi0f6takSCdF35p37nokYdMt91P2R76XNsN+Oi17v+r4RvxaxDQ== X-Received: by 2002:a05:6512:3051:b0:52f:441:bdd6 with SMTP id 2adb3069b0e04-5366b7d4cdcmr168105e87.0.1725904360823; Mon, 09 Sep 2024 10:52:40 -0700 (PDT) Received: from pc636 (host-90-235-20-248.mobileonline.telia.com. [90.235.20.248]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5365f914008sm845371e87.304.2024.09.09.10.52.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Sep 2024 10:52:40 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Mon, 9 Sep 2024 19:52:37 +0200 To: Baoquan He Cc: "Uladzislau Rezki (Sony)" , linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages Message-ID: References: <20240906095049.3486-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: B417E140002 X-Stat-Signature: 9euagij9fue84qug193dx4zj73yt6wmn X-HE-Tag: 1725904363-576990 X-HE-Meta: U2FsdGVkX1+ixAe8n8Q9EZRkYuqQ2dvMA26IB9t6Xks+EB2LO0p9rr/vrJ6WOrcqukEeM1743Jtj0Q9T6sSjyzKn3iPZnypAIbgwn1vIL26FuaUpe8O+NrsA1g8WnwW0ZkRuzuXoI8f0Z6sNTar/NvndNNRYR+SCMRT8DaOGWnbFgT28yrbJIQE8rGG2OSKVMG615rFTapcQojgvoNgSA203xoWuC7Emw5uQDKD1nRPo1RJJeYZ0SnCu5pQFWqWRQgfB1tRWDiFZ9KuSV81wN7xWePTFJ8BkNyu7oTAxXVWE+3rgIGutD930C5j6u8JxhsNbSAV6rU2l2Czlb7kgYSqmWI3ddM6Zsi5JPFLNyBnGPTuduOrgEKeCZ9aqwGu23fFOv/ixmsAUo5XUHlo3W3dxtlh0OEbSZmQmMcLSgFk3XHb6+D8ni11aEbVgGqYbaFgm63wmLmsVQTs4cr4Y2ZjK/vKl7VxRvmSiwmPuJwtHnf/G9u4s904ARr1dPbnAlivdPU5EgOyZTiY2fkG7eSYlVioCbkZc5bZJ5/Nn4q8X9ONQoq3Mzoh9C3G4u8Zp7E/COBG41Dbx8Fa1C71reGj9ZnrPAKgtfoAUvUkbRvluEiJ1u6J9LEQl7W8NFek4RJhO/z/3egoQ7Hl8qzdQT8C1UdF90kq/vITUn3ZAnbiNPSxVhjWC2YDxGDuGTNbIsOSUqN5aOuTzLTyWSU7qKZDkAlYGCZ4+874JRsLhnoD0IvgcWqW9Kta1enDzz/38xxOY5JweobseF+mDyQzda2j3I6oEb343Jx+O0F8009RZ3SiGgXbughy3zXnYHzuLwFUidvsGopUv1Hx/FbaMB9OVil4WOUfF8jTlfijk19mcnCKlVtXnvI2zWmFSE+t0FkEFwfirg7N6DC7oF58xb0hK5aikEtu3W96r2PspyRi0JhQ3TLW8PxuUa5Tc8wcaZzOr0kaQpRXIF1hWkL4 +p3Y6N8d srBJCzv/zgJQOVUgby0EAD+rltHta4pD2iLNajrF7cbkmQTgyLw/X+J/olLLBTTcccFPsGVVVrZysjPZJx83CZ7L7cJscQuFgnJqmVWDVAIoJM+PyMxgvFUdQ1UEFM4pjz5J/aYm2AJZ6tFF2wVAnKQQiy2s+gnk/QO7EoX3OFJn1ftmDVbPRKsaviJz4GlgjsSeGeu6N8FppRGQkoGvzrX7tM4Qf0UzGyOHNY9aP7w09/eolfxaMstUcMYt9r6VFuXYOa4h7WoJz6EsDsh8Q1kHgiLhb4Z1YxE1Ks5SjZXO1A+P0ySMbn7Sr3w9nJZwpzvzkFwJFhAiWKwAH9hUNBzvklaRtS+TR5qIX9NyNBRCF+Dg4KsfSvFwJni5wFZyOVY+3DdllVMu8s4a1aujnYCbASCqP3cq0thed X-Bogosity: Ham, tests=bogofilter, spamicity=0.000017, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote: > On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote: > > In many places, in the comments, we use both "higher-order" and > > "high-order" to describe the non 0-order pages. That is confusing, > > because a "higher-order" statement does not reflect what it is > > compared with. > > > > Suggested-by: Baoquan He > > Signed-off-by: Uladzislau Rezki (Sony) > > --- > > mm/vmalloc.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > This looks good to me, thanks. > > Reviewed-by: Baoquan He > > By the way, do you plan to clean up the rest of them in other places? > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c 493: * nr is a running index into the array which helps higher level urezki@pc638:~/data/raid0/coding/linux-next.git$ What am i missing? Didn't i do it? -- Uladzislau Rezki