From: Uladzislau Rezki <urezki@gmail.com>
To: Baoquan He <bhe@redhat.com>
Cc: "Uladzislau Rezki (Sony)" <urezki@gmail.com>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
Christoph Hellwig <hch@infradead.org>,
Michal Hocko <mhocko@suse.com>,
Oleksiy Avramchenko <oleksiy.avramchenko@sony.com>
Subject: Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages
Date: Mon, 9 Sep 2024 19:52:37 +0200 [thread overview]
Message-ID: <Zt815f8dHOKdAeiY@pc636> (raw)
In-Reply-To: <Zt5j+c/SUNvCMY/+@MiWiFi-R3L-srv>
On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote:
> On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote:
> > In many places, in the comments, we use both "higher-order" and
> > "high-order" to describe the non 0-order pages. That is confusing,
> > because a "higher-order" statement does not reflect what it is
> > compared with.
> >
> > Suggested-by: Baoquan He <bhe@redhat.com>
> > Signed-off-by: Uladzislau Rezki (Sony) <urezki@gmail.com>
> > ---
> > mm/vmalloc.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
>
> This looks good to me, thanks.
>
> Reviewed-by: Baoquan He <bhe@redhat.com>
>
> By the way, do you plan to clean up the rest of them in other places?
>
urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h
urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c
493: * nr is a running index into the array which helps higher level
urezki@pc638:~/data/raid0/coding/linux-next.git$
What am i missing? Didn't i do it?
--
Uladzislau Rezki
next prev parent reply other threads:[~2024-09-09 17:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-06 9:50 Uladzislau Rezki (Sony)
2024-09-09 2:56 ` Baoquan He
2024-09-09 17:52 ` Uladzislau Rezki [this message]
2024-09-10 0:40 ` Baoquan He
2024-09-10 8:57 ` Uladzislau Rezki
2024-09-10 9:38 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zt815f8dHOKdAeiY@pc636 \
--to=urezki@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=oleksiy.avramchenko@sony.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox