From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3AE0ECE57B for ; Mon, 9 Sep 2024 08:28:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154F16B0139; Mon, 9 Sep 2024 04:28:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 105436B013A; Mon, 9 Sep 2024 04:28:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F0E4F6B013B; Mon, 9 Sep 2024 04:28:25 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D28AE6B0139 for ; Mon, 9 Sep 2024 04:28:25 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 76F33A1F3C for ; Mon, 9 Sep 2024 08:28:25 +0000 (UTC) X-FDA: 82544522970.13.C701BE6 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id D9FCB140006 for ; Mon, 9 Sep 2024 08:28:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sPgQkTXw; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725870402; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P+8/1kl4iBNVGxqhRafza431mA/uwZyKx745Nh3z4tc=; b=atybTWaO0ZDGXp2y0Gy6BMI0ymeHhMYUvpOPCgQGjYZAYWH5cBDqrVUBHN6Fa1ex3QzeF2 m5KqQQRfR0OuPwqb6u4m4Qim+Qb4xkFowjVOGyyinlB0iRld+M8VML6ovvTkqZEJTgcyRm n7FZrXpBFNRohAcwc8od7vDOXEFRgBM= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725870402; a=rsa-sha256; cv=none; b=asHcDmWh3mPyL13HJWhwbcdaBKzQahZhM+G99OSb+rl3LRLChXxqr9JNbOXdodOMkPbitV YvRckMlbpYfVohIHh+6X2yO3XCLSyUWvTCsI7AtAapjfqXv67VXfzXdln/TeLD5UlEG4mM PVKaJ07idLZcEx0ZY/Cz29lOASA9N00= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=sPgQkTXw; spf=pass (imf26.hostedemail.com: domain of rppt@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=rppt@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 907B7A428A8; Mon, 9 Sep 2024 08:28:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ECA3CC4CEC8; Mon, 9 Sep 2024 08:28:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1725870502; bh=khXHjXx8hRmTU/IZvQEdj6n2m1e+nZBZNshqBcuC64M=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=sPgQkTXwfphMGS+/ZFhlh4yIOdnDC2/lvd22xOGZvcWRQxKOovtkHeEsXmgUG9Oxu AU6NL+VAawKzRdIKy/FRbjN6v1EPfdKtyhunnwXmu2iK53p9An4fFhL42Tpc8Z5PFC 0G0SUiNQogt87AvHengOpQsaRXBXK4q0v0fYLH/0tCj3xADNNPMZ2zX0YaTZF2HRoa 6sawlMOWW4CIiPVrdpyfejUUjdOuAni3tWb3/khACbyQrfM4IgintD/K5F+7CgmoBc Eyw81FcmGTiGsb8H5BGRCi46Lpe557JzTIdVQy3pd0vWy40Fm0Du22pkUZrEs3/cu4 X4Nu2Z4Tcb2ZQ== Date: Mon, 9 Sep 2024 11:25:29 +0300 From: Mike Rapoport To: "Kirill A. Shutemov" Cc: Andrew Morton , Vlastimil Babka , "Matthew Wilcox (Oracle)" , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel test robot Subject: Re: [PATCH] mm/page: Drop has_unaccepted_memory() helper Message-ID: References: <20240909081930.748708-1-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240909081930.748708-1-kirill.shutemov@linux.intel.com> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: D9FCB140006 X-Stat-Signature: mjui1xhwe48dofxxpmjpc8o95uktibm5 X-HE-Tag: 1725870503-104980 X-HE-Meta: U2FsdGVkX19FFPicx5RDh4UlbQicIicxJ4QM8GMoPpAOvx4hrf4z+PGRaoP0ZpAhA/tnDOVQ9nOVjF1JqPj7EMhA7AX3Mxqh8rRNOmmUH1htfbdJDH7mldvOkZs0ngDMh3iOwcwYTxSRlOLwfRut1L/6Pa7mr2XlkYsisFCel55ykT2Mccgi+8B7ZFqeFtKsBOkJWh7QDepf/uf8Tj2yy5kSW7tqD6D/ooYEelL/PvVAmHMiWGYqLNvYtcAUbEsoLU3hX51h+moZ3xagGC6xnxQlFY30aacsWUKL3sEw1CpDLuDXdm420GFQaoTNh6Tl5Pb49twIzaVLmBTa8EEGMjQXTOg21RK57D+oMsWCMEXGE8qpxOzsyCU7TTC88v2JSdaV3YLN4W7+VIprLwRP2AQ06OrvPbptblvrX7Tc9k/OPVpVUv0gh0hchi8sYxwnBns1HI0bp34oOHVbTQPVCS/bWbkdCP3zLmyOfjuJ4ZJWXN3t3Bn2XQVLuyYxvJ5BzvX3t2E8OvGC5gPzDyUpwnTeZlbzR+FRPqauEVxgRGBxJXk4+sbPz4Lisa6FgNcWVSSiXUNO+zt7GgUOuufSYpWL9EfvFjPoX5t4e3PVb4UHep+kjikUTFWpKhjZm+pN6n1jGI20qfRlXB/BQCe9lqe+d0d/TeY1Xwdsln//Eus/wHvYt9m7K3ywf0ffHX1+g3d5HJRGcSncqBdG9Gm/fKExEg+xSqPesK9wh9TqHr+5QmfIJBvaj8KqypeBUHMTWynjbqLpd6eYSs/t4sCWUujIFHXpBFNl01fpHaGZvfaSzFKhQbjVFsYfiQBUFl728bymtnPf4J9MtmpCKVSv0q3WpTz/rZ6RkvkWnkI167x2/5bAn6AKJdQ+Ue2V6UV1REUhhCNZdcJPfietQ3TxceX3es8xzyd63S8RW8sF6euiTc1DgeatHFXN2cxJZ/aaPASdYWyy7UxYeMuVoPO Jf4+duhY HNaciw37rfvktVONd95z8kVaPfTGcRrlO660ODr29F/R/YOvGtAYUxSJ2oZqEmhxCTYiH4u/IlatRqd8STsZQnVm8XYrvotsuxyZ8uZCncT10YvIgUfnkqwnMZtPagmqGBTQP5V/Tyj/d8CLghPLc8Z3Jo3JcQW/4dS8RdhBbtHfWlEMAA9mDga+0I1m+XZ0cq7atzU8VziSkEXpBu/jPMvtgpVR+xq6hwQBWcp8ni96Oh6xWTIivm16PohjkwzgaXqubT06hR/RERNkek+4Z9/SyRM+A/vIMLBjf2Z5HcPzMVbFGOhUjHGW9LEF/fuIdD2yXLDZFtBHroCX8Hd/7kiqvRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Sep 09, 2024 at 11:19:30AM +0300, Kirill A. Shutemov wrote: > has_unaccepted_memory() has the only caller -- cond_accept_memory(). > > Remove the helper and check zones_with_unaccepted_pages directly in > cond_accept_memory(). > > It also fixes warning with clang 18 when kernel is compiled without > unaccepted memory support: > > mm/page_alloc.c:7043:20: error: unused function 'has_unaccepted_memory' [-Werror,-Wunused-function] > > Signed-off-by: Kirill A. Shutemov > Reported-by: kernel test robot > Closes: https://lore.kernel.org/oe-kbuild-all/202409061101.Jlx5z2fI-lkp@intel.com/ Reviewed-by: Mike Rapoport (Microsoft) > --- > mm/page_alloc.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 91ace8ca97e2..7fc5af7cb387 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -288,7 +288,6 @@ EXPORT_SYMBOL(nr_online_nodes); > static bool page_contains_unaccepted(struct page *page, unsigned int order); > static void accept_page(struct page *page, unsigned int order); > static bool cond_accept_memory(struct zone *zone, unsigned int order); > -static inline bool has_unaccepted_memory(void); > static bool __free_unaccepted(struct page *page); > > int page_group_by_mobility_disabled __read_mostly; > @@ -6975,7 +6974,7 @@ static bool cond_accept_memory(struct zone *zone, unsigned int order) > long to_accept; > bool ret = false; > > - if (!has_unaccepted_memory()) > + if (!static_branch_unlikely(&zones_with_unaccepted_pages)) > return false; > > if (list_empty(&zone->unaccepted_pages)) > @@ -6997,11 +6996,6 @@ static bool cond_accept_memory(struct zone *zone, unsigned int order) > return ret; > } > > -static inline bool has_unaccepted_memory(void) > -{ > - return static_branch_unlikely(&zones_with_unaccepted_pages); > -} > - > static bool __free_unaccepted(struct page *page) > { > struct zone *zone = page_zone(page); > @@ -7040,11 +7034,6 @@ static bool cond_accept_memory(struct zone *zone, unsigned int order) > return false; > } > > -static inline bool has_unaccepted_memory(void) > -{ > - return false; > -} > - > static bool __free_unaccepted(struct page *page) > { > BUILD_BUG(); > -- > 2.45.2 > -- Sincerely yours, Mike.