From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76AC8CD4F4C for ; Mon, 9 Sep 2024 02:57:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B4FF46B0107; Sun, 8 Sep 2024 22:57:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B00256B0108; Sun, 8 Sep 2024 22:57:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9C79D6B0109; Sun, 8 Sep 2024 22:57:12 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 7F2A36B0107 for ; Sun, 8 Sep 2024 22:57:12 -0400 (EDT) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id EE66CA0B28 for ; Mon, 9 Sep 2024 02:57:11 +0000 (UTC) X-FDA: 82543688262.22.4C5F17C Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 23A2DA0002 for ; Mon, 9 Sep 2024 02:57:09 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L7/xVjOx"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725850548; a=rsa-sha256; cv=none; b=a2jaE0mHev4/Nw+OuOaHJdiGTuVQ8P4w8IIBi+R64q7tSbol8TbxstvIGNt1Y7r/oX7a5c UGKfOMT6QhjcQ9+B8RDYUE7myXUmNwZoT8P2KruhJjrDyOmBFP45bJ1/1R0aeX9lz3Gy/o 7gYdOwRLOieodU294mVNRB+vHo2nTHk= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="L7/xVjOx"; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725850548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=auyTagAR38/zXhvomOHgx5kToruU3DjXNgh8gDAvr98=; b=4reOb7CslvVp4zKLVtCmpGpEk5b7z7+YuA5rCemIWdH98NJ7rBePW8MMzzZEGZiRXSc/BB QKXRq/VgwGIk/hxqFMIwXXOrUdm2MdAz4WRo1GvKTDZy0VpA+G16xyoYQVs/j1DaAZUZcn neqz/XCwLRJh3/RDzxpfkqdcNZOQ60k= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725850629; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=auyTagAR38/zXhvomOHgx5kToruU3DjXNgh8gDAvr98=; b=L7/xVjOxeUo2C1MH73OWOEH3pZBGPcWadr5aHZrLfiuYskCaYYT4eKX+74Mbr4IHzSU4AS phV5rP75AMH+3xx8Rs4wWhpyaVPQLAluYKYoBjSKM7m+YRrAIrjLyZTWwLRytuEFvoNGGg 9mMN9tEWIYi/CRsKxZCmrNiJsSYBK9Y= Received: from mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-199-pGVghPk5NqKckzPzmSfDCQ-1; Sun, 08 Sep 2024 22:57:06 -0400 X-MC-Unique: pGVghPk5NqKckzPzmSfDCQ-1 Received: from mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.12]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id DAFF51953954; Mon, 9 Sep 2024 02:57:03 +0000 (UTC) Received: from localhost (unknown [10.72.112.58]) by mx-prod-int-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 4140A19560AA; Mon, 9 Sep 2024 02:57:01 +0000 (UTC) Date: Mon, 9 Sep 2024 10:56:57 +0800 From: Baoquan He To: "Uladzislau Rezki (Sony)" Cc: linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages Message-ID: References: <20240906095049.3486-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240906095049.3486-1-urezki@gmail.com> X-Scanned-By: MIMEDefang 3.0 on 10.30.177.12 X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 23A2DA0002 X-Stat-Signature: i411jcnc3e51g35utjw6de93osiekfq6 X-Rspam-User: X-HE-Tag: 1725850629-518946 X-HE-Meta: U2FsdGVkX1+Vxb5WdkwRHK8N0B8uPBh7h+kgdCRoqrkUg7jJ3CY5f1b3AQX7YqzwigfPW6SON5KdDLPXG18sZkxzK5mEY6InTnJd/4rYVzLO5KUdk6zpR/UHhPcEhUgIQd2uO3/iOOa65GCfFDzM1kxUISRqVo86D3iWOkQnXymkZjnzIySMoQ+9WBg7KwvKZasMZn6AuDsHwyR8ccd+WdehBSdcBNUDWvXsnchcqhe9wAT66kfpjuW4DJny2DSPYqw7537K3Orlo5Q74ZIifzOPIm5Ub9zrMnsUJvhdV9s5zOAKIu183xQSbc3fbH1ZcHfNWidzeyIxELTP46p4HvXHzpL/+adA2EJkZWGDXHphGkKw4nAb4bA2TnlC4pU3+OzaoZSS9tgLFmsDUKTs+OxnDLKXSuoWr18YBzDqGmmYKGVXiikHQWpc78T94kt0rjLPkUuYkisYg6t0SQFxWpfjtlNCzCGkEra4+lpDNC3Y7cKGIP9Hi8Ihg+V2nie7lxgx+k4fuiRCfZyEczgel23ynn+PLMpvCmjF9mFUpiPryOok8SMFrDLR2GtOTgbj66SRxCR6X2psa4NoryTPAZruXbzMDRICxisKlRdwt/hNx+TG0NcQv9DlsuhNds6G6w0XHbbFVriCH1qfOpjd8E55R8+CsdF0VsScDhuucA5LQnHigWkAEdCTolpcsfkWRHXNjW7osYySvmY13FUWibwDFKFPDwpmKKDYQ+FmNIuuN5ZTs/kynYrqZAVMKRD6Ij/cjPXhmm/LlipTPkegPPAd/XeTIpRHHfbWEJ0Lh3+rLWXFN+dwpyNeaXcd34emrxj2SpsBDPKtv0sscPrXvMDGT+9EDsyClkA7FO7W05p1uN3Zd8DpNocQ2q1ayEojh1wuxHv7ZfL7pAemsl96AEo8Du36An7WqkR6E/mc8kHWMNKpyKzwS7BuP70OE2HzI8zIgiCGdOvG39D1Ggo oGI3JxBt Erwu9cKWvlrioVqzVgz1wPz0AcHDVsf6s8vokxl5cGgzL+/Y7/OKXyNnqtGSdIuF+4Zqwum1Y5HqF5B8sdtb0+jnBajymfVVPBOKn2V143EDLTPyOYz7j5V65dWGZAp2WVLbn9cW+Yy+I1R2bjzIjJeMemMWcF7gfe0I9x/H6tiVN6Sy0CkYIp+3EZc0S7zDtrNiyjl+2RW63kx4ABN+67FON3sXT0s4151mkwoL3zkOGDFZJ4fWL7mXFkJWws1qFmYd2nLjn68xDI8JxJv/Euuf57AE7/SnofybMMhxrebqhyUbhpJD9h/ZK1wMKUoFWI8GgLezoYqNjseNU4dQGBaJz/+0H3npR0cFM0r/rhF7isT2stKkkQInxJDHyto17EjRRDcrOAUISa/Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote: > In many places, in the comments, we use both "higher-order" and > "high-order" to describe the non 0-order pages. That is confusing, > because a "higher-order" statement does not reflect what it is > compared with. > > Suggested-by: Baoquan He > Signed-off-by: Uladzislau Rezki (Sony) > --- > mm/vmalloc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) This looks good to me, thanks. Reviewed-by: Baoquan He By the way, do you plan to clean up the rest of them in other places? > > diff --git a/mm/vmalloc.c b/mm/vmalloc.c > index 37b6e987234e..c7bd8740b8a2 100644 > --- a/mm/vmalloc.c > +++ b/mm/vmalloc.c > @@ -3590,7 +3590,7 @@ vm_area_alloc_pages(gfp_t gfp, int nid, > break; > > /* > - * Higher order allocations must be able to be treated as > + * High-order allocations must be able to be treated as > * independent small pages by callers (as they can with > * small-page vmallocs). Some drivers do their own refcounting > * on vmalloc_to_page() pages, some use page->mapping, > @@ -3653,7 +3653,7 @@ static void *__vmalloc_area_node(struct vm_struct *area, gfp_t gfp_mask, > page_order = vm_area_page_order(area); > > /* > - * Higher order nofail allocations are really expensive and > + * High-order nofail allocations are really expensive and > * potentially dangerous (pre-mature OOM, disruptive reclaim > * and compaction etc. > * > -- > 2.39.2 >