From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DC4DCECE59C for ; Tue, 10 Sep 2024 00:40:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7099B6B0257; Mon, 9 Sep 2024 20:40:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 6B9C96B0259; Mon, 9 Sep 2024 20:40:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 580F46B025A; Mon, 9 Sep 2024 20:40:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 34A106B0257 for ; Mon, 9 Sep 2024 20:40:57 -0400 (EDT) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BCC6A4128C for ; Tue, 10 Sep 2024 00:40:56 +0000 (UTC) X-FDA: 82546973712.28.12AE216 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf13.hostedemail.com (Postfix) with ESMTP id 0B5EF20004 for ; Tue, 10 Sep 2024 00:40:54 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DsQDtm9K; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1725928752; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZskKqrKp0wbir+h8HFNXShTsEGcgzC7sQ4EikqVlHM0=; b=s+iddlDD5UaimW7Yji3QmYy/QxUHnF+EEOYDK9v+c4l6Zluh2CqWaCa7CAhUtOmgOjQtjk mpsDaGwPkH/ntSXJO+WYCfCRDHarZgs1P13FulBbk4Qhed04bDl13D30UmXv36Od1utx/e v7pKQaXllaudlH5MDTC2B2nJR4q9h7Q= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1725928752; a=rsa-sha256; cv=none; b=c4yoccCobMoNSElf/gn2q4/mMT8EPYxRcO4B79NZFWNqpXK3r/TMPMn4hf0KddY3h+Dwo8 0KoYEpvTiGYAqb9+L+wLepODqniaDgZVoeJOvtBeoOvE+raJ+wZUoX04W5Qc+wOCd/f6H6 WgCkA6VBL3U9G1w2/SYM/OS11q4qAtY= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=DsQDtm9K; spf=pass (imf13.hostedemail.com: domain of bhe@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=bhe@redhat.com; dmarc=pass (policy=none) header.from=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725928854; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ZskKqrKp0wbir+h8HFNXShTsEGcgzC7sQ4EikqVlHM0=; b=DsQDtm9KY500njjGCEBIlCmeM/YJaNE4a5P84TPjWHv4YotRjcoo79HN+6KLf38hClBjhd l9VNKp26yOl79zRPeMHf1Ip5Dw3q/dS7436vJIw3kiJdrRECi8IUYofup/QmO91cbMSyeq ya62aXZ/gigDcAFnjZkhUUQ+UaImto4= Received: from mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (ec2-54-186-198-63.us-west-2.compute.amazonaws.com [54.186.198.63]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-61-lSGu7297Phyw44JRTjrQPQ-1; Mon, 09 Sep 2024 20:40:50 -0400 X-MC-Unique: lSGu7297Phyw44JRTjrQPQ-1 Received: from mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.17]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-03.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id E58BC19560B8; Tue, 10 Sep 2024 00:40:48 +0000 (UTC) Received: from localhost (unknown [10.72.112.58]) by mx-prod-int-05.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 6C5B019560A3; Tue, 10 Sep 2024 00:40:47 +0000 (UTC) Date: Tue, 10 Sep 2024 08:40:42 +0800 From: Baoquan He To: Uladzislau Rezki Cc: linux-mm@kvack.org, Andrew Morton , LKML , Christoph Hellwig , Michal Hocko , Oleksiy Avramchenko Subject: Re: [PATCH] mm/vmalloc.c: Use "high-order" in description non 0-order pages Message-ID: References: <20240906095049.3486-1-urezki@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Scanned-By: MIMEDefang 3.0 on 10.30.177.17 X-Stat-Signature: 6t1xqefcjpebdeykqn3o4njnwd6uncrf X-Rspamd-Queue-Id: 0B5EF20004 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1725928854-644384 X-HE-Meta: U2FsdGVkX18AAP+c15Xi6Cz/iDrOIA3iz3LbVYCqVKDsJat5vtipzzZf6tgsFmlJ5V86YhO07ijFwrth6Az68mJ7UWG7uc8iH6+KFUKXct+bmlgB+YysByb+HJtB3iP1cg5gcq+T2lNb+pF0O70OYXTIHyJqqd3wQLvFfJZYslGy6NAKH9k9SxE+S8R1EHYcMeAuTOivA6GoKLKoxdVijjvLgpcjyxQ0vYleVbPjn9zrYOFEEA8+kKB4LYRS7s9Y3T9BXVRmNul5lyVyqJojMdvZrdNGbcjzhic0awwdYrVUoxJroIyrXb/lBG3x52DnNof5VTbB2RchTGPnNa4gNKmzdIyHV+9SjjppKmmA0hb3sRKsKAOJkye/srjvCvm1dVH4qC0EOY2mMYBpmhHGkaoQlKWwj+shANaoVA6liqUF6bFrP94POQzG4LFFVvRKZic9WuQDCu6mKzYdkPLSwyWLmyrphCaOdDrM6DIlvY4rr5X+C3Uni8bo/BLpZeiLFHBUSjXeuZdgtiAsosG51al7srw4k/YSMZ7OnL7FHJpvqo6zk7Bkl3ygIiWZuQD39RgN5x6FEdojeoXvI6YNrwEL4LOQxIA8/GtTEstrhn74w8tyYsgNdCY13YaTV/vRLkEzSVq3ntXKLHGnO27qBxWHoJgPTWRdCl/niTEKk5Rs0rjSasjE2L2qdX5NQhFSRlwt0f+Sej18iXbHCB3WdzTSJeyWoZ/hkEHbzgKf87ZSw+/2TSouK+Pr3utJLsbAFN2U2MhktGhhaNatKG/nG0j0bMJC7hXF9v037UPK3A0SKI9m0LnGHtCj9LClf8HgWbl22AWdcFjgX31WPemRoK1gv2f9Cp5rmlIDbZkDaD3522aQmRxQ3sV3arq3OkBybDCOiB9H3XKOf2J/9r/9+xFa36CHji+z7mURwP7gJ1ymu2vX8BL3IxRk8VGIRQgQIWRdE/ZzOBXJFLhe5z0 Dtq6ju+5 DCYqVrjIhUMIDa5kzxIxJRmis2ievp+e9tSpMgdZxxVLBIaIJhixkt3VWXs2Z2OFc4eAwnoWOjceNLw3b+Rhqhf1aq9JYVQIcu/fbDNrw4JLgVoKULbITguf/TbOBMlaeC+LIaqfLUOPX+c68fJ/FcJ8bjgq3Y2niLqRu9tdewJQVgb0qQmf7JlhTIZ1PW6QB7M1zYBRTZNIvZiQ2GOVZwTJRfshapEwGkdkbLOMyupqoXdIrK949igkc55fK2Qo0paPjZLwXqcsElcq3JFyhHl+cRSR7xkvp8x2bXoY2YEQxfRYdwqqMcyiMfv3bmnuAq7eu7Rm4h/jE8AhAClMoVsp0rKXCylVsfTSpHM8Kas8S4HEARqOz4ESR3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09/09/24 at 07:52pm, Uladzislau Rezki wrote: > On Mon, Sep 09, 2024 at 10:56:57AM +0800, Baoquan He wrote: > > On 09/06/24 at 11:50am, Uladzislau Rezki (Sony) wrote: > > > In many places, in the comments, we use both "higher-order" and > > > "high-order" to describe the non 0-order pages. That is confusing, > > > because a "higher-order" statement does not reflect what it is > > > compared with. > > > > > > Suggested-by: Baoquan He > > > Signed-off-by: Uladzislau Rezki (Sony) > > > --- > > > mm/vmalloc.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > This looks good to me, thanks. > > > > Reviewed-by: Baoquan He > > > > By the way, do you plan to clean up the rest of them in other places? > > > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher include/linux/vmalloc.h > urezki@pc638:~/data/raid0/coding/linux-next.git$ grep -rni higher mm/vmalloc.c > 493: * nr is a running index into the array which helps higher level > urezki@pc638:~/data/raid0/coding/linux-next.git$ > > What am i missing? Didn't i do it? Sorry, I didn't make it clear. I meant those places other than vmalloc related files, e.g mm/page_alloc.c, there are a lot of [Hhigh]er-order mixed with high-order. I can continue the cleaning sometime if it's not in your TO-DO list. mm/page_alloc.c:551: * Higher-order pages are called "compound pages". They are structured thusly: mm/page_alloc.c:716: * of the next-higher order is free. If it is, it's possible mm/page_alloc.c:720: * as a 2-level higher order page mm/page_alloc.c:735: return find_buddy_page_pfn(higher_page, higher_page_pfn, order + 1, mm/page_alloc.c:2750: * split_page takes a non-compound higher-order page, and splits it into mm/page_alloc.c:3587: /* The OOM killer will not help higher order allocs */ mm/page_alloc.c:4811: * within a 0 or higher order page. Multiple fragments within that page mm/page_alloc.c:6516: * page allocator holds, ie. they can be part of higher order mm/page_alloc.c:6790: * Break down a higher-order page in sub-pages, and keep our target out of