From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18B24C5321E for ; Mon, 26 Aug 2024 16:48:36 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 930CF6B008C; Mon, 26 Aug 2024 12:48:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8E07E6B0092; Mon, 26 Aug 2024 12:48:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 784AE6B0093; Mon, 26 Aug 2024 12:48:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 574916B008C for ; Mon, 26 Aug 2024 12:48:35 -0400 (EDT) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 17E47C11B7 for ; Mon, 26 Aug 2024 16:48:35 +0000 (UTC) X-FDA: 82494980190.24.BABE737 Received: from mail-ej1-f44.google.com (mail-ej1-f44.google.com [209.85.218.44]) by imf10.hostedemail.com (Postfix) with ESMTP id 0D02CC0003 for ; Mon, 26 Aug 2024 16:48:32 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=SBPpfXvy; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724690827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=p2US3quHF4FGj36QLp9HjPVeknmBzXwXeyiUwSXj0dY=; b=uhAUbXDw1dnJzbqXHO/B2G7x08f9JYMOheQmfsLRf86kZA3KLHRlLn6DIdKquho8FPMsos Vl+L1B6j4+G2AibgaplwA2RC8VSTapFpj4qznqpYp1lEJuDFVJpv0aCPV5sHRIjfoyaXTS AFqwL9l37VsVv+LzEaNm+NYMNFrD2aI= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724690827; a=rsa-sha256; cv=none; b=08mZi6sDwWnfYHuFxoD9Pz8l6iqY6cYDNll0bXDl4mKWhBoql9xR1sr0r/s18I6LEpLBNN EpSbUExl1X4vrRpIroaEIEGQAp3pQtnaivDMHvYY6QRPxen0tD00Yj2yHxrAeTOip58hoV PFNRmYWOLVj9wS4OZqOreQaxOFf8aFY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=SBPpfXvy; spf=pass (imf10.hostedemail.com: domain of mhocko@suse.com designates 209.85.218.44 as permitted sender) smtp.mailfrom=mhocko@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com Received: by mail-ej1-f44.google.com with SMTP id a640c23a62f3a-a86b46c4831so260428266b.1 for ; Mon, 26 Aug 2024 09:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1724690911; x=1725295711; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=p2US3quHF4FGj36QLp9HjPVeknmBzXwXeyiUwSXj0dY=; b=SBPpfXvyMV5oII4vx1vWv8XRBS8f6bzGtMCGtpeuqQ3fy9mOvAEUy1R40M+pluVlvk 4av9Q6/DWV2r9cKtunHoyeSIa1LEURvxHTKp4dDTVEo74ShI6cNzgirb1AV9fqpT2jQ4 kc9l9GsnwcJvBTO7fftk1cSY1a72od6m9YfP/p4i+j7EvrpHJX+a0yzxTX6hgmGGuNZB 4mgRP6VlMrINJdUSWu1UmuHKc0hDNY/KIXVwR8j0rS0P8mpk7ZRquF4t6uXzz6P6g5Bh EnuRSLjMycWP4whJisdyHbpKbT/ByYcLHuVAZK9DNWWitPG0bS62F/AKNojredtcOlNj xOJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1724690911; x=1725295711; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=p2US3quHF4FGj36QLp9HjPVeknmBzXwXeyiUwSXj0dY=; b=jsAhWiY0OUq6ZD5rEvNz5qo4kpiMrEsBJsgjsr5Ht/ERwC/rObUnF+zzocOq8YuBPi nNrrtiAH7Fh9p70byudT/YmayNTvEJGxraJLyNQpz1IDRf/eEni/r4k3DOTVjUJFj2YC FTn+4+NJ5XzgFDFgVGv4fFMMW3is9s6AL5GBXzSgtZhql9X/ocgZ62R0OfYncKDBuEyJ iW7KqIKK3Vu3mOg9XVJHpavWrGifdfaOBYQlEzyl9ffw6JJaSSXj3joZd4SgGxhvlO7C tWzsNKYy8ZcpIKPhyJkLf3YUkVwlKKlELYhWGlw+QJMtp/na+m2tO19xVj+6saqqgl9L MvBw== X-Forwarded-Encrypted: i=1; AJvYcCX9NMTt7UX+hY++REbmj5A88ZCqk99AsV0RRnsFRh1+XZvb2BhdnBva2yusgYKBKf+xlt6q3/yaZg==@kvack.org X-Gm-Message-State: AOJu0Yw1Ou/Yb5YZjvKKlOnphXOLKcElilf7w7sbdKa6Jkw7pTT/mXV/ Xp/mVFx7j06sl0dvJEPdWcMaHiVYNGFQp/clLm/j6V4ABZ9VIBLcW5wYfRfNJcs= X-Google-Smtp-Source: AGHT+IG4RhYrAmiaKC8by+8hzzm8ayqsOf70yu/Jj7guOgp1pyGhZgvl9T107oQfHo/SuMj/vaWTvA== X-Received: by 2002:a17:907:9816:b0:a7a:9f0f:ab2c with SMTP id a640c23a62f3a-a86a52c71f9mr684278266b.29.1724690911285; Mon, 26 Aug 2024 09:48:31 -0700 (PDT) Received: from localhost (109-81-92-122.rct.o2.cz. [109.81.92.122]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a869cdd4ef4sm567776066b.166.2024.08.26.09.48.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Aug 2024 09:48:31 -0700 (PDT) Date: Mon, 26 Aug 2024 18:48:30 +0200 From: Michal Hocko To: Matthew Wilcox Cc: Andrew Morton , Christoph Hellwig , Yafang Shao , Kent Overstreet , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Message-ID: References: <20240826085347.1152675-1-mhocko@kernel.org> <20240826085347.1152675-2-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Stat-Signature: y3gqiny4an3nh8n9zgyziacixq6q3n6a X-Rspamd-Queue-Id: 0D02CC0003 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1724690912-479051 X-HE-Meta: U2FsdGVkX18sduj3QDqvqPBtyIE8BZX5X/kylNLTabk7SJ6bctTgHWnWZgS5Vn9cnoGdpbD2B+Rbcdj5fsMOKpoYEijb5lOZIv3DnlhUB+Q970yjlzVR6elVsTpGzrVo2rBByS6pZHwWjctOAKrGCJ3dx29FhtmlKmyaXvzW5jjSGXrnwgk8QLpDEFJjf5xf6MU74b0QtIsD3WuCK4PLG4IAWOEVmjTAblpuz29ikHSCmtmmNAY486UM0Oek356PsiVGgOnAn8h1noo2ZhpLkSAGOV7OuQcWFPJxL0H8FZ0zpXNtZYEawuiWk0MpsZZD+lua1iI8syt22TAo8AMHvFN0nn1nc49YSxMQiHcawk6i71sszZIfx/raKVnSDXghNE4ufQYnAMhwL5SgFRvWHJDGniyZsDjWBN7JKFkvVKmXqscGUgiDjuwyB5J7KAeIW5wCmfF2RU7OkZ4vbPH/D6GvQjVMOiktobdQLJu7EbErRvBCaMT2szJA1a008IARN3CfUJzsSrzTOvlsXfsfqXouehjMyBKHRC2pwLTBEMjQZGIHjm3nJSLIEiYn3ch18Q5p+PzssPd7E6hNJxqvky28837VMAeR7feFoZiQr7vEVDyjdPUkjz3m7F1uQ4SUynWrL6xhMSSmiNX/QjJP/Ix/I6dVrHiQbxfJEqmjG23Gte7XkqZdo7rRNc6bumsl1Wp+Pl3x7DTxX9FJcYDQVapCeFk+kuKzvRKN8NaLTY3Tvgdz9wcpxwhfIhrvRjovnBWrJUAJ8VZKG+K2sRA2PwZpB1N45jaZUJQYFyfJviRH/OjG0Xe85RnrpK5je2I8pwMpmouewi536+xpfSE6fyUQRudgUTXW4wJKM1wZI7Fe0yPtCKN8V3xDpMzao6wGqKF07TI+n2nUWbR/GB+kCM5g4qDpcij9WGa7mDmHtA516986CJ3QZPPzPAif4DMN2OYGFI6tmxoDAg94qV9 mcA3Sdkr R3ufH421W20UlbH0bpRLw2bJWDAKltbPNBqgOz91zblvGQ/YwXw9rvpZ4AOioNQMAK2ihGX4kkJYXVdvHw8LzZLnKXRjHOCUeYPtSn6+ryr1ECncwk2/ut2c//88a41ZM4v3JFyHYDgcwlThJsDjo6GLR+cMkQx2/eZeU7pkRKQlFBMmzW4TnLibYv6djRIqTfYHlC+vEgnSz81HAJEeNLPwGk8msJChehmioLAKReis7IfYlEnDr6atzLTquokbWpCCBV98Nby6tb+RqFApzsNpAtuj/7FN5TZ9m77teeqp9XgFHw+Fuo4pKK4JcHoEs5S1l1t6w8/Y0RB8J1VyFEc20HtoHurl6j69FTMeKN57BdUm2rBfBuI9huvGmlWzODaB8+8XwdlNr2d4JTiLGr2lCPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon 26-08-24 14:11:39, Matthew Wilcox wrote: > On Mon, Aug 26, 2024 at 10:47:12AM +0200, Michal Hocko wrote: > > @@ -258,12 +258,10 @@ static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c) > > */ > > static struct bch_inode_info *bch2_new_inode(struct btree_trans *trans) > > { > > - struct bch_inode_info *inode = > > - memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, > > - __bch2_new_inode(trans->c)); > > + struct bch_inode_info *inode = __bch2_new_inode(trans->c, GFP_NOWARN | GFP_NOWAIT); > > GFP_NOWAIT include GFP_NOWARN these days (since 16f5dfbc851b) Ohh, I was not aware of that. I will drop NOWARN then. > > +++ b/fs/inode.c > > @@ -153,7 +153,7 @@ static int no_open(struct inode *inode, struct file *file) > > * These are initializations that need to be done on every inode > > * allocation as the fields are not initialised by slab allocation. > > */ > > -int inode_init_always(struct super_block *sb, struct inode *inode) > > +int inode_init_always(struct super_block *sb, struct inode *inode, gfp_t gfp) > > Did you send the right version of this patch? There should be a "_gfp" > appended to this function name. yes, screw up on my end. > > +++ b/include/linux/fs.h > > @@ -3027,7 +3027,12 @@ extern loff_t default_llseek(struct file *file, loff_t offset, int whence); > > > > extern loff_t vfs_llseek(struct file *file, loff_t offset, int whence); > > > > -extern int inode_init_always(struct super_block *, struct inode *); > > +extern int inode_init_always_gfp(struct super_block *, struct inode *, gfp_t); > > You can drop the "extern" while you're changing this line. OK, I can. I just kept the usual style in this file. Thanks! -- Michal Hocko SUSE Labs