From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8672EC5321D for ; Mon, 26 Aug 2024 13:12:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AD49F6B04A9; Mon, 26 Aug 2024 09:11:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A84AF6B04AA; Mon, 26 Aug 2024 09:11:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9257B6B04AB; Mon, 26 Aug 2024 09:11:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 73D8F6B04A9 for ; Mon, 26 Aug 2024 09:11:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 29975A0F01 for ; Mon, 26 Aug 2024 13:11:59 +0000 (UTC) X-FDA: 82494434358.17.9E208F7 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf28.hostedemail.com (Postfix) with ESMTP id 85F92C0026 for ; Mon, 26 Aug 2024 13:11:57 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kcRs0Up6; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724677822; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=CnEqIrJf/5Uvl3Jm/q/BrEQtwg9oxHJd/L725YJbtSg=; b=sO3QEF4fDZeRiixUGvm8DhKNo9sZCvuB2W0dsivWKdUorCm//aL5CkE8b/oVn2CJye/oDk fVIsNuV9JPRf3wLyNQn3ijxSKGHKSKfrZGWhfk0h7EwIs9tT/StqEyushgeg6SeDGQiKX5 pbW3VOca0a5wjdrajFlwjl2XqJJC9So= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724677822; a=rsa-sha256; cv=none; b=V+bVjAAJutvKVkpEj2BrsQvg9JpldR4/PGlcIR+kp3JJMgCn1wVCJ69wZUmLoQzFp4Ief2 B9ngXRqQVzUvs5cqGpY0y4hF7b7CFz8UBNJuVH3j2oIe4MJlKF9AsBERph6UoSqfGmVxIz yXbPpP922nAKoIjCGKR+MlMOXwzkmL8= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b=kcRs0Up6; dmarc=none; spf=none (imf28.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=CnEqIrJf/5Uvl3Jm/q/BrEQtwg9oxHJd/L725YJbtSg=; b=kcRs0Up6Cpe13NcGd7CsxcTXEg wfUx33ph4ytvCOW5PBAgqcDvh4o1EGSJoK5TGxQCgPNeuG/v3D6JkU/rF2hdYZcbDhu6XmX0Y461C LZZ8BwGkStTknZyAzOa9dQgtUckbdxeGFNrcU3twnz5o7iteGmZ3xjv70tJkt3u7oT/lbuXQlLbzO oSF3vL64NTiTdj3Z70gPw8W2W86zGz3Rd9OF/5fwwtq68NRPdXcEq+NKFk1zhI15jjtzu+HtZn8pt H5KbjDahvkUiYuDiMfOr8HwTsFriXnImrEp4FssGplhuGTpXTswtIQPfYPK+il474iHx5lr1OO8mC ZMNhtxgw==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1siZVT-0000000FQMj-2njG; Mon, 26 Aug 2024 13:11:39 +0000 Date: Mon, 26 Aug 2024 14:11:39 +0100 From: Matthew Wilcox To: Michal Hocko Cc: Andrew Morton , Christoph Hellwig , Yafang Shao , Kent Overstreet , jack@suse.cz, Christian Brauner , Alexander Viro , Paul Moore , James Morris , "Serge E. Hallyn" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-bcachefs@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Michal Hocko Subject: Re: [PATCH 1/2] bcachefs: do not use PF_MEMALLOC_NORECLAIM Message-ID: References: <20240826085347.1152675-1-mhocko@kernel.org> <20240826085347.1152675-2-mhocko@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240826085347.1152675-2-mhocko@kernel.org> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 85F92C0026 X-Stat-Signature: 5ufzz68f95k4wh6oq7sq9d4rjdw4o6i4 X-Rspam-User: X-HE-Tag: 1724677917-82646 X-HE-Meta: U2FsdGVkX19d9U/2Du3jXIjvfjOcUibfRla8wjfyLH6n6WLQwjmnB5jajYcPC24cYpqAbVn4b/1KfJXDz4h1c06Qy6M2+k5G+w29g0FNw1DkbZwvZiKHYaYuOVa8uxeZxZYm4VYcP0MLJ7Am7vmT/2LKpu8k2eSuLw/7/NAuw3kqrMrotRvdbqTriM0rQaq+IKR2iVERDAUAsvYHfxQcUV5ub0mh8bWIPpEeI31sNcjFpFaraxCMc4Q35wixWfvpUoC63HzlirJnpNKJnD7YEBd85V0wLgUXMTxdAbNAmmfPypuePwnvE5csBNT4YLRNRO4dAXAIwJp3C6aQ1GR2w/y+ZcrZjnMREA+O/y1gQri3UrHcVjUwf3HKLV/5WHO1DNLTyQWrjMJ7L1E6GSMCArtLWxyCFhqisHM7z1vvyDgdThLgl4zIsqWJnRihPH6VxxOtvPca7OqP9BJy++vwmMMTtk1H8FMWCf7e8vqrwvpsOeMVr7TFISfvNgci8Q1Ajug6VrcpWHfKKNg0uJvbhzKtlE+DVag81IoTPL1hMk3pJ00A81x9s4dzJ0LK8qvxSO6/ol+JoodU2DOPQxW0ZgYHa3bPoEMnK6x8T33WDMPP0HGH0WyifNmYxtwB8H1ZzNohuJ+QXDVEoaTtQsdZSw6Djzb2UYhXrmx6tD4lGBI6h3lSlyS5YmOUvKG83bO175VXDkU5uinn+eNWlSjmZ/yQlnWbSeVSgnnhEYzaHbK+6i/wawGEzoisb4Yjaga7lhMGfa62gP7a/QBWTFkFAN8L2EMOWtoRWWmBMNpMZ0j6gEzjR96STInMg+bzcWSQjfW1f470w6TRTL2rNx7YvPIWnofRyTfNFqYfacMLl2yjE4sA1HiI7vOoX3HaExv0lm/wh55/zN1QFtz7CXy/4Cbck5Fe+YHP9L7RVSlnGJi97Dr6br0bzqm8A5AU8LmEIPusXPLCFXWtb+gLv/Z 6zNTjdG1 WwRoxaSsLW+sHDjDp6GGSLhdjHxHQahNBwaMotSn1YF0Dq9z53xro4vPzTNLkVgMQEbDJvWe4a4Fv9D5ZiVaBbS6uIsrXirZmPr5jo/q5zaXNgLVerWXlz57eZw2u4i05imhVUrRhp17+2BZ/GJpp3ZZQkKTBDfWINOiFkhnO/LhZONBDFjLXSzjEP4pbt6caDbHEeJ/1vp3YhhCXTANIloJdVr9bbqnPCs3EpP23+3A5YKuq2POIYI6bZS09Nd/n442+7vb1DDjjGzjCkTSJu125Yijkjk+ngJDCEbMqyG2nrZuz9qrF7QZ5Rty/3ABLE2oxqGFzsrYw11k= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 10:47:12AM +0200, Michal Hocko wrote: > @@ -258,12 +258,10 @@ static struct bch_inode_info *__bch2_new_inode(struct bch_fs *c) > */ > static struct bch_inode_info *bch2_new_inode(struct btree_trans *trans) > { > - struct bch_inode_info *inode = > - memalloc_flags_do(PF_MEMALLOC_NORECLAIM|PF_MEMALLOC_NOWARN, > - __bch2_new_inode(trans->c)); > + struct bch_inode_info *inode = __bch2_new_inode(trans->c, GFP_NOWARN | GFP_NOWAIT); GFP_NOWAIT include GFP_NOWARN these days (since 16f5dfbc851b) > +++ b/fs/inode.c > @@ -153,7 +153,7 @@ static int no_open(struct inode *inode, struct file *file) > * These are initializations that need to be done on every inode > * allocation as the fields are not initialised by slab allocation. > */ > -int inode_init_always(struct super_block *sb, struct inode *inode) > +int inode_init_always(struct super_block *sb, struct inode *inode, gfp_t gfp) Did you send the right version of this patch? There should be a "_gfp" appended to this function name. > +++ b/include/linux/fs.h > @@ -3027,7 +3027,12 @@ extern loff_t default_llseek(struct file *file, loff_t offset, int whence); > > extern loff_t vfs_llseek(struct file *file, loff_t offset, int whence); > > -extern int inode_init_always(struct super_block *, struct inode *); > +extern int inode_init_always_gfp(struct super_block *, struct inode *, gfp_t); You can drop the "extern" while you're changing this line. > +static inline int inode_init_always(struct super_block *sb, struct inode *inode) > +{ > + return inode_init_always_gfp(sb, inode, GFP_NOFS); > +}