From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 291DBC5321E for ; Mon, 26 Aug 2024 09:07:35 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1B496B04CC; Mon, 26 Aug 2024 05:07:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9CBB46B04E0; Mon, 26 Aug 2024 05:07:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 86C026B04E1; Mon, 26 Aug 2024 05:07:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 68D806B04CC for ; Mon, 26 Aug 2024 05:07:34 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E202F160DDC for ; Mon, 26 Aug 2024 09:07:33 +0000 (UTC) X-FDA: 82493818386.05.FFD9D6C Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf20.hostedemail.com (Postfix) with ESMTP id 1C8711C001A for ; Mon, 26 Aug 2024 09:07:30 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=QcZNv2yU; spf=pass (imf20.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724663165; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ocYxyao+YeYVwZkJVZlNCDBZUEKM/vUAfandsZETTJ0=; b=HXGEbc3+uh0nH9QVgmbVoeWHf7QC2w3tVsOkJGmPLaR39juO844pIMBn2mIYt2UGL9kn6J uFI1JSLG30qtTKu9mDXXbqC1+dcS8JN8QvhaDH7T1LQg/f/um3gPK8hMZ+g0Q+ibhZeMtB 4NeYvcJfI3tKIpLw6MhfNL8YUKsJDrA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724663165; a=rsa-sha256; cv=none; b=auyWBu6/8pRABNNoH4QLxKdwVoxQM3V24IoAXW3tvrSiyIEeBz2smBwxX1VZiV7vKj0Cee wcJRGBpA+uwFiVXsV0DLttXTTNb6TyifnowHOV6QgK+9A5uBLOKTCZNx7BXbCfDMC3EXKO JUD76faYUuCG86xI+ZnFLAL6kNTh/tY= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=QcZNv2yU; spf=pass (imf20.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 06A1DA42046; Mon, 26 Aug 2024 09:07:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0EB46C567C1; Mon, 26 Aug 2024 08:58:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1724662715; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ocYxyao+YeYVwZkJVZlNCDBZUEKM/vUAfandsZETTJ0=; b=QcZNv2yUAl78MTanT1uEILVIG0Rwr7Gq5dxZIeMULB8F3+zNHLp+iJBBgbdma6WoOLSZZm dyEAM4d4sn63r+0vrzUEc2Y/7Gvw6Sd+SX+9xw+3TQl5UNUPtgirmdTEW4ELU96hQQ2Ups B1IIgm4VbXKEFP704+R3/GvFPvQLfh0= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id b99b8b23 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Aug 2024 08:58:35 +0000 (UTC) Date: Mon, 26 Aug 2024 10:58:26 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom Message-ID: References: <2a081f1fff5e40f496153f8e0162fc7ec5adab2e.1724309198.git.christophe.leroy@csgroup.eu> <7e519ba2-0293-4320-84bf-44f930fc286d@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <7e519ba2-0293-4320-84bf-44f930fc286d@csgroup.eu> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 1C8711C001A X-Stat-Signature: 33f75ixzfp9x3wfnzmnchj8wejfjr34r X-HE-Tag: 1724663250-461323 X-HE-Meta: U2FsdGVkX19HBEjTz1ffdP9hp5NiF0MV9U9aDLVo8lyAP+PgzE3YLKU2nPm5Ivv0epMthNKu8Tlf9BVHBVXzgYwu3kfMti0Mfy8trm1TjEl6KBw4KFUQNrhG91kmyBvcCC5bz9Qq2njGKCqaYOFGCGaN7SGh6+UP6GD338uWH4vjl1MfQwRLn7EY/PXeQzDrF4IljpjVlvCQHIBqlgGf5QXETzf6vG1dt8/vUXv90dvTW0UakkuHhw7kuq4DzP6er/aUKfLvQfCLV9lGfLwOrADSisws67a6kRs/ekRDumh+uuDeuQluc2gj7LPaBak6dCG22O8MS32jeRBsb/zidf4GNWvIbtkdZDPqE0P+0iCUz1ibMJSKssZL9S7NlUyQo2yN4/D3Wziz1rs9YmM6GNjIp+prESpvzgYP59zdJhNmZbvs92sAXqi0y92bc6NFl25n4esOUt+fbYsCFkVS0kkJIWg3egQlcUeIeG+6UyZ1DODdXtdqVBayiKm2jFenaWFbyJqu22f1nLt4WDkDmFpAcF9XoKnOtfDZJ7xysBC04OZ4J+wvfQ72/XEl2DkqlvN4t73X2rctc7ovwUAz2qhinMCpui6juwVuS9a0yIe5wqE8uDL4IT0a0FhhR7tPWqMDh7yQDoSdtlTXx0zsuuLa/u8WZA/NVG0xBdXk2X2nsWSML2k70mkcBOsD1OkajVUZJT2fcXlFhHzr6Zr7bCpsZtVYCXSTDCqs7WqGNZebmCbUK807hTrKrlH0v8f+rmQWYjGV5l3C6W3CoDygTdP9UebbHfdpSNvsj6w3qiPYfSnC+e5T59jJ5eDuj0Icc6SkKE4dUVK4NNqSbaWwjGF/xStrLQ5PSr7p4+b83uNWJH98ajys2wBMf7Hcnkr5oL8d09ShokHTkfiKs0u6WHJKO//HxZ3MUoUiTb70tJV2p7ulOAZY2gtZ+pKJE82G6Leyg8vGpAzPlulIFdB iv6gKppz XfO8fsKoGyaO9sdpG39reI6aTZ7zZmhkKkwFI0AOT0si8uh0YMHMuSkDRX+khd0/A0Bttxtjkn7/DNhPpYguoZsnsIuWaFYyMxM6dlnsPF+dYuvj6eXduBFZFi9LApgkkKFjJSH5h3087Gtxyn9JPyc1XTEtuop253zYDNIsb59El3uG3XtirLCrMTwX952a47pwIErDdy3m+3PIyuMInMKu9qwwg7Uay/VyuZdwPq+ag25U/fTLmHsNoIofnl+750L5v8FGuC2MaXrhkFY2hrDLsJBplKT0ELevNxPsq3l0Uyc03MuBbu1rOxEUg4rg1hl8GhUGI2JLjmkrc1/E6d5gVFLeRn+UOKSXm8OZ1qSeM8s8rf8vjXnrArc/PdyE7TDWKbrCk+0Q2beFWMqgrBcXcNTeotxJ0GiK8DVr95O9y3AnPBETB3HHvOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Aug 26, 2024 at 10:37:49AM +0200, Christophe Leroy wrote: > > > Le 26/08/2024 à 10:07, Jason A. Donenfeld a écrit : > > On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: > >> > >> +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) > >> +#define _PAGE_MASK (~(_PAGE_SIZE - 1)) > > > > If PAGE_SIZE isn't defined at this point, why not just call it PAGE_SIZE > > instead of _PAGE_SIZE? But if that's the case, why not put the vdso > > definition of PAGE_SIZE into some vdso header included by this file? > > It was working ok on powerpc but on x86 I got: Seems like there might be some more fiddling to do, then? Or did you conclude it's impossible?