From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F7C4C5321E for ; Mon, 26 Aug 2024 07:28:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2DD46B02D8; Mon, 26 Aug 2024 03:28:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id CB6556B02D7; Mon, 26 Aug 2024 03:28:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B30ED6B02D8; Mon, 26 Aug 2024 03:28:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 913736B02D3 for ; Mon, 26 Aug 2024 03:28:58 -0400 (EDT) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4AF02A0D5C for ; Mon, 26 Aug 2024 07:28:58 +0000 (UTC) X-FDA: 82493569956.16.FB68D52 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf04.hostedemail.com (Postfix) with ESMTP id A9E9540003 for ; Mon, 26 Aug 2024 07:28:56 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=fGS4lsQP; spf=pass (imf04.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724657293; a=rsa-sha256; cv=none; b=NHDanXnSKQL7fJyeOqFyu9T+bWpyWvhVaRatY8wAedB09WT0TmUBu0ltguoChCuyKs1DX8 3zSJZwJUKTVZFoGaqKNT20OmNXgnWqypR+tWKDIOpWt5ma33mlfkEGTJeSsEjFeLlI42z0 t0ytl/Sv2t3x2NWEz5BxzxQMST7BOeE= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=fGS4lsQP; spf=pass (imf04.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724657293; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cIIjB88DbOJOvuZ2jjU6lJJKiyoqxEyU/0md06aOA9Y=; b=3GWHIRpb+azUsXr8NkWfJtHGO7XoYF8pJF++qVeLppWjUFCvkTg2x0ukerrIcGMWx+ASKn GJf/Hp65SuArAhz9tBRWrTQD7sgCvAFlPPGH44gO7d3xuNoNZEsGP4frgIglXpKm3ZIv1Q 4lrBng5G3b+YpiBFzEihlxDkjxYPj/o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3C13CA41197; Mon, 26 Aug 2024 07:28:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 880B9C8CDC1; Mon, 26 Aug 2024 07:28:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1724657332; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cIIjB88DbOJOvuZ2jjU6lJJKiyoqxEyU/0md06aOA9Y=; b=fGS4lsQPmJ47S4KPzgxk3QvyNtKhSk0/NSOVe7mmBsaTQCOpf8LdeOZ8NRFSZVGvJlo+6S zya3q8/MC3vnj7W6QkSb/tQ7ibwWIO7gaTmCFFEUbZBJZ4gTKo0ADc09YExEQZvcI0SprG MnhV/Nlqebjptb73hPDfjdwYVd0Acps= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 087983a8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Aug 2024 07:28:51 +0000 (UTC) Date: Mon, 26 Aug 2024 09:28:42 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 14/17] selftests: vdso: Make test_vdso_getrandom look for the right vDSO function Message-ID: References: <04d1de23a2ff14e2709edd8b75e27b81d703bc57.1724309198.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <04d1de23a2ff14e2709edd8b75e27b81d703bc57.1724309198.git.christophe.leroy@csgroup.eu> X-Stat-Signature: ehnyk5o7m58igy98ns87zd75wh53kcpi X-Rspamd-Queue-Id: A9E9540003 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724657336-158294 X-HE-Meta: U2FsdGVkX18p29R3Zk/TTHmgAlsi0ILNfCSF3YO1WyG2+v9u5f9WDeBFeZRaHTpT+K0zE/L6w3Wg3+37sKzqz2EY4uRA7+s7XWwgSGCZdO0X56cfVfkErO6hKfQ8u9MJpbWFtt9gU57xGtCcsS/HX4aIglFPWI+RnUjtisfKnQIbF3ICcDsT43p+pIva05IBGZ0SG8czKiF8OW9DT51ZaHmq+pt4db0pGd1hRT129snGzw1NrzZ/OXUsrrcnirJOgr8742evHd/3sgBQgeocfIImtJ5cvYq2AqmtaBdYFCcb9jnr1q4SVbj0F9cpLamh03BLGo90+dAYBx6igEkl58Upi5cObf+xgoJdFUNAiFY+6Q2pR79vC4V9zXl8aHr4liUJwhso4UypPRlHHkNjvpyF3PDliu6IHdXoVkuUOvE3OcUt8xAd6Cc76wMpjMMS2V0zJJIc8v1/W4LDnj3eNSbFZBvNxUHPMd86i4cpN0B84NTNhqjZJa3xWKFZwfFuhfAsLrUbyn0CqVDe+1Rl4Qm/O7acrrDsIAYkP2wJwtjIrkIGNypFpbyMPy19PrKi6WE+EKfdyVIDDE4s+Gewbyi3dEdLSfvGa9Hb02WX8FrV0lo8aFiEAMY+8lfPvFAl+ewMdvE/3cjdODvuFBUkdxNx0ebabofI0V+hlyhZTzDjqg+xwW3MmnsC9Htl4KbuqY4Dzk87S+1Ys2cLj7acpQ09kLLjtlSHBBF55MygStSbpEjkTzTA3yGhTRBBkbih4g7LRDEVe04M1S48B7Sqo5t31ApB2BlQwpi3Xxh27ZqzYYrHDCL/ikdwRJMbUY62li7xVACcog+nfDQ4HLOCSNH2Gy1FsncW3XWUymr3vKPZh1GFcBxCcL+HNnO/+Fj/YukIZyDUpSd2ahlPyR8NuApBVdwhS4aMTekasbRcfxXcAqwDdZJp5F7K0zu05VgGaVikfnVooZq5bWDRzZC THUQHMLH X1V0brlfxtxhf3V2CA6uEEfucCoR2kHQXj5DdV3wrPvTt0SPhRpaYxRkon/+oigZB3SVvf5XscK7duu/06vmYggaM4br4BDFdvzn1e/RqeixhK6dgjAtu17UpH7iuAFWUGV63N4/YCfM5YFaYGgG+MoTQ2Yp442G+r0T5h2LxkuuCKlmac6YAWG2UpCkHVstv9vwE/Xbn33u+EjE2DwzTUq25KrSNGYzz9Yvf1fFW0+PvfK45mqRhZqhBQeJB0mgKXcSQwzwxDLfeqwH+pteWDTYJM9sqvo+d1sw2K/33I5x42c0svb+xYOCU99MES92nSja2dWd8/fyrP/80x7ffvUsvXrP4bW7WTPwgWXDLT11sIAtdnEVDJDBWfWRQvzqmRXS35a4bosiK4Q3gKD4uXwCCGMxalDvZb/OXagWw03GGwpPynOcMEOmt9t9iLaZtChiUOqp7a0qHhEU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 09:13:22AM +0200, Christophe Leroy wrote: > Don't hard-code x86 specific names, use vdso_config definitions > to find the correct function matching the architecture. > > Add random VDSO function names in names[][]. Remove the #ifdef > CONFIG_VDSO32, having the name there all the time is harmless > and guaranties a steady index for following strings. This is indeed the right way of doing it. Thanks. I'll take this now, though with one small fixup: > + const char *version = versions[VDSO_VERSION]; > + const char **name = (const char **)&names[VDSO_NAMES]; I'll just do: const char *name = names[VDSO_NAMES][6]; Instead of referring to name[6] everywhere after. Seems more straight forward. Jason