From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0837FC5321D for ; Mon, 26 Aug 2024 07:26:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6EADB6B016D; Mon, 26 Aug 2024 03:26:58 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 69A016B0178; Mon, 26 Aug 2024 03:26:58 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 563506B017A; Mon, 26 Aug 2024 03:26:58 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 248C86B016D for ; Mon, 26 Aug 2024 03:26:58 -0400 (EDT) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id B1D1C120DA3 for ; Mon, 26 Aug 2024 07:26:56 +0000 (UTC) X-FDA: 82493564832.19.6F6F3B7 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf21.hostedemail.com (Postfix) with ESMTP id E8A481C000C for ; Mon, 26 Aug 2024 07:26:54 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=eYAnrPy3; spf=pass (imf21.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724657172; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=w24dLA36c/d+xQ7ZOImOMWGl1II9pRfdgFurGBE0teA=; b=ZEcObYkotIYbgXw7bpaMi5A0fvk9J6F4Vn8tX1Tsebpt9mgJeEVlBwZEvh/WY1vRCS76+e INoYTCXHcm+do95q+TAGHXbzchCeJi7J4zn7YErutv/6t/y416GgsnUWIkBYt/QD5M1oPT Fh75wUgrjivIahmjpEpVtcDRB24jBuA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=eYAnrPy3; spf=pass (imf21.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724657172; a=rsa-sha256; cv=none; b=enQM6pcmzBNwDlx0tX3csfKzYXu6GeC3yYhCdNYMW9mZ05uUgyVZXxqy0LUmFCKCmZXQU8 iWjyaKTdVEAGc493/offC0XIHLAwYiKMJkXM0DrqloWHJnhKl2MJv4xQO7PYZxJg4Qnne+ FGUYLxq+UvP/POK4ZRK/Cg82iEdvDxI= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7FE08A41188; Mon, 26 Aug 2024 07:26:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF2BEC4FDF3; Mon, 26 Aug 2024 07:26:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1724657210; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=w24dLA36c/d+xQ7ZOImOMWGl1II9pRfdgFurGBE0teA=; b=eYAnrPy37tSdpNsOmLxnE9vtVohlmjxR65Olke78XoDNkBDbyRAPVZ8yVj5TfBfvzC93iz U17fXHlJI9Qzp1HLsBACdsK6/LpPt0sDt6PMsbbcE1euKmR/4Icub25zv3gIElrlQ9wXEB 9UYlaBoAY1m9Yx1tf5dw5a/jQPgDNBY= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id d127c021 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Aug 2024 07:26:50 +0000 (UTC) Date: Mon, 26 Aug 2024 09:26:40 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 13/17] selftests: vdso: Don't hard-code location of vDSO sources Message-ID: References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: E8A481C000C X-Stat-Signature: msuhnz4ijn9o1hb1g3ztj1siqr3ypcsp X-HE-Tag: 1724657214-153518 X-HE-Meta: U2FsdGVkX19LP6Jdt8//D7q1Z/Vi88QfW7bl349hWnwN1tfQccFtjV71g3JN4pu/ET8JEglDur4yYBslr8coFQreRYbBAWnlmUdHEuUYE0aUY4eiqrWBmya/is+/PTbMENi5BAfWCQpDm7htm5q8Z8FhS2uSYjbjk/ebxsFLi1pOsxxAKxVU8fqGlbADF4/Y2NWXeTkrVrBTVAILqqnb9oZzfeJXwKEDzwitMzikPVZiTIOIZysyhszfO9Ny9baJKSw7/w6ztlXcz8q7JYy/mQX3unxkX6l15Hnt+jg6JSdGVFYylrOIF7oEFLfaM4IF/Z5x0rTltNpYT44eA4ilgWHDYs5SsTV3i5DYduEVPAeXJ7oy7TQKeji1QrsyPhoG5eEXJRPzwU3T8k0IZchpg9WDVnVfYxypfHwhZUZ1SHcvtqwe2bkVrtQhb0WBda2qjPqKAnQuo2OTBIFFhcl37AkYhcMfpJLU6Jtpj7BOGrUn+6WL46ZdRD1hdwiaiFicedecvj8fbPM40Qz+U3PHvuuFOBRCDxSgdPRmleG3T38UZWwyDChuaPOhcM2y+fAya2tKNZ+4+uc80jf/5ArRoRKwxnUFUGfkcT2anVNRK5nk05preSQB9mbrtg1//riL3N/s4ih4cWTPi2oQqvLz6caoQtrRhOcazQmVGUEfSWIEOQAfygxHf4H6pR3S6pRTO0jXhn1z0xzXY+vGTRB8OKflfhc/KkSi8C+mS7jcmeWCFzKtht6nr1q9xT6Z/E+d9r55q0nltRV8LREuCKWYsZdCcEBc56sRVFFIEXPdSbiS6JERCGp/JitIIiSgMZedwW7dHu0qBhN0PwxIQrEb6M+wlRfcq4GV865SAd3aV45ItkMlice9emk6SmmtwVWEwyQMYlizEfdHLkSpY7yMbdfQ3gNVASbTDQBlcwD2OQmn1eqFWYGBHamOrJ9LILHwCZkHcOGQ73qvU4KmnGa zV1EOAjd j2SM6sp5pwR5CeDRhrHpYz+uuA7feZZWI+wxLsm8kuDj6/BGxzLZfF31Bnm5zclS8e5LixBRZPwZacuRlBw1/XmlG3lqETf9tKiJQ4TSrG5EnTG1rYNw7nG3D3CkCX3ylx2H3OEck5lumM2f7xckXILhNg34OsBlNI0mvGJjdA9BB3Bq9lrQRXe27LkYoK0HxTQP2bLY+cg+/bCK2sWyg0lmLyvd5J/VuUTVwQGmYxJmru2WxUvMfcEhAV0AuD2yr2axNI12T2lQ+z3k+QK6eT1isnZnKw3WHdRX9P67iGRJ5EpKm7uGHGpTnPczX2SqSEFJjhUApqNz3CGOTozGxFWQvGh4qeP2t0KAp0dWdMid3d8zs6eBBXrAOapqd2PStaiG57oTOdHjPHplowqQUKx6Zpdkd28YbUp0v X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 09:13:21AM +0200, Christophe Leroy wrote: > Architectures use different location for vDSO sources: > arch/mips/vdso > arch/sparc/vdso > arch/arm64/kernel/vdso > arch/riscv/kernel/vdso > arch/csky/kernel/vdso > arch/x86/um/vdso > arch/x86/entry/vdso > arch/powerpc/kernel/vdso > arch/arm/vdso > arch/loongarch/vdso > > Don't hard-code vdso sources location in selftest Makefile, > instead create a vdso/ symbolic link in tools/arch/$arch/ and > update Makefile accordingly. That seems like a good way of handling it. As archs add their implementations, they can just add the symlink and do no more work. It will also make review slightly easier: if I don't see the symlink added, I'll know the submitter didn't actually test their chacha :-P. I'll take this into my random.git tree now as a fix. Jason