From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 827E3C5321D for ; Mon, 26 Aug 2024 07:24:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F25326B04F0; Mon, 26 Aug 2024 03:24:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id ED5156B04F1; Mon, 26 Aug 2024 03:24:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9C496B051E; Mon, 26 Aug 2024 03:24:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id B37936B04F0 for ; Mon, 26 Aug 2024 03:24:33 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 539E3140CA5 for ; Mon, 26 Aug 2024 07:24:33 +0000 (UTC) X-FDA: 82493558826.02.6129353 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf06.hostedemail.com (Postfix) with ESMTP id 820B1180017 for ; Mon, 26 Aug 2024 07:24:30 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=WRvWNHkl; spf=pass (imf06.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724657028; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=4XYrcqllZpLLj+sqSt83ZS4OGpB+ny/dHDpTQVKEcw0=; b=L+/lNMTta2mJaXhs/ROFskL8aS6fuJXx55oDatb2yiWy1ExtIk6vUspAkQtfz+N95dggpO VowfQKTFwWUYQ8vaLEs4SMGge5D/1/G+/OdPQrtKia3WBTcWsxIuS1RihtSmu197SExnMc I4qJzqe47FLcMPPOPRTSAOim9Zd6HYQ= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=WRvWNHkl; spf=pass (imf06.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724657028; a=rsa-sha256; cv=none; b=G9/VDU4mS5iTEJTq38jZN3dyMvlY95a89+ui2dhzspMq0PDjAU9GD/hUCLHFesZP6VZceP 9xaweknTcYv0i5awMloaOW6i9phHFyrG4f6IGpSPWLl4JqF9NOUdmbyK1guCdxuKPas2N/ qYp0OqHIeJnRAOqvrzgJLDzlcX/QYu8= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D1238A41C61; Mon, 26 Aug 2024 07:24:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20AFAC4FDFE; Mon, 26 Aug 2024 07:24:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1724657065; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=4XYrcqllZpLLj+sqSt83ZS4OGpB+ny/dHDpTQVKEcw0=; b=WRvWNHkl3kMGmPVF84AOTFbuLtotKvO5WMOvOcjiQTO5GGt6yxvAvXfJ5NC3ABH4Au/AaH lXGxAvyyPehGMUl9Mc67zHgogobiWleqNKnOoQ+iYXZybbgRN4TFpXcnAnXpsJUY6u7XVU ZC6nTPIX+X1v5ceKtm4RmJaWa03cBCQ= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id 9e51e9de (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Aug 2024 07:24:25 +0000 (UTC) Date: Mon, 26 Aug 2024 09:24:16 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 03/17] vdso: Add __arch_get_k_vdso_rng_data() Message-ID: References: <30560b394eaa00fded11fa5bbe5f679c7ffe1714.1724309198.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <30560b394eaa00fded11fa5bbe5f679c7ffe1714.1724309198.git.christophe.leroy@csgroup.eu> X-Rspamd-Server: rspam03 X-Rspam-User: X-Rspamd-Queue-Id: 820B1180017 X-Stat-Signature: pytj1f14fptx5oij14jej55t7scm9uw9 X-HE-Tag: 1724657070-558691 X-HE-Meta: U2FsdGVkX1+GZAiTfTwUZxuFx4B/YLI/Up5iDX9IGTgLLuXUuZfGJBLXRPZS1TFAhR73LG1Y4h6prdpTBUpWzhmA+n3ME9/JdCQBIXS89YCgKdN5wQHS5WPNjjlGg2FKD570UeJNwZ1V+FIvjtnwq+Yr3MG3haejQvlQxOq4VWSI5r7cmYjdfmRHjqmGRwErW6x7ZjdRpNRoiDu0yNotTU+QESKqA/Y5tflyD6M0pzTSMycUpoK4hFUfX1MZoHdbcVYFWoUxtdqf+2zAqAsHEFaNbIoA98Xpe1OSvcm43qno3UPIL4IoaOvCVVGEdarfRgbVq+/4pLoHKR1K7qadHoqNzxGjJVF8uGgSjBR1RqGup/SgVfNFPiFResXXnY957MApqyEtaroVHVzIwgAo3IxI4lbgkKV0HIRfOcOUtQRX+K8x/Q2QTK792MTrLzRRPj9HK+RaW1nilCY6I27Iq177xE0vFOmvnEtBxRw9HGFR2YspRl/oAQ1buVylRtBRCGg/ArKfp1AOoqge2hrEwM03Pf+d2q0Geyb6P/zDypyvyB0pCFcwtQRT9WPsGe4oEu0cTTQO+JElLJjv/b3VVWQuWfTU13pTr2wrt2PH/2u7/ZvnVMwwXuPYWB28w5Q/Q5R6cAMlaET/UHAoOgf5Xw4qC3vmV0yr5TdG/ondKuQZzqfraPw/6eKtBo7wqB26IoMZmQUUhxhkNm7L7UyWTPPafMajUA5H4TAvEFSC9OeY6VfzKPpF0GTS1UyNLxNqncYJOqcVoS3CmLcbJGasPxcYwbbJzN+4JhM02v3XdGi8/I5yVnKi1zR6ztCUTPBbdp83W03Ml+a6ADu3M/tp9VqMAzBO/VOS0H+/E+DVnd4HE4ef9c/rHjwdT3KHOAQoL/dAZsa7tZX3vvXvWgC7zGnByxNcvM62K/E12ZvtzEYBw8nXFePURA1yNXifJ56eu7q4YGRSMCVkgwztBk9 LbjSgduh vOLDCzuv4sBFkYjp3t4XWiElU7siIGRz5U0SzFDOM57xSqEiEFyZKGeLX4BPbMeXc9bsZNG2k19g2P1C9ftXWkdLjR6J/NfXjAcBAD1VyNfdGo0co1AtnO51bCNt64OPQnTf6aNVsoLP0459PVzt+PvHU5TLUu5UVNsN69H7Dqnq/fB1xg3fewsPreypt93v0oda4ElG1q/0UBk6EcUYVZ3juo1u/SF5e5kBDNzfin9HKTT4O/bi6Ry0RVm/9WukvHKCvQHkgs8mE4McoCRYpatyibRcFmBVS1C2IEpfBMjdlY6nx321PdnSVaMBD1H85B95H5xD03NL0BE4T5U4JWBx8v6leHtxsBqOgy8ZkW45eKEPeaD8EVIpTOZh7mkOY1ceve9heaXNe70oKHDqcE6LvMTG4ux7wQKtGMhGXibEIAQzwPXM7SWkIQ/yEEIHdcmxWOD0/AT2aYGA+Sm/BADUOdSeLd730ghD/WaP3hfPJdkh/SJIKZoLs1oD+4uWGHB/S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 09:13:11AM +0200, Christophe Leroy wrote: > _vdso_data is specific to x86 and __arch_get_k_vdso_data() is provided > so that all architectures can provide the requested pointer. > > Do the same with _vdso_rng_data, provide __arch_get_k_vdso_rng_data() > and don't use x86 _vdso_rng_data directly. > > Until now vdso/vsyscall.h was only included by time/vsyscall.c but now > it will also be included in char/random.c, leading to a duplicate > declaration of _vdso_data and _vdso_rng_data. > > To fix this issue, move declaration in a C file. vma.c looks like the > most appropriate candidate. Don't need to replace the definitions in > vsyscall.h by declarations as declarations are already in asm/vvar.h > > Signed-off-by: Christophe Leroy > --- > v2: Move x86 DEFINE_VVAR(_vdso_data) and DEFINE_VVAR(_vdso_rng_data) in vma.c Thanks, this seems sane to me. I'll apply this now to random.git as a fix; it should have been done this way before and is going to be a headache to coordinate later. Jason