From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 499D6C5321D for ; Mon, 26 Aug 2024 08:17:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B81306B04F0; Mon, 26 Aug 2024 04:17:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B322B6B04F1; Mon, 26 Aug 2024 04:17:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9F9B76B04F2; Mon, 26 Aug 2024 04:17:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 82FF06B04F0 for ; Mon, 26 Aug 2024 04:17:32 -0400 (EDT) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 20AE3160C17 for ; Mon, 26 Aug 2024 08:17:32 +0000 (UTC) X-FDA: 82493692344.29.B370DD8 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf30.hostedemail.com (Postfix) with ESMTP id 7564480007 for ; Mon, 26 Aug 2024 08:17:30 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=StHVCOh4; spf=pass (imf30.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724660166; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UaxHDzyeQARFqyBuo6p6nbdr7RFX49mOAxwSudvJyzo=; b=Xar/yIFgvmbuHYnPcK8dAYMVpw7LBxtebwx0W1fD+RYTAIcOvGwJCugrCJiDwyCBQWxead Ma2hG8A/zqRqAv41UatXoC0SuL+Y1VMUdj5sVUxc2d5bAiuJN5cgBUKXmeYt7kPBa+X3St rjd66sPod3CGRI/14WqgzBe5v4Lw+I0= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724660166; a=rsa-sha256; cv=none; b=G/DB4/iAcgzz1lbzFGcpXKyhxV7ODLntYTL9nM/zhh8xU3zAnJ5FnvjCZhXIUMh4z5w6Qe WaIO61caqYjSHBEEdoTPDoE10hYygHTeGazPvUozwcI/YD4erWin+3FJajLCV4IX9g9Cyj nQAytqgfoHaSFH0thJgGlN44iNIpiw4= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=zx2c4.com header.s=20210105 header.b=StHVCOh4; spf=pass (imf30.hostedemail.com: domain of "SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org" designates 147.75.193.91 as permitted sender) smtp.mailfrom="SRS0=kq7x=PZ=zx2c4.com=Jason@kernel.org"; dmarc=pass (policy=quarantine) header.from=zx2c4.com Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id D2C65A41DC9; Mon, 26 Aug 2024 08:17:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2F8E8C8CDD6; Mon, 26 Aug 2024 08:07:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zx2c4.com; s=20210105; t=1724659661; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=UaxHDzyeQARFqyBuo6p6nbdr7RFX49mOAxwSudvJyzo=; b=StHVCOh4KNNCyFXRLYUoNCdTcNxSS6Z3asRmnJ9ATPyiIOC/xbFWmEWaSFpaObsfsoO+X3 qqjWV+mwTMIgJyMwkuMkqXw1CrHepM96JxAR4p2UKjZOsZsDhunIzVT2qZzKIWCwWJ7sje lqmadHbYXdoCfy5fWd5XhoCzWQm9vhQ= Received: by mail.zx2c4.com (ZX2C4 Mail Server) with ESMTPSA id a6c12a3f (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Mon, 26 Aug 2024 08:07:41 +0000 (UTC) Date: Mon, 26 Aug 2024 10:07:32 +0200 From: "Jason A. Donenfeld" To: Christophe Leroy Cc: Michael Ellerman , Nicholas Piggin , Naveen N Rao , Andy Lutomirski , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Theodore Ts'o , Arnd Bergmann , Andrew Morton , Steven Rostedt , Masami Hiramatsu , Mathieu Desnoyers , Vincenzo Frascino , Shuah Khan , linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v2 02/17] vdso: Clean header inclusion in getrandom Message-ID: References: <2a081f1fff5e40f496153f8e0162fc7ec5adab2e.1724309198.git.christophe.leroy@csgroup.eu> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <2a081f1fff5e40f496153f8e0162fc7ec5adab2e.1724309198.git.christophe.leroy@csgroup.eu> X-Rspamd-Queue-Id: 7564480007 X-Stat-Signature: k7cy1ior5kydtpj6s4955uaefecxy5id X-Rspamd-Server: rspam09 X-Rspam-User: X-HE-Tag: 1724660250-857187 X-HE-Meta: U2FsdGVkX1+osxWTrBBOi0IzUvcnia1WXHgVPhjKrr99Nj8Dk/MqKGLL8Raihr31H3RkBoC7KBrzpbJvDspo9OR6Uwyzc3IxOxg8Gz6tEMOE9ia3RC4tIUH6hokhbFpOVZy3Gb4oNVkOi8FZbWGKKLm+9A1SzPJ60dDfiUgr3Tzp5CF+x6ljJSe9h+W5XiNuZVVJRikbIBRurTY2CqETS/50O8Wt1NaLKiVtOxYdkWBPr5j6pOHPdmo5+dFD4/Az/r7jOYVnpO7J+gy+xs0w3ULZKs5rtTL5BUjis7i42DLrry1dcuRUo68GuUkYf+5xzq1PBSH46TZtMBPj4S4hkIG074iU6AFtdoShBkdhIBaTbUCPiA5RA8whtcNFwVp8z3gGYB5PaFaIY8nTfewDY6AQINREajoZPYqOlYrXLAjUeTHsGrj22omWdSZHYodwcLT+kOHfYEIMz2coK+AAszKgEJ6Pba1ji73lFFOqsphKfm6slG+5jC3dokGLABDBiTRs4F0BHNLg7ILdP7xqPNkepo7TTZnHQoGdixkjTmo6t/z//2oLF2kIadpPbH9ym87+8l/vTJEfvumQzsxrXcb6YlkreGwnQaMwuIy4TpAA0WKTk+1RKEjJbZeonK70iPrcBkcCCy6IP3EKLXa9fGXMxaMvLzoDV4Z5FTqSp5rkL53vk4c4Erm1ZvzQzHFemOc7FZWeaVYbHD5pGzrn85+lLKGGQiWI2q/+q74aPTSCXE67pa/ysK0fyRmA5Yj+tLFg8J0dhvg8SQzbCtPNisspmikzXRnVwH8K2enNYpX3jWBP18HM4b403rv/qYLYQQQ4V+ydo81eKLKIc0BWXSUaVzPsxkoFYGQaTYX9owruoS5GdSkGOBmHg3N9qKVSLjn34kPICLzXL3RClfLCDdiH05/JtvWxmy/D5SaAYT/mesKdYOqzDGTA1kuHr6JB2+3vodf+2R9O7jEqlX6 CWjWiubs QUxvAgVp6k6+x9eRMj0lK5Tp2ve8qhcDdNc5steIwXZ0QldAFVu4HJpBoTtVgNxYmoXor+v2Fh4Sm/1x6fVwo0xzJkBzrNnV7FkMKj3bqHerIcy3GXLzhQaC5jzIJesUY3nGduiasLAx6I2sd3ldPQNhpssBiZI8RFYAU7zDfiF4pGMFbbj6w2dm4oJubrJ3PItn+NEXFH2GciNuTOXqDt2cPurJF609YI/qYXqlixAKQ1tSAD/JceMkc/06vOPP7fuUSvuTjL2SwnOcw8mSElesDZNKMN0CvlkZxSPyFeLlGWCzs+jagnPYmYAIgh55rZxL890T27gVs6EomTw4E5+xTIKt1lQfQjkgYwdGxFg9brGM3GGUPvbLmAei+jsyUrOqp4k9tdSPHVkiEfPV2k1PREQaDGy5oDqi2hsg/loUIhqYdsI89AOEoJNziOGYoVWPd9afzQppJ9hAMImnZyimcjP6M18WxY+ofmnLQPPWtdhFCy5k8xfoI3A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 09:13:10AM +0200, Christophe Leroy wrote: > diff --git a/arch/x86/include/asm/pvclock.h b/arch/x86/include/asm/pvclock.h > index 0c92db84469d..6e4f8fae3ce9 100644 > --- a/arch/x86/include/asm/pvclock.h > +++ b/arch/x86/include/asm/pvclock.h > @@ -5,6 +5,7 @@ > #include > #include > > +struct timespec64; > /* some helper functions for xen and kvm pv clock sources */ > u64 pvclock_clocksource_read(struct pvclock_vcpu_time_info *src); > u64 pvclock_clocksource_read_nowd(struct pvclock_vcpu_time_info *src); This change isn't mentioned in the commit message and could probably benefit from doing so. > diff --git a/lib/vdso/getrandom.c b/lib/vdso/getrandom.c > index b230f0b10832..cab153c5f9be 100644 > --- a/lib/vdso/getrandom.c > +++ b/lib/vdso/getrandom.c > @@ -3,15 +3,13 @@ > * Copyright (C) 2022-2024 Jason A. Donenfeld . All Rights Reserved. > */ > > -#include > -#include > -#include > +#include > #include > #include > +#include Ah, that's where you do it. Ignore my comment on the previous commit, then. > #include > -#include > -#include > #include > +#include > > #define MEMCPY_AND_ZERO_SRC(type, dst, src, len) do { \ > while (len >= sizeof(type)) { \ > @@ -23,6 +21,9 @@ > } \ > } while (0) > > +#define _PAGE_SIZE (1UL << CONFIG_PAGE_SHIFT) > +#define _PAGE_MASK (~(_PAGE_SIZE - 1)) If PAGE_SIZE isn't defined at this point, why not just call it PAGE_SIZE instead of _PAGE_SIZE? But if that's the case, why not put the vdso definition of PAGE_SIZE into some vdso header included by this file?