From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3600C3DA4A for ; Thu, 22 Aug 2024 18:34:09 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A4056B00AA; Thu, 22 Aug 2024 14:34:09 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 352C06B01FB; Thu, 22 Aug 2024 14:34:09 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 21D9F6B01A9; Thu, 22 Aug 2024 14:34:09 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 04E566B02FE for ; Thu, 22 Aug 2024 14:34:08 -0400 (EDT) Received: from smtpin03.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 7978C14188E for ; Thu, 22 Aug 2024 18:34:08 +0000 (UTC) X-FDA: 82480730976.03.15E95CE Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf21.hostedemail.com (Postfix) with ESMTP id 0FFAA1C0017 for ; Thu, 22 Aug 2024 18:34:05 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="s8Lt/CZe"; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1724351605; a=rsa-sha256; cv=none; b=szO62hzoEyFqsnUUthACsdXWL3CYD2lgeAt7JFjzeT8pG2XGFDU1luYleLazz27Q1pJ9kN 0SSCdD/EDuHYv2ghYsTQoL/FSc1wPRSbI+gtttpjQElKh9Mz9bmcEIzrTGpPmjHUIEX7Ve cNJhgZUgYOAlGBcDb6f16LoxYbmgYeo= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="s8Lt/CZe"; spf=none (imf21.hostedemail.com: domain of willy@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=willy@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1724351605; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Qn7vUOEA2rcYCABVNLNAa2eRTIExK6tDC0WoyGL66Oo=; b=ZVq3OI9LNo+JzSyfm2qEJep+lV4I0cbrsoW5r9Ve/jjeJMY+7AtpwElYrNU8GFZcF4SBk7 43zfBmVvOX7PFo8W46jSnWRUPuQ/iTVIyGetRdgJ/CzMKv0icW3sgM1JXhf5r2czUWLCbZ i2BSOer+2XvKD1pcupfpzu3bCoz7Mqs= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=Qn7vUOEA2rcYCABVNLNAa2eRTIExK6tDC0WoyGL66Oo=; b=s8Lt/CZeLmlPCHsWuymDEeLgFj fYIXLopOkHGhXcTutxG5zjMpudm0cEDvepNkedxkEIax47IgisUkU5q0i1wywF7uj7QbfNrvNOppH sJkthtAlR7lg6CITJF2/VcLly3rTg4GL4DiR4LqbMecrZd3wCphZwY6lZKO3Xjd2xSlnCuSo4XBGa +4+oATw0wSLMTBSklLT+1jr0Wp8Srs6TDwn70/eSRp3BkbB5LpO5SODZrs0Dgsb2Rhtxsd5TV1d32 28eT0qLNrgVMbL+hoBr7pqCeVvhuI2dVUheQcqU1QkST1p9MJkTLlL42sOOyRmvnl8BTMT6TYO78j 6a/PuM8Q==; Received: from willy by casper.infradead.org with local (Exim 4.97.1 #2 (Red Hat Linux)) id 1shCdH-0000000AohJ-0Ae2; Thu, 22 Aug 2024 18:34:03 +0000 Date: Thu, 22 Aug 2024 19:34:02 +0100 From: Matthew Wilcox To: Andrew Morton Cc: kernel test robot , oe-kbuild-all@lists.linux.dev, Linux Memory Management List , linux-fsdevel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH 01/10] mm: Remove PageActive Message-ID: References: <20240821193445.2294269-2-willy@infradead.org> <202408222044.zZMToCKk-lkp@intel.com> <20240822112424.281245ba8874b4b39ce25c37@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240822112424.281245ba8874b4b39ce25c37@linux-foundation.org> X-Stat-Signature: fw7z179x8mwhzjcjer7fwh3ac1ayq8n5 X-Rspamd-Queue-Id: 0FFAA1C0017 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1724351645-575234 X-HE-Meta: U2FsdGVkX1/R7sYoJ5t3WEP2Ka8rO+qVNpJc3jSWqNg3wLm7Yn1IYS/sJq6XLbJfzPszd+UfdVdzGRmaqJI0XCP4G+C/Zcx3Bi3EDwn7GA21BntBk2t7DlI0iKi+sdi1Eran9/9lv8QN370+ITnnx61kFL2NaQDm/q7IQWvkjIZJsBiAeRMXcBdyFA00Y8aHPfCnoV4O5H3iauyc5luwo3erLtWRWzatfLjMpwZmxbq/IdOl/UpHL2GzCKgTrZpwISM+G/4/COyaK3hfc0BAHaUUrWuCAQtJZwYy/nJekixopFVnnN8hv/XnKdyJTniz4hgGhjFJgGXRHNKys6QNmLpLPJtudoAosI0QQIe99zezcEevvVAwVUM+alz3ngVFaYE6YMV3TcWwvFNR33h8dK03grTpFjI1hzc9pcjbxPmckFoCP5BCTsm+5ggNP4yaDvvq3xyWxc7Mu7abnmzI+WbGwyLfVfushUnx1D13H6NziBRuKd1zfeStrKNVkYIzMup/0CkRqqZvvuZVhovj5Pbvpppk0bBYgMkOBVuMYFYiz2o8r7U0HSrhmL0s+wJH+/yDGR6Jww2NEKKhSnRgvSWwwxyoMSkPukmVM4ZzHPlSA6EqS2nJ1yOptbgY2lO/52PoczRcRng5MxR0JAcLbOVp+xrUHh5HNz+Nezd9OrX+bEbF5U9+OBM77tCx75FVnPrICP3scyWpsggc/XT0IjVBUEOpVkBnt57+gIol67zffHJEz/fSSGUt5BHPK/4XN8KQmSRrROPTORL0xQWu7OGoXYVYAgkZqYGioT+HaZ1sey8qu01qWKyxL2qvqEGWw0ObXH9ekuMY2WZITphFJWi40hvFzcjkfO/8AayTArcHaJhS5wTzwr+IJdqdEdHPCbxeP5Q/pnvlFM8gA07DEl+Y7WJnzKt6MyZOcnEW9GZp6EceQjC4sBweK9Wycn4+DnFXz4V6XFdYv06uQGL 61zxsXDh 6XOe8cMeWVYlzHJ4fDzXhxTkCRw4YUIbK5LRfhtuZtNoXJIsZ4pwH3gh6dCl5ZFuyWDYIxjobQFFuvBtFNRWzsTJC6ubPWE9P0i74//+xbHRFTyIcClEa9WwarJCCN74508sNiRCAX2XuiQHDC3S5/ffBNqitj5uZC+xbsm4dryQotQLsGkQEWdWZeffP94jRd+cOVvcvjpZwdYz0YHQzdEu0cTr5GUiEKt63 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Aug 22, 2024 at 11:24:24AM -0700, Andrew Morton wrote: > On Thu, 22 Aug 2024 21:22:43 +0800 kernel test robot wrote: > > > arch/powerpc/mm/pgtable-frag.c: In function 'pte_free_defer': > > >> arch/powerpc/mm/pgtable-frag.c:142:9: error: implicit declaration of function 'SetPageActive' [-Wimplicit-function-declaration] > > 142 | SetPageActive(page); > > | ^~~~~~~~~~~~~ > > this, I assume? It's a good quick fix. I don't think this use of PG_active is documented anywhere, so I'll send a patch to fix that too. > --- a/arch/powerpc/mm/pgtable-frag.c~mm-remove-pageactive-fix > +++ a/arch/powerpc/mm/pgtable-frag.c > @@ -136,10 +136,10 @@ void pte_fragment_free(unsigned long *ta > #ifdef CONFIG_TRANSPARENT_HUGEPAGE > void pte_free_defer(struct mm_struct *mm, pgtable_t pgtable) > { > - struct page *page; > + struct folio *folio; > > - page = virt_to_page(pgtable); > - SetPageActive(page); > + folio = virt_to_folio(pgtable); > + folio_set_active(folio); > pte_fragment_free((unsigned long *)pgtable, 0); > } > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > _ >